Re: Should string constants in template filters should be marked safe?

2007-11-15 Thread Malcolm Tredinnick
On Thu, 2007-11-15 at 10:44 +0100, Michael Radziej wrote: > On Wed, Nov 14, SmileyChris wrote: > > > > > Just noticed an escaped string in my template due to: > > > > {{ image.caption|default:"No caption" }} > > > > It seems like to me that we should trust that string constants in > >

Re: Should string constants in template filters should be marked safe?

2007-11-15 Thread Michael Radziej
On Thu, Nov 15, Michael Radziej wrote: > > Your logic is right as far as it goes, unfortunately, there is a problem > > with message instruction. If the same string appears in two templates, > > it will only appear once in the PO file. However, that doesn't work if > > one of the templates is an

Re: Should string constants in template filters should be marked safe?

2007-11-15 Thread Michael Radziej
Hi Malcolm! On Thu, Nov 15, Malcolm Tredinnick wrote: > On Thu, 2007-11-15 at 10:44 +0100, Michael Radziej wrote: > > On Wed, Nov 14, SmileyChris wrote: > > > > > > > > Just noticed an escaped string in my template due to: > > > > > > {{ image.caption|default:"No caption" }} > > > ... > > I

Re: Should string constants in template filters should be marked safe?

2007-11-15 Thread Michael Radziej
On Wed, Nov 14, SmileyChris wrote: > > Just noticed an escaped string in my template due to: > > {{ image.caption|default:"No caption" }} > > It seems like to me that we should trust that string constants in > template variable tags are safe since they are directly in the > template author's

Should string constants in template filters should be marked safe?

2007-11-14 Thread SmileyChris
Just noticed an escaped string in my template due to: {{ image.caption|default:"No caption" }} It seems like to me that we should trust that string constants in template variable tags are safe since they are directly in the template author's realm, yes? The only way I could figure out how to