[dm-devel] dm thin: data block's ref count is not zero but not belong to any device.

2018-09-25 Thread monty
Hi! I met a problem of dm-thin: a thin-pool has no volumes but its nr_free_blocks_data is not zero. I guess the scene of this problem like: a. create a thin volume thin01, size is 10GB; b. write 10GB to thin01; c. create a snapshot thin01-snap, orig is thin01; d. write 10GB to thin01-snap; e. for

Re: [dm-devel] dm thin: superblock may write succeed before other metadata blocks because of wirting metadata in async mode.

2018-06-20 Thread monty
On Wed, Jun 20, 2018 at 10:51:17AM -0400, Mike Snitzer wrote: > > On Wed, Jun 20 2018 at 1:03pm -0400, > monty wrote: > > > > > On Tue, Jun 19, 2018 at 11:00:32AM -0400, Mike Snitzer wrote: > > > > > > On Tue, Jun 19 2018 at 10:43am -0400, > &

Re: [dm-devel] dm thin: superblock may write succeed before other metadata blocks because of wirting metadata in async mode.

2018-06-19 Thread monty
On Tue, Jun 19, 2018 at 11:00:32AM -0400, Mike Snitzer wrote: > > On Tue, Jun 19 2018 at 10:43am -0400, > Joe Thornber wrote: > > > On Tue, Jun 19, 2018 at 09:11:06AM -0400, Mike Snitzer wrote: > > > On Mon, May 21 2018 at 8:53pm -0400, > > > Monty Pave

[dm-devel] [PATCH] dm thin: superblock may write succeed before other metadata blocks because of wirting metadata in async mode.

2018-05-21 Thread Monty Pavel
other blocks but we cannot guarantee that superblock write completely early than other blocks. So, We need to commit other metadata blocks before change superblock. Signed-off-by: Monty Pavel --- drivers/md/dm-thin-metadata.c |8 1 files changed, 8 insertions(+), 0 deletions(-)

[dm-devel] [dm-thin] releasing a block and reusing it occurs in the same transaction cause metadata corruption

2018-04-01 Thread monty
During my test(create thin-volume and do power loss test), thin-provision report errors: device-mapper: btree spine: node_check failed: csum 3763734755 != wanted 3763708718 device-mapper: block manager: btree_node validator check failed for block 62775 device-mapper: tabl

Re: [dm-devel] [PATCH] persistent-data: fix bug about btree of updating internal node's minima key in btree_split_beneath.

2017-12-18 Thread monty
y=127), we can not find 127 in btree. On Mon, Dec 18, 2017 at 05:34:09PM +, Joe Thornber wrote: > > On Mon, Dec 18, 2017 at 05:13:08PM +0000, Joe Thornber wrote: > > Hi Monty, > > > > On Mon, Dec 18, 2017 at 04:27:58PM -0500, monty wrote: > > > Subject: [PATCH] p

[dm-devel] [PATCH] persistent-data: fix bug about btree of updating internal node's minima key in btree_split_beneath.

2017-12-18 Thread monty
Signed-off-by: monty --- drivers/md/persistent-data/dm-btree.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/md/persistent-data/dm-btree.c b/drivers/md/persistent-data/dm-btree.c index f21ce6a..25ce5ec 100644 --- a/drivers/md/persistent-data/dm-btree.c +++ b

Re: [dm-devel] [PATCH] dm thin: fix NULL pointer exception caused by two concurrent "vgchange -ay -K " processes.

2017-11-24 Thread monty
eed do is to ensure pool_target registering ops is the last ops in dm_thin_init. So does the dm-cache, dm-mpath, and dm-snap. Thanks for Alasdair G Kergon reminding me. Signed-off-by: monty Signed-off-by: Alasdair G Kergon --- drivers/md/dm-cache-target.c | 12 +- driv