Re: [PATCH v2 0/4] crypto: switch to crypto API for ESSIV generation

2019-06-19 Thread Ard Biesheuvel
On Wed, 19 Jun 2019 at 14:49, Ard Biesheuvel wrote: > > On Wed, 19 Jun 2019 at 14:36, Ard Biesheuvel > wrote: > > > > On Wed, 19 Jun 2019 at 13:33, Milan Broz wrote: > > > > > > On 19/06/2019 13:16, Ard Biesheuvel wrote: > > > >> Try > > > >> cryptsetup open --type plain -c null /dev/sdd test

Re: [PATCH v2 0/4] crypto: switch to crypto API for ESSIV generation

2019-06-19 Thread Milan Broz
On 19/06/2019 14:49, Ard Biesheuvel wrote: > On Wed, 19 Jun 2019 at 14:36, Ard Biesheuvel > wrote: >> >> On Wed, 19 Jun 2019 at 13:33, Milan Broz wrote: >>> >>> On 19/06/2019 13:16, Ard Biesheuvel wrote: > Try > cryptsetup open --type plain -c null /dev/sdd test -q > or > dms

Re: [PATCH v2 0/4] crypto: switch to crypto API for ESSIV generation

2019-06-19 Thread Ard Biesheuvel
On Wed, 19 Jun 2019 at 14:36, Ard Biesheuvel wrote: > > On Wed, 19 Jun 2019 at 13:33, Milan Broz wrote: > > > > On 19/06/2019 13:16, Ard Biesheuvel wrote: > > >> Try > > >> cryptsetup open --type plain -c null /dev/sdd test -q > > >> or > > >> dmsetup create test --table " 0 417792 crypt ciph

Re: [PATCH v2 0/4] crypto: switch to crypto API for ESSIV generation

2019-06-19 Thread Ard Biesheuvel
On Wed, 19 Jun 2019 at 13:33, Milan Broz wrote: > > On 19/06/2019 13:16, Ard Biesheuvel wrote: > >> Try > >> cryptsetup open --type plain -c null /dev/sdd test -q > >> or > >> dmsetup create test --table " 0 417792 crypt cipher_null-ecb - 0 > >> /dev/sdd 0" > >> > >> (or just run full cryptse

Re: [PATCH v2 0/4] crypto: switch to crypto API for ESSIV generation

2019-06-19 Thread Milan Broz
On 19/06/2019 13:16, Ard Biesheuvel wrote: >> Try >> cryptsetup open --type plain -c null /dev/sdd test -q >> or >> dmsetup create test --table " 0 417792 crypt cipher_null-ecb - 0 /dev/sdd >> 0" >> >> (or just run full cryptsetup testsuite) >> > > Is that your mode-test script? > > I saw so

Re: [PATCH v2 0/4] crypto: switch to crypto API for ESSIV generation

2019-06-19 Thread Ard Biesheuvel
On Wed, 19 Jun 2019 at 13:01, Milan Broz wrote: > > On 19/06/2019 11:14, Ard Biesheuvel wrote: > > Apologies, this was a rebase error on my part. > > > > Could you please apply the hunk below and try again? > > > > diff --git a/crypto/essiv.c b/crypto/essiv.c > > index 029a65afb4d7..5dc2e592077e 1

Re: [PATCH v2 0/4] crypto: switch to crypto API for ESSIV generation

2019-06-19 Thread Milan Broz
On 19/06/2019 11:14, Ard Biesheuvel wrote: > Apologies, this was a rebase error on my part. > > Could you please apply the hunk below and try again? > > diff --git a/crypto/essiv.c b/crypto/essiv.c > index 029a65afb4d7..5dc2e592077e 100644 > --- a/crypto/essiv.c > +++ b/crypto/essiv.c > @@ -243,6

Re: [PATCH v2 0/4] crypto: switch to crypto API for ESSIV generation

2019-06-19 Thread Ard Biesheuvel
On Wed, 19 Jun 2019 at 09:11, Ard Biesheuvel wrote: > > On Wed, 19 Jun 2019 at 08:56, Milan Broz wrote: > > > > On 18/06/2019 23:27, Ard Biesheuvel wrote: > > > This series creates an ESSIV template that produces a skcipher or AEAD > > > transform based on a tuple of the form ',,' > > > (or ',,'

Re: [PATCH v2 0/4] crypto: switch to crypto API for ESSIV generation

2019-06-19 Thread Ard Biesheuvel
On Wed, 19 Jun 2019 at 08:56, Milan Broz wrote: > > On 18/06/2019 23:27, Ard Biesheuvel wrote: > > This series creates an ESSIV template that produces a skcipher or AEAD > > transform based on a tuple of the form ',,' > > (or ',,' for the AEAD case). It exposes the > > encapsulated sync or async s

Re: [PATCH v2 0/4] crypto: switch to crypto API for ESSIV generation

2019-06-18 Thread Milan Broz
On 18/06/2019 23:27, Ard Biesheuvel wrote: > This series creates an ESSIV template that produces a skcipher or AEAD > transform based on a tuple of the form ',,' > (or ',,' for the AEAD case). It exposes the > encapsulated sync or async skcipher/aead by passing through all operations, > while using

[PATCH v2 0/4] crypto: switch to crypto API for ESSIV generation

2019-06-18 Thread Ard Biesheuvel
This series creates an ESSIV template that produces a skcipher or AEAD transform based on a tuple of the form ',,' (or ',,' for the AEAD case). It exposes the encapsulated sync or async skcipher/aead by passing through all operations, while using the cipher/shash pair to transform the input IV into