Re: [PATCH] drm: Replace drm_modeset_lock/unlock_all with DRM_MODESET_LOCK_ALL_* helpers

2020-04-29 Thread Michał Orzeł
On 29.04.2020 10:57, Jani Nikula wrote: > On Tue, 28 Apr 2020, Michal Orzel wrote: >> As suggested by the TODO list for the kernel DRM subsystem, replace >> the deprecated functions that take/drop modeset locks with new helpers. >> >> Signed-off-by: Michal Orzel >> --- >>

Re: [PATCH] dma-buf: Documentation: fix: `make htmldocs` warnings

2020-04-29 Thread Sam Ravnborg
On Wed, Apr 29, 2020 at 11:27:22PM -0300, Vitor Massaru Iha wrote: > On Wed, 2020-04-29 at 19:06 -0700, Randy Dunlap wrote: > > On 4/29/20 6:59 PM, Vitor Massaru Iha wrote: > > > Add missed ":" on kernel-doc function parameter. > > > > > > This patch fixes this warnings from `make htmldocs`: > >

Re: [Nouveau] [PATCH] drm/nouveau: Fix regression by audio component transition

2020-04-29 Thread Ben Skeggs
Good catch! The OR is definitely a far better choice than the head here, as it's what we use to select the GPU-side HDA registers too. Merged. On Thu, 16 Apr 2020 at 17:54, Takashi Iwai wrote: > > Since the commit 742db30c4ee6 ("drm/nouveau: Add HD-audio component > notifier support"), the

[PATCH v2] dt-bindings: arm-smmu: Add sc7180 compatible string and mem_iface clock

2020-04-29 Thread Sharat Masetty
This patch adds a new compatible string for sc7180 and also an additional clock listing needed to power the TBUs and the TCU. Signed-off-by: Sharat Masetty --- v2: Addressed review comments from Doug Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 8 1 file changed, 8

Re: [Nouveau] [PATCH] drm/nouveau/mmu: Remove unneeded semicolon

2020-04-29 Thread Ben Skeggs
Thanks! On Fri, 24 Apr 2020 at 17:29, Zheng Bin wrote: > > Fixes coccicheck warning: > > drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.h:307:2-3: Unneeded semicolon > drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:583:2-3: Unneeded semicolon > > Reported-by: Hulk Robot > Signed-off-by: Zheng Bin

Re: [PATCH 1/1] drm/nouveau: Use generic helper to check _PR3 presence

2020-04-29 Thread Ben Skeggs
Thanks! On Thu, 23 Apr 2020 at 17:37, Kai-Heng Feng wrote: > > Replace nouveau_pr3_present() in favor of a more generic one, > pci_pr3_present(). > > Also the presence of upstream bridge _PR3 doesn't need to go hand in > hand with device's _DSM, so check _PR3 before _DSM. > > Signed-off-by:

Re: [PATCH -next] drm/nouveau/acr: Use kmemdup instead of kmalloc and memcpy

2020-04-29 Thread Ben Skeggs
Thanks! On Wed, 22 Apr 2020 at 16:56, Zou Wei wrote: > > Fixes coccicheck warning: > > drivers/gpu/drm/nouveau/nvkm/subdev/acr/hsfw.c:103:23-30: WARNING opportunity > for kmemdup > drivers/gpu/drm/nouveau/nvkm/subdev/acr/hsfw.c:113:22-29: WARNING opportunity > for kmemdup > > Fixes:

Re: [PATCH] dma-buf: Documentation: fix: `make htmldocs` warnings

2020-04-29 Thread Vitor Massaru Iha
On Wed, 2020-04-29 at 19:06 -0700, Randy Dunlap wrote: > On 4/29/20 6:59 PM, Vitor Massaru Iha wrote: > > Add missed ":" on kernel-doc function parameter. > > > > This patch fixes this warnings from `make htmldocs`: > > ./drivers/dma-buf/dma-buf.c:678: warning: Function parameter or > > member

[PATCH] dma-buf: Documentation: fix: `make htmldocs` warnings

2020-04-29 Thread Vitor Massaru Iha
Add missed ":" on kernel-doc function parameter. This patch fixes this warnings from `make htmldocs`: ./drivers/dma-buf/dma-buf.c:678: warning: Function parameter or member 'importer_ops' not described in 'dma_buf_dynamic_attach' ./drivers/dma-buf/dma-buf.c:678: warning: Function parameter or

Re: [PATCH 1/1] drm/mm: optimize rb_hole_addr rbtree search in high addr mode

2020-04-29 Thread kbuild test robot
Hi Nirmoy, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next drm-tip/drm-tip linus/master v5.7-rc3 next-20200429] [cannot apply to drm/drm-next

[pull] amdgpu drm-fixes-5.7

2020-04-29 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.7. The following changes since commit e32b2484b3e00170b6cf57d99a18972e174e10ea: Merge tag 'drm-misc-fixes-2020-04-23' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2020-04-24 10:14:04 +1000) are available in the Git repository at:

Re: [PATCH] drm/bridge: fix stack usage warning on old gcc

2020-04-29 Thread Sam Ravnborg
Hi Arnd. On Tue, Apr 28, 2020 at 11:53:54PM +0200, Arnd Bergmann wrote: > Some older versions of gcc badly optimize code that passes > an inline function argument into another function by reference, > causing huge stack usage: > > drivers/gpu/drm/bridge/tc358768.c: In function

Re: [PATCH] misc: sram: Add dma-heap-export reserved SRAM area type

2020-04-29 Thread Andrew F. Davis
On 4/24/20 8:44 PM, John Stultz wrote: > On Fri, Apr 24, 2020 at 3:27 PM Andrew F. Davis wrote: >> This new export type exposes to userspace the SRAM area as a DMA-Heap, >> this allows for allocations as DMA-BUFs that can be consumed by various >> DMA-BUF supporting devices. >> >> Signed-off-by:

Re: [PATCH] [v2] amdgpu: fix gcc-4.8 build warnings

2020-04-29 Thread Arnd Bergmann
On Wed, Apr 29, 2020 at 3:42 PM Kazlauskas, Nicholas wrote: > > On 2020-04-29 5:20 a.m., Arnd Bergmann wrote: > > Older compilers warn about initializers with incorrect curly > > braces: > > > > drivers/gpu/drm/drm_dp_mst_topology.c: In function > > 'drm_dp_mst_dsc_aux_for_port': > >

[PATCH v6 09/16] drm/i915: Support DP MST in enc_to_dig_port() function

2020-04-29 Thread Sean Paul
From: Sean Paul Although DP_MST fake encoders are not subclassed from digital ports, they are associated with them. Support these encoders. Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20191203173638.94919-9-s...@poorly.run #v1 Link:

[PATCH v6 11/16] drm/i915: Factor out HDCP shim functions from dp for use by dp_mst

2020-04-29 Thread Sean Paul
From: Sean Paul These functions are all the same for dp and dp_mst, so move them into a dedicated file for both sst and mst to use. Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20191203173638.94919-11-s...@poorly.run #v1 Link:

[PATCH v6 03/16] drm/i915: WARN if HDCP signalling is enabled upon disable

2020-04-29 Thread Sean Paul
From: Sean Paul HDCP signalling should not be left on, WARN if it is Cc: Ville Syrjälä Cc: Daniel Vetter Reviewed-by: Ramalingam C Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20191212190230.188505-4-s...@poorly.run #v2 Link:

[PATCH v6 04/16] drm/i915: Intercept Aksv writes in the aux hooks

2020-04-29 Thread Sean Paul
From: Sean Paul Instead of hand rolling the transfer ourselves in the hdcp hook, inspect aux messages and add the aksv flag in the aux transfer hook. IIRC, this was the original implementation and folks wanted this hack to be isolated to the hdcp code, which makes sense. However in testing an

[PATCH v6 16/16] drm/i915: Add HDCP 1.4 support for MST connectors

2020-04-29 Thread Sean Paul
From: Sean Paul Now that all the groundwork has been laid, we can turn on HDCP 1.4 over MST. Everything except for toggling the HDCP signalling and HDCP 2.2 support is the same as the DP case, so we'll re-use those callbacks Cc: Juston Li Signed-off-by: Sean Paul Link:

[PATCH v6 06/16] drm/i915: Factor out hdcp->value assignments

2020-04-29 Thread Sean Paul
From: Sean Paul This is a bit of housecleaning for a future patch. Instead of sprinkling hdcp->value assignments and prop_work scheduling everywhere, introduce a function to do it for us. Reviewed-by: Ramalingam C Signed-off-by: Sean Paul Link:

[PATCH v6 13/16] drm/i915: Add connector to hdcp_shim->check_link()

2020-04-29 Thread Sean Paul
From: Sean Paul Currently we derive the connector from digital port in check_link(). For MST, this isn't sufficient since the digital port passed into the function can have multiple connectors downstream. This patch adds connector to the check_link() arguments so we have it when we need it.

[PATCH v6 14/16] drm/mst: Add support for QUERY_STREAM_ENCRYPTION_STATUS MST sideband message

2020-04-29 Thread Sean Paul
From: Sean Paul Used to query whether an MST stream is encrypted or not. Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20200218220242.107265-14-s...@poorly.run #v4 Link: https://patchwork.freedesktop.org/patch/msgid/20200305201236.152307-15-s...@poorly.run

[PATCH v6 15/16] drm/i915: Print HDCP version info for all connectors

2020-04-29 Thread Sean Paul
From: Sean Paul De-duplicate the HDCP version code for each connector and print it for all connectors. Cc: Juston Li Cc: Ramalingam C Reviewed-by: Juston Li Reviewed-by: Ramalingam C Signed-off-by: Sean Paul Link:

[PATCH v6 08/16] drm/i915: Don't fully disable HDCP on a port if multiple pipes are using it

2020-04-29 Thread Sean Paul
From: Sean Paul This patch is required for HDCP over MST. If a port is being used for multiple HDCP streams, we don't want to fully disable HDCP on a port if one of them is disabled. Instead, we just disable the HDCP signalling on that particular pipe and exit early. The last pipe to disable

[PATCH v6 10/16] drm/i915: Use ddi_update_pipe in intel_dp_mst

2020-04-29 Thread Sean Paul
From: Sean Paul In order to act upon content_protection property changes, we'll need to implement the .update_pipe() hook. We can re-use intel_ddi_update_pipe for this Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20191203173638.94919-10-s...@poorly.run #v1

[PATCH v6 07/16] drm/i915: Protect workers against disappearing connectors

2020-04-29 Thread Sean Paul
From: Sean Paul This patch adds some protection against connectors being destroyed before the HDCP workers are finished. For check_work, we do a synchronous cancel after the connector is unregistered which will ensure that it is finished before destruction. In the case of prop_work, we can't

[PATCH v6 12/16] drm/i915: Plumb port through hdcp init

2020-04-29 Thread Sean Paul
From: Sean Paul This patch plumbs port through hdcp init instead of relying on intel_attached_encoder() to return a non-NULL encoder which won't work for MST connectors. Cc: Ville Syrjälä Signed-off-by: Sean Paul Changes in v5: -Added to the set Changes in v6: -None Signed-off-by: Sean Paul

[PATCH v6 05/16] drm/i915: Use the cpu_transcoder in intel_hdcp to toggle HDCP signalling

2020-04-29 Thread Sean Paul
From: Sean Paul Instead of using intel_dig_port's encoder pipe to determine which transcoder to toggle signalling on, use the cpu_transcoder field already stored in intel_hdmi. This is particularly important for MST. Suggested-by: Ville Syrjälä Reviewed-by: Ramalingam C Signed-off-by: Sean

[PATCH v6 01/16] drm/i915: Fix sha_text population code

2020-04-29 Thread Sean Paul
From: Sean Paul This patch fixes a few bugs: 1- We weren't taking into account sha_leftovers when adding multiple ksvs to sha_text. As such, we were or'ing the end of ksv[j - 1] with the beginning of ksv[j] 2- In the sha_leftovers == 2 and sha_leftovers == 3 case, bstatus was being

[PATCH v6 02/16] drm/i915: Clear the repeater bit on HDCP disable

2020-04-29 Thread Sean Paul
From: Sean Paul On HDCP disable, clear the repeater bit. This ensures if we connect a non-repeater sink after a repeater, the bit is in the state we expect. Fixes: ee5e5e7a5e0f (drm/i915: Add HDCP framework + base implementation) Cc: Chris Wilson Cc: Ramalingam C Cc: Daniel Vetter Cc: Sean

[PATCH v6 00/16] drm/i915: Add support for HDCP 1.4 over MST connectors

2020-04-29 Thread Sean Paul
From: Sean Paul Changes in v6: -Rebased on -tip -Disabled HDCP over MST on GEN12 -Addressed Lyude's review comments in the QUERY_STREAM_ENCRYPTION_STATUS patch Sean Paul (16): drm/i915: Fix sha_text population code drm/i915: Clear the repeater bit on HDCP disable drm/i915: WARN if HDCP

Re: [PATCH v2] video: fbdev: controlfb: fix build for COMPILE_TEST=y && PPC_PMAC=y && PPC32=n

2020-04-29 Thread Sam Ravnborg
Hi Bartlomiej On Wed, Apr 29, 2020 at 12:48:24PM +0200, Bartlomiej Zolnierkiewicz wrote: > > powerpc allyesconfig fails like this: > > drivers/video/fbdev/controlfb.c: In function 'controlfb_mmap': > drivers/video/fbdev/controlfb.c:756:23: error: implicit declaration of > function

Re: [PATCH] misc: sram: Add dma-heap-export reserved SRAM area type

2020-04-29 Thread Andrew F. Davis
On 4/27/20 11:17 AM, Rob Herring wrote: > On Fri, Apr 24, 2020 at 5:27 PM Andrew F. Davis wrote: >> >> This new export type exposes to userspace the SRAM area as a DMA-Heap, >> this allows for allocations as DMA-BUFs that can be consumed by various >> DMA-BUF supporting devices. >> >>

Re: [PATCH v5 1/3] dt-bindings: phy: qcom,qmp: Convert QMP PHY bindings to yaml

2020-04-29 Thread Matthias Kaehlcke
Hi Sandeep, On Thu, Apr 23, 2020 at 10:14:36AM -0700, Matthias Kaehlcke wrote: > Hi Sandeep, > > On Tue, Apr 14, 2020 at 02:21:17PM -0700, Stephen Boyd wrote: > > Quoting Sandeep Maheswaram (2020-04-01 23:38:52) > > > Convert QMP PHY bindings to DT schema format using json-schema. > > > > > >

Re: [PATCH] drm: Correct DP DSC macro typo

2020-04-29 Thread Harry Wentland
On 2020-04-29 2:41 p.m., Rodrigo Siqueira wrote: > In the file drm_dp_helper.h we have a macro named > DP_DSC_THROUGHPUT_MODE_{0,1}_UPSUPPORTED, the correct name should be > DP_DSC_THROUGHPUT_MODE_{0,1}_UNSUPPORTED. This commits adjusts this typo > in the header file and in other places that

[PATCH] drm: Correct DP DSC macro typo

2020-04-29 Thread Rodrigo Siqueira
In the file drm_dp_helper.h we have a macro named DP_DSC_THROUGHPUT_MODE_{0,1}_UPSUPPORTED, the correct name should be DP_DSC_THROUGHPUT_MODE_{0,1}_UNSUPPORTED. This commits adjusts this typo in the header file and in other places that attempt to access this macro. Signed-off-by: Rodrigo Siqueira

Re: [PATCH 02/10] drm: Add backlight helper

2020-04-29 Thread Noralf Trønnes
Den 29.04.2020 16.13, skrev Hans de Goede: > Hi Noralf, > > On 4/29/20 2:48 PM, Noralf Trønnes wrote: >> This adds a function that creates a backlight device for a connector. >> It does not deal with the KMS backlight ABI proposition[1] to add a >> connector property. It only takes the current

Re: [PATCH 07/17] drm/mgag200: Move mode-setting code into separate helper function

2020-04-29 Thread Sam Ravnborg
On Wed, Apr 29, 2020 at 04:32:28PM +0200, Thomas Zimmermann wrote: > The mode-setting code is now located in mgag200_set_mode_regs(), sans > a few flags that will be moved in a later patch for clarity. > > Signed-off-by: Thomas Zimmermann Looked like trivial code movements, did not look

Re: [PATCH 06/17] drm/mgag200: Clean up mga_crtc_do_set_base()

2020-04-29 Thread Sam Ravnborg
On Wed, Apr 29, 2020 at 04:32:27PM +0200, Thomas Zimmermann wrote: > The function now only takes the device structure, and the old and new > framebuffers. > > Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg > --- > drivers/gpu/drm/mgag200/mgag200_mode.c | 18 +- > 1

Re: [PATCH 05/17] drm/mgag200: Clean up mga_set_start_address()

2020-04-29 Thread Sam Ravnborg
Hi Thomas, On Wed, Apr 29, 2020 at 04:32:26PM +0200, Thomas Zimmermann wrote: > All register names and fields are now named according to the > MGA programming manuals. The function doesn't need the CRTC, so > callers pass in the device structure directly. The logging now > uses device-specific

Re: [PATCH 04/17] drm/mgag200: Use managed mode-config initialization

2020-04-29 Thread Sam Ravnborg
On Wed, Apr 29, 2020 at 04:32:25PM +0200, Thomas Zimmermann wrote: > Signed-off-by: Thomas Zimmermann Nice simplification. Changelog could be a bit more descriptive... Anyway: Acked-by: Sam Ravnborg > --- > drivers/gpu/drm/mgag200/mgag200_drv.h | 1 - >

Re: [PATCH 01/17] drm/mgag200: Remove HW cursor

2020-04-29 Thread Sam Ravnborg
On Wed, Apr 29, 2020 at 04:32:22PM +0200, Thomas Zimmermann wrote: > The HW cursor of Matrox G200 cards only supports a 16-color palette > format. Univeral planes require at least ARGB or a similar component- > based format. Converting a cursor image from ARGB to 16 colors does not > produce

Re: [PATCH 03/17] drm/mgag200: Embed connector instance in struct mga_device

2020-04-29 Thread Sam Ravnborg
Hi Thomas. On Wed, Apr 29, 2020 at 04:32:24PM +0200, Thomas Zimmermann wrote: > Storing the connector instance in struct mga_device avoids some > dynamic memory allocation. Done im preparation of converting > mgag200 to simple-KMS helpers. > > Signed-off-by: Thomas Zimmermann One nit below,

Re: [PATCH 02/17] drm/mgag200: Remove unused fields from struct mga_device

2020-04-29 Thread Sam Ravnborg
On Wed, Apr 29, 2020 at 04:32:23PM +0200, Thomas Zimmermann wrote: > The fields mode_info, num_crtcs and mode in struct mga_device serve > no purpose. Remove them. > > Signed-off-by: Thomas Zimmermann Looks straight forward. Acked-by: Sam Ravnborg > --- >

Re: [PATCH] drm: enable render nodes wherever buffer sharing is supported

2020-04-29 Thread Liviu Dudau
On Wed, Apr 29, 2020 at 09:51:19AM -0700, Peter Collingbourne wrote: > On Wed, Apr 29, 2020 at 9:17 AM Brian Starkey wrote: > > > > Hi Peter, > > > > On Mon, Apr 27, 2020 at 01:05:13PM -0700, Peter Collingbourne wrote: > > > Render nodes are not just useful for devices supporting GPU hardware > >

Re: [PATCH v2] drm: Fix HDCP failures when SRM fw is missing

2020-04-29 Thread Ramalingam C
On 2020-04-29 at 10:46:29 -0400, Sean Paul wrote: > On Wed, Apr 29, 2020 at 10:22 AM Ramalingam C wrote: > > > > On 2020-04-29 at 09:58:16 -0400, Sean Paul wrote: > > > On Wed, Apr 29, 2020 at 9:50 AM Ramalingam C > > > wrote: > > > > > > > > On 2020-04-14 at 15:02:55 -0400, Sean Paul wrote: >

Re: [PATCH] drm: enable render nodes wherever buffer sharing is supported

2020-04-29 Thread Brian Starkey
Hi Peter, On Mon, Apr 27, 2020 at 01:05:13PM -0700, Peter Collingbourne wrote: > Render nodes are not just useful for devices supporting GPU hardware > acceleration. Even on devices that only support dumb frame buffers, > they are useful in situations where composition (using software >

Re: [PATCH] drm/amdgpu/smu10: remove duplicate assignment of smu10_hwmgr_funcs members

2020-04-29 Thread Alex Deucher
On Tue, Apr 28, 2020 at 8:47 AM Jason Yan wrote: > > The struct member 'asic_setup' was assigned twice, let's remove one: > > static const struct pp_hwmgr_func smu10_hwmgr_funcs = { > .. > .asic_setup = NULL, > .. > .asic_setup = smu10_setup_asic_task, >

Re: [PATCH] drm/amd/display: remove duplicate assignment of dcn21_funcs members

2020-04-29 Thread Alex Deucher
On Tue, Apr 28, 2020 at 8:46 AM Jason Yan wrote: > > Fix the following coccicheck warning: > > drivers/gpu/drm/amd/display/dc/dcn21/dcn21_init.c:31:51-52: > exit_optimized_pwr_state: first occurrence line 86, second occurrence > line 92 >

RE: [PATCH 03/17] drm/mgag200: Embed connector instance in struct mga_device

2020-04-29 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Thomas Zimmermann >Sent: Wednesday, April 29, 2020 10:32 AM >To: airl...@redhat.com; dan...@ffwll.ch; kra...@redhat.com; >nor...@tronnes.org; s...@ravnborg.org; john.p.donne...@oracle.com >Cc: Thomas Zimmermann ; dri-

Re: [PATCH] drm/ast: remove duplicate assignment of ast_crtc_funcs member

2020-04-29 Thread Thomas Zimmermann
Hi Am 29.04.20 um 16:10 schrieb Jason Yan: > The struct member 'set_config' was assigned twice: > > static const struct drm_crtc_funcs ast_crtc_funcs = { > .reset = ast_crtc_reset, > .set_config = drm_crtc_helper_set_config, > .. > .set_config =

Re: [PATCH] drm/i915/hdcp: Fix the return handling of drm_hdcp_check_ksvs_revoked

2020-04-29 Thread Sean Paul
On Wed, Apr 29, 2020 at 9:46 AM Ramalingam C wrote: > > drm_hdcp_check_ksvs_revoked() returns the number of revoked keys and > error codes when the SRM parsing is failed. > > Errors in SRM parsing can't affect the HDCP auth, hence with this patch, > I915 will look out for revoked key count alone.

Re: [PATCH v2] drm: Fix HDCP failures when SRM fw is missing

2020-04-29 Thread Sean Paul
On Wed, Apr 29, 2020 at 10:22 AM Ramalingam C wrote: > > On 2020-04-29 at 09:58:16 -0400, Sean Paul wrote: > > On Wed, Apr 29, 2020 at 9:50 AM Ramalingam C wrote: > > > > > > On 2020-04-14 at 15:02:55 -0400, Sean Paul wrote: > > > > From: Sean Paul > > > > > > > > The SRM cleanup in

[PATCH 10/17] drm/mgag200: Set pitch in a separate helper function

2020-04-29 Thread Thomas Zimmermann
The framebuffer's pitch is now set in mgag200_set_offset(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_mode.c | 41 +- 1 file changed, 27 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c

[PATCH 15/17] drm/mgag200: Remove waiting from DPMS code

2020-04-29 Thread Thomas Zimmermann
The mgag200 drivers waits for the VSYNC flag to get signalled (i.e., the page flip happens) before changing DPMS settings. This doesn't work reliably if no mode has been programmed. Therefore remove the waiting code. Synchronization with page flips should be done by DRM's vblank handlers anyway.

[PATCH 00/17] drm/mgag200: Convert to atomic modesetting

2020-04-29 Thread Thomas Zimmermann
This patchset converts mgag200 to atomic modesetting. It uses simple KMS helpers and SHMEM. Patches 1 to 4 simplifies the driver before the conversion. For example, the HW cursor is not usable with the way universal planes work. A few data structures can be cleaned up. Patches 5 to 15 untangle

[PATCH 14/17] drm/mgag200: Move register initialization into separate function

2020-04-29 Thread Thomas Zimmermann
Registers are initialized with constants. This is now done in mgag200_init_regs(), mgag200_set_dac_regs() and mgag200_set_pci_regs(). Later patches should move these calls from mode setting to device initialization. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_mode.c |

[PATCH 09/17] drm/mgag200: Update mode registers after plane registers

2020-04-29 Thread Thomas Zimmermann
Setting the plane registers first and the mode registers afterwards reproduces the sequence used by atomic helpers. Done in preparation of switching to simple KMS helpers. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_mode.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 17/17] drm/mgag200: Replace VRAM helpers with SHMEM helpers

2020-04-29 Thread Thomas Zimmermann
The VRAM helpers managed the framebuffer memory for mgag200. This came with several problems, as some MGA device require the scanout address to be located at VRAM offset 0. It's incompatible with the page-flip semantics of DRM's atomic modesettting. With atomic modesetting, old and new

[PATCH 01/17] drm/mgag200: Remove HW cursor

2020-04-29 Thread Thomas Zimmermann
The HW cursor of Matrox G200 cards only supports a 16-color palette format. Univeral planes require at least ARGB or a similar component- based format. Converting a cursor image from ARGB to 16 colors does not produce pleasent-looking results in general, so remove the HW cursor. Signed-off-by:

[PATCH 02/17] drm/mgag200: Remove unused fields from struct mga_device

2020-04-29 Thread Thomas Zimmermann
The fields mode_info, num_crtcs and mode in struct mga_device serve no purpose. Remove them. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_drv.h | 8 drivers/gpu/drm/mgag200/mgag200_main.c | 3 --- drivers/gpu/drm/mgag200/mgag200_mode.c | 6 -- 3 files

[PATCH 12/17] drm/mgag200: Move TAGFIFO reset into separate function

2020-04-29 Thread Thomas Zimmermann
The TAGFIFO state is now reset in mgag200_g200er_reset_tagfifo(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_drv.h | 6 drivers/gpu/drm/mgag200/mgag200_mode.c | 45 +- 2 files changed, 35 insertions(+), 16 deletions(-) diff --git

[PATCH 07/17] drm/mgag200: Move mode-setting code into separate helper function

2020-04-29 Thread Thomas Zimmermann
The mode-setting code is now located in mgag200_set_mode_regs(), sans a few flags that will be moved in a later patch for clarity. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_mode.c | 140 ++--- 1 file changed, 78 insertions(+), 62 deletions(-) diff

[PATCH 11/17] drm/mgag200: Set primary plane's format in separate helper function

2020-04-29 Thread Thomas Zimmermann
The primary plane's format registers are now updated in a mgag200_set_format_regs(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_mode.c | 109 - 1 file changed, 69 insertions(+), 40 deletions(-) diff --git

[PATCH 08/17] drm/mgag200: Split MISC register update into PLL selection, SYNC and I/O

2020-04-29 Thread Thomas Zimmermann
Set different fields in MISC in their rsp location in the code. This patch also fixes a bug in the original code where the mode's SYNC flags were never written into the MISC register. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_mode.c | 37 ++

[PATCH 06/17] drm/mgag200: Clean up mga_crtc_do_set_base()

2020-04-29 Thread Thomas Zimmermann
The function now only takes the device structure, and the old and new framebuffers. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_mode.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c

[PATCH 05/17] drm/mgag200: Clean up mga_set_start_address()

2020-04-29 Thread Thomas Zimmermann
All register names and fields are now named according to the MGA programming manuals. The function doesn't need the CRTC, so callers pass in the device structure directly. The logging now uses device-specific macros. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_drv.h |

[PATCH 16/17] drm/mgag200: Convert to simple KMS helper

2020-04-29 Thread Thomas Zimmermann
The mgag200 supports a single pipeline with only a primary plane. It can be converted to simple KMS helpers. This also adds support for atomic modesetting. Wayland compositors, which use pageflip ioctls, can now be used with mgag200. Signed-off-by: Thomas Zimmermann ---

[PATCH 03/17] drm/mgag200: Embed connector instance in struct mga_device

2020-04-29 Thread Thomas Zimmermann
Storing the connector instance in struct mga_device avoids some dynamic memory allocation. Done im preparation of converting mgag200 to simple-KMS helpers. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_drv.h | 1 + drivers/gpu/drm/mgag200/mgag200_mode.c | 54

[PATCH 13/17] drm/mgag200: Move hiprilvl setting into separate functions

2020-04-29 Thread Thomas Zimmermann
The hiprivlvl settings are now updated in mgag200_g200se_set_hiprilvl() and mgag200_g200ev_set_hiprilvl(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_mode.c | 98 ++ 1 file changed, 54 insertions(+), 44 deletions(-) diff --git

[PATCH 04/17] drm/mgag200: Use managed mode-config initialization

2020-04-29 Thread Thomas Zimmermann
Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_drv.h | 1 - drivers/gpu/drm/mgag200/mgag200_main.c | 18 - drivers/gpu/drm/mgag200/mgag200_mode.c | 37 -- 3 files changed, 29 insertions(+), 27 deletions(-) diff --git

Re: [PATCH] drm/mediatek: cleanup coding style in mediatek a bit

2020-04-29 Thread Chun-Kuang Hu
Hi, Bernard: Bernard Zhao 於 2020年4月27日 週一 下午3:53寫道: > > This code change is to make code bit more readable. > Optimise array size align to HDMI macro define. > Add check if len is overange. One patch should just do one thing, but this do three things. So break this into three patches. Regards,

Re: [PATCH v2] drm: Fix HDCP failures when SRM fw is missing

2020-04-29 Thread Ramalingam C
On 2020-04-29 at 09:58:16 -0400, Sean Paul wrote: > On Wed, Apr 29, 2020 at 9:50 AM Ramalingam C wrote: > > > > On 2020-04-14 at 15:02:55 -0400, Sean Paul wrote: > > > From: Sean Paul > > > > > > The SRM cleanup in 79643fddd6eb2 ("drm/hdcp: optimizing the srm > > > handling") inadvertently

Re: [PATCH v3 05/17] drm/msm/dpu: Use OPP API to set clk/perf state

2020-04-29 Thread Rajendra Nayak
On 4/29/2020 5:44 AM, Matthias Kaehlcke wrote: On Tue, Apr 28, 2020 at 07:02:53PM +0530, Rajendra Nayak wrote: On some qualcomm platforms DPU needs to express a perforamnce state requirement on a power domain depennding on the clock rates. Use OPP table from DT to register with OPP framework

Re: [PATCH v3 -next] drm/mediatek: Fix Kconfig warning

2020-04-29 Thread Chun-Kuang Hu
Hi, YueHaibing: YueHaibing 於 2020年4月29日 週三 下午3:14寫道: > > WARNING: unmet direct dependencies detected for MTK_MMSYS > Depends on [n]: (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n]) && > COMMON_CLK_MT8173_MMSYS [=n] > Selected by [y]: > - DRM_MEDIATEK [=y] && HAS_IOMEM [=y] && DRM [=y] &&

Re: [PATCH 02/10] drm: Add backlight helper

2020-04-29 Thread Hans de Goede
Hi Noralf, On 4/29/20 2:48 PM, Noralf Trønnes wrote: This adds a function that creates a backlight device for a connector. It does not deal with the KMS backlight ABI proposition[1] to add a connector property. It only takes the current best practise to standardise the creation of a backlight

Re: [PATCH v3 05/17] drm/msm/dpu: Use OPP API to set clk/perf state

2020-04-29 Thread Rajendra Nayak
On 4/28/2020 10:02 PM, Rob Clark wrote: On Tue, Apr 28, 2020 at 6:39 AM Rajendra Nayak wrote: On some qualcomm platforms DPU needs to express a perforamnce state s/perforamnce/performance/ requirement on a power domain depennding on the clock rates. s/depennding/depending/ Use OPP

Re: [PATCH v2] drm/panel: simple: Support reset GPIOs

2020-04-29 Thread Wadim Egorov
Hi Sam, you've asked in another thread [1] if there is any known simple panel that requires a reset. We have a Densitron DMT070WSNLCMI-1E Panel (compatible to avic,tm070ddh03) with some reset timing requirements, [2] Page 20. So it would be nice to see this patch accepted. [1]

Re: [PATCH v2] drm: Fix HDCP failures when SRM fw is missing

2020-04-29 Thread Sean Paul
On Wed, Apr 29, 2020 at 9:50 AM Ramalingam C wrote: > > On 2020-04-14 at 15:02:55 -0400, Sean Paul wrote: > > From: Sean Paul > > > > The SRM cleanup in 79643fddd6eb2 ("drm/hdcp: optimizing the srm > > handling") inadvertently altered the behavior of HDCP auth when > > the SRM firmware is

Re: [PATCH v3] backlight: lms283gf05: Convert to GPIO descriptors

2020-04-29 Thread Daniel Thompson
On Wed, Apr 29, 2020 at 02:43:54PM +0200, Linus Walleij wrote: > This converts the lms283gf05 backlight driver to use GPIO > descriptors and switches the single PXA Palm Z2 device > over to defining these. > > Since the platform data was only used to convey GPIO > information we can delete the

Re: [PATCH v2] drm: Fix HDCP failures when SRM fw is missing

2020-04-29 Thread Ramalingam C
On 2020-04-14 at 15:02:55 -0400, Sean Paul wrote: > From: Sean Paul > > The SRM cleanup in 79643fddd6eb2 ("drm/hdcp: optimizing the srm > handling") inadvertently altered the behavior of HDCP auth when > the SRM firmware is missing. Before that patch, missing SRM was > interpreted as the device

[PATCH] drm/i915/hdcp: Fix the return handling of drm_hdcp_check_ksvs_revoked

2020-04-29 Thread Ramalingam C
drm_hdcp_check_ksvs_revoked() returns the number of revoked keys and error codes when the SRM parsing is failed. Errors in SRM parsing can't affect the HDCP auth, hence with this patch, I915 will look out for revoked key count alone. Signed-off-by: Ramalingam C cc: Sean Paul ---

Re: [PATCH] [v2] amdgpu: fix gcc-4.8 build warnings

2020-04-29 Thread Kazlauskas, Nicholas
On 2020-04-29 5:20 a.m., Arnd Bergmann wrote: Older compilers warn about initializers with incorrect curly braces: drivers/gpu/drm/drm_dp_mst_topology.c: In function 'drm_dp_mst_dsc_aux_for_port': drivers/gpu/drm/drm_dp_mst_topology.c:5497:9: error: missing braces around initializer

Re: [PATCH v2] video: fbdev: controlfb: fix build for COMPILE_TEST=y && PPC_PMAC=y && PPC32=n

2020-04-29 Thread Sam Ravnborg
Hi Christoph On Wed, Apr 29, 2020 at 05:51:01AM -0700, Christoph Hellwig wrote: > Why do we even bother allocing the driver to compile for !ppc32 > given that it clearly needs ppc-specific infrastructure? The whole > idea of needing magic stubs for the COMPILE_TEST case seems rather >

Re: [PATCH v2] drm/meson: add mode selection limits against specific SoC revisions

2020-04-29 Thread Neil Armstrong
Hi, On 29/04/2020 00:03, Martin Blumenstingl wrote: > Hi Neil, > > On Tue, Apr 28, 2020 at 11:21 AM Neil Armstrong > wrote: >> >> The Amlogic S805X/Y uses the same die as the S905X, but with more >> limited graphics capabilities. >> >> This adds a soc version detection adding specific

Re: [PATCH v2] video: fbdev: controlfb: fix build for COMPILE_TEST=y && PPC_PMAC=y && PPC32=n

2020-04-29 Thread Bartlomiej Zolnierkiewicz
On 4/29/20 2:51 PM, Christoph Hellwig wrote: > Why do we even bother allocing the driver to compile for !ppc32 > given that it clearly needs ppc-specific infrastructure? The whole > idea of needing magic stubs for the COMPILE_TEST case seems rather > counterproduction. Not a perfect solution

Re: [PATCH] sun6i: dsi: fix gcc-4.8

2020-04-29 Thread Paul Kocialkowski
Hi, On Tue 28 Apr 20, 23:50, Arnd Bergmann wrote: > Older compilers warn about initializers with incorrect curly > braces: > > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c: In function > 'sun6i_dsi_encoder_enable': > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c:720:8: error: missing braces around >

[PATCH 08/10] drm: Add Generic USB Display driver

2020-04-29 Thread Noralf Trønnes
This adds a generic USB display driver with the intention that it can be used with future USB interfaced low end displays/adapters. The Linux gadget device driver will serve as the canonical device implementation. The following DRM properties are supported: - Plane rotation - Connector TV

[PATCH 03/10] drm/client: Add drm_client_init_from_id()

2020-04-29 Thread Noralf Trønnes
drm_client_init_from_id() provides a way for clients to add a client based on the minor. drm_client_register() is changed to return whether it was registered or not depending on the unplugged status of the DRM device. Its only caller drm_fbdev_generic_setup() runs inside probe() so it doesn't have

[PATCH 01/10] backlight: Add backlight_device_get_by_name()

2020-04-29 Thread Noralf Trønnes
Add a way to lookup a backlight device based on its name. Will be used by a USB display gadget getting the name from configfs. Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han Signed-off-by: Noralf Trønnes --- drivers/video/backlight/backlight.c | 21 +

[PATCH 10/10] usb: gadget: function: Add Generic USB Display support

2020-04-29 Thread Noralf Trønnes
This adds the gadget side support for the Generic USB Display. It presents a DRM display device as a USB Display configured through configfs. The display is implemented as a vendor type USB interface with one bulk out endpoint. The protocol is implemented using control requests. lz4 compressed

[PATCH 07/10] drm/format-helper: Add drm_fb_swab()

2020-04-29 Thread Noralf Trønnes
This replaces drm_fb_swab16() with drm_fb_swab() supporting 16 and 32-bit. Also make pixel line caching optional. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_format_helper.c | 61 +++-- drivers/gpu/drm/drm_mipi_dbi.c | 2 +-

[PATCH 04/10] drm/client: Add drm_client_framebuffer_flush()

2020-04-29 Thread Noralf Trønnes
Some drivers need explicit flushing of buffer changes, add a function that does that. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_client.c | 31 +++ include/drm/drm_client.h | 1 + 2 files changed, 32 insertions(+) diff --git

[PATCH 00/10] Generic USB Display driver

2020-04-29 Thread Noralf Trønnes
Hi, A while back I had the idea to turn a Raspberry Pi Zero into a $5 USB to HDMI/SDTV/DSI/DPI display adapter. This series adds a USB host driver and a device/gadget driver to achieve that. The reason for calling it 'Generic' is so anyone can make a USB display/adapter against this driver, all

[PATCH 09/10] drm/gud: Add functionality for the USB gadget side

2020-04-29 Thread Noralf Trønnes
Since the USB gadget/device has to reach into the DRM internals, part of the code is placed in the DRM subsystem as a separate module. All calls into this module runs in process context and are serialized, except one function that runs in interrupt context. Since both the gadget side and the DRM

[PATCH 05/10] drm/client: Add drm_client_modeset_check()

2020-04-29 Thread Noralf Trønnes
Add a way for client to check the configuration before comitting. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_client_modeset.c | 35 include/drm/drm_client.h | 1 + 2 files changed, 32 insertions(+), 4 deletions(-) diff --git

[PATCH 02/10] drm: Add backlight helper

2020-04-29 Thread Noralf Trønnes
This adds a function that creates a backlight device for a connector. It does not deal with the KMS backlight ABI proposition[1] to add a connector property. It only takes the current best practise to standardise the creation of a backlight device for DRM drivers while we wait for the property.

[PATCH 06/10] drm/client: Add a way to set modeset, properties and rotation

2020-04-29 Thread Noralf Trønnes
This adds functions for clients that need more control over the configuration than what's setup by drm_client_modeset_probe(). Connector, fb and display mode can be set using drm_client_modeset_set(). Plane rotation can be set using drm_client_modeset_set_rotation() and other properties using

[PATCH v3] backlight: lms283gf05: Convert to GPIO descriptors

2020-04-29 Thread Linus Walleij
This converts the lms283gf05 backlight driver to use GPIO descriptors and switches the single PXA Palm Z2 device over to defining these. Since the platform data was only used to convey GPIO information we can delete the platform data header. Notice that we define the proper active low semantics

Re: [PATCH] backlight: lms283gf05: Convert to GPIO descriptors

2020-04-29 Thread kbuild test robot
a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Linus-Walleij/backlight-lms283gf05-Convert-to-GPIO-descriptors/20200429-181222

  1   2   >