Re: [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types

2022-07-16 Thread Sakari Ailus
Folks, > Laurent Pinchart (6): > dt-bindings: media: Add macros for video interface bus types > dt-bindings: Use new video interface bus type macros in examples > ARM: dts: freescale: Use new media bus type macros > ARM: dts: omap: Use new media bus type macros > ARM: dts: renesas: Use n

[BUG] most: usb: Found a bug at the probe time

2022-07-16 Thread Zheyu Ma
Hello, I found a bug in the most usb driver. When the driver fails at mdev->conf = kcalloc(num_endpoints, sizeof(*mdev->conf), GFP_KERNEL); I got the following warning message: [ 15.406256] kobject: '(null)' (8881068f8000): is not initialized, yet kobject_put() is being called. [

Re: [linux-next:master] BUILD REGRESSION 4662b7adea50bb62e993a67f611f3be625d3df0d

2022-07-16 Thread Liam Howlett
* Andrew Morton [220716 21:03]: > On Thu, 14 Jul 2022 09:56:19 +0800 kernel test robot wrote: > > > lib/maple_tree.c:1522:52: warning: Parameter 'gaps' can be declared with > > const [constParameter] > > lib/maple_tree.c:1871:21: warning: Array index 'split' is used before > > limits check. [a

Re: [linux-next:master] BUILD REGRESSION 4662b7adea50bb62e993a67f611f3be625d3df0d

2022-07-16 Thread Andrew Morton
On Thu, 14 Jul 2022 09:56:19 +0800 kernel test robot wrote: > lib/maple_tree.c:1522:52: warning: Parameter 'gaps' can be declared with > const [constParameter] > lib/maple_tree.c:1871:21: warning: Array index 'split' is used before limits > check. [arrayIndexThenCheck] > lib/maple_tree.c:2033:5

[Bug 216119] 087451f372bf76d breaks hibernation on amdgpu Radeon R9 390

2022-07-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216119 --- Comment #33 from Harald Judt (h.j...@gmx.at) --- With "if I reboot the machine" I mean, if I shutdown/reboot it later after resume, then the shutdown messages get printed that strange way. -- You may reply to this email to add a comment. Yo

Re: [PATCH] drm: Fix EDID firmware load on resume

2022-07-16 Thread kernel test robot
, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Matthieu-CHARETTE/drm-Fix-EDID-firmware-load-on-resume/20220716-214028 base:32346491ddf24599decca06190ebca03ff9de

[Bug 216119] 087451f372bf76d breaks hibernation on amdgpu Radeon R9 390

2022-07-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216119 --- Comment #32 from Harald Judt (h.j...@gmx.at) --- There still seem to be issues with the shared fb implementation and hibernation. After resume, chvt to another vt causes the following errors in dmesg: [ 975.920944] [drm:amdgpu_job_timedout]

[PATCH 3/4] drm/amd/display: add doc entries for MPC blending configuration

2022-07-16 Thread Melissa Wen
Describe structs and enums used to set blend mode properties to MPC blocks. Some pieces of information are already available as code comments, and were just formatted. Others were collected and summarised from discusssions on AMD issue tracker[1][2]. [1] https://gitlab.freedesktop.org/drm/amd/-/is

[PATCH 4/4] Documentation/gpu/amdgpu/amdgpu_dm: add DM docs for pixel blend mode

2022-07-16 Thread Melissa Wen
AMD GPU display manager (DM) maps DRM pixel blend modes (None, Pre-multiplied, Coverage) to MPC hw blocks through blend configuration options. Describe relevant elements and how to set and test them to get the expected DRM blend mode on DCN hw. Signed-off-by: Melissa Wen --- .../gpu/amdgpu/displ

[PATCH 2/4] Documentation/amdgpu/display: add DC color caps info

2022-07-16 Thread Melissa Wen
Add details about color correction capabilities and explain a bit about differences between DC hw generations and also how they are mapped between DRM and DC interface. Two schemas for DCN 2.0 and 3.0 (converted to svg from the original png) is included to illustrate it. They were obtained from a d

[PATCH 0/4] Documentation/amdgpu/display: describe color and blend mode properties mapping

2022-07-16 Thread Melissa Wen
Patches 1 and 2 describe DM mapping of DRM color correction properties to DC interface and where detached from 3D LUT RFC series [1]. Patches 3 and 4 describe MPC block programming that matches the three DRM blend modes and came from previous work [2][3] and discussions on AMD issue tracker. Let me

[PATCH 1/4] Documentation/amdgpu_dm: Add DM color correction documentation

2022-07-16 Thread Melissa Wen
AMDGPU DM maps DRM color management properties (degamma, ctm and gamma) to DC color correction entities. Part of this mapping is already documented as code comments and can be converted as kernel docs. v2: - rebase to amd-staging-drm-next Reviewed-by: Harry Wentland Signed-off-by: Melissa Wen -

Re: [git pull] drm fixes for 5.19-rc7

2022-07-16 Thread Linus Torvalds
On Sat, Jul 16, 2022 at 2:35 PM Linus Torvalds wrote: > > That said, even those type simplifications do not fix the fundamental > issue. That "DIV_ROUND_UP()" still ends up being a 64-bit divide, > although now it's at least a "64-by-32" bit divide. Hmm. The "DIV_ROUND_UP()" issue could be solved

Re: [PATCH] drm: Fix EDID firmware load on resume

2022-07-16 Thread kernel test robot
, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Matthieu-CHARETTE/drm-Fix-EDID-firmware-load-on-resume/20220716-214028 base:32346491ddf24599decca06190ebca03ff9de

Re: [PATCH v5 10/13] power: supply: mt6370: Add MediaTek MT6370 charger driver

2022-07-16 Thread Sebastian Reichel
Hi, On Fri, Jul 15, 2022 at 07:26:04PM +0800, ChiaEn Wu wrote: > From: ChiaEn Wu > > MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger > with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight > driver, display bias voltage supply, one general purpose LDO, a

Re: [git pull] drm fixes for 5.19-rc7

2022-07-16 Thread Linus Torvalds
On Fri, Jul 15, 2022 at 2:09 PM Nathan Chancellor wrote: > > On Fri, Jul 15, 2022 at 01:36:17PM +1000, Dave Airlie wrote: > > Matthew Auld (1): > > drm/i915/ttm: fix sg_table construction > > This patch breaks i386_defconfig with both GCC and clang: > > ld: drivers/gpu/drm/i915/i915_scatte

[PATCH] drm/i915/gt: Remove unneeded semicolon

2022-07-16 Thread Jason Wang
The semicolon after the `}' in line 648 is unneeded. Signed-off-by: Jason Wang --- drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c index 2c35324b5f68..a6

Re: [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples

2022-07-16 Thread Sakari Ailus
Hi Laurent, On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote: > Now that a header exists with macros for the media interface bus-type > values, replace hardcoding numerical constants with the corresponding > macros in the DT binding examples. > > Signed-off-by: Laurent Pinchart >

Re: [PATCH 0/1] [RFC] drm/fourcc: Add new unsigned R16_UINT/RG1616_UINT formats

2022-07-16 Thread Dennis Tsiang
On 30/06/2022 08:47, Pekka Paalanen wrote: On Wed, 29 Jun 2022 14:53:49 + Simon Ser wrote: On Wednesday, June 29th, 2022 at 16:46, Dennis Tsiang wrote: Thanks for your comments. This is not intended to be used for KMS, where indeed there would be no difference. This proposal is for oth

[PATCH v2] i2c: imx: fix typo in comment

2022-07-16 Thread Flavio Suligoi
to provid --> to provide Signed-off-by: Flavio Suligoi --- v2: - fix typo in subject drivers/i2c/busses/i2c-imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c index e9e2db68b9fb..78fb1a4274a6 100644 --- a/driver

[PATCH] drm/amd/display: move dcn31_update_soc_for_wm_a func to dml fpu folder

2022-07-16 Thread Melissa Wen
Although dcn31_update_soc_for_wm_a() is only called in dml/dcn31/dcn31_fpu by dc->res_pool->funcs->update_soc_for_wm_a(dc, context), it's declared in dcn31_resource that is not FPU protected. Move this function to dcn31_fpu file as part of the work to isolate FPU code. Signed-off-by: Melissa Wen

Re: [PATCH] drm: Fix EDID firmware load on resume

2022-07-16 Thread kernel test robot
patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Matthieu-CHARETTE/drm-Fix-EDID-firmware-load-on-resume/20220716-214028 base:32346491ddf24599decca06190ebca

[PATCH v1 11/11] drm: Move dri1 core files to drm/dri1

2022-07-16 Thread Sam Ravnborg
To have more of the dri1 specific support in one place move the dri1 core files to the dri1 folder. The files continue to be part of the drm module, we just refer to the files with a folder name. Signed-off-by: Sam Ravnborg --- drivers/gpu/drm/Makefile | 10 +++--- driver

[PATCH v1 06/11] drm/mga: Move the mga driver to drm/dri1/

2022-07-16 Thread Sam Ravnborg
drm/dri1 is the new home for all the legacy DRI1 drivers. Signed-off-by: Sam Ravnborg Suggested-by: Javier Martinez Canillas --- drivers/gpu/drm/Makefile | 1 - drivers/gpu/drm/dri1/Makefile | 1 + drivers/gpu/drm/{ => dri1}/mga/Makefile| 0 drivers/gpu/drm/{

[PATCH v1 10/11] drm/dri1: Move Kconfig logic to drm/dri1

2022-07-16 Thread Sam Ravnborg
Move the DRI1 section from drm/Kconfig to a new Kconfig file that lives in the dri1/ directory. This isolates more of the DRI1 functionality. Signed-off-by: Sam Ravnborg --- drivers/gpu/drm/Kconfig | 77 +-- drivers/gpu/drm/dri1/Kconfig | 79 +

[PATCH v1 09/11] drm/savage: Move the savage driver to drm/dri1/

2022-07-16 Thread Sam Ravnborg
drm/dri1 is the new home for all the legacy DRI1 drivers. Signed-off-by: Sam Ravnborg Suggested-by: Javier Martinez Canillas --- drivers/gpu/drm/Makefile | 1 - drivers/gpu/drm/dri1/Makefile| 1 + drivers/gpu/drm/{ => dri1}/savage/Makefile | 0

[PATCH v1 03/11] drm/tdfx: Move the tdfx driver to drm/dri1/

2022-07-16 Thread Sam Ravnborg
drm/dri1 is the new home for all the legacy DRI1 drivers. Signed-off-by: Sam Ravnborg Suggested-by: Javier Martinez Canillas --- drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/dri1/Makefile | 5 + drivers/gpu/drm/{ => dri1}/tdfx/Makefile | 0 drivers/gpu/d

[PATCH v1 05/11] drm/i810: Move the i810 driver to drm/dri1/

2022-07-16 Thread Sam Ravnborg
drm/dri1 is the new home for all the legacy DRI1 drivers. Signed-off-by: Sam Ravnborg Suggested-by: Javier Martinez Canillas --- drivers/gpu/drm/Makefile | 1 - drivers/gpu/drm/dri1/Makefile | 1 + drivers/gpu/drm/{ => dri1}/i810/Makefile | 0 drivers/gpu/drm/{

[PATCH v1 07/11] drm/sis: Move the sis driver to drm/dri1/

2022-07-16 Thread Sam Ravnborg
drm/dri1 is the new home for all the legacy DRI1 drivers. Signed-off-by: Sam Ravnborg Suggested-by: Javier Martinez Canillas --- drivers/gpu/drm/Makefile | 1 - drivers/gpu/drm/dri1/Makefile| 1 + drivers/gpu/drm/{ => dri1}/sis/Makefile | 0 drivers/gpu/drm/{ => dri

[PATCH v1 08/11] drm/via: Move the via driver to drm/dri1/

2022-07-16 Thread Sam Ravnborg
drm/dri1 is the new home for all the legacy DRI1 drivers. Used the opportunity to rename the file to via.c to match the name of the driver. Signed-off-by: Sam Ravnborg Suggested-by: Javier Martinez Canillas --- drivers/gpu/drm/Makefile | 1 - drivers/gpu/drm/dri1/Makef

[PATCH v1 02/11] drm: Rename CONFIG_DRM_LEGACY to CONFIG_DRM_DRI1

2022-07-16 Thread Sam Ravnborg
The rename is done to make it more obvious what is DRI1 drivers and what is other type of legacy. Signed-off-by: Sam Ravnborg --- arch/powerpc/configs/pmac32_defconfig | 2 +- arch/powerpc/configs/ppc6xx_defconfig | 2 +- drivers/char/agp/Makefile | 2 +- drivers/char/agp/agp.h

[PATCH v1 04/11] drm/r128: Move the r128 driver to drm/dri1/

2022-07-16 Thread Sam Ravnborg
drm/dri1 is the new home for all the legacy DRI1 drivers. Signed-off-by: Sam Ravnborg Suggested-by: Javier Martinez Canillas --- drivers/gpu/drm/Makefile | 1 - drivers/gpu/drm/dri1/Makefile | 1 + drivers/gpu/drm/{ => dri1}/r128/Makefile | 0 drivers/g

[PATCH v1 01/11] drm: rename DRIVER_LEGACY to DRIVER_DRI1

2022-07-16 Thread Sam Ravnborg
"legacy" is a general term - be specific and use the term dri1. The first step is to rename DRIVER_LEGACY to DRIVER_DRI1. Suggested-by: Javier Martinez Canillas Signed-off-by: Sam Ravnborg --- drivers/gpu/drm/drm_agpsupport.c| 4 ++-- drivers/gpu/drm/drm_bufs.c | 22 +++---

[PATCH v1 0/11] drm: move dri1 drivers to drm/dri1/

2022-07-16 Thread Sam Ravnborg
While discussing the way forward for the via driver Javier came up with the proposal to move all DRI1 drivers to their own folder. The idea is to move the old DRI1 drivers so one do not accidentally consider them modern drivers. This set of patches implements this idea. To prepare the move, DRIV

Re: [v3] drm/i915/ttm: fix sg_table construction

2022-07-16 Thread Guenter Roeck
On Mon, Jul 11, 2022 at 09:58:59AM +0100, Matthew Auld wrote: > If we encounter some monster sized local-memory page that exceeds the > maximum sg length (UINT32_MAX), ensure that don't end up with some > misaligned address in the entry that follows, leading to fireworks > later. Also ensure we hav

Re: (subset) [PATCH v2 0/9] dt-bindings: msm/dp: cleanup Qualcomm DP and eDP bidndings

2022-07-16 Thread Bjorn Andersson
On Sun, 10 Jul 2022 11:41:24 +0300, Dmitry Baryshkov wrote: > Fix several issues with the DP and eDP bindings on the Qualcomm > platforms. While we are at it, fix several small issues with platform > files declaring these controllers. > > Changes since v1: > - Reordered patches to cleanup dts fir

Re: (subset) [PATCH v2 00/11] dt-bindings: display/msm: rework MDSS and DPU bindings

2022-07-16 Thread Bjorn Andersson
On Sun, 10 Jul 2022 12:00:29 +0300, Dmitry Baryshkov wrote: > Create separate YAML schema for MDSS devicesd$ (both for MDP5 and DPU > devices). Cleanup DPU schema files, so that they do not contain schema > for both MDSS and DPU nodes. Apply misc small fixes to the DPU schema > afterwards. > > Cha

Re: [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples

2022-07-16 Thread Laurent Pinchart
Hi Sakari, On Sat, Jul 16, 2022 at 12:28:45PM +0300, Sakari Ailus wrote: > On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote: > > Now that a header exists with macros for the media interface bus-type > > values, replace hardcoding numerical constants with the corresponding > > macro

Re: [PATCH v2 3/9] arm64: dts: qcom: sc7280: split register block for DP controller

2022-07-16 Thread Bjorn Andersson
On Sun 10 Jul 03:41 CDT 2022, Dmitry Baryshkov wrote: > Follow the schema for the DP controller and declare 5 register regions > instead of using a single region for all the registers. Note, this > extends the dts by adding p1 region to the DP node (to be used for DP > MST). > Reviewed-by: Bjorn

Re: [PATCH v2 1/9] arm64: dts: qcom: sc7180: split register block for DP controller

2022-07-16 Thread Bjorn Andersson
On Sun 10 Jul 03:41 CDT 2022, Dmitry Baryshkov wrote: > Follow the schema for the DP controller and declare 5 register regions > instead of using a single region for all the registers. Note, this > extends the dts by adding p1 region to the DP node (to be used for DP > MST). > Reviewed-by: Bjorn

Re: [PATCH 2/2] drm/msm/dsi: use drm_dsc_config instead of msm_display_dsc_config

2022-07-16 Thread Marijn Suijten
On 2022-07-11 13:04:32, Dmitry Baryshkov wrote: > There is no need to use the struct msm_display_dsc_config wrapper inside > the dsi driver, use the struct drm_dsc_config directly to pass pps data. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten > --- > drivers/gpu/drm/msm/dis

[PATCH] drm/bridge: megachips: Fix a null pointer dereference bug

2022-07-16 Thread Zheyu Ma
When removing the module we will get the following warning: [ 31.911505] i2c-core: driver [stdp2690-ge-b850v3-fw] unregistered [ 31.912484] general protection fault, probably for non-canonical address 0xdc01: [#1] PREEMPT SMP KASAN PTI [ 31.913338] KASAN: null-ptr-deref in

Re: [Intel-gfx] [PATCH RFC] drm/i915/gt: Retry RING_HEAD reset until it sticks

2022-07-16 Thread Rodrigo Vivi
On Fri, Jul 15, 2022 at 09:26:16AM +0100, Mauro Carvalho Chehab wrote: > From: Chris Wilson > > On Haswell, in particular, we see an issue where resets fails because Can we then make this platform specific? Only because some older hw doesn't behave like expected we shouldn't make this a default

Re: [PATCH 1/2] drm/msm/dpu: use drm_dsc_config instead of msm_display_dsc_config

2022-07-16 Thread Marijn Suijten
On 2022-07-11 13:04:31, Dmitry Baryshkov wrote: > There is no need to use the struct msm_display_dsc_config wrapper inside > the dpu driver, use the struct drm_dsc_config directly to pass pps data. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten > --- > drivers/gpu/drm/msm/dis

[GIT PULL FOR v5.20] Miscellaneous R-Car DU fixes and enhancements

2022-07-16 Thread Laurent Pinchart
Hi Dave, Daniel, I would have sworn I had sent this pull request a week ago, but I can't find any trace of it in the mailing list archive, so I'm not sure what I messed up. If there's still time for v5.20 it would be nice to get those 5 patches in, otherwise I'll resend for v5.21. The following c

[Bug 216120] [BISECTED][REGRESSION] drm/amdgpu: add drm buddy support to amdgpu

2022-07-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216120 mat2003...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [PATCH v2 24/39] drm/i915: dvo_sil164.c: use SPDX header

2022-07-16 Thread Joe Perches
On Fri, 2022-07-15 at 17:35 -0400, Rodrigo Vivi wrote: > On Wed, Jul 13, 2022 at 09:12:12AM +0100, Mauro Carvalho Chehab wrote: > > This file is licensed with MIT license. Change its license text > > to use SPDX. > > > > Signed-off-by: Mauro Carvalho Chehab > > Reviewed-by: Rodrigo Vivi No

Re: [git pull] drm fixes for 5.19-rc7

2022-07-16 Thread Nathan Chancellor
On Fri, Jul 15, 2022 at 01:36:17PM +1000, Dave Airlie wrote: > Matthew Auld (1): > drm/i915/ttm: fix sg_table construction This patch breaks i386_defconfig with both GCC and clang: ld: drivers/gpu/drm/i915/i915_scatterlist.o: in function `i915_rsgt_from_mm_node': i915_scatterlist.c:(.t

Re: [PATCH v2] i2c: imx: fix typo in comment

2022-07-16 Thread Oleksij Rempel
On Fri, Jul 15, 2022 at 03:42:18PM +0200, Flavio Suligoi wrote: > to provid --> to provide > > Signed-off-by: Flavio Suligoi Acked-by: Oleksij Rempel Thank you. > --- > v2: > - fix typo in subject > > drivers/i2c/busses/i2c-imx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH v2 22/39] drm/i915: stop using kernel-doc markups for something else

2022-07-16 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:10AM +0100, Mauro Carvalho Chehab wrote: > There are some occurrences of "/**" that aren't actually part of > a kernel-doc markup. Replace them by "/*", in order to make easier > to identify what i915 files contain kernel-doc markups. > > Signed-off-by: Mauro Carvalho

Re: [PATCH v2 25/39] drm/i915: i915_vma_resource.c: fix some kernel-doc markups

2022-07-16 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:13AM +0100, Mauro Carvalho Chehab wrote: > Building docs currently produces two warnings: > > Documentation/foo/i915:71: > ./drivers/gpu/drm/i915/i915_vma_resource.c:286: WARNING: Inline strong > start-string without end-string. > Documentation/foo/i915:71:

Re: [Intel-gfx] [PATCH v2 16/39] drm/i915: intel_fb: fix a kernel-doc issue with Sphinx

2022-07-16 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:04AM +0100, Mauro Carvalho Chehab wrote: > We can't use %foo[] as this produces a bad markup. > Use instead, the emphasis markup directly. > > Fix this issue: > Documentation/gpu/i915:136: > ./drivers/gpu/drm/i915/display/intel_fb.c:280: WARNING: Inline strong

Re: [Intel-gfx] [PATCH v2 26/39] drm/i915: i915_gem.c fix a kernel-doc issue

2022-07-16 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:14AM +0100, Mauro Carvalho Chehab wrote: > Prevent this Sphinx warning: > > Documentation/foo/i915:728: ./drivers/gpu/drm/i915/i915_gem.c:447: > WARNING: Inline emphasis start-string without end-string. > > By using @data to identify the data field, as expecte

Re: [Intel-gfx] [PATCH v2 20/39] drm/i915: i915_gem_wait.c: fix a kernel-doc markup

2022-07-16 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:08AM +0100, Mauro Carvalho Chehab wrote: > The return codes for i915_gem_wait_ioctl() have identation issues, > and will be displayed on a very confusing way. Use lists to improve > its output. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi > -

Re: [PATCH] drm/nouveau/bios: set info only when the return is not 0

2022-07-16 Thread Tom Rix
On 7/15/22 12:09 PM, Lyude Paul wrote: On Mon, 2022-07-04 at 17:32 -0400, Lyude Paul wrote: Reviewed-by: Lyude Paul Currently on flakey internet in the back of a car, so I probably won't be able to push this until I get back tonight or early tomorrow Whoops! Slipped my mind when I got back,

[PATCH] drm/i915/guc: support v69 in parallel to v70

2022-07-16 Thread Daniele Ceraolo Spurio
This patch re-introduces support for GuC v69 in parallel to v70. As this is a quick fix, v69 has been re-introduced as the single "fallback" guc version in case v70 is not available on disk. All v69 specific code has been labeled as such for easy identification, and the same was done for all v70 fu

[PATCH] drm/i915/guc: Check for ct enabled while waiting for response

2022-07-16 Thread Zhanjun Dong
We are seeing error message of "No response for request". Some cases happened while waiting for response and reset/suspend action was triggered. In this case, no response is not an error, active requests will be cancelled. This patch will handle this condition and change the error message into deb

Re: [PATCH 1/2] drm/msm/dpu: use drm_dsc_config instead of msm_display_dsc_config

2022-07-16 Thread Abhinav Kumar
On 7/11/2022 3:04 AM, Dmitry Baryshkov wrote: There is no need to use the struct msm_display_dsc_config wrapper inside the dpu driver, use the struct drm_dsc_config directly to pass pps data. Signed-off-by: Dmitry Baryshkov This is a nice cleanup! Reviewed-by: Abhinav Kumar --- drivers

Re: [PATCH v2 23/39] drm/i915: dvo_ch7xxx.c: use SPDX header

2022-07-16 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:11AM +0100, Mauro Carvalho Chehab wrote: > This file is licensed with MIT license. Change its license text > to use SPDX. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi > --- > > To avoid mailbombing on a large number of people, only mailing l

Re: [PATCH v2 21/39] drm/i915: fix i915_gem_ttm_move.c DOC: markup

2022-07-16 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:09AM +0100, Mauro Carvalho Chehab wrote: > The doc markup should not end with ":", as it would generate a > warning on Sphinx while generating the cross-reference tag. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi > --- > > To avoid mailbombi

Re: [Intel-gfx] [PATCH v2 28/39] drm/i915: i915_deps: use a shorter title markup

2022-07-16 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:16AM +0100, Mauro Carvalho Chehab wrote: > The DOC: tag waits for a one-line short title for the doc > section. Using multiple lines will produce a weird output. > So, add a shorter description for the title, while keeping > the current content below it. > > Signed-of

Re: [git pull] drm fixes for 5.19-rc7

2022-07-16 Thread pr-tracker-bot
The pull request you sent on Fri, 15 Jul 2022 13:36:17 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2022-07-15 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/fcd1b2b9c7b085e9c200f73c079b322eb8c666f9 Thank you! -- Deet-doot-dot, I am a bot. https://k

Re: [PATCH] drm/nouveau/bios: set info only when the return is not 0

2022-07-16 Thread Lyude Paul
On Mon, 2022-07-04 at 17:32 -0400, Lyude Paul wrote: > Reviewed-by: Lyude Paul > > Currently on flakey internet in the back of a car, so I probably won't be > able > to push this until I get back tonight or early tomorrow Whoops! Slipped my mind when I got back, but I just remembered it now so I

Re: [Intel-gfx] [PATCH v2 13/39] drm/i915: i915_gpu_error.c: document dump_flags

2022-07-16 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:01AM +0100, Mauro Carvalho Chehab wrote: > Kernel-doc dump_flags parameter is missing at i915_capture_error_state(). > Document it. > > Fixes: a6f0f9cf330a ("drm/i915/guc: Plumb GuC-capture into gpu_coredump") Why the fix here and not in the i915_vma_destroy_locked o

Re: [Intel-gfx] [PATCH v2 14/39] drm/i915: document kernel-doc trivial issues

2022-07-16 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:02AM +0100, Mauro Carvalho Chehab wrote: > Fix those kernel-doc warnings: > drivers/gpu/drm/i915/intel_region_ttm.c:199: warning: Function > parameter or member 'offset' not described in > 'intel_region_ttm_resource_alloc' > drivers/gpu/drm/i915/i915_vma_

Re: [Intel-gfx] [PATCH v3 5/7] drm/i915: Check if the size is too big while creating shmem file

2022-07-16 Thread kernel test robot
-creation/20220714-171019 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip config: i386-randconfig-a004 (https://download.01.org/0day-ci/archive/20220716/202207161058.dmozoqzg-...@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project

[PATCH] drm/msm/dpu: populate wb or intf before reset_intf_cfg

2022-07-16 Thread Abhinav Kumar
dpu_encoder_helper_phys_cleanup() was not populating neither wb or intf to the intf_cfg before calling the reset_intf_cfg(). This causes the reset of the active bits of wb/intf to be skipped which is incorrect. Fix this by populating the relevant wb or intf indices correctly. Fixes: ae4d721ce100

Re: [Freedreno] [PATCH 2/2] drm/msm/dsi: use drm_dsc_config instead of msm_display_dsc_config

2022-07-16 Thread Abhinav Kumar
On 7/11/2022 3:04 AM, Dmitry Baryshkov wrote: There is no need to use the struct msm_display_dsc_config wrapper inside the dsi driver, use the struct drm_dsc_config directly to pass pps data. This change is good but needs to be rebased? See below Signed-off-by: Dmitry Baryshkov ---

Re: [PATCH 1/2] drm/ttm: fix locking in vmap/vunmap TTM GEM helpers

2022-07-16 Thread Thomas Zimmermann
Hi Am 15.07.22 um 13:15 schrieb Christian König: I've stumbled over this while reviewing patches for DMA-buf and it looks like we completely messed the locking up here. In general most TTM function should only be called while holding the appropriate BO resv lock. Without this we could break the

Re: [PATCH v5 13/13] video: backlight: mt6370: Add MediaTek MT6370 support

2022-07-16 Thread Daniel Thompson
On Fri, Jul 15, 2022 at 02:38:45PM +0200, AngeloGioacchino Del Regno wrote: > Il 15/07/22 13:26, ChiaEn Wu ha scritto: > > From: ChiaEn Wu > > > > MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger > > with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight > >

[PATCH v9 13/14] tools: add hmm gup tests for device coherent type

2022-07-16 Thread Alex Sierra
The intention is to test hmm device coherent type under different get user pages paths. Also, test gup with FOLL_LONGTERM flag set in device coherent pages. These pages should get migrated back to system memory. Signed-off-by: Alex Sierra Reviewed-by: Alistair Popple --- tools/testing/selftests

Re: [PATCH v2 17/39] drm/i915: skl_scaler: fix return value kernel-doc markup

2022-07-16 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:05AM +0100, Mauro Carvalho Chehab wrote: > The way it is, it produces this warning: > > Documentation/gpu/i915:150: > ./drivers/gpu/drm/i915/display/skl_scaler.c:213: WARNING: Block quote ends > without a blank line; unexpected unindent. > > Use list markups

Re: [PATCH v2 24/39] drm/i915: dvo_sil164.c: use SPDX header

2022-07-16 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:12AM +0100, Mauro Carvalho Chehab wrote: > This file is licensed with MIT license. Change its license text > to use SPDX. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi > --- > > To avoid mailbombing on a large number of people, only mai

Re: [PATCH v5 12/13] leds: flashlight: mt6370: Add MediaTek MT6370 flashlight support

2022-07-16 Thread Andy Shevchenko
On Fri, Jul 15, 2022 at 1:29 PM ChiaEn Wu wrote: > The MediaTek MT6370 is a highly-integrated smart power management IC, > whichincludes a single cell Li-Ion/Li-Polymer switching battery which includes > charger, a USB Type-C & Power Delivery (PD) controller, dual Flash > LED current sources, a

Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

2022-07-16 Thread Andy Shevchenko
On Fri, Jul 15, 2022 at 1:29 PM ChiaEn Wu wrote: > > From: ChiYuan Huang > > The MediaTek MT6370 is a highly-integrated smart power management IC, > which includes a single cell Li-Ion/Li-Polymer switching battery > charger, a USB Type-C & Power Delivery (PD) controller, dual > Flash LED current

Re: [PATCH v14 05/10] drm/mediatek: Add MT8195 Embedded DisplayPort driver

2022-07-16 Thread kernel test robot
op.org/drm/drm-misc drm-misc-next config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20220716/202207160102.zyueii7s-...@intel.com/config) compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/m

Re: [PATCH 2/3] drm/komeda - At init write GCU control block to handle already on DPU

2022-07-16 Thread Carsten Haitzler
On 7/8/22 17:07, Liviu Dudau wrote: On Mon, Jun 06, 2022 at 12:47:13PM +0100, carsten.haitz...@foss.arm.com wrote: From: Carsten Haitzler If something has already set up the DPU before the komeda driver comes up, it will fail to init because it was just writing to the SRST bit in the GCU co

[PATCH v9 04/14] mm: handling Non-LRU pages returned by vm_normal_pages

2022-07-16 Thread Alex Sierra
With DEVICE_COHERENT, we'll soon have vm_normal_pages() return device-managed anonymous pages that are not LRU pages. Although they behave like normal pages for purposes of mapping in CPU page, and for COW. They do not support LRU lists, NUMA migration or THP. Callers to follow_page() currently do

Re: [PATCH v2 27/39] drm/i915: i915_scatterlist.h: fix some kernel-doc markups

2022-07-16 Thread Rodrigo Vivi
On Wed, Jul 13, 2022 at 09:12:15AM +0100, Mauro Carvalho Chehab wrote: > Building docs currently produces this warning: > > Documentation/foo/i915:159: > ./drivers/gpu/drm/i915/i915_scatterlist.h:73: WARNING: Inline strong > start-string without end-string. > > That's because @foo evaluat

Re: [PATCH 1/2] drm/ttm: fix locking in vmap/vunmap TTM GEM helpers

2022-07-16 Thread Christian König
Am 15.07.22 um 17:36 schrieb Thomas Zimmermann: Hi Am 15.07.22 um 13:15 schrieb Christian König: I've stumbled over this while reviewing patches for DMA-buf and it looks like we completely messed the locking up here. In general most TTM function should only be called while holding the appropri

Re: [PATCH 3/3] drm/komeda - Fix handling of pending crtc state commit to avoid lock-up

2022-07-16 Thread Carsten Haitzler
On 7/11/22 11:13, Liviu Dudau wrote: On Fri, Jul 08, 2022 at 07:03:37PM +0100, Carsten Haitzler wrote: On 7/8/22 17:02, Liviu Dudau wrote: On Mon, Jun 06, 2022 at 12:47:14PM +0100, carsten.haitz...@foss.arm.com wrote: From: Carsten Haitzler Hi Carsten, Sometimes there is an extra dc

Re: [PATCH 1/2] drm/ttm: fix locking in vmap/vunmap TTM GEM helpers

2022-07-16 Thread Dmitry Osipenko
On 7/15/22 14:33, Christian König wrote: > Am 15.07.22 um 13:31 schrieb Dmitry Osipenko: >> On 7/15/22 14:15, Christian König wrote: >>> I've stumbled over this while reviewing patches for DMA-buf and it looks >>> like we completely messed the locking up here. >>> >>> In general most TTM function s

[PATCH v9 11/14] tools: update hmm-test to support device coherent type

2022-07-16 Thread Alex Sierra
Test cases such as migrate_fault and migrate_multiple, were modified to explicit migrate from device to sys memory without the need of page faults, when using device coherent type. Snapshot test case updated to read memory device type first and based on that, get the proper returned results migrat

Re: [PATCH 07/12] drm/i915/guc: Route semaphores to GuC for Gen12+

2022-07-16 Thread Ceraolo Spurio, Daniele
On 7/12/2022 4:31 PM, john.c.harri...@intel.com wrote: From: Michał Winiarski Since we're going to use semaphores in selftests (and eventually in regular GuC submission), let's route semaphores to GuC. I'd specify that this interrupt is only relevant for semaphores that context switch out

Re: [PATCH v5 10/13] power: supply: mt6370: Add MediaTek MT6370 charger driver

2022-07-16 Thread Andy Shevchenko
On Fri, Jul 15, 2022 at 1:29 PM ChiaEn Wu wrote: > > From: ChiaEn Wu > > MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger > with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight > driver, display bias voltage supply, one general purpose LDO, and the > USB

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-07-16 Thread Dmitry Osipenko
On 7/15/22 18:18, Andrey Grodzovsky wrote: > > On 2022-07-14 17:16, Alex Deucher wrote: >> On Thu, Jul 14, 2022 at 1:58 PM Andrey Grodzovsky >> wrote: >>> On 2022-07-14 12:22, Alex Deucher wrote: >>> On Thu, Jul 14, 2022 at 10:14 AM Andrey Grodzovsky wrote: > On 2022-07-14 05:57, D

[PATCH v9 09/14] lib: test_hmm add module param for zone device type

2022-07-16 Thread Alex Sierra
In order to configure device coherent in test_hmm, two module parameters should be passed, which correspond to the SP start address of each device (2) spm_addr_dev0 & spm_addr_dev1. If no parameters are passed, private device type is configured. Signed-off-by: Alex Sierra Acked-by: Felix Kuehling

[PATCH v9 07/14] drm/amdkfd: add SPM support for SVM

2022-07-16 Thread Alex Sierra
When CPU is connected throug XGMI, it has coherent access to VRAM resource. In this case that resource is taken from a table in the device gmc aperture base. This resource is used along with the device type, which could be DEVICE_PRIVATE or DEVICE_COHERENT to create the device page map region. Also

[PATCH v9 02/14] mm: move page zone helpers from mm.h to mmzone.h

2022-07-16 Thread Alex Sierra
[WHY] It makes more sense to have these helpers in zone specific header file, rather than the generic mm.h Signed-off-by: Alex Sierra --- include/linux/memremap.h | 2 +- include/linux/mm.h | 78 --- include/linux/mmzone.h | 80 +++

[PATCH v9 06/14] mm/gup: migrate device coherent pages when pinning instead of failing

2022-07-16 Thread Alex Sierra
From: Alistair Popple Currently any attempts to pin a device coherent page will fail. This is because device coherent pages need to be managed by a device driver, and pinning them would prevent a driver from migrating them off the device. However this is no reason to fail pinning of these pages.

[PATCH 1/3] drm: Use original src rect while initializing damage iterator

2022-07-16 Thread Jouni Högander
drm_plane_state->src might be modified by the driver. This is done e.g. in i915 driver when there is bigger framebuffer than the plane and there is some offset within framebuffer. I915 driver calculates separate offset and adjusts src rect coords to be relative to this offset. Damage clips are stil

[PATCH v9 08/14] lib: test_hmm add ioctl to get zone device type

2022-07-16 Thread Alex Sierra
new ioctl cmd added to query zone device type. This will be used once the test_hmm adds zone device coherent type. Signed-off-by: Alex Sierra Acked-by: Felix Kuehling Reviewed-by: Alistair Poppple Signed-off-by: Christoph Hellwig --- lib/test_hmm.c | 11 +-- lib/test_hmm_uapi.h |

Re: [PATCH v2 16/29] ACPI: video: Add Nvidia WMI EC brightness control detection

2022-07-16 Thread Hans de Goede
Hi, On 7/15/22 17:32, Daniel Dadap wrote: > > >> On Jul 15, 2022, at 06:59, Hans de Goede wrote: >> >> Hi Daniel, >> >>> On 7/12/22 22:13, Daniel Dadap wrote: >>> Thanks, Hans: >>> On 7/12/22 14:38, Hans de Goede wrote: On some new laptop designs a new Nvidia specific WMI interface i

[PATCH v9 03/14] mm: add zone device coherent type memory support

2022-07-16 Thread Alex Sierra
Device memory that is cache coherent from device and CPU point of view. This is used on platforms that have an advanced system bus (like CAPI or CXL). Any page of a process can be migrated to such memory. However, no one should be allowed to pin such memory so that it can always be evicted. Signed

Re: [PATCH 3/3] drm/komeda - Fix handling of pending crtc state commit to avoid lock-up

2022-07-16 Thread Carsten Haitzler
On 7/14/22 13:20, Robin Murphy wrote: On 2022-07-11 11:13, Liviu Dudau wrote: [...] But nothing worrying. It does work, though doesn't compile due to: drivers/gpu/drm/arm/display/komeda/komeda_kms.c: In function ‘komeda_kms_atomic_commit_hw_done’: drivers/gpu/drm/arm/display/komeda/komeda_km

Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

2022-07-16 Thread Andy Shevchenko
On Fri, Jul 15, 2022 at 2:40 PM AngeloGioacchino Del Regno wrote: > Il 15/07/22 13:26, ChiaEn Wu ha scritto: ... > > +#define STATE_OFF0 > > +#define STATE_KEEP 1 > > +#define STATE_ON 2 > > I propose, instead: > >

Re: [PATCH v2 16/29] ACPI: video: Add Nvidia WMI EC brightness control detection

2022-07-16 Thread Daniel Dadap
> On Jul 15, 2022, at 06:59, Hans de Goede wrote: > > Hi Daniel, > >> On 7/12/22 22:13, Daniel Dadap wrote: >> Thanks, Hans: >> >>> On 7/12/22 14:38, Hans de Goede wrote: >>> On some new laptop designs a new Nvidia specific WMI interface is present >>> which gives info about panel brightness

[PATCH v9 10/14] lib: add support for device coherent type in test_hmm

2022-07-16 Thread Alex Sierra
Device Coherent type uses device memory that is coherently accesible by the CPU. This could be shown as SP (special purpose) memory range at the BIOS-e820 memory enumeration. If no SP memory is supported in system, this could be faked by setting CONFIG_EFI_FAKE_MEMMAP. Currently, test_hmm only sup

Re: [PATCH v5 06/13] dt-bindings: mfd: Add MediaTek MT6370

2022-07-16 Thread Rob Herring
On Fri, 15 Jul 2022 19:26:00 +0800, ChiaEn Wu wrote: > From: ChiYuan Huang > > Add MediaTek MT6370 binding documentation. > > Signed-off-by: ChiYuan Huang > Reviewed-by: Krzysztof Kozlowski > --- > .../devicetree/bindings/mfd/mediatek,mt6370.yaml | 280 > + > include/dt

[PATCH 2/3] drm/i915/display: Use original src in psr2 sel fetch area calculation

2022-07-16 Thread Jouni Högander
drm_plane_state->src is modified when offset is calculated: before calculation: src.x1 = 8192, src.y1 = 8192 after calculation (pitch = 65536, cpp = 4, alignment = 262144) src.x1 = 8192, src.y1 = 0, offset = 0x2000 Damage clips are relative to original coodrdinates provided by user-space. To

  1   2   >