Re: [PATCH v6 4/8] drm/bridge: mhdp8546: Set input_bus_flags from atomic_check

2023-05-16 Thread Aradhya Bhatia
Hi Neil, On 16-May-23 12:54, Neil Armstrong wrote: > On 09/05/2023 11:30, Aradhya Bhatia wrote: >> From: Nikhil Devshatwar >> >> input_bus_flags are specified in drm_bridge_timings (legacy) as well >> as drm_bridge_state->input_bus_cfg.flags >> >> The flags from the timings will be deprecated.

[PATCH v2] drm/i915: Fix memory leaks in function live_nop_switch

2023-05-16 Thread Cong Liu
Be sure to properly free the allocated memory before exiting the live_nop_switch function. Signed-off-by: Cong Liu Suggested-by: Rodrigo Vivi --- .../gpu/drm/i915/gem/selftests/i915_gem_context.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git

[PATCH] drm/drm_atomic_helper.c: fix a typo

2023-05-16 Thread Sui Jingfeng
From: Sui Jingfeng <15330273...@189.cn> Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/drm_atomic_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index e0ab555aad2c..41b8066f61ff 100644 ---

RE: [Freedreno] [PATCH v5 6/8] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters

2023-05-16 Thread Kandpal, Suraj
> -Original Message- > From: Dmitry Baryshkov > Sent: Wednesday, May 17, 2023 5:33 AM > To: Kandpal, Suraj ; David Airlie > ; Daniel Vetter ; Jani Nikula > ; Joonas Lahtinen > ; Vivi, Rodrigo ; > Tvrtko Ursulin ; Rob Clark > ; Abhinav Kumar ; > Sean Paul ; Marijn Suijten > > Cc:

RE: [PATCH v6 6/8] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters

2023-05-16 Thread Kandpal, Suraj
> > The array of rc_parameters contains a mixture of parameters from DSC 1.1 > and DSC 1.2 standards. Split these tow configuration arrays in preparation to > adding more configuration data. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/display/drm_dsc_helper.c | 139

Re: [PATCH V6 0/6] drm: bridge: samsung-dsim: Support variable clocking

2023-05-16 Thread Adam Ford
On Tue, May 16, 2023 at 5:57 PM Marek Szyprowski wrote: > > On 16.05.2023 01:57, Adam Ford wrote: > > This series fixes the blanking pack size and the PMS calculation. It then > > adds support to allows the DSIM to dynamically DPHY clocks, and support > > non-burst mode while allowing the

Re: [PATCH V6 5/6] drm: bridge: samsung-dsim: Dynamically configure DPHY timing

2023-05-16 Thread Adam Ford
On Mon, May 15, 2023 at 6:57 PM Adam Ford wrote: > > The DPHY timings are currently hard coded. Since the input > clock can be variable, the phy timings need to be variable > too. To facilitate this, we need to cache the hs_clock > based on what is generated from the PLL. > > The

Re: [v2,11/12] drm/fbdev-generic: Implement dedicated fbdev I/O helpers

2023-05-16 Thread Sui Jingfeng
Hi, Thomas After apply your patch set, the kernel with arch/loongarch/configs/loongson3_defconfig can not finish compile anymore.  gcc complains:   AR  drivers/gpu/built-in.a   AR  drivers/built-in.a   AR  built-in.a   AR  vmlinux.a   LD  vmlinux.o   OBJCOPY

Re: [PATCH v10 4/8] drm/msm: Add MSM-specific DSC helper methods

2023-05-16 Thread Jessica Zhang
On 5/16/2023 3:49 PM, Marijn Suijten wrote: On 2023-05-16 01:07:05, Dmitry Baryshkov wrote: On 16/05/2023 01:01, Marijn Suijten wrote: On 2023-05-15 13:29:21, Jessica Zhang wrote: Const, as requested elsewhere. But this function is not used anywhere in any of the series (because we

[PATCH v6 5/8] drm/display/dsc: use flat array for rc_parameters lookup

2023-05-16 Thread Dmitry Baryshkov
Next commits are going to add support for additional RC parameter lookup tables. These tables are going to use different bpp/bpc combinations, thus it makes little sense to keep the 2d array for RC parameters. Switch to using the flat array. Reviewed-by: Jani Nikula Signed-off-by: Dmitry

[PATCH v6 3/8] drm/i915/dsc: move DSC tables to DRM DSC helper

2023-05-16 Thread Dmitry Baryshkov
Move DSC RC tables to DRM DSC helper. No additional code changes and/or cleanups are a part of this commit, it will be cleaned up in the followup commits. Reviewed-by: Jani Nikula Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dsc_helper.c | 372 ++

[PATCH v6 4/8] drm/i915/dsc: stop using interim structure for calculated params

2023-05-16 Thread Dmitry Baryshkov
Stop using an interim structure rc_parameters for storing calculated params and then setting drm_dsc_config using that structure. Instead put calculated params into the struct drm_dsc_config directly. Reviewed-by: Jani Nikula Signed-off-by: Dmitry Baryshkov ---

[PATCH v6 8/8] drm/display/dsc: add YCbCr 4:2:2 and 4:2:0 RC parameters

2023-05-16 Thread Dmitry Baryshkov
Include RC parameters for YCbCr 4:2:2 and 4:2:0 configurations. Reviewed-by: Suraj Kandpal Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dsc_helper.c | 450 +++ include/drm/display/drm_dsc_helper.h | 2 + 2 files changed, 452 insertions(+) diff

[PATCH v6 7/8] drm/display/dsc: include the rest of pre-SCR parameters

2023-05-16 Thread Dmitry Baryshkov
DSC model contains pre-SCR RC parameters for other bpp/bpc combinations, include them here for completeness. The values were generated from the 'pre_scr_cfg_files_for_reference' files found in DSC models 20210623. The same fileset is a part of DSC model 20161212. Reviewed-by: Jessica Zhang

[PATCH v6 2/8] drm/i915/dsc: move rc_buf_thresh values to common helper

2023-05-16 Thread Dmitry Baryshkov
The rc_buf_thresh values are common to all DSC implementations. Move them to the common helper together with the code to propagate them to the drm_dsc_config. Reviewed-by: Jani Nikula Reviewed-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dsc_helper.c |

[PATCH v6 6/8] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters

2023-05-16 Thread Dmitry Baryshkov
The array of rc_parameters contains a mixture of parameters from DSC 1.1 and DSC 1.2 standards. Split these tow configuration arrays in preparation to adding more configuration data. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dsc_helper.c | 139 ++

[PATCH v6 1/8] drm/i915/dsc: change DSC param tables to follow the DSC model

2023-05-16 Thread Dmitry Baryshkov
After cross-checking DSC models (20150914, 20161212, 20210623) change values in rc_parameters tables to follow config files present inside the DSC model. Handle two places, where i915 tables diverged from the model, by patching the rc values in the code. Note: I left one case uncorrected,

[PATCH v6 0/8] drm/i915: move DSC RC tables to drm_dsc_helper.c

2023-05-16 Thread Dmitry Baryshkov
Other platforms (msm) will benefit from sharing the DSC config setup functions. This series moves parts of static DSC config data from the i915 driver to the common helpers to be used by other drivers. Note: the RC parameters were cross-checked against config files found in DSC model 2021062,

Re: [Freedreno] [PATCH v5 6/8] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters

2023-05-16 Thread Dmitry Baryshkov
On 16/05/2023 21:46, Kandpal, Suraj wrote: The array of rc_parameters contains a mixture of parameters from DSC 1.1 and DSC 1.2 standards. Split these tow configuration arrays in preparation to adding more configuration data. Hi , Needed to add some more comments apart from the previous ones

Re: [PATCH] drm/i915/pmu: Change bitmask of enabled events to u32

2023-05-16 Thread Umesh Nerlige Ramappa
On Tue, May 16, 2023 at 03:13:01PM -0700, Umesh Nerlige Ramappa wrote: On Tue, May 16, 2023 at 10:24:45AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Having it as u64 was a confusing (but harmless) mistake. Also add some asserts to make sure the internal field does not overflow in the

Re: [PATCH v4 2/2] drm/msm: Be more shouty if per-process pgtables aren't working

2023-05-16 Thread Dmitry Baryshkov
On 17/05/2023 01:20, Rob Clark wrote: From: Rob Clark Otherwise it is not always obvious if a dt or iommu change is causing us to fall back to global pgtable. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_iommu.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-)

Re: [PATCH v4 1/2] iommu/arm-smmu-qcom: Fix missing adreno_smmu's

2023-05-16 Thread Dmitry Baryshkov
On 17/05/2023 01:20, Rob Clark wrote: From: Rob Clark When the special handling of qcom,adreno-smmu was moved into qcom_smmu_create(), it was overlooked that we didn't have all the required entries in qcom_smmu_impl_of_match. So we stopped getting adreno_smmu_priv on sc7180, breaking

Re: [Freedreno] [PATCH v10 8/8] drm/msm/dsi: update hdisplay calculation for dsi_timing_setup

2023-05-16 Thread Jessica Zhang
On 5/16/2023 3:45 PM, Marijn Suijten wrote: On 2023-05-16 11:18:17, Jessica Zhang wrote: On 5/14/2023 2:29 PM, Marijn Suijten wrote: On 2023-05-12 14:32:18, Jessica Zhang wrote: hdisplay for compressed images should be calculated as bytes_per_slice * slice_count. Thus, use MSM DSC helper

Re: [PATCH V6 0/6] drm: bridge: samsung-dsim: Support variable clocking

2023-05-16 Thread Marek Szyprowski
On 16.05.2023 01:57, Adam Ford wrote: > This series fixes the blanking pack size and the PMS calculation. It then > adds support to allows the DSIM to dynamically DPHY clocks, and support > non-burst mode while allowing the removal of the hard-coded clock values > for the PLL for imx8m

Re: [PATCH v10 4/8] drm/msm: Add MSM-specific DSC helper methods

2023-05-16 Thread Marijn Suijten
On 2023-05-15 17:59:14, Jessica Zhang wrote: > > The name is good, I'm just not too keen on it hiding the multiplication > > with msm_dsc_get_slice_per_intf() which is already also computed and > > available in DSI, and I assume DP too? > > Got it, I see why you want to make that change now. DP

Re: [PATCH v10 4/8] drm/msm: Add MSM-specific DSC helper methods

2023-05-16 Thread Marijn Suijten
On 2023-05-16 01:07:05, Dmitry Baryshkov wrote: > > On 16/05/2023 01:01, Marijn Suijten wrote: > > On 2023-05-15 13:29:21, Jessica Zhang wrote: > > > >>> Const, as requested elsewhere. But this function is not used anywhere > >>> in any of the series (because we replaced the usages with more

Re: [Freedreno] [PATCH v10 8/8] drm/msm/dsi: update hdisplay calculation for dsi_timing_setup

2023-05-16 Thread Marijn Suijten
On 2023-05-16 11:18:17, Jessica Zhang wrote: > On 5/14/2023 2:29 PM, Marijn Suijten wrote: > > On 2023-05-12 14:32:18, Jessica Zhang wrote: > >> > >> hdisplay for compressed images should be calculated as bytes_per_slice * > >> slice_count. Thus, use MSM DSC helper to calculate hdisplay for > >>

Re: [PATCH v2 2/2] drm/bridge: ti-sn65dsi83: Fix enable/disable flow to meet spec

2023-05-16 Thread Fabio Estevam
On Thu, May 4, 2023 at 6:12 AM Alexander Stein wrote: > > Am Mittwoch, 3. Mai 2023, 18:33:07 CEST schrieb Frieder Schrempf: > > From: Frieder Schrempf > > > > The datasheet describes the following initialization flow including > > minimum delay times between each step: > > > > 1. DSI data lanes

[PATCH v4 2/2] drm/msm: Be more shouty if per-process pgtables aren't working

2023-05-16 Thread Rob Clark
From: Rob Clark Otherwise it is not always obvious if a dt or iommu change is causing us to fall back to global pgtable. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_iommu.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_iommu.c

[PATCH v4 1/2] iommu/arm-smmu-qcom: Fix missing adreno_smmu's

2023-05-16 Thread Rob Clark
From: Rob Clark When the special handling of qcom,adreno-smmu was moved into qcom_smmu_create(), it was overlooked that we didn't have all the required entries in qcom_smmu_impl_of_match. So we stopped getting adreno_smmu_priv on sc7180, breaking per-process pgtables. Fixes: 30b912a03d91

Re: [PATCH] drm/i915/pmu: Change bitmask of enabled events to u32

2023-05-16 Thread Umesh Nerlige Ramappa
On Tue, May 16, 2023 at 10:24:45AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Having it as u64 was a confusing (but harmless) mistake. Also add some asserts to make sure the internal field does not overflow in the future. Signed-off-by: Tvrtko Ursulin Cc: Ashutosh Dixit Cc: Umesh

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Dump error capture to kernel log

2023-05-16 Thread John Harrison
On 5/16/2023 13:52, Rodrigo Vivi wrote: On Tue, May 16, 2023 at 12:21:05PM -0700, John Harrison wrote: On 5/16/2023 12:17, Belgaumkar, Vinay wrote: > On 4/18/2023 11:17 AM, [1]john.c.harri...@intel.com

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Dump error capture to kernel log

2023-05-16 Thread Rodrigo Vivi
On Tue, May 16, 2023 at 12:21:05PM -0700, John Harrison wrote: >On 5/16/2023 12:17, Belgaumkar, Vinay wrote: > > > >> On 4/18/2023 11:17 AM, [1]john.c.harri...@intel.com

[PATCH] fbdev: i810: include i810_main.h in i810_dvt.c

2023-05-16 Thread Arnd Bergmann
From: Arnd Bergmann Building with W=1 shows that a header needs to be included to make the prototypes visible: drivers/video/fbdev/i810/i810_dvt.c:194:6: error: no previous prototype for 'round_off_xres' [-Werror=missing-prototypes] drivers/video/fbdev/i810/i810_dvt.c:233:6: error: no previous

[PATCH] fbdev: fbmem: mark get_fb_unmapped_area() static

2023-05-16 Thread Arnd Bergmann
From: Arnd Bergmann There is a global function with this name on sparc, but no global declaration: drivers/video/fbdev/core/fbmem.c:1469:15: error: no previous prototype for 'get_fb_unmapped_area' Make the generic definition static to avoid this warning. On sparc, this is never seen.

[PATCH 1/2] dt-bindings: display: panel: Add Visionox R66451 AMOLED DSI panel bindings

2023-05-16 Thread Jessica Zhang
Document the 1080x2340 Visionox R66451 AMOLED DSI panel bindings Signed-off-by: Jessica Zhang --- .../bindings/display/panel/visionox,r66451.yaml| 59 ++ 1 file changed, 59 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/visionox,r66451.yaml

[PATCH 2/2] drm/panel: Add driver for Visionox r66451 panel

2023-05-16 Thread Jessica Zhang
Add support for the 1080x2340 Visionox R66451 AMOLED DSI panel that comes with the Qualcomm HDK8350 display expansion pack. The panel enables display compression (DSC v1.2) by default. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/panel/Kconfig | 8 +

[PATCH 0/2] Add support for Visionox R66451 AMOLED DSI panel

2023-05-16 Thread Jessica Zhang
/panel-visionox-r66451.c | 395 + 4 files changed, 463 insertions(+) --- base-commit: a5abc0900af0cfb1b8093200a265d2791864f26b change-id: 20230516-b4-r66451-panel-driver-bf04b5fb3d52 Best regards, -- Jessica Zhang

Re: [PATCH 0/3] drm/vkms: Minor Improvements

2023-05-16 Thread Arthur Grillo Queiroz Cabral
On 15/05/23 10:52, Maíra Canal wrote: > This series addresses some minor improvements to the writeback > functionality. The first patch intends to reduce the critical section > of a spinlock by removing assignments that don't need to be protected > by a lock. The second patch enables the

Re: [PATCH] accel/qaic: silence some uninitialized variable warnings

2023-05-16 Thread Jeffrey Hugo
On 5/10/2023 10:48 AM, Dan Carpenter wrote: On Wed, May 10, 2023 at 08:57:03AM -0600, Jeffrey Hugo wrote: On 5/3/2023 4:41 AM, Dan Carpenter wrote: Smatch complains that these are not initialized if get_cntl_version() fails but we still print them in the debug message. Not the end of the

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Dump error capture to kernel log

2023-05-16 Thread John Harrison
On 5/16/2023 12:17, Belgaumkar, Vinay wrote: On 4/18/2023 11:17 AM, john.c.harri...@intel.com wrote: From: John Harrison This is useful for getting debug information out in certain situations, such as failing kernel selftests and CI runs that don't log error captures. It is especially useful

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/guc: Dump error capture to dmesg on CTB error

2023-05-16 Thread Belgaumkar, Vinay
On 4/18/2023 11:17 AM, john.c.harri...@intel.com wrote: From: John Harrison In the past, There have been sporadic CTB failures which proved hard to reproduce manually. The most effective solution was to dump the GuC log at the point of failure and let the CI system do the repro. It is

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Dump error capture to kernel log

2023-05-16 Thread Belgaumkar, Vinay
On 4/18/2023 11:17 AM, john.c.harri...@intel.com wrote: From: John Harrison This is useful for getting debug information out in certain situations, such as failing kernel selftests and CI runs that don't log error captures. It is especially useful for things like retrieving GuC logs as GuC

Re: [Intel-gfx] [PATCH v2 0/2] Add support for dumping error captures via kernel logging

2023-05-16 Thread Belgaumkar, Vinay
On 4/18/2023 11:17 AM, john.c.harri...@intel.com wrote: From: John Harrison Sometimes, the only effective way to debug an issue is to dump all the interesting information at the point of failure. So add support for doing that. v2: Extra CONFIG wrapping (review feedback from Rodrigo)

RE: [PATCH v5 6/8] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters

2023-05-16 Thread Kandpal, Suraj
> > The array of rc_parameters contains a mixture of parameters from DSC 1.1 > and DSC 1.2 standards. Split these tow configuration arrays in preparation to > adding more configuration data. > Hi , Needed to add some more comments apart from the previous ones already given > Signed-off-by:

Re: [Freedreno] [PATCH v10 8/8] drm/msm/dsi: update hdisplay calculation for dsi_timing_setup

2023-05-16 Thread Jessica Zhang
On 5/14/2023 2:29 PM, Marijn Suijten wrote: On 2023-05-12 14:32:18, Jessica Zhang wrote: hdisplay for compressed images should be calculated as bytes_per_slice * slice_count. Thus, use MSM DSC helper to calculate hdisplay for dsi_timing_setup instead of directly using mode->hdisplay. As

[PATCH v9 2/2] drm/i915: Allow user to set cache at BO creation

2023-05-16 Thread fei . yang
From: Fei Yang To comply with the design that buffer objects shall have immutable cache setting through out their life cycle, {set, get}_caching ioctl's are no longer supported from MTL onward. With that change caching policy can only be set at object creation time. The current code applies a

[PATCH v9 1/2] drm/i915/mtl: end support for set caching ioctl

2023-05-16 Thread fei . yang
From: Fei Yang The design is to keep Buffer Object's caching policy immutable through out its life cycle. This patch ends the support for set caching ioctl from MTL onward. While doing that we also set BO's to be 1-way coherent at creation time because GPU is no longer automatically snooping CPU

[PATCH v9 0/2] drm/i915: Allow user to set cache at BO creation

2023-05-16 Thread fei . yang
From: Fei Yang This series introduce a new extension for GEM_CREATE, 1. end support for set caching ioctl [PATCH 4/5] 2. add set_pat extension for gem_create [PATCH 5/5] v2: drop one patch that was merged separately commit 341ad0e8e254 ("drm/i915/mtl: Add PTE encode function") v3: rebased

Re: [PATCH v4 07/41] drm: handle HAS_IOPORT dependencies

2023-05-16 Thread Arnd Bergmann
On Tue, May 16, 2023, at 19:13, Thomas Zimmermann wrote: > > Am 16.05.23 um 13:00 schrieb Niklas Schnelle: >> In a future patch HAS_IOPORT=n will result in inb()/outb() and friends >> not being declared. We thus need to add HAS_IOPORT as dependency for >> those drivers using them. In the bochs

Re: [PATCH v7 1/7] fbdev/hitfb: Cast I/O offset to address

2023-05-16 Thread Helge Deller
On 5/12/23 12:24, Thomas Zimmermann wrote: Cast I/O offsets to pointers to use them with I/O functions. The I/O functions expect pointers of type 'volatile void __iomem *', but the offsets are plain integers. Build warnings are ../drivers/video/fbdev/hitfb.c: In function 'hitfb_accel_wait':

[linux-next:master] BUILD SUCCESS WITH WARNING 885df05bf634d589fbf030c3751614eaa453fb5d

2023-05-16 Thread kernel test robot
tree/branch: INFO setup_repo_specs: /db/releases/20230516180935/lkp-src/repo/*/linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 885df05bf634d589fbf030c3751614eaa453fb5d Add linux-next specific files for 20230516 Warning reports: https

[PATCH] drm/drm_vblank.c: avoid unsigned int to signed int cast

2023-05-16 Thread Sui Jingfeng
From: Sui Jingfeng Both mode->crtc_htotal and mode->crtc_vtotal are u16 type, mode->crtc_htotal * mode->crtc_vtotal will results a unsigned type. Using a u32 is enough to store the result, but considering that the result will be casted to u64 soon after. We use a u64 type directly. So there no

Re: [PATCH v4 38/41] video: handle HAS_IOPORT dependencies

2023-05-16 Thread Thomas Zimmermann
Hi Am 16.05.23 um 13:00 schrieb Niklas Schnelle: In a future patch HAS_IOPORT=n will result in inb()/outb() and friends not being declared. We thus need to add HAS_IOPORT as dependency for those drivers using them and guard inline code in headers. Co-developed-by: Arnd Bergmann Signed-off-by:

Re: [PATCH v4 07/41] drm: handle HAS_IOPORT dependencies

2023-05-16 Thread Thomas Zimmermann
Hi Am 16.05.23 um 13:00 schrieb Niklas Schnelle: In a future patch HAS_IOPORT=n will result in inb()/outb() and friends not being declared. We thus need to add HAS_IOPORT as dependency for those drivers using them. In the bochs driver there is optional MMIO support detected at runtime, warn if

Re: [PATCH] drm/drm_vblank.c: avoid unsigned int to signed int cast

2023-05-16 Thread Sui Jingfeng
Hi, On 2023/5/17 01:06, Thomas Zimmermann wrote: Am 16.05.23 um 18:59 schrieb Sui Jingfeng: Both mode->crtc_htotal and mode->crtc_vtotal are u16 type, mode->crtc_htotal * mode->crtc_vtotal will results a unsigned type. Using a u32 is enough to store the result, but considering that the

Re: [PATCH] drm/drm_vblank.c: avoid unsigned int to signed int cast

2023-05-16 Thread Thomas Zimmermann
Am 16.05.23 um 18:59 schrieb Sui Jingfeng: Both mode->crtc_htotal and mode->crtc_vtotal are u16 type, mode->crtc_htotal * mode->crtc_vtotal will results a unsigned type. Using a u32 is enough to store the result, but considering that the result will be casted to u64 soon after. We use a u64

RE: [PATCH v5 6/8] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters

2023-05-16 Thread Kandpal, Suraj
> Subject: [PATCH v5 6/8] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) > parameters > > The array of rc_parameters contains a mixture of parameters from DSC 1.1 > and DSC 1.2 standards. Split these tow configuration arrays in preparation to > adding more configuration data. > >

Re: [PATCH v5 1/6] mm/gup: remove unused vmas parameter from get_user_pages()

2023-05-16 Thread John Hubbard
On 5/16/23 07:35, David Hildenbrand wrote: ... >>> When passing NULL as "pages" to get_user_pages(), __get_user_pages_locked() >>> won't set FOLL_GET. As FOLL_PIN is also not set, we won't be messing with >>> the mapcount of the page. > > For completeness: s/mapcount/refcount/ :) whew, you had

[Bug 216119] 087451f372bf76d breaks hibernation on amdgpu Radeon R9 390

2023-05-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216119 Mario Limonciello (AMD) (mario.limoncie...@amd.com) changed: What|Removed |Added Status|REOPENED

Re: [PATCH] drm/i915/pmu: Change bitmask of enabled events to u32

2023-05-16 Thread Dixit, Ashutosh
On Tue, 16 May 2023 02:24:45 -0700, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Having it as u64 was a confusing (but harmless) mistake. > > Also add some asserts to make sure the internal field does not overflow > in the future. > > Signed-off-by: Tvrtko Ursulin > Cc: Ashutosh Dixit >

Re: [PATCH 2/5] drm/amd/display: Move three variable assignments behind condition checks in trigger_hotplug()

2023-05-16 Thread Markus Elfring
>> The address of a data structure member was determined before >> a corresponding null pointer check in the implementation of >> the function “trigger_hotplug”. >> >> Thus avoid the risk for undefined behaviour by moving the assignment >> for three local variables behind some condition checks. >

[Bug 216119] 087451f372bf76d breaks hibernation on amdgpu Radeon R9 390

2023-05-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216119 --- Comment #52 from Harald Judt (h.j...@gmx.at) --- I believe my last issue regarding hibernation after this rewrite has been fixed somewhere in linux-stable 6.2.13: The desktop no longer freezes when VT-switching after resuming from

Re: [PATCH] drm/ttm: let struct ttm_device_funcs be placed in rodata

2023-05-16 Thread Alex Deucher
On Tue, May 16, 2023 at 4:05 AM Jani Nikula wrote: > > On Thu, 09 Mar 2023, Jani Nikula wrote: > > On Thu, 09 Mar 2023, Christian König wrote: > >> Am 09.03.23 um 13:37 schrieb Jani Nikula: > >>> Make the struct ttm_device_funcs pointers const so the data can be placed > >>> in rodata. > >>> >

Re: [PATCH] drm/ttm: let struct ttm_device_funcs be placed in rodata

2023-05-16 Thread Thomas Zimmermann
Am 09.03.23 um 13:37 schrieb Jani Nikula: Make the struct ttm_device_funcs pointers const so the data can be placed in rodata. Cc: Christian Koenig Cc: Huang Rui Signed-off-by: Jani Nikula Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/ttm/ttm_device.c | 2 +-

Re: [PATCH v2] dt-bindings: display: panel: add panel-mipi-dsi-bringup

2023-05-16 Thread Krzysztof Kozlowski
On 16/05/2023 15:09, Paulo Pavačić wrote: > Add dt-bindings documentation for panel-mipi-dsi-bringup which currently > supports fannal,c3004 panel. Also added fannal to vendor-prefixes. Thank you for your patch. There is something to discuss/improve. > > v2 changelog: Please put changelog

Re: [v2] drm/panel: Modify innolux hj110iz panel inital code

2023-05-16 Thread Doug Anderson
Hi, On Tue, May 9, 2023 at 8:42 AM Doug Anderson wrote: > > Hi, > > On Mon, May 8, 2023 at 7:52 PM Cong Yang > wrote: > > > > There is a problem of screen shake on the old panel. So increase the > > panel GOP component pull-down circuit size in hardware, and update the > > initialization code

[PATCH] drm/i915/guc/slpc: Disable rps_boost debugfs

2023-05-16 Thread Vinay Belgaumkar
rps_boost debugfs shows host turbo related info. This is not valid when SLPC is enabled. guc_slpc_info already shows the number of boosts. Add num_waiters there as well and disable rps_boost when SLPC is enabled. v2: Replace Bug with Link to resolve checkpatch warning Link:

Re: [PATCH v2 2/2] phy: mtk-mipi-csi: add driver for CSI phy

2023-05-16 Thread AngeloGioacchino Del Regno
Il 16/05/23 11:30, Julien Stephan ha scritto: On Mon, May 15, 2023 at 04:32:42PM +0200, AngeloGioacchino Del Regno wrote: Il 15/05/23 16:07, Julien Stephan ha scritto: On Mon, May 15, 2023 at 02:22:52PM +0200, AngeloGioacchino Del Regno wrote: +#define CSIxB_OFFSET 0x1000 What if

Re: [PATCH v5 1/6] mm/gup: remove unused vmas parameter from get_user_pages()

2023-05-16 Thread David Hildenbrand
On 16.05.23 16:30, Sean Christopherson wrote: On Tue, May 16, 2023, David Hildenbrand wrote: On 15.05.23 21:07, Sean Christopherson wrote: On Sun, May 14, 2023, Lorenzo Stoakes wrote: diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index cb5c13eee193..eaa5bb8dbadc 100644 ---

Re: [PATCH v5 1/6] mm/gup: remove unused vmas parameter from get_user_pages()

2023-05-16 Thread Sean Christopherson
On Tue, May 16, 2023, David Hildenbrand wrote: > On 15.05.23 21:07, Sean Christopherson wrote: > > On Sun, May 14, 2023, Lorenzo Stoakes wrote: > > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > > > index cb5c13eee193..eaa5bb8dbadc 100644 > > > --- a/virt/kvm/kvm_main.c > > > +++

Re: [PATCH v6 2/8] drm/bridge: tfp410: Set input_bus_flags in atomic_check

2023-05-16 Thread Aradhya Bhatia
Hi Neil, On 16-May-23 12:55, Neil Armstrong wrote: > On 09/05/2023 11:30, Aradhya Bhatia wrote: >> From: Nikhil Devshatwar >> >> input_bus_flags are specified in drm_bridge_timings (legacy) as well >> as drm_bridge_state->input_bus_cfg.flags >> >> The flags from the timings will be deprecated.

Re: [PATCH v6 3/8] drm/bridge: mhdp8546: Add minimal format negotiation

2023-05-16 Thread Aradhya Bhatia
Hi Neil, Thank you for reviewing the patch. On 16-May-23 12:51, Neil Armstrong wrote: > On 15/05/2023 17:59, Aradhya Bhatia wrote: >> Hi Tomi, >> >> On 12-May-23 14:45, Tomi Valkeinen wrote: >>> On 09/05/2023 12:30, Aradhya Bhatia wrote: From: Nikhil Devshatwar With new connector

Re: [PATCH v2] phy: mediatek: rework the floating point comparisons to fixed point

2023-05-16 Thread Vinod Koul
On 02-05-23, 10:50, Tom Rix wrote: > gcc on aarch64 reports > drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c: In function > ‘mtk_hdmi_pll_set_rate’: > drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:240:52: error: > ‘-mgeneral-regs-only’ > is incompatible with the use of floating-point types > 240 |

KUnit tests for TTM subsystem

2023-05-16 Thread Karolina Stolarek
Hi all, I'm working on KUnit tests for TTM subsystem (nothing RFC-worthy yet), with an aim to provide better test coverage for the code used by i915 and Xe. Before digging deeper, I wanted to check if the priorities outlined here make sense and clarify a couple of things. My plan is to

Re: [PATCH v3 1/2] iommu/arm-smmu-qcom: Fix missing adreno_smmu's

2023-05-16 Thread Will Deacon
On Thu, May 11, 2023 at 07:59:05AM -0700, Rob Clark wrote: > From: Rob Clark > > When the special handling of qcom,adreno-smmu was moved into > qcom_smmu_create(), it was overlooked that we didn't have all the > required entries in qcom_smmu_impl_of_match. So we stopped getting >

Re: [PATCH] drm:amd:amdgpu: Fix missing buffer object unlock in failure path

2023-05-16 Thread Alex Deucher
Applied. Thanks! Alex On Mon, May 15, 2023 at 6:27 PM Sukrut Bellary wrote: > > > On 5/3/23 16:15, Sukrut Bellary wrote: > > smatch warning - > > 1) drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:3615 gfx_v9_0_kiq_resume() > > warn: inconsistent returns 'ring->mqd_obj->tbo.base.resv'. > > > > 2)

Re: [PATCH v2 03/12] drm/exynos: Use regular fbdev I/O helpers

2023-05-16 Thread Thomas Zimmermann
Hi Sam Am 15.05.23 um 19:43 schrieb Sam Ravnborg: Hi Thomas, On Mon, May 15, 2023 at 11:40:24AM +0200, Thomas Zimmermann wrote: Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Exynos does not use damage handling, so DRM's fbdev helpers are mere wrappers around the

Re: [PATCH v2 02/12] drm/armada: Use regular fbdev I/O helpers

2023-05-16 Thread Thomas Zimmermann
Hi Am 15.05.23 um 20:04 schrieb Russell King (Oracle): On Mon, May 15, 2023 at 07:55:44PM +0200, Sam Ravnborg wrote: Hi Thomas, On Mon, May 15, 2023 at 11:40:23AM +0200, Thomas Zimmermann wrote: Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Armada does not use

[PATCH v2] dt-bindings: display: panel: add panel-mipi-dsi-bringup

2023-05-16 Thread Paulo Pavačić
Add dt-bindings documentation for panel-mipi-dsi-bringup which currently supports fannal,c3004 panel. Also added fannal to vendor-prefixes. v2 changelog: - revised driver title, now describes purpose - revised description, now describes hw - revised maintainers, now has only 1 mail -

Re: [PATCH v4 10/13] phy: amlogic: phy-meson-g12a-mipi-dphy-analog: fix CNTL2_DIF_TX_CTL0 value

2023-05-16 Thread Vinod Koul
On 12-05-23, 15:11, Neil Armstrong wrote: > Use the same CNTL2_DIF_TX_CTL0 value used by the vendor, it was reported > fixing timings issues. Applied to phy/fixes, thanks -- ~Vinod

Re: [PATCH v2 02/12] drm/armada: Use regular fbdev I/O helpers

2023-05-16 Thread Thomas Zimmermann
Hi Am 15.05.23 um 19:55 schrieb Sam Ravnborg: Hi Thomas, On Mon, May 15, 2023 at 11:40:23AM +0200, Thomas Zimmermann wrote: Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Armada does not use damage handling, so DRM's fbdev helpers are mere wrappers around the

Re: [PATCH V6 6/6] drm: bridge: samsung-dsim: Support non-burst mode

2023-05-16 Thread Adam Ford
On Mon, May 15, 2023 at 10:26 PM Chen-Yu Tsai wrote: > > On Tue, May 16, 2023 at 7:57 AM Adam Ford wrote: > > > > The high-speed clock is hard-coded to the burst-clock > > frequency specified in the device tree. However, when > > using devices like certain bridge chips without burst mode > >

Re: [PATCH v5 0/8] drm/i915: move DSC RC tables to drm_dsc_helper.c

2023-05-16 Thread Dmitry Baryshkov
On 15/05/2023 12:12, Jani Nikula wrote: On Thu, 04 May 2023, Dmitry Baryshkov wrote: Other platforms (msm) will benefit from sharing the DSC config setup functions. This series moves parts of static DSC config data from the i915 driver to the common helpers to be used by other drivers. Note:

Re: [PATCH v4 37/41] fbdev: atyfb: Remove unused clock determination

2023-05-16 Thread Ville Syrjälä
On Tue, May 16, 2023 at 01:00:33PM +0200, Niklas Schnelle wrote: > Just below the removed lines par->clk_wr_offset is hard coded to 3 so > there is no use in determining a different clock just to then ignore it > anyway. This also removes the only I/O port use remaining in the driver > allowing it

[PATCH v4 38/41] video: handle HAS_IOPORT dependencies

2023-05-16 Thread Niklas Schnelle
In a future patch HAS_IOPORT=n will result in inb()/outb() and friends not being declared. We thus need to add HAS_IOPORT as dependency for those drivers using them and guard inline code in headers. Co-developed-by: Arnd Bergmann Signed-off-by: Arnd Bergmann Signed-off-by: Niklas Schnelle ---

Re: [PATCH 12/13] drm/i915/dp: Get optimal link config to have best compressed bpp

2023-05-16 Thread Ville Syrjälä
On Tue, May 16, 2023 at 01:43:44PM +0300, Lisovskiy, Stanislav wrote: > On Fri, May 12, 2023 at 11:54:16AM +0530, Ankit Nautiyal wrote: > > Currently, we take the max lane, rate and pipe bpp, to get the maximum > > compressed bpp possible. We then set the output bpp to this value. > > This patch

[PATCH v4 07/41] drm: handle HAS_IOPORT dependencies

2023-05-16 Thread Niklas Schnelle
In a future patch HAS_IOPORT=n will result in inb()/outb() and friends not being declared. We thus need to add HAS_IOPORT as dependency for those drivers using them. In the bochs driver there is optional MMIO support detected at runtime, warn if this isn't taken when HAS_IOPORT is not defined.

[PATCH v4 37/41] fbdev: atyfb: Remove unused clock determination

2023-05-16 Thread Niklas Schnelle
Just below the removed lines par->clk_wr_offset is hard coded to 3 so there is no use in determining a different clock just to then ignore it anyway. This also removes the only I/O port use remaining in the driver allowing it to be built without CONFIG_HAS_IOPORT. Link:

Re: [PATCH 1/5] drm/debugfs: drop debugfs_init() for the render and accel node v2

2023-05-16 Thread Stanislaw Gruszka
On Mon, Apr 24, 2023 at 02:30:24PM +0200, Christian König wrote: > We want to remove per minor debugfs directories. Start by stopping > drivers from adding anything inside of those in the mid layer callback. > > v2: drop it for the accel node as well > > Signed-off-by: Christian König

Re: [PATCH] drm/panel: simple: fix active size for Ampire AM-480272H3TMQW-T01H

2023-05-16 Thread Neil Armstrong
On 16/05/2023 10:50, Dario Binacchi wrote: The previous setting was related to the overall dimension and not to the active display area. In the "PHYSICAL SPECIFICATIONS" section, the datasheet shows the following parameters: -- |

RE: [PATCH v3 1/5] i2c: Enhance i2c_new_ancillary_device API

2023-05-16 Thread Biju Das
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH v3 1/5] i2c: Enhance i2c_new_ancillary_device API > > Hi Biju, > > On Sat, May 13, 2023 at 6:52 PM Biju Das > wrote: > > Renesas PMIC RAA215300 exposes two separate i2c devices, one for the > > main device and another for rtc device. >

Re: [PATCH 12/13] drm/i915/dp: Get optimal link config to have best compressed bpp

2023-05-16 Thread Lisovskiy, Stanislav
On Fri, May 12, 2023 at 11:54:16AM +0530, Ankit Nautiyal wrote: > Currently, we take the max lane, rate and pipe bpp, to get the maximum > compressed bpp possible. We then set the output bpp to this value. > This patch provides support to have max bpp, min rate and min lanes, > that can support

Re: [PATCH v2] drm/dp_mst: Clear MSG_RDY flag before sending new message

2023-05-16 Thread Jani Nikula
On Thu, 27 Apr 2023, Wayne Lin wrote: > [Why] > The sequence for collecting down_reply from source perspective should > be: > > Request_n->repeat (get partial reply of Request_n->clear message ready > flag to ack DPRX that the message is received) till all partial > replies for Request_n are

Re: [PATCH v5 1/6] mm/gup: remove unused vmas parameter from get_user_pages()

2023-05-16 Thread David Hildenbrand
On 15.05.23 21:07, Sean Christopherson wrote: On Sun, May 14, 2023, Lorenzo Stoakes wrote: No invocation of get_user_pages() use the vmas parameter, so remove it. The GUP API is confusing and caveated. Recent changes have done much to improve that, however there is more we can do. Exporting

Re: [PATCH 05/13] drm/i915/intel_cdclk: Add vdsc with bigjoiner constraints on min_cdlck

2023-05-16 Thread Lisovskiy, Stanislav
On Mon, May 15, 2023 at 05:44:51PM +0300, Ville Syrjälä wrote: > On Fri, May 12, 2023 at 11:54:09AM +0530, Ankit Nautiyal wrote: > > As per Bsepc:49259, Bigjoiner BW check puts restriction on the > > compressed bpp for a given CDCLK, pixelclock in cases where > > Bigjoiner + DSC are used. > > > >

[PATCH 08/12] accel/habanalabs: use binning info when handling razwi

2023-05-16 Thread Oded Gabbay
From: Dani Liberman When receiving sei interrupt from tpc or decoder, we need to check the binning mask because if the engine is binned, the razwi info won't be in the router of the binned engine, instead will be in the router of the substitute engine. Signed-off-by: Dani Liberman Reviewed-by:

[PATCH 11/12] accel/habanalabs: update state when loading boot fit

2023-05-16 Thread Oded Gabbay
From: Koby Elbaz Any FW component we load must be followed by a corresponding state update. However, it seems that so far we skipped doing so for the bootfit case, so fix that. Signed-off-by: Koby Elbaz Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay ---

[PATCH 12/12] accel/habanalabs: mask part of hmmu page fault captured address

2023-05-16 Thread Oded Gabbay
From: Dani Liberman When receiving page fault from hmmu, the captured address is scrambled both by HW and by driver. The driver part is unscrambled but the HW part isn't getting unscrambled. To avoid declaring wrong address, the HW scrambled part will be masked. Signed-off-by: Dani Liberman

[PATCH 07/12] accel/habanalabs: remove support for mmu disable

2023-05-16 Thread Oded Gabbay
From: Ofir Bitton As mmu disable mode is only used for bring-up stages, let's remove this option and all code related to it. Signed-off-by: Ofir Bitton Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- .../accel/habanalabs/common/command_buffer.c | 6 -

  1   2   >