Re: [PATCH] qcom-scm: Include header

On Sat, Dec 29, 2018 at 10:19:32AM -0200, Fabio Estevam wrote: > Hi Bjorn, > > On Fri, Dec 28, 2018 at 10:27 PM Bjorn Andersson > wrote: > > > Sorry about that, I forgot that the header file is not covered by the > > MAINTAINERS file. > > > > Your second patch looks good, but I'm hoping we can

Re: [v2 1/7] soc: qcom: llcc-slice: Add error checks for API functions

On Fri, Oct 05, 2018 at 06:38:29PM +0530, Sharat Masetty wrote: > From: Jordan Crouse > > llcc_slice_getd can return a ERR_PTR code on failure. Add a IS_ERR_OR_NULL > check to subsequent API calls that use struct llcc_slice_desc to guard > against faults and to let the leaf drivers get away with

Re: [PATCH] firmware: qcom_scm: Add set remote state API

On 24 January 2017 at 03:54, Stanimir Varbanov wrote: > Andy, > > Could you queue this patch for 4.11? This patch is in the qcom-drivers-for-4.11 pull request I sent 9 hours ago. So you should be good. https://www.spinics.net/lists/arm-kernel/msg557325.html

[PATCH] firmware: qcom_scm: Add set remote state API

This patch adds a set remote state SCM API. This will be used by the Venus and GPU subsystems to set state on the remote processors. This work was based on two patch sets by Jordan Crouse and Stanimir Varbanov. Signed-off-by: Andy Gross <andy.gr...@linaro.org> --- drivers/firmware/qcom_

Re: [Freedreno] [PATCH 10/12] firmware: qcom_scm: Add qcom_scm_gpu_zap_resume()

On Tue, Jan 17, 2017 at 10:04:59AM -0700, Jordan Crouse wrote: > On Sat, Jan 14, 2017 at 11:20:58PM -0600, Andy Gross wrote: > > + Stanimir > > > > On Sat, Jan 14, 2017 at 09:49:01PM -0600, Andy Gross wrote: > > > On Fri, Jan 13, 2017 at 04:24:38PM -0700, Jordan Cro

Re: [Freedreno] [PATCH 10/12] firmware: qcom_scm: Add qcom_scm_gpu_zap_resume()

On Fri, Jan 13, 2017 at 04:24:38PM -0700, Jordan Crouse wrote: > On Fri, Jan 13, 2017 at 11:12:41AM -0600, Andy Gross wrote: > > On Mon, Nov 28, 2016 at 12:28:35PM -0700, Jordan Crouse wrote: > > > Add an interface to trigger the remote processor to reinitialize the GPU > &g

Re: [Freedreno] [PATCH 10/12] firmware: qcom_scm: Add qcom_scm_gpu_zap_resume()

+ Stanimir On Sat, Jan 14, 2017 at 09:49:01PM -0600, Andy Gross wrote: > On Fri, Jan 13, 2017 at 04:24:38PM -0700, Jordan Crouse wrote: > > On Fri, Jan 13, 2017 at 11:12:41AM -0600, Andy Gross wrote: > > > On Mon, Nov 28, 2016 at 12:28:35PM -0700, Jordan Crouse wrote: > &

Re: [PATCH 10/12] firmware: qcom_scm: Add qcom_scm_gpu_zap_resume()

On Mon, Nov 28, 2016 at 12:28:35PM -0700, Jordan Crouse wrote: > Add an interface to trigger the remote processor to reinitialize the GPU > zap shader on power-up. > > Signed-off-by: Jordan Crouse > --- > +int __qcom_scm_gpu_zap_resume(struct device *dev) > +{ > +

Re: [PATCH 10/12] firmware: qcom_scm: Add qcom_scm_gpu_zap_resume()

On Fri, Jan 13, 2017 at 10:22:45AM -0700, Jordan Crouse wrote: > On Fri, Jan 13, 2017 at 11:12:41AM -0600, Andy Gross wrote: > > On Mon, Nov 28, 2016 at 12:28:35PM -0700, Jordan Crouse wrote: > > > Add an interface to trigger the remote processor to reinitialize the GPU > &g

[PATCH] drm/msm: Fix error handling crashes seen when VRAM allocation fails

t; Signed-off-by: Archit Taneja > --- Reviewed-by: Andy Gross

[PATCH v2 25/25] arm64: dts: apq8016-sbc: Add HDMI display support

or. > > Add the ADV7533 DT node under its I2C control bus, and tie the DSI > output port to the ADV7533's input port. > > Cc: Andy Gross > Cc: Rob Herring > Cc: devicetree at vger.kernel.org > > Signed-off-by: Archit Taneja This also looks fine. Regards, Andy

[PATCH v2 24/25] arm64: dts: msm8916: Add display support

s > input port. > > Cc: Andy Gross > Cc: Rob Herring > Cc: devicetree at vger.kernel.org This looks fine to me. Regards, Andy

[PATCH] drm/omap: Add device tree support to DMM

Added in detection/support for DMM devices when booting with device tree. Signed-off-by: Andy Gross --- drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm

[PATCH] drm/omap: Add device tree support to DMM

Added in detection/support for DMM devices when booting with device tree. Signed-off-by: Andy Gross andy.gr...@ti.com --- drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b

[PATCH 2/2] drm/omap: Add OMAP5 support

Add support for OMAP5 processor. The main differences are that the OMAP5 has 2 containers, one for 1D and one for 2D. Each container is 128MiB in size. Signed-off-by: Andy Gross Signed-off-by: Rob Clark --- drivers/staging/omapdrm/omap_dmm_priv.h |5 + drivers/staging/omapdrm

[PATCH 1/2] drm/omap: Add PM capabilities

is done by device creation. We create the DMM device before the omapdrm, so the correct order is maintained. Signed-off-by: Andy Gross Signed-off-by: Rob Clark --- drivers/staging/omapdrm/omap_dmm_tiler.c | 34 ++ drivers/staging/omapdrm/omap_drv.c | 14

[PATCH v2 0/2] drm/omap: Add PM and OMAP5 support

First patch adds PM capabilities for omapdrm. Second patch adds OMAP5 support to DMM driver component. Series was build tested and based on linux-next. v2: Updated commit msg for PM patch Andy Gross (2): drm/omap: Add PM capabilities drm/omap: Add OMAP5 support drivers/staging/omapdrm

[PATCH v2 0/2] drm/omap: Add PM and OMAP5 support

First patch adds PM capabilities for omapdrm. Second patch adds OMAP5 support to DMM driver component. Series was build tested and based on linux-next. v2: Updated commit msg for PM patch Andy Gross (2): drm/omap: Add PM capabilities drm/omap: Add OMAP5 support drivers/staging/omapdrm

[PATCH 2/2] drm/omap: Add OMAP5 support

Add support for OMAP5 processor. The main differences are that the OMAP5 has 2 containers, one for 1D and one for 2D. Each container is 128MiB in size. Signed-off-by: Andy Gross andy.gr...@ti.com Signed-off-by: Rob Clark r...@ti.com --- drivers/staging/omapdrm/omap_dmm_priv.h |5

[PATCH 1/2] drm/omap: Add PM capabilities

is done by device creation. We create the DMM device before the omapdrm, so the correct order is maintained. Signed-off-by: Andy Gross andy.gr...@ti.com Signed-off-by: Rob Clark r...@ti.com --- drivers/staging/omapdrm/omap_dmm_tiler.c | 34 ++ drivers/staging/omapdrm

[PATCH 2/2] drm/omap: Add OMAP5 support

Add support for OMAP5 processor. The main differences are that the OMAP5 has 2 containers, one for 1D and one for 2D. Each container is 128MiB in size. Signed-off-by: Andy Gross --- drivers/staging/omapdrm/omap_dmm_priv.h |5 + drivers/staging/omapdrm/omap_dmm_tiler.c | 127

[PATCH 1/2] drm/omap: Add PM capabilities

Added resume hooks that will be called on resuming from DEVICE_OFF. The dmm portion of the patch reprograms the LUT to point to the dummy pages. The omapdrm portion of the patch repins the buffers into the DMM. Signed-off-by: Andy Gross --- drivers/staging/omapdrm/omap_dmm_tiler.c | 34

[PATCH 0/2] drm/omap: Add PM and OMAP5 support

First patch adds PM capabilities for omapdrm. Second patch adds OMAP5 support to DMM driver component. Series was build tested and based on linux-next. Andy Gross (2): drm/omap: Add PM capabilities drm/omap: Add OMAP5 support drivers/staging/omapdrm/omap_dmm_priv.h |5 + drivers

[PATCH 1/2] drm/omap: Add PM capabilities

Added resume hooks that will be called on resuming from DEVICE_OFF. The dmm portion of the patch reprograms the LUT to point to the dummy pages. The omapdrm portion of the patch repins the buffers into the DMM. Signed-off-by: Andy Gross andy.gr...@ti.com --- drivers/staging/omapdrm

[PATCH 0/2] drm/omap: Add PM and OMAP5 support

First patch adds PM capabilities for omapdrm. Second patch adds OMAP5 support to DMM driver component. Series was build tested and based on linux-next. Andy Gross (2): drm/omap: Add PM capabilities drm/omap: Add OMAP5 support drivers/staging/omapdrm/omap_dmm_priv.h |5 + drivers

[PATCH 2/2] drm/omap: Add OMAP5 support

Add support for OMAP5 processor. The main differences are that the OMAP5 has 2 containers, one for 1D and one for 2D. Each container is 128MiB in size. Signed-off-by: Andy Gross andy.gr...@ti.com --- drivers/staging/omapdrm/omap_dmm_priv.h |5 + drivers/staging/omapdrm/omap_dmm_tiler.c

[PATCH v2] drm/omap: Fix usage of IS_ERR_OR_NULL and PTR_ERR

Return -ENOMEM if dmm_txn_init cannot allocate a refill engine. v2: Fix typing issue seen with newer compilers Signed-off-by: Andy Gross --- drivers/staging/omapdrm/omap_dmm_tiler.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/omapdrm

[PATCH v2] drm/omap: Fix usage of IS_ERR_OR_NULL and PTR_ERR

Return -ENOMEM if dmm_txn_init cannot allocate a refill engine. v2: Fix typing issue seen with newer compilers Signed-off-by: Andy Gross andy.gr...@ti.com --- drivers/staging/omapdrm/omap_dmm_tiler.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging

[PATCH v2] drm/omap: Fix usage of IS_ERR_OR_NULL and PTR_ERR

Return -ENOMEM if dmm_txn_init cannot allocate a refill engine. v2: Fix typing issue seen with newer compilers Signed-off-by: Andy Gross --- drivers/staging/omapdrm/omap_dmm_tiler.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/omapdrm

[PATCH v2] drm/omap: Fix usage of IS_ERR_OR_NULL and PTR_ERR

Return -ENOMEM if dmm_txn_init cannot allocate a refill engine. v2: Fix typing issue seen with newer compilers Signed-off-by: Andy Gross andy.gr...@ti.com --- drivers/staging/omapdrm/omap_dmm_tiler.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging

[PATCH] drm/omap: Fix usage of IS_ERR_OR_NULL and PTR_ERR

Return PTR_ERR(-ENOMEM) if dmm_txn_init cannot allocate a refill engine. Signed-off-by: Andy Gross --- drivers/staging/omapdrm/omap_dmm_tiler.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/omapdrm/omap_dmm_tiler.c b/drivers/staging/omapdrm

[PATCH] drm/omap: Fix usage of IS_ERR_OR_NULL and PTR_ERR

Return PTR_ERR(-ENOMEM) if dmm_txn_init cannot allocate a refill engine. Signed-off-by: Andy Gross andy.gr...@ti.com --- drivers/staging/omapdrm/omap_dmm_tiler.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/omapdrm/omap_dmm_tiler.c b/drivers/staging

[PATCH] drm/omap: Remove cpu_is_omapXXXX usage in DMM

Removed usage of the cpu_is_omap in the DMM driver. This is no longer necessary as we can key off of the omap_dmm pointer that is only non-NULL if the device has been probed successfully. Signed-off-by: Andy Gross --- drivers/staging/omapdrm/omap_dmm_tiler.c |2 +- drivers/staging

[PATCH] drm/omap: Remove cpu_is_omapXXXX usage in DMM

Removed usage of the cpu_is_omap in the DMM driver. This is no longer necessary as we can key off of the omap_dmm pointer that is only non-NULL if the device has been probed successfully. Signed-off-by: Andy Gross andy.gr...@ti.com --- drivers/staging/omapdrm/omap_dmm_tiler.c |2

[PATCH] drm/omap: Fix include error during make

Fixed include error for drm_mode.h Signed-off-by: Andy Gross --- drivers/staging/omapdrm/omap_crtc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/omapdrm/omap_crtc.c b/drivers/staging/omapdrm/omap_crtc.c index 732f2ad..5249223 100644 --- a/drivers

[PATCH] drm/omap: Fix include error during make

Fixed include error for drm_mode.h Signed-off-by: Andy Gross andy.gr...@ti.com --- drivers/staging/omapdrm/omap_crtc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/omapdrm/omap_crtc.c b/drivers/staging/omapdrm/omap_crtc.c index 732f2ad..5249223

[PATCH v2] drm/omap: Fix release of refill engine

refills will continue to release the engine after they unblock from waiting on the refill. v2: Fixed review comments on async variable and bool type Signed-off-by: Andy Gross --- drivers/staging/omapdrm/omap_dmm_priv.h |5 ++- drivers/staging/omapdrm/omap_dmm_tiler.c | 76

[PATCH] drm/omap: Fix release of refill engine

Please disregard this mail. Wrong patch sent On 10/12/2012 10:56 AM, Andy Gross wrote: > During asynchronous refills, we don't wait for the refill to > finish. However, we cannot release the engine back to the idle > list until it has actually completed the refill operation. The

[PATCH] drm/omap: Fix release of refill engine

refills will continue to release the engine after they unblock from waiting on the refill. Signed-off-by: Andy Gross --- drivers/staging/omapdrm/omap_dmm_priv.h |5 ++- drivers/staging/omapdrm/omap_dmm_tiler.c | 77 - 2 files changed, 57 insertions(+), 25

[PATCH] drm/omap: Fix release of refill engine

On 10/12/2012 08:44 AM, Rob Clark wrote: > > US); > > for (i = 0; i < dmm->num_engines; i++) { > - if (status & DMM_IRQSTAT_LST) > + if (status & DMM_IRQSTAT_LST) { > > wake_up_interruptible(>engines[i].wait_for_refill); > > +

[PATCH] drm/omap: Fix release of refill engine

refills will continue to release the engine after they unblock from waiting on the refill. Signed-off-by: Andy Gross --- drivers/staging/omapdrm/omap_dmm_priv.h |5 ++- drivers/staging/omapdrm/omap_dmm_tiler.c | 77 - 2 files changed, 57 insertions(+), 25

[PATCH] drm/omap: Use writecombine for descriptors

Use writecombine for descriptor and PAT programming memory. Signed-off-by: Andy Gross --- drivers/staging/omapdrm/omap_dmm_tiler.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/omapdrm/omap_dmm_tiler.c b/drivers/staging/omapdrm/omap_dmm_tiler.c

[PATCH] drm/omap: Remove shadow lut usage

Removing extraneous shadow lut maintenance. There is no need for this to be in place until power management is added to the driver, and this extra copy degrades performance for no gain. Signed-off-by: Andy Gross --- drivers/staging/omapdrm/omap_dmm_priv.h |6 -- drivers/staging

Re: [PATCH] drm/omap: Fix release of refill engine

On 10/12/2012 08:44 AM, Rob Clark wrote: US); for (i = 0; i dmm-num_engines; i++) { - if (status DMM_IRQSTAT_LST) + if (status DMM_IRQSTAT_LST) { wake_up_interruptible(dmm-engines[i].wait_for_refill); + if

[PATCH] drm/omap: Fix release of refill engine

refills will continue to release the engine after they unblock from waiting on the refill. Signed-off-by: Andy Gross andy.gr...@ti.com --- drivers/staging/omapdrm/omap_dmm_priv.h |5 ++- drivers/staging/omapdrm/omap_dmm_tiler.c | 77 - 2 files changed, 57

Re: [PATCH] drm/omap: Fix release of refill engine

Please disregard this mail. Wrong patch sent On 10/12/2012 10:56 AM, Andy Gross wrote: During asynchronous refills, we don't wait for the refill to finish. However, we cannot release the engine back to the idle list until it has actually completed the refill operation. The engine release

[PATCH v2] drm/omap: Fix release of refill engine

refills will continue to release the engine after they unblock from waiting on the refill. v2: Fixed review comments on async variable and bool type Signed-off-by: Andy Gross andy.gr...@ti.com --- drivers/staging/omapdrm/omap_dmm_priv.h |5 ++- drivers/staging/omapdrm/omap_dmm_tiler.c

[PATCH] drm/omap: Use writecombine for descriptors

Use writecombine for descriptor and PAT programming memory. Signed-off-by: Andy Gross andy.gr...@ti.com --- drivers/staging/omapdrm/omap_dmm_tiler.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/omapdrm/omap_dmm_tiler.c b/drivers/staging/omapdrm

[PATCH] drm/omap: Remove shadow lut usage

Removing extraneous shadow lut maintenance. There is no need for this to be in place until power management is added to the driver, and this extra copy degrades performance for no gain. Signed-off-by: Andy Gross andy.gr...@ti.com --- drivers/staging/omapdrm/omap_dmm_priv.h |6

[PATCH] drm/omap: Fix release of refill engine

refills will continue to release the engine after they unblock from waiting on the refill. Signed-off-by: Andy Gross andy.gr...@ti.com --- drivers/staging/omapdrm/omap_dmm_priv.h |5 ++- drivers/staging/omapdrm/omap_dmm_tiler.c | 77 - 2 files changed, 57

[PATCH] staging: omapdrm: Fix DMM sparse warnings

Fix the following sparse warnings: drivers/staging/omapdrm/omap_dmm_tiler.c:123:13: warning: symbol 'omap_dmm_irq_handler' was not declared. Should it be static? drivers/staging/omapdrm/omap_dmm_tiler.c:370:24: warning: Using plain integer as NULL pointer Signed-off-by: Andy Gross

[PATCH] staging: omapdrm: Remove unnecessary memcpy

led to a fairly hefty penalty when programming large 1D or 2D buffers. This can be implemented in a more efficient manner when we actually have to support DEVICE_OFF suspend/resume operations. Signed-off-by: Andy Gross --- drivers/staging/omapdrm/omap_dmm_priv.h |6 -- drivers/staging

[PATCH] staging: omapdrm: Fix DMM sparse warnings

Fix the following sparse warnings: drivers/staging/omapdrm/omap_dmm_tiler.c:123:13: warning: symbol 'omap_dmm_irq_handler' was not declared. Should it be static? drivers/staging/omapdrm/omap_dmm_tiler.c:370:24: warning: Using plain integer as NULL pointer Signed-off-by: Andy Gross

[PATCH] staging: omapdrm: fix crash when freeing bad fb

During unload, don't cleanup the framebuffer if it is not valid. Signed-off-by: Andy Gross --- drivers/staging/omapdrm/omap_fbdev.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/staging/omapdrm/omap_fbdev.c b/drivers/staging/omapdrm/omap_fbdev.c

[PATCH] staging: omapdrm: Fix error paths during dmm init

Failures during the dmm probe can cause the kernel to crash. Moved the spinlock to a global and moved list initializations immediately after the allocation of the dmm private structure. Signed-off-by: Andy Gross --- drivers/staging/omapdrm/omap_dmm_priv.h |1 - drivers/staging/omapdrm

[PATCH] staging: omapdrm: Fix error paths during dmm init

Failures during the dmm probe can cause the kernel to crash. Moved the spinlock to a global and moved list initializations immediately after the allocation of the dmm private structure. Signed-off-by: Andy Gross andy.gr...@ti.com --- drivers/staging/omapdrm/omap_dmm_priv.h |1 - drivers

[PATCH] omap2+: add drm device

Register OMAP DRM/KMS platform device. DMM is split into a separate device using hwmod. Signed-off-by: Andy Gross --- arch/arm/mach-omap2/Makefile |4 ++ arch/arm/mach-omap2/drm.c | 61 drivers/staging/omapdrm/omap_drv.h |2

[PATCH] omap2+: add drm device

Register OMAP DRM/KMS platform device. DMM is split into a separate device using hwmod. Signed-off-by: Andy Gross andy.gr...@ti.com --- arch/arm/mach-omap2/Makefile |4 ++ arch/arm/mach-omap2/drm.c | 61 drivers/staging/omapdrm