[PATCH v3 56/56] drm/omap: remove dss_mgr_ops

2020-11-05 Thread Tomi Valkeinen
dss_mgr_ops was needed with the multi-module architecture, but is no longer needed. We can thus remove it and use direct calls. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dss.h | 1 - drivers/gpu/drm/omapdrm/dss/omapdss.h | 42 +++ drivers/gpu/drm

[PATCH v3 53/56] drm/omap: remove unused display.c

2020-11-05 Thread Tomi Valkeinen
The functions in display.c are not used, so drop the file. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/Makefile | 2 +- drivers/gpu/drm/omapdrm/dss/display.c | 58 --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 4 -- 3 files changed, 1 insertion(+), 63

[PATCH v3 35/56] drm/omap: dsi: implement check timings

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Implement check timings, which will check if its possible to configure the clocks for the provided mode using the same code as the set_config() hook. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dsi.c | 70

[PATCH v3 30/56] drm/omap: dsi: move panel refresh function to host

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel This moves the panel refresh/update function from the panel driver into the DSI host driver to prepare for common drm_panel support. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 68

[PATCH v3 27/56] drm/omap: dsi: do bus locking in host driver

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel This moves the bus locking into the host driver and unexports the custom API in preparation for drm_panel support. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 46 +-- drivers/gpu

[PATCH v3 49/56] drm/omap: simplify DSI manual update code

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Move dsi_ops into the main structure, since all other ops are gone. Instead of checking the device type we can simply check if dsi_ops are set. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dsi.c | 10

[PATCH v3 40/56] drm/panel: Move OMAP's DSI command mode panel driver

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel The panel driver is no longer using any OMAP specific APIs, so let's move it into the generic panel directory. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/omapdrm/Kc

[PATCH v3 29/56] drm/omap: dsi: do ULPS in host driver

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Move ULPS handling into the DSI host controller, so that we no longer need a custom API for the DSI client. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 273 +- drivers/gpu/drm

[PATCH v3 28/56] drm/omap: dsi: untangle ulps ops from enable/disable

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Create a custom function pointer for ULPS and use it instead of reusing disable/enable functions for ULPS mode switch. This allows us to use the common disable/enable functions pointers for DSI. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen

[PATCH v3 26/56] drm/omap: dsi: drop custom enable_te() API

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Instead of using the custon enable_te() API, this automatically enables/disables TE core support when a matching packet is send to the panel. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 3

[PATCH v3 33/56] drm/omap: dsi: convert to drm_panel

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel This converts the DSI module to expect common drm_panel display drivers instead of dssdev based ones. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 204 +++--- drivers/gpu/drm/omapdrm/dss

[PATCH v3 44/56] drm/omap: simplify omap_display_id

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel We no longer need to check for the DSS API, since all encoders, panels and connectors have been converted to the bridge API. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_drv.c | 9 + 1 file changed, 1

[PATCH v3 50/56] drm/omap: dsi: simplify pin config

2020-11-05 Thread Tomi Valkeinen
conversion and means the pins can be configured earlier. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dsi.c | 33 +-- drivers/gpu/drm/omapdrm/dss/omapdss.h | 15 2 files changed, 11 insertions(+), 37

[PATCH v3 32/56] drm/omap: dsi: drop custom panel capability support

2020-11-05 Thread Tomi Valkeinen
ities. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 3 --- drivers/gpu/drm/omapdrm/dss/dsi.c | 8 drivers/gpu/drm/omapdrm/dss/omapdss.h | 8 +--- drivers/gpu/drm/omapdrm/omap_c

[PATCH v3 37/56] drm/omap: panel-dsi-cm: support unbinding

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Now, that the driver implements the common DRM panel API the unbind no longer needs to be suppressed. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 5 ++--- 1 file changed, 2 insertions(+), 3

[PATCH v3 36/56] drm/omap: panel-dsi-cm: use DEVICE_ATTR_RO

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Use DEVICE_ATTR_RO helper instead of plain DEVICE_ATTR, which makes the code a bit shorter and easier to read. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 8 1 file changed, 4 insertions

[PATCH v3 47/56] drm/omap: drop DSS ops_flags

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel The omapdss device's ops_flags field is no longer used and can be dropped. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 9 - drivers/gpu/drm/omapdrm/dss/venc.c| 1 - 2 files change

[PATCH v3 45/56] drm/omap: drop unused DSS next pointer

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Since all encoders and panels are using the bridge API now, we next pointer is no longer useful and can be dropped. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/base.c | 2 +- drivers/gpu/drm/omapdrm/dss/omapdss.h

[PATCH v3 34/56] drm/omap: drop omapdss-boot-init

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel The table of compatible values needed to be prefixed with "omapdss," is empty, so all of this code is doing nothing now. Let's drop it. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/Kconfig |

[PATCH v3 46/56] drm/omap: drop empty omap_encoder helper functions

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Cleanup empty functions for encoder enable, disable and atomic check. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_encoder.c | 28 -- 1 file changed, 28 deletions(-) diff --git a/drivers/gpu

[PATCH v3 52/56] drm/omap: squash omapdrm sub-modules into one

2020-11-05 Thread Tomi Valkeinen
;dss = NULL; } -EXPORT_SYMBOL_GPL(omapdss_device_disconnect); /* - * Components Handling @@ -290,7 +275,6 @@ void omapdss_gather_components(struct device *dev) for_each_available_child_of_node(dev->of_node, ch

[PATCH v3 41/56] drm/omap: dsi: Register a drm_bridge

2020-11-05 Thread Tomi Valkeinen
Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dsi.c | 134 -- 1 file changed, 89 insertions(+), 45 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c index f643321434e9..bbcdb62e1571 100644 --- a

[PATCH v3 38/56] drm/omap: panel-dsi-cm: fix remove()

2020-11-05 Thread Tomi Valkeinen
-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c index 086c7d71fe17..795db22d148d 100644 --- a/drivers/gpu/drm/omapdrm

[PATCH v3 48/56] drm/omap: drop dssdev display field

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel All displays are using drm_panel instead off dssdev now, so this field is always 0 and can be dropped. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/base.c| 2 +- drivers/gpu/drm/omapdrm/dss/omapdss.h | 6 -- 2

[PATCH v3 42/56] drm/omap: remove legacy DSS device operations

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel All DSS devices have been converted to bridge API, so the device operations are always NULL. This removes the device ops function pointers and all code using it. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/base.c

[PATCH v3 43/56] drm/omap: remove unused omap_connector

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Remove unused code. Connectors are now created via drm_bridge_connector_init() and no longer OMAP specific. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/Makefile | 1 - drivers/gpu/drm/omapdrm/omap_connector.c

[PATCH v3 39/56] drm/omap: remove global dss_device variable

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel We can simply provide the device to the omapdrm driver via pdata. omapdss_is_initialized() is no longer required (even before this patch), since omapdrm device is only registered after the pointer is initialized. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi

[PATCH v3 31/56] drm/omap: dsi: Reverse direction of the DSS device enable/disable operations

2020-11-05 Thread Tomi Valkeinen
nel driver moving it a bit further to a standard drm_panel driver. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 74 +-- drivers/gpu/drm/omapdrm/omap_encoder.c| 24 ++ 2 files changed, 45 inserti

[PATCH v3 10/56] drm/omap: dsi: simplify write function

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Simplify the write related messages handling by using the functionality provided by CONFIG_DRM_MIPI_DSI. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/Kconfig | 1 + drivers/gpu/drm/omapdrm/dss/dsi.c | 146

[PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-05 Thread Tomi Valkeinen
fy omap_display_id drm/omap: drop unused DSS next pointer drm/omap: drop empty omap_encoder helper functions drm/omap: drop DSS ops_flags drm/omap: drop dssdev display field drm/omap: simplify DSI manual update code drm/omap: dsi: simplify pin config ARM: omap2plus_defconfig: Update

[PATCH v3 24/56] drm/omap: dsi: lp/hs switching support for transfer()

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Integrate low-power / high-speed bus switching into transfer function and drop the omapdrm specific enable_hs() callback. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 6 +++--- drivers/gpu/drm

[PATCH v3 06/56] drm/omap: dsi: add generic transfer function

2020-11-05 Thread Tomi Valkeinen
patches. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dsi.c | 54 +++ drivers/gpu/drm/omapdrm/dss/omapdss.h | 3 ++ 2 files changed, 57 insertions(+) diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm

[PATCH v3 08/56] drm/omap: dsi: unexport specific data transfer functions

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel After converting all DSI drivers, unexport the specific transfer functions. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dsi.c | 12 drivers/gpu/drm/omapdrm/dss/omapdss.h | 20 2

[PATCH v3 07/56] drm/omap: panel-dsi-cm: convert to transfer API

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel This converts the panel-dsi-cm driver to use the transfer API instead of specific functions, so that the specific functions can be unexported and squashed into the generic transfer function. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu

[PATCH v3 11/56] drm/omap: dsi: simplify read functions

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Simplify the read related message handling by using the functionality provided by CONFIG_DRM_MIPI_DSI. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dsi.c | 110 +- 1 file changed, 34

[PATCH v3 16/56] drm/omap: panel-dsi-cm: drop hardcoded VC

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Use dsi->channel everywhere, which originates from DT. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 20 +++ 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/

[PATCH v3 02/56] Revert "drm/omap: dss: Remove unused omap_dss_device operations"

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel This reverts commit 4ff8e98879e6eeae9d125dfcf3b642075d00089d. This is still needed by DSI. E.g. unloading modules without this will cause a crash. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/base.c | 26

[PATCH v3 12/56] drm/omap: dsi: switch dsi_vc_send_long/short to mipi_dsi_msg

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Simplify the DSI encoder by using mipi_dsi_msg for dsi_vc_send_long and dsi_vc_send_short. Further improvements require cleaning up the channel allocation code first. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dsi.c

[PATCH v3 01/56] drm/dsi: add MIPI_DSI_MODE_ULPS_IDLE

2020-11-05 Thread Tomi Valkeinen
introduce a flag to signal the DSI host implementation that the panel allows going into ULPS mode. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- include/drm/drm_mipi_dsi.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_mipi_dsi.h b/include/drm

[PATCH v3 22/56] drm/omap: dsi: use pixel-format and mode from attach

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel In order to reduce the amount of custom functionality, this moves handling of pixel format and DSI mode from set_config() to dsi attach. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 2 -- drivers

[PATCH v3 14/56] drm/omap: panel-dsi-cm: use DSI helpers

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel After converting the driver to mipi_dsi_device we can use the generic message helpers to simplify the driver a lot. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 125 +++--- 1 file

[PATCH v3 09/56] drm/omap: dsi: drop virtual channel logic

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel This drops the virtual channel logic. Afterwards DSI clients request their channel number and get the virtual channel with the same number or -EBUSY if already in use. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays

[PATCH v3 25/56] drm/omap: dsi: move TE GPIO handling into core

2020-11-05 Thread Tomi Valkeinen
acquisition follows works in the same way as the exynos DSI implementation. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 101 + drivers/gpu/drm/omapdrm/dss/dsi.c | 138 -- 2 files changed

[PATCH v3 04/56] drm/omap: dsi: use MIPI_DSI_FMT_* instead of OMAP_DSS_DSI_FMT_*

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel This replaces OMAP specific enum for pixel format with common implementation. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 2 +- drivers/gpu/drm/omapdrm/dss/dsi.c | 55

[PATCH v3 18/56] drm/omap: dsi: drop unused memory_read()

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel memory_read is not used, so we can drop the code. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 93 --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 4 - 2 files changed, 97

[PATCH v3 13/56] drm/omap: dsi: introduce mipi_dsi_host

2020-11-05 Thread Tomi Valkeinen
: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 121 +- drivers/gpu/drm/omapdrm/dss/dsi.c | 54 ++-- drivers/gpu/drm/omapdrm/dss/omapdss.h | 4 - 3 files changed, 103 insertions(+), 76 deletions(-) diff --git

[PATCH v3 19/56] drm/omap: dsi: drop unused get_te()

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel The get_te() callback is not used, so we can drop the custom API. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 13 - drivers/gpu/drm/omapdrm/dss/omapdss.h | 1 - 2 files

[PATCH v3 21/56] drm/omap: dsi: drop useless sync()

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel The DSI sync() function only locks the bus and then releases it again. Currently the only invocation is directly before update(), which locks the bus anyways. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi

[PATCH v3 20/56] drm/omap: dsi: drop unused enable_te()

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel enable_te() is not used, so the custom API can be dropped. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 39 --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 2 - 2 files changed

[PATCH v3 15/56] drm/omap: dsi: request VC via mipi_dsi_attach

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Drop custom request_vc/release_vc callbacks by using the generic mipi_dsi_attach/mipi_dsi_detach functions. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 24 +--- drivers/gpu/drm/omapdrm/dss

[PATCH v3 03/56] drm/omap: drop unused dsi.configure_pins

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel The panel-dsi-cm's ddata->pin_config is always NULL, so this callback is never called. Instead the DSI encoder gets the pin configuration directly from DT. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/displays/p

[PATCH v3 05/56] drm/omap: constify write buffers

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel The write buffers are not modified, so they can be constant. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dsi.c | 24 drivers/gpu/drm/omapdrm/dss/omapdss.h | 10 +- 2 files changed

[PATCH v3 17/56] drm/omap: panel-dsi-cm: use common MIPI DCS 1.3 defines

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Drop local definition of common MIPI DCS 1.3 defines. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v3 23/56] drm/omap: panel-dsi-cm: use bulk regulator API

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Use bulk regulator API to simplify the code. This also switches from _optional variant to normal variant, which will provide a dummy regulator (i.e. if some always-enabled regulator is not described in DT). Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen

[PATCH v2 4/5] drm/omap: rearrange includes in omapdss.h

2020-11-03 Thread Tomi Valkeinen
Drop "uapi/" and rearrange alphabetically. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h index ab

[PATCH v2 3/5] drm/omap: Implement CTM property for CRTC using OVL managers CPR matrix

2020-11-03 Thread Tomi Valkeinen
add a custom property just for that. Signed-off-by: Jyri Sarha Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_crtc.c | 39 +++-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c b/drivers/gpu/drm/omapdrm/omap_c

[PATCH v2 0/5] drm/omap: add color mgmt support

2020-11-03 Thread Tomi Valkeinen
l will use DEGAMMA_LUT underneath. And on top of that, we have the CTM and plane color mgmt. Tomi Jyri Sarha (2): drm/omap: Implement CTM property for CRTC using OVL managers CPR matrix drm/omap: Enable COLOR_ENCODING and COLOR_RANGE properties for planes Tomi Valkeinen (3): drm:

[PATCH v2 5/5] drm/omap: Enable COLOR_ENCODING and COLOR_RANGE properties for planes

2020-11-03 Thread Tomi Valkeinen
-off-by: Jyri Sarha Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dispc.c | 104 -- drivers/gpu/drm/omapdrm/dss/omapdss.h | 4 + drivers/gpu/drm/omapdrm/omap_plane.c | 30 3 files changed, 97 insertions(+), 41 deletions(-) diff --git a/drivers

[PATCH v2 2/5] drm/omap: use degamma property for gamma table

2020-11-03 Thread Tomi Valkeinen
GAMMA_LUT to DEGAMMA_LUT, and uses drm_atomic_helper_legacy_degamma_set for gamma_set helper. Thus we will have: degamma -> ctm -> out and the legacy ioctl will continue working as before. Signed-off-by: Tomi Valkeinen Reviewed-by: Pekka Paalanen --- drivers/gpu/drm/omapdrm/omap_crtc.c | 14

[PATCH v2 1/5] drm: add legacy support for using degamma for gamma

2020-11-03 Thread Tomi Valkeinen
but the legacy gamma-set ioctl does not work. This patch adds a new helper, drm_atomic_helper_legacy_degamma_set(), which can be used instead of drm_atomic_helper_legacy_gamma_set() when the DEGAMMA_LUT is the underlying property that needs to be set. Signed-off-by: Tomi Valkeinen Reviewed-by: Pek

Re: [PATCH v2] drm/bridge: tpd12s015: Fix irq registering in tpd12s015_probe

2020-11-03 Thread Tomi Valkeinen
+ if (tpd->hpd_irq >= 0) { > ret = devm_request_threaded_irq(&pdev->dev, tpd->hpd_irq, NULL, > tpd12s015_hpd_isr, > IRQF_TRIGGER_RISING | > Reviewed-by: Tomi Valkeinen

Re: [PATCH] drm/bridge: tpd12s015: Fix irq registering in tpd12s015_probe

2020-11-02 Thread Tomi Valkeinen
On 02/11/2020 11:36, Yuehaibing wrote: > On 2020/11/2 14:57, Tomi Valkeinen wrote: >> On 31/10/2020 09:19, Sam Ravnborg wrote: >>> Hi YueHaibing >>> >>> Thanks for the fix. Appreciated but please update as per comments below. >>> >>> On S

Re: [PATCH 5/5] drm/bridge: mhdp8564: Support format negotiation

2020-11-02 Thread Tomi Valkeinen
On 30/10/2020 00:39, Laurent Pinchart wrote: > Hi Nikhil, > > Thank you for the patch. > > On Fri, Oct 16, 2020 at 04:09:17PM +0530, Nikhil Devshatwar wrote: >> With new connector model, mhdp bridge will not create the connector and >> SoC driver will rely on format negotiation to setup the encod

Re: [PATCH] drm/bridge: tpd12s015: Fix irq registering in tpd12s015_probe

2020-11-02 Thread Tomi Valkeinen
On 31/10/2020 09:19, Sam Ravnborg wrote: > Hi YueHaibing > > Thanks for the fix. Appreciated but please update as per comments below. > > On Sat, Oct 31, 2020 at 11:16:48AM +0800, YueHaibing wrote: >> gpiod_to_irq() return negative value in case of error, >> the existing code handle negative erro

Re: [PATCH 3/5] drm: bridge: Propagate the bus flags from bridge->timings

2020-10-30 Thread Tomi Valkeinen
Hi Boris, On 30/10/2020 10:08, Boris Brezillon wrote: > The "propagate output flags" and soon to be added "use > timing->input_flags if present" logic should only be used as a fallback > for bridges that do not support dynamic bus format/flags negotiation > IMHO. Ideally we'd want to convert all b

Re: [PATCH] fbcon: Disable accelerated scrolling

2020-10-30 Thread Tomi Valkeinen
piler warnings (Sam) > - Fix typo in comment (Jiri) > - add a todo entry for the cleanup (Thomas) > > v3: Remove more unused variables (0day) > > Reviewed-by: Thomas Zimmermann > Reviewed-by: Greg Kroah-Hartman > Acked-by: Sam Ravnborg > Cc: Jiri Slaby > Cc: Bartl

Re: [PATCH 3/5] drm: bridge: Propagate the bus flags from bridge->timings

2020-10-30 Thread Tomi Valkeinen
On 30/10/2020 00:48, Laurent Pinchart wrote: >>> And, hmm... It's too easy to get confused with these, but... If the bridge >>> defines timings, and >>> timings->input_bus_flags != 0, should we always pick that, even if we got >>> something via >>> output_flags? Logic being, if this bridge defin

Re: [PATCH 0/5] drm/tidss: Use new connector model for tidss

2020-10-29 Thread Tomi Valkeinen
On 28/10/2020 16:19, Nikhil Devshatwar wrote: >> Also, with J7 EVM and DP, when I unload the modules I see: >> > I confirm the same issue. > I doubt if it is because of the change I did. > Will try to revert the patches and confirm again My guess is that it's not your patches as such, but that the

Re: [PATCH] drm: bridge: cdns: Kconfig: Switch over dependency to ARCH_K3

2020-10-27 Thread Tomi Valkeinen
ixes: afba7e6c5fc1 ("rm: bridge: cdns-mhdp8546: Add TI J721E wrapper") > Cc: Swapnil Jakhade > Cc: Tomi Valkeinen > Cc: Laurent Pinchart > Cc: Yuti Amonkar > Cc: Jyri Sarha > Signed-off-by: Nishanth Menon > --- > drivers/gpu/drm/bridge/cadence/Kconfig | 2 +

Re: [PATCH 13/65] drm/omapdrm: Annotate dma-fence critical section in commit path

2020-10-26 Thread Tomi Valkeinen
pped if there wasn't a modeset done on a given crtc. > > For a bit more clarity pull the hw_done() call out of the if/else, > that way it's a bit clearer flow. But happy to shuffle this around as > is seen fit. > > Signed-off-by: Daniel Vetter > Cc: Tomi Valke

Re: [PATCH 3/5] drm: bridge: Propagate the bus flags from bridge->timings

2020-10-21 Thread Tomi Valkeinen
On 16/10/2020 13:39, Nikhil Devshatwar wrote: > When the next bridge does not specify any bus flags, use the > bridge->timings->input_bus_flags as fallback when propagating > bus flags from next bridge to current bridge. > > Signed-off-by: Nikhil Devshatwar > --- > drivers/gpu/drm/drm_bridge.c |

Re: [PATCH 1/5] drm/tidss: Move to newer connector model

2020-10-21 Thread Tomi Valkeinen
On 16/10/2020 13:39, Nikhil Devshatwar wrote: > To be able to support connector operations across multiple > bridges, it is recommended that the connector should be > created by the SoC driver instead of the bridges. > > Modify the tidss modesetting initialization sequence to > create the connecto

[PATCH v3 0/2] drm: add DisplayPort connector

2020-10-19 Thread Tomi Valkeinen
Hi, This series adds the DT bindings and a driver for DisplayPort connector. I have previously sent v1 and v2 with only the bindings. The bindings are unchanged, but I updated the patch description slightly for eDP and DP++. Tomi Tomi Valkeinen (2): dt-bindings: dp-connector: add binding

[PATCH v3 2/2] drm/bridge: display-connector: add DP support

2020-10-19 Thread Tomi Valkeinen
as possible. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/display-connector.c | 46 +- 1 file changed, 44 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/display-connector.c b/drivers/gpu/drm/bridge/display-connector.c index 4d278573cdb9..04362

[PATCH v3 1/2] dt-bindings: dp-connector: add binding for DisplayPort connector

2020-10-19 Thread Tomi Valkeinen
even if there is, I don't want to guess what it could look like, and could it be part of the dp-connector binding. * No DP++. I'm not familiar with DP++. DP++ might need an i2c bus added to the bindings. Signed-off-by: Tomi Valkeinen --- .../display/connector/dp-connector.yam

Re: [PATCH 0/5] drm/tidss: Use new connector model for tidss

2020-10-19 Thread Tomi Valkeinen
Hi Nikhil, On 16/10/2020 13:39, Nikhil Devshatwar wrote: > This series moves the tidss to using new connectoe model, where the > SoC driver (tidss) creates the connector and all the bridges are > attached with the flag DRM_BRIDGE_ATTACH_NO_CONNECTOR > > Since the bridges do not create the conne

Re: drm: Supporting new connector model in tidss

2020-10-06 Thread Tomi Valkeinen
Adding Boris who added bus format negotiation. On 06/10/2020 00:31, Nikhil Devshatwar wrote: > Hi all, > > I am trying to convert the upstream tidss drm driver to new > connector model. > The connector is getting created by the tidss driver and bridges are > attached with flag DRM_BRIDGE_ATTACH_N

Re: [PATCH v2] drm: bridge: cdns-mhdp8546: fix compile warning

2020-10-01 Thread Tomi Valkeinen
Hi Dave, Can you pick this up to drm-next? Fixes the x64 build warnings for the recent cdns-mhdp-5.10 pull. Tomi On 29/09/2020 12:19, Tomi Valkeinen wrote: > On x64 we get: > > drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c:751:10: warning: > conversion from 'long

Re: [PATCH v2 2/2] drm/tilcdc: Remove tilcdc_crtc_max_width(), use private data

2020-09-29 Thread Tomi Valkeinen
- > drivers/gpu/drm/tilcdc/tilcdc_drv.h | 7 ++--- > 3 files changed, 26 insertions(+), 35 deletions(-) Reviewed-by: Tomi Valkeinen Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Hel

[PATCH v2] drm: bridge: cdns-mhdp8546: fix compile warning

2020-09-29 Thread Tomi Valkeinen
sting to u32. Fixes: fb43aa0acdfd ("drm: bridge: Add support for Cadence MHDP8546 DPI/DP bridge") Signed-off-by: Tomi Valkeinen Reported-by: Stephen Rothwell Reviewed-by: Swapnil Jakhade Acked-by: Laurent Pinchart --- v2: No changes to code, added tags. drivers/gpu/drm/bridge/cadence/

Re: [PATCH] drm: bridge: cdns-mhdp8546: fix compile warning

2020-09-25 Thread Tomi Valkeinen
On 25/09/2020 15:00, Laurent Pinchart wrote: > On Fri, Sep 25, 2020 at 10:36:44AM +0300, Tomi Valkeinen wrote: >> On 24/09/2020 14:48, Laurent Pinchart wrote: >>> Hi Tomi, >>> >>> Thank you for the patch. >>> >>> On Wed, Sep 23, 2020 at 11:3

Re: [PATCH] drm: bridge: cdns-mhdp8546: fix compile warning

2020-09-25 Thread Tomi Valkeinen
On 24/09/2020 14:48, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Wed, Sep 23, 2020 at 11:30:57AM +0300, Tomi Valkeinen wrote: >> On x64 we get: >> >> drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c:751:10: warning: >>

Re: [PATCHv2] dt-bindings: dp-connector: add binding for DisplayPort connector

2020-09-24 Thread Tomi Valkeinen
On 23/09/2020 23:00, Rob Herring wrote: > On Wed, Sep 23, 2020 at 11:15 AM Tomi Valkeinen wrote: >> >> Hi Rob, >> >> On 23/09/2020 19:17, Rob Herring wrote: >> >>>> * No eDP. There's really no "eDP connector", as it's always a c

Re: [PATCH] drm: bridge: cdns-mhdp8546: fix compile warning

2020-09-24 Thread Tomi Valkeinen
On 23/09/2020 11:30, Tomi Valkeinen wrote: > On x64 we get: > > drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c:751:10: warning: > conversion from 'long unsigned int' to 'unsigned int' changes value from > '18446744073709551613' to '42949672

Re: [PATCHv2] dt-bindings: dp-connector: add binding for DisplayPort connector

2020-09-23 Thread Tomi Valkeinen
Hi Rob, On 23/09/2020 19:17, Rob Herring wrote: * No eDP. There's really no "eDP connector", as it's always a custom made connection between the DP and the DP panel. So possibly there is no need for edp-connector binding, but even if there is, I don't want to guess what it could look l

[PATCH 1/5] drm: add legacy support for using degamma for gamma

2020-09-23 Thread Tomi Valkeinen
but the legacy gamma-set ioctl does not work. This patch adds a new helper, drm_atomic_helper_legacy_degamma_set(), which can be used instead of drm_atomic_helper_legacy_gamma_set() when the DEGAMMA_LUT is the underlying property that needs to be set. Signed-off-by: Tomi Valkeinen --- drivers/gp

[PATCH 0/5] drm/omap: add color mgmt support

2020-09-23 Thread Tomi Valkeinen
t CTM property for CRTC using OVL managers CPR matrix drm/omap: Enable COLOR_ENCODING and COLOR_RANGE properties for planes Tomi Valkeinen (3): drm: add legacy support for using degamma for gamma drm/omap: use degamma property for gamma table drm/omap: rearrange includes in omapdss.h dr

[PATCH 2/5] drm/omap: use degamma property for gamma table

2020-09-23 Thread Tomi Valkeinen
GAMMA_LUT to DEGAMMA_LUT, and uses drm_atomic_helper_legacy_degamma_set for gamma_set helper. Thus we will have: degamma -> ctm -> out and the legacy ioctl will continue working as before. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_crtc.c | 14 +++--- 1 file cha

[PATCH 4/5] drm/omap: rearrange includes in omapdss.h

2020-09-23 Thread Tomi Valkeinen
Drop "uapi/" and rearrange alphabetically. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h index ab

[PATCH 3/5] drm/omap: Implement CTM property for CRTC using OVL managers CPR matrix

2020-09-23 Thread Tomi Valkeinen
add a custom property just for that. Signed-off-by: Jyri Sarha Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_crtc.c | 39 +++-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c b/drivers/gpu/drm/omapdrm/omap_c

[PATCH 5/5] drm/omap: Enable COLOR_ENCODING and COLOR_RANGE properties for planes

2020-09-23 Thread Tomi Valkeinen
-off-by: Jyri Sarha Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dispc.c | 104 -- drivers/gpu/drm/omapdrm/dss/omapdss.h | 4 + drivers/gpu/drm/omapdrm/omap_plane.c | 30 3 files changed, 97 insertions(+), 41 deletions(-) diff --git a/drivers

[PATCH] drm: bridge: cdns-mhdp8546: fix compile warning

2020-09-23 Thread Tomi Valkeinen
sting to u32. Fixes: fb43aa0acdfd ("drm: bridge: Add support for Cadence MHDP8546 DPI/DP bridge") Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/cadence/cdns

Re: linux-next: build warning after merge of the drm tree

2020-09-23 Thread Tomi Valkeinen
Hi Stephen, On 23/09/2020 06:36, Stephen Rothwell wrote: > Hi all, > > After merging the drm tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c: In function > 'cdns_mhdp_fw_activate': > drivers/gpu/drm/bridge/cad

Re: [PATCH 4/7] drm/omap: Implement CTM property for CRTC using OVL managers CPR matrix

2020-09-22 Thread Tomi Valkeinen
On 21/09/2020 14:49, Pekka Paalanen wrote: > would it not be simplest if KMS UAPI specification defined the abstract > color pipeline with all the blocks that may be exposed with > driver-agnostic UAPI, and then just say that if a block is not present, > it behaves as pass-through, a no-op? > > E

Re: [PATCH -next] drm: omapdrm: dss: simplify the return expression of hdmi_init_pll_data

2020-09-21 Thread Tomi Valkeinen
Hi, On 21/09/2020 16:10, Qinglang Miao wrote: > Simplify the return expression. > > Signed-off-by: Qinglang Miao > --- > drivers/gpu/drm/omapdrm/dss/hdmi_pll.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c > b/drivers/gpu

Re: [PATCH 4/7] drm/omap: Implement CTM property for CRTC using OVL managers CPR matrix

2020-09-21 Thread Tomi Valkeinen
Hi, On 04/09/2019 23:20, Ilia Mirkin wrote: >> Implement CTM color management property for OMAP CRTC using DSS >> overlay manager's Color Phase Rotation matrix. The CPR matrix does not >> exactly match the CTM property documentation. On DSS the CPR matrix is >> applied after gamma

[GIT PULL] cdns-mhdp bridge for 5.10

2020-09-18 Thread Tomi Valkeinen
8546 DisplayPort bridge driver Swapnil Jakhade (4): phy: Add new PHY attribute max_link_rate phy: cadence-torrent: Set Torrent PHY attributes drm: bridge: Add support for Cadence MHDP8546 DPI/DP bridge drm: bridge: cdns-mhdp8546: Add TI J721E wrapper Tomi Valkeinen (

Re: [PATCH v3 1/2] dt-bindings: display: ti,am65x-dss: add missing properties to dt-schema

2020-09-18 Thread Tomi Valkeinen
On 18/09/2020 04:18, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Wed, Sep 16, 2020 at 04:10:08PM +0300, Tomi Valkeinen wrote: >> Add assigned-clocks, assigned-clock-parents and dma-coherent optional >> properties. >> >> Signed

Re: [PATCHv2] dt-bindings: dp-connector: add binding for DisplayPort connector

2020-09-17 Thread Tomi Valkeinen
On 17/09/2020 14:22, Ville Syrjälä wrote: > On Thu, Sep 17, 2020 at 08:52:10AM +0300, Tomi Valkeinen wrote: >> Add binding for DisplayPort connector. A few notes: >> >> * Similar to hdmi-connector, it has hpd-gpios as an optional property, >> as the HPD could also

[PATCHv2] dt-bindings: dp-connector: add binding for DisplayPort connector

2020-09-17 Thread Tomi Valkeinen
k like, and could it be part of the dp-connector binding. * No DP++. I'm not familiar with DP++, but I think it's all handled by the DP bridge, and does not need any new properties to the dp-connector. Signed-off-by: Tomi Valkeinen --- Changes in v2: Add connector type. .../d

<    6   7   8   9   10   11   12   13   14   15   >