[PATCH v2 22/22] iommu: Remove iommu_domain_alloc()

2024-06-03 Thread Lu Baolu
The iommu_domain_alloc() interface is no longer used in the tree anymore. Remove it to avoid dead code. There is increasing demand for supporting multiple IOMMU drivers, and this is the last bus-based thing standing in the way of that. Signed-off-by: Lu Baolu --- include/linux/iommu.h | 6

[PATCH v2 21/22] iommu: Remove iommu_present()

2024-06-03 Thread Lu Baolu
The iommu_present() interface is no longer used in the tree anymore. Remove it to avoid dead code. Signed-off-by: Lu Baolu --- include/linux/iommu.h | 6 -- drivers/iommu/iommu.c | 25 - 2 files changed, 31 deletions(-) diff --git a/include/linux/iommu.h

[PATCH v2 20/22] drm/tegra: Remove call to iommu_domain_alloc()

2024-06-03 Thread Lu Baolu
Commit <17de3f5fdd35> ("iommu: Retire bus ops") removes iommu ops from the bus structure. The iommu subsystem no longer relies on bus for operations. So iommu_domain_alloc() interface is no longer relevant. Normally, iommu_paging_domain_alloc() could be a replacement for iommu_domain_alloc() if

[PATCH v2 19/22] drm/rockchip: Use iommu_paging_domain_alloc()

2024-06-03 Thread Lu Baolu
Commit <421be3ee36a4> ("drm/rockchip: Refactor IOMMU initialisation") has refactored rockchip_drm_init_iommu() to pass a device that the domain is allocated for. Replace iommu_domain_alloc() with iommu_paging_domain_alloc() to retire the former. Signed-off-by: Lu Baolu ---

[PATCH v2 17/22] ARM: dma-mapping: Pass device to arm_iommu_create_mapping()

2024-06-03 Thread Lu Baolu
From: Robin Murphy All users of ARM IOMMU mappings create them for a particular device, so change the interface to accept the device rather than forcing a vague indirection through a bus type. This prepares for making a similar change to iommu_domain_alloc() itself. Signed-off-by: Robin Murphy

[PATCH v2 18/22] ARM: dma-mapping: Use iommu_paging_domain_alloc()

2024-06-03 Thread Lu Baolu
Since arm_iommu_create_mapping() now accepts the device, let's replace iommu_domain_alloc() with iommu_paging_domain_alloc() to retire the former. Signed-off-by: Lu Baolu --- arch/arm/mm/dma-mapping.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH v2 15/22] RDMA/usnic: Use iommu_paging_domain_alloc()

2024-06-03 Thread Lu Baolu
usnic_uiom_alloc_pd() allocates a paging domain for a given device. In this case, iommu_domain_alloc(dev->bus) is equivalent to  iommu_paging_domain_alloc(dev). Replace it as iommu_domain_alloc() has been deprecated. Signed-off-by: Lu Baolu --- drivers/infiniband/hw/usnic/usnic_uiom.c | 6

[PATCH v2 16/22] iommu/vt-d: Add helper to allocate paging domain

2024-06-03 Thread Lu Baolu
The domain_alloc_user operation is currently implemented by allocating a paging domain using iommu_domain_alloc(). This is because it needs to fully initialize the domain before return. Add a helper to do this to avoid using iommu_domain_alloc(). Signed-off-by: Lu Baolu ---

[PATCH v2 14/22] soc/fsl/qbman: Use iommu_paging_domain_alloc()

2024-06-03 Thread Lu Baolu
An iommu domain is allocated in portal_set_cpu() and is attached to pcfg->dev in the same function. Use iommu_paging_domain_alloc() to make it explicit. Signed-off-by: Lu Baolu --- drivers/soc/fsl/qbman/qman_portal.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH v2 13/22] remoteproc: Use iommu_paging_domain_alloc()

2024-06-03 Thread Lu Baolu
An iommu domain is allocated in rproc_enable_iommu() and is attached to rproc->dev.parent in the same function. Use iommu_paging_domain_alloc() to make it explicit. Signed-off-by: Lu Baolu --- drivers/remoteproc/remoteproc_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH v2 12/22] wifi: ath11k: Use iommu_paging_domain_alloc()

2024-06-03 Thread Lu Baolu
An iommu domain is allocated in ath11k_ahb_fw_resources_init() and is attached to ab_ahb->fw.dev in the same function. Use iommu_paging_domain_alloc() to make it explicit. Signed-off-by: Lu Baolu --- drivers/net/wireless/ath/ath11k/ahb.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH v2 11/22] ath10k: Use iommu_paging_domain_alloc()

2024-06-03 Thread Lu Baolu
An iommu domain is allocated in ath10k_fw_init() and is attached to ar_snoc->fw.dev in the same function. Use iommu_paging_domain_alloc() to make it explicit. Signed-off-by: Lu Baolu --- drivers/net/wireless/ath/ath10k/snoc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH v2 10/22] media: venus: firmware: Use iommu_paging_domain_alloc()

2024-06-03 Thread Lu Baolu
An iommu domain is allocated in venus_firmware_init() and is attached to core->fw.dev in the same function. Use iommu_paging_domain_alloc() to make it explicit. Signed-off-by: Lu Baolu --- drivers/media/platform/qcom/venus/firmware.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH v2 09/22] media: nvidia: tegra: Use iommu_paging_domain_alloc()

2024-06-03 Thread Lu Baolu
An iommu domain is allocated in tegra_vde_iommu_init() and is attached to vde->dev. Use iommu_paging_domain_alloc() to make it explicit. Signed-off-by: Lu Baolu --- drivers/media/platform/nvidia/tegra-vde/iommu.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH v2 07/22] drm/nouveau/tegra: Use iommu_paging_domain_alloc()

2024-06-03 Thread Lu Baolu
In nvkm_device_tegra_probe_iommu(), a paging domain is allocated for @dev and attached to it on success. Use iommu_paging_domain_alloc() to make it explicit. Signed-off-by: Lu Baolu --- drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH v2 08/22] gpu: host1x: Use iommu_paging_domain_alloc()

2024-06-03 Thread Lu Baolu
An iommu domain is allocated in host1x_iommu_attach() and is attached to host->dev. Use iommu_paging_domain_alloc() to make it explicit. Signed-off-by: Lu Baolu --- drivers/gpu/host1x/dev.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/host1x/dev.c

[PATCH v2 06/22] drm/msm: Use iommu_paging_domain_alloc()

2024-06-03 Thread Lu Baolu
The domain allocated in msm_iommu_new() is for the @dev. Replace iommu_domain_alloc() with iommu_paging_domain_alloc() to make it explicit. Signed-off-by: Lu Baolu --- drivers/gpu/drm/msm/msm_iommu.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[PATCH v2 05/22] iommu: Add iommu_paging_domain_alloc() interface

2024-06-03 Thread Lu Baolu
Commit <17de3f5fdd35> ("iommu: Retire bus ops") removes iommu ops from bus. The iommu subsystem no longer relies on bus for operations. So the bus parameter in iommu_domain_alloc() is no longer relevant. Add a new interface named iommu_paging_domain_alloc(), which explicitly indicates the

[PATCH v2 04/22] vhost-vdpa: Use iommu_user_domain_alloc()

2024-06-03 Thread Lu Baolu
Replace iommu_domain_alloc() with iommu_user_domain_alloc(). Signed-off-by: Lu Baolu --- drivers/vhost/vdpa.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index 63a53680a85c..d15673cb05f2 100644 ---

[PATCH v2 03/22] vfio/type1: Use iommu_user_domain_alloc()

2024-06-03 Thread Lu Baolu
Replace iommu_domain_alloc() with iommu_user_domain_alloc(). Signed-off-by: Lu Baolu --- drivers/vfio/vfio_iommu_type1.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c index 3a0218171cfa..1d553f7f7c26

[PATCH v2 02/22] iommufd: Use iommu_user_domain_alloc()

2024-06-03 Thread Lu Baolu
Replace iommu_domain_alloc() with iommu_user_domain_alloc(). Signed-off-by: Lu Baolu --- drivers/iommu/iommufd/hw_pagetable.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/iommu/iommufd/hw_pagetable.c b/drivers/iommu/iommufd/hw_pagetable.c

[PATCH v2 01/22] iommu: Add iommu_user_domain_alloc() interface

2024-06-03 Thread Lu Baolu
Commit <909f4abd1097> ("iommu: Add new iommu op to create domains owned by userspace") added a dedicated iommu op to allocate a user domain. While IOMMUFD has already made use of this callback, other frameworks like vfio/type1 and vDPA still use the paging domain allocation interface. Add a new

[PATCH v2 00/22] iommu: Refactoring domain allocation interface

2024-06-03 Thread Lu Baolu
The IOMMU subsystem has undergone some changes, including the removal of iommu_ops from the bus structure. Consequently, the existing domain allocation interface, which relies on a bus type argument, is no longer relevant: struct iommu_domain *iommu_domain_alloc(struct bus_type *bus) This

Re: [PATCH 00/20] iommu: Refactoring domain allocation interface

2024-06-03 Thread Baolu Lu
On 6/3/24 9:35 PM, Jason Gunthorpe wrote: On Wed, May 29, 2024 at 08:02:12PM +0800, Baolu Lu wrote: drivers/infiniband/hw/usnic/usnic_uiom.c:   pd->domain = domain = iommu_domain_alloc(dev->bus); This series leave those cases unchanged and keep iommu_domain_alloc() for their usage. But new

Re: [PATCH] drm/i915/gt: Fix potential UAF by revoke of fence registers

2024-06-03 Thread Andi Shyti
Hi Janusz, On Mon, Jun 03, 2024 at 09:54:45PM +0200, Janusz Krzysztofik wrote: > CI has been sporadically reporting the following issue triggered by > igt@i915_selftest@live@hangcheck on ADL-P and similar machines: > > <6> [414.049203] i915: Running >

Re: [PATCH] drm/i915/gt: Delete the live_hearbeat_fast selftest

2024-06-03 Thread Andi Shyti
Hi Krzysztof, On Mon, Jun 03, 2024 at 06:20:22PM +0200, Niemiec, Krzysztof wrote: > The test is trying to push the heartbeat frequency to the limit, which > might sometimes fail. Such a failure does not provide valuable > information, because it does not indicate that there is something >

[PATCH] drm/msm/adreno: Add support for Adreno 505 GPU

2024-06-03 Thread Barnabás Czémán
From: Daniil Titov This GPU is found on SoCs such as MSM8937 (450 MHz), MSM8940 (475 MHz), SDM439 (650 MHz). Signed-off-by: Daniil Titov Signed-off-by: Barnabás Czémán --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 29 +

Re: [RFC PATCH v1] dma-buf: heaps: move the verification of heap_flags to the corresponding heap

2024-06-03 Thread Hailong Liu
On Mon, 03. Jun 09:01, John Stultz wrote: > On Mon, Jun 3, 2024 at 4:40 AM wrote: > > > > From: "Hailong.Liu" > > > > This help module use heap_flags to determine the type of dma-buf, > > so that some mechanisms can be used to speed up allocation, such as > > memory_pool, to optimize the

[PATCH v1 1/1] treewide: Align match_string() with sysfs_match_string()

2024-06-03 Thread Andy Shevchenko
Make two APIs look similar. Hence convert match_string() to be a 2-argument macro. In order to avoid unneeded churn, convert all users as well. There is no functional change intended. Signed-off-by: Andy Shevchenko --- Compile tested with `make allyesconfig` and `make allmodconfig` on x86_64,

[RFC PATCH v1] dma-buf: heaps: move the verification of heap_flags to the corresponding heap

2024-06-03 Thread hailong.liu
From: "Hailong.Liu" This help module use heap_flags to determine the type of dma-buf, so that some mechanisms can be used to speed up allocation, such as memory_pool, to optimize the allocation time of dma-buf. Signed-off-by: Hailong.Liu --- drivers/dma-buf/dma-heap.c | 3 ---

Re: [PATCH v1 1/1] treewide: Align match_string() with sysfs_match_string()

2024-06-03 Thread Bjorn Helgaas
On Sun, Jun 02, 2024 at 06:57:12PM +0300, Andy Shevchenko wrote: > Make two APIs look similar. Hence convert match_string() to be > a 2-argument macro. In order to avoid unneeded churn, convert > all users as well. There is no functional change intended. Looks nice, thanks for doing this. > diff

Re: [PATCH] drm/amd/display: Increase frame-larger-than warning limit

2024-06-03 Thread Nathan Chancellor
Hi Palmer, On Thu, May 30, 2024 at 07:57:42AM -0700, Palmer Dabbelt wrote: > From: Palmer Dabbelt > > I get a handful of build errors along the lines of > > > linux/drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:58:13: > error: stack frame size (2352) exceeds

Re: [PATCH] Revert "drm/amdgpu: init iommu after amdkfd device init"

2024-06-03 Thread Armin Wolf
works again. He also confirmed that kernel 6.8.1 also works on his device, so the upstream commit itself seems to be ok. An amdgpu developer (Alex Deucher) confirmed that this patch should have never been ported to 5.15 in the first place, so revert this commit from the 5.15 stable series. Hi

Re: [PATCH v3 4/5] drm/mipi-dbi: Add support for DRM_FORMAT_RGB888

2024-06-03 Thread Dmitry Baryshkov
-off-by: Noralf Trønnes > --- > drivers/gpu/drm/drm_mipi_dbi.c | 29 + > include/drm/drm_mipi_dbi.h | 5 + > 2 files changed, 30 insertions(+), 4 deletions(-) The patch generally LGTM. The only nit is the name of 'emulation_format'. My first impression wa

Re: [PATCH v2] drm/msm/dpu: fix encoder irq wait skip

2024-06-03 Thread Abhinav Kumar
To make patchwork happy, I am re-adding the tags this patch for previously as they got lost. Reviewed-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar

Re: [PATCH v2 7/9] drm/msm/dpu: check for overflow in _dpu_crtc_setup_lm_bounds()

2024-06-03 Thread Dmitry Baryshkov
ould have had . Does this qualify for a Fixes tag? > > > > Probably no. We currently have a limit in the drm_mode_config, which > > ensures that the CRTC isn't too wide. > > > > The limit in drm_mode_config is to ensure we will not go beyond > 2*max_m

Re: [PATCH 2/6] drm/bridge: tc358767: Use tc_pxl_pll_calc() to correct adjusted_mode clock

2024-06-03 Thread Marek Vasut
On 6/3/24 2:45 PM, Alexander Stein wrote: Hi, @@ -1631,6 +1643,18 @@ static int tc_edp_atomic_check(struct drm_bridge *bridge, struct drm_crtc_state *crtc_state, struct drm_connector_state *conn_state) { + struct tc_data *tc

Re: [PATCH 3/6] drm/bridge: tc358767: Drop line_pixel_subtract

2024-06-03 Thread Marek Vasut
], no? It is. I was wondering because it was not stated. I thought [1] was already applied, but it seems it was only RBd. I can either apply [1] and then add this on top, so the two commits can be reverted separately if this one breaks something, or squash [1] into this patch and send V2

Re: [PATCH v2 9/9] drm/msm/dpu: sync mode_config limits to the FB limits in dpu_plane.c

2024-06-03 Thread Abhinav Kumar
On 6/2/2024 2:39 PM, Dmitry Baryshkov wrote: Lift mode_config limits set by the DPU driver to the actual FB limits as handled by the dpu_plane.c. Move 2*max_lm_width check where it belongs, to the drm_crtc_helper_funcs::mode_valid() callback. Signed-off-by: Dmitry Baryshkov ---

Re: [PATCH v2 7/9] drm/msm/dpu: check for overflow in _dpu_crtc_setup_lm_bounds()

2024-06-03 Thread Abhinav Kumar
On 6/3/2024 2:16 PM, Dmitry Baryshkov wrote: On Mon, 3 Jun 2024 at 23:57, Abhinav Kumar wrote: On 6/2/2024 2:39 PM, Dmitry Baryshkov wrote: Check in _dpu_crtc_setup_lm_bounds() that CRTC width is not overflowing LM requirements. Signed-off-by: Dmitry Baryshkov ---

Re: [PATCH] drm/msm/dpu: drop duplicate drm formats from wb2_formats arrays

2024-06-03 Thread Dmitry Baryshkov
On Fri, May 24, 2024 at 11:01:12PM +0800, Junhao Xie wrote: > There are duplicate items in wb2_formats_rgb and wb2_formats_rgb_yuv, > which cause weston assertions failed. > > weston: libweston/drm-formats.c:131: weston_drm_format_array_add_format: > Assertion

Re: [PATCH v2 7/9] drm/msm/dpu: check for overflow in _dpu_crtc_setup_lm_bounds()

2024-06-03 Thread Dmitry Baryshkov
On Mon, 3 Jun 2024 at 23:57, Abhinav Kumar wrote: > > > > On 6/2/2024 2:39 PM, Dmitry Baryshkov wrote: > > Check in _dpu_crtc_setup_lm_bounds() that CRTC width is not overflowing > > LM requirements. > > > > Signed-off-by: Dmitry Baryshkov > > --- > > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c |

Re: [PATCH v2 7/9] drm/msm/dpu: check for overflow in _dpu_crtc_setup_lm_bounds()

2024-06-03 Thread Abhinav Kumar
On 6/2/2024 2:39 PM, Dmitry Baryshkov wrote: Check in _dpu_crtc_setup_lm_bounds() that CRTC width is not overflowing LM requirements. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff

Re: [PATCH v3 3/5] drm/mipi-dbi: Make bits per word configurable for pixel transfers

2024-06-03 Thread Dmitry Baryshkov
On Mon, Jun 03, 2024 at 01:21:34PM +0200, Noralf Trønnes via B4 Relay wrote: > From: Noralf Trønnes > > This prepares for supporting other pixel formats than RGB565. Yes, the patch is pretty simple, however could you please expand the commit message by describing write_memory_bpw int

Re: [PATCH v3 2/5] drm/mipi-dbi: Remove mipi_dbi_machine_little_endian()

2024-06-03 Thread Dmitry Baryshkov
On Mon, Jun 03, 2024 at 01:21:33PM +0200, Noralf Trønnes via B4 Relay wrote: > From: Noralf Trønnes > > mipi_dbi_machine_little_endian() should really have been called > mipi_dbi_framebuffer_little_endian() because that's the function it > performs. When I added support for these SPI displays I

Re: [PATCH] drm: Combine identical if/elif code blocks

2024-06-03 Thread Thorsten Blum
it a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h >>>>> index 16122819edfe..315af7b19c97 100644 >>>>> --- a/include/uapi/drm/drm.h >>>>> +++ b/include/uapi/drm/drm.h >>>>> @@ -35,13 +35,7 @@ >>>>> #ifndef _DRM_H_ >

[PATCH] drm/i915/gt: Fix potential UAF by revoke of fence registers

2024-06-03 Thread Janusz Krzysztofik
CI has been sporadically reporting the following issue triggered by igt@i915_selftest@live@hangcheck on ADL-P and similar machines: <6> [414.049203] i915: Running intel_hangcheck_live_selftests/igt_reset_evict_fence ... <6> [414.068804] i915 :00:02.0: [drm] GT0: GUC: submission enabled <6>

Re: [PATCH v2 6/9] drm/msm/dpu: drop call to _dpu_crtc_setup_lm_bounds from atomic_begin

2024-06-03 Thread Abhinav Kumar
On 6/2/2024 2:39 PM, Dmitry Baryshkov wrote: The dpu_crtc_atomic_check() already calls _dpu_crtc_setup_lm_bounds(). There is no need to call it from dpu_crtc_atomic_begin(). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 -- 1 file changed, 2

Re: [PATCH v2 4/9] drm/msm/dpu: move dpu_format_populate_plane_sizes to atomic_check

2024-06-03 Thread Abhinav Kumar
On 6/2/2024 2:39 PM, Dmitry Baryshkov wrote: Move a call to dpu_format_populate_plane_sizes() to the atomic_check step, so that any issues with the FB layout can be reported as early as possible. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 12

Re: [PATCH 4/9] drm/msm/dpu: move dpu_format_populate_plane_sizes to atomic_check

2024-06-03 Thread Abhinav Kumar
On 4/22/2024 5:22 AM, Dmitry Baryshkov wrote: On Fri, Apr 19, 2024 at 07:37:44PM -0700, Abhinav Kumar wrote: On 4/19/2024 6:34 PM, Dmitry Baryshkov wrote: On Fri, Apr 19, 2024 at 05:14:01PM -0700, Abhinav Kumar wrote: On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote: Move a call to

Re: [PATCH v2 2/9] drm/msm/dpu: drop dpu_format_populate_layout from dpu_plane_sspp_atomic_update

2024-06-03 Thread Abhinav Kumar
On 6/2/2024 2:39 PM, Dmitry Baryshkov wrote: The dpu_plane_prepare_fb() already calls dpu_format_populate_layout(). Store the generated layour in the plane state and drop this call from dpu_plane_sspp_update(). noticed a small typo (missed it in v1), layour --> layout. No need to resend,

Re: [PATCH v2 1/9] drm/msm/dpu: drop dpu_format_check_modified_format

2024-06-03 Thread Abhinav Kumar
On 6/2/2024 2:39 PM, Dmitry Baryshkov wrote: The msm_kms_funcs::check_modified_format() callback is not used by the driver. Drop it completely. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 43 -

Re: [PATCH 1/9] drm/msm/dpu: drop dpu_format_check_modified_format

2024-06-03 Thread Abhinav Kumar
patch? Please don't attach patches to the email. It makes it impossible to respond to them. I attached it because it was too much to paste over here. Please review msm_framebuffer_init() in the downstream sources. The only missing piece I can see is the handling of DRM_MODE_FB_MODIFIERS flags

Re: [RFC PATCH v1] dma-buf: heaps: move the verification of heap_flags to the corresponding heap

2024-06-03 Thread John Stultz
f usage identification becomes a challenge. A potential > solution could be heap_flags. the use of heap_flags seems ugly and > contrary to the intended design as you said, How aboult extending > dma_heap_allocation_data as follows? > > struct dma_heap_allocation_data { > __

[PATCH] drm/xe/vm: Simplify if condition

2024-06-03 Thread Thorsten Blum
The if condition !A || A && B can be simplified to !A || B. Fixes the following Coccinelle/coccicheck warning reported by excluded_middle.cocci: WARNING !A || A && B is equivalent to !A || B Compile-tested only. Signed-off-by: Thorsten Blum --- drivers/gpu/drm/xe/xe_vm.c | 4 ++-- 1

Re: [PATCH v10 1/8] x86/vmware: Introduce VMware hypercall API

2024-06-03 Thread Borislav Petkov
On Wed, May 29, 2024 at 05:44:32PM -0700, Alexey Makhalov wrote: > While most of the vmware_hypercall callers are executed after alternative > patching applied, there are small amount of hypercalls running before that. > Only for them we have the logic of analyzing vmware_hypercall_mode as a >

Re: [PATCH 2/6] drm/nouveau: remove unused struct 'init_exec'

2024-06-03 Thread Dr. David Alan Gilbert
* li...@treblig.org (li...@treblig.org) wrote: > From: "Dr. David Alan Gilbert" > > 'init_exec' is unused since > commit cb75d97e9c77 ("drm/nouveau: implement devinit subdev, and new > init table parser") > Remove it. > > Signed-off-by: Dr. David Alan Gilbert Ping. > --- >

Re: [PATCH 3/6] drm/vmwgfx: remove unused struct 'vmw_stdu_dma'

2024-06-03 Thread Dr. David Alan Gilbert
* li...@treblig.org (li...@treblig.org) wrote: > From: "Dr. David Alan Gilbert" > > 'vmw_stdu_dma' is unused since > commit 39985eea5a6d ("drm/vmwgfx: Abstract placement selection") > Remove it. Ping. > Signed-off-by: Dr. David Alan Gilbert > --- > drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 5

[PATCH] agp: add missing MODULE_DESCRIPTION() macros

2024-06-03 Thread Jeff Johnson
make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/char/agp/amd64-agp.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/char/agp/intel-agp.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/char/agp/intel-gtt.o WARNING: modpost:

Re: [PATCH 00/14] Add initial support for the Rockchip RK3588 HDMI TX Controller

2024-06-03 Thread Maxime Ripard
ick review of your patchset and I don't understand why you need > > > to add a separate dw-hdmi-qp.c since you only need simple variants of the > > > I2C > > > bus, infoframe and bridge setup. > > > > > > Can you elaborate further ? isn't this Quad-Pix

[PATCH] drm/i915/gt: Delete the live_hearbeat_fast selftest

2024-06-03 Thread Niemiec, Krzysztof
The test is trying to push the heartbeat frequency to the limit, which might sometimes fail. Such a failure does not provide valuable information, because it does not indicate that there is something necessarily wrong with either the driver or the hardware. Remove the test to prevent random,

Re: [RFC PATCH v1] dma-buf: heaps: move the verification of heap_flags to the corresponding heap

2024-06-03 Thread John Stultz
On Mon, Jun 3, 2024 at 4:40 AM wrote: > > From: "Hailong.Liu" > > This help module use heap_flags to determine the type of dma-buf, > so that some mechanisms can be used to speed up allocation, such as > memory_pool, to optimize the allocation time of dma-buf. This feels like it's trying to

Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers

2024-06-03 Thread Mina Almasry
cator including larger order / > >> huge page and dmabuf. > >> > > > > Thanks Christoph, this particular patch series adds dmabuf, so I > > assume no objection there. I assume the objection is that you want the > > generic, extensible hooks removed. > > &

Re: [PATCH v3 01/10] media: Add Chameleon v3 video interface driver

2024-06-03 Thread Hans Verkuil
On 03/06/2024 16:32, Paweł Anikiel wrote: > On Mon, Jun 3, 2024 at 9:57 AM Hans Verkuil wrote: >> >> On 07/05/2024 17:54, Paweł Anikiel wrote: >>> Add v4l2 driver for the video interface present on the Google >>> Chameleon v3. The Chameleon v3 uses the video interface to capture >>> a single

Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers

2024-06-03 Thread Pavel Begunkov
of the series. As far as I'm concerned it is not. I've not seen any convincing argument for more than page/folio allocator including larger order / huge page and dmabuf. Thanks Christoph, this particular patch series adds dmabuf, so I assume no objection there. I assume the objection is that you want

Re: [PATCH v3 00/12] drm/imx/ipuv3: switch LDB and parallel-display driver to use drm_bridge_connector

2024-06-03 Thread Chris Healy
On Mon, Jun 3, 2024 at 3:12 AM Dmitry Baryshkov wrote: > > On Sun, Jun 02, 2024 at 08:25:39PM -0700, Chris Healy wrote: > > On an i.MX53 QSB with HDMI daughter board, this patch series is: > > > > Tested-by: Chris Healy > > Thank you! I assume this is imx53-qsrb-hdm

Re: [PATCH v3 01/10] media: Add Chameleon v3 video interface driver

2024-06-03 Thread Paweł Anikiel
On Mon, Jun 3, 2024 at 9:57 AM Hans Verkuil wrote: > > On 07/05/2024 17:54, Paweł Anikiel wrote: > > Add v4l2 driver for the video interface present on the Google > > Chameleon v3. The Chameleon v3 uses the video interface to capture > > a single video source from a given HDMI or DP connector and

Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers

2024-06-03 Thread Mina Almasry
> > As far as I'm concerned it is not. I've not seen any convincing > argument for more than page/folio allocator including larger order / > huge page and dmabuf. > Thanks Christoph, this particular patch series adds dmabuf, so I assume no objection there. I assume the objection is that

Re: [PATCH 01/20] drm/bridge: add dsi_lp11_notify mechanism

2024-06-03 Thread Michael Walle
eems more sensible. > > Granted that there can be several DSI devices sharing the DSI bus (aka > split-link), I was toying with the idea of making the DSI host call > attached DSI devices when the transition happens. So almost the same, as this patch? > I don't have a fully working PoC an

[PATCH v13 12/12] drm/ttm/tests: Use u32 and u64 over uint*_t types

2024-06-03 Thread Karolina Stolarek
Update the tests and helpers to use unsigned kernel types. Signed-off-by: Karolina Stolarek Suggested-by: Thomas Hellström --- drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 12 ++-- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 6 ++

[PATCH v13 11/12] drm/ttm/tests: Correct modules' licenses

2024-06-03 Thread Karolina Stolarek
The test files are GPL and MIT, so update the definitions accordingly. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 2 +- drivers/gpu/drm/ttm/tests/ttm_device_test.c | 2 +- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 2 +-

[PATCH v13 10/12] drm/ttm/tests: Add TODO file

2024-06-03 Thread Karolina Stolarek
List improvements for the test suite with some notes. Signed-off-by: Karolina Stolarek Reviewed-by: Thomas Hellström --- drivers/gpu/drm/ttm/tests/TODO | 27 +++ 1 file changed, 27 insertions(+) create mode 100644 drivers/gpu/drm/ttm/tests/TODO diff --git

[PATCH v13 09/12] drm/ttm/tests: Add tests for ttm_tt_populate

2024-06-03 Thread Karolina Stolarek
Add tests for functions that add and release pages to TTs. Test the swapin operation. Export ttm_tt_unpopulate, ttm_tt_swapin and ttm_tt_swapout symbols for testing purposes. Signed-off-by: Karolina Stolarek Reviewed-by: Somalapuram, Amaranath Tested-by: Somalapuram, Amaranath ---

[PATCH v13 08/12] drm/ttm/tests: Add eviction testing

2024-06-03 Thread Karolina Stolarek
Add tests for ttm_bo_validate that focus on BO eviction and swapout. Update device funcs definition with eviction-related callbacks. Add alternative funcs where evict_flags() routes eviction to a domain that can't allocate resources (dubbed "busy manager" in the tests). Extract the common path of

[PATCH v13 07/12] drm/ttm/tests: Add test cases dependent on fence signaling

2024-06-03 Thread Karolina Stolarek
Add test cases that check how the state of dma fences in BO's reservation object influence the ttm_bo_validation() flow. Do similar tests for resource manager's move fence. Signed-off-by: Karolina Stolarek Reviewed-by: Somalapuram, Amaranath Tested-by: Somalapuram, Amaranath ---

[PATCH v13 06/12] drm/ttm/tests: Add tests with mock resource managers

2024-06-03 Thread Karolina Stolarek
Add mock resource manager to test ttm_bo_validate() with non-system placements. Update KConfig entry to enable DRM Buddy allocator, used by the mock manager. Update move function to do more than just assign a resource. Signed-off-by: Karolina Stolarek Tested-by: Somalapuram, Amaranath ---

[PATCH v13 05/12] drm/ttm/tests: Test simple BO creation and validation

2024-06-03 Thread Karolina Stolarek
Add tests for ttm_bo_init_reserved() and ttm_bo_validate() that use sys manager. Define a simple move function in ttm_device_funcs. Expose destroy callback of the buffer object to make testing of ttm_bo_init_reserved() behaviour easier. Signed-off-by: Karolina Stolarek Reviewed-by: Matthew Auld

[PATCH v13 04/12] drm/ttm/tests: Use an init function from the helpers lib

2024-06-03 Thread Karolina Stolarek
Add a new helper function that also initializes the device. Use it in ttm_tt test suite and delete the local definition. Signed-off-by: Karolina Stolarek Reviewed-by: Matthew Auld Reviewed-by: Somalapuram, Amaranath --- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 14 ++

[PATCH v13 03/12] drm/ttm/tests: Set DMA mask in KUnit device

2024-06-03 Thread Karolina Stolarek
In commit d393acce7b3f ("drm/tests: Switch to kunit devices"), DRM test helpers migrated away from using a dummy platform driver in favour of KUnit device. This means that DMA masks for the device are not set but are required by ttm_pool_alloc tests. Set the DMA mask for coherent mappings to

[PATCH v13 02/12] drm/ttm/tests: Delete unnecessary config option

2024-06-03 Thread Karolina Stolarek
DRM KUnit helpers are selected automatically when TTM tests are enabled, so there's no need to do it directly in the .kunitconfig file. Signed-off-by: Karolina Stolarek Reviewed-by: Nirmoy Das --- drivers/gpu/drm/ttm/tests/.kunitconfig | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH v13 01/12] drm/ttm/tests: Fix a warning in ttm_bo_unreserve_bulk

2024-06-03 Thread Karolina Stolarek
BOs in a bulk move have to share the same reservation object. That is not the case in the ttm_bo_unreserve_bulk subtest. Update ttm_bo_kunit_init() helper to accept dma_resv object so we can define buffer objects that share the same resv. Update calls to that helper accordingly. Fixes:

[PATCH v13 00/12] Improve test coverage of TTM

2024-06-03 Thread Karolina Stolarek
4)_t (also respectively, 12/12) - Update TODO to describe how the mock manager can be rewritten v12: - Rewrite "drm/ttm/tests: Fix a warning in ttm_bo_unreserve_bulk" patch to extend ttm_bo_kunit_init() helper to accept a dma_resv object and update calls to that helper (C

Re: [PATCH 00/20] iommu: Refactoring domain allocation interface

2024-06-03 Thread Jason Gunthorpe
On Wed, May 29, 2024 at 08:02:12PM +0800, Baolu Lu wrote: > > > drivers/infiniband/hw/usnic/usnic_uiom.c:   pd->domain = domain > > > = iommu_domain_alloc(dev->bus); > > > > > > This series leave those cases unchanged and keep iommu_domain_alloc() > > > for their usage. But new drivers should

Re: [PATCH 00/14] Add initial support for the Rockchip RK3588 HDMI TX Controller

2024-06-03 Thread neil . armstrong
ers layout, see PATCH 13/14. I think make it a separate driver will be easier for development and maintenance. I'm with Andy here. Trying to navigate a driver for two IP blocks really sounds taxing especially when both are so different. I agree, I just wanted more details than "

Re: [PATCH 00/14] Add initial support for the Rockchip RK3588 HDMI TX Controller

2024-06-03 Thread Heiko Stuebner
bridge setup. > > > > Can you elaborate further ? isn't this Quad-Pixel (QP) TX controller version > > detectable at runtime ? > > > > I would prefer to keep a single dw-hdmi driver if possible. > > > > The QP HDMI controller is a completely different variant with totall

Re: [PATCH] drm/vmwgfx: Don't destroy Screen Target when CRTC is enabled but inactive

2024-06-03 Thread Martin Krastev
On Fri, May 31, 2024 at 11:34 PM Ian Forbes wrote: > > drm_crtc_helper_funcs::atomic_disable can be called even when the CRTC is > still enabled. This can occur when the mode changes or the CRTC is set as > inactive. > > In the case where the CRTC is being set as inactive we only want to > blank

Re: [PATCH net-next v10 01/14] netdev: add netdev_rx_queue_restart()

2024-06-03 Thread Pavel Begunkov
On 5/30/24 21:16, Mina Almasry wrote: Add netdev_rx_queue_restart() function to netdev_rx_queue.h Signed-off-by: David Wei Signed-off-by: Mina Almasry --- ... diff --git a/net/core/netdev_rx_queue.c b/net/core/netdev_rx_queue.c new file mode 100644 index 0..b3899358e5a9c ---

Re: [PATCH v11 6/8] drm/i915/display: Compute Adaptive sync SDP params

2024-06-03 Thread Nautiyal, Ankit K
On 6/3/2024 11:19 AM, Mitul Golani wrote: Compute params for Adaptive Sync SDP when Fixed Average Vtotal mode is enabled. --v2: Since vrr.enable is set in case of cmrr also, handle accordingly(Ankit). --v3: - Since vrr.enable is set in case of cmrr also, handle accordingly(Ankit). - check

Re: [PATCH 2/6] drm/bridge: tc358767: Use tc_pxl_pll_calc() to correct adjusted_mode clock

2024-06-03 Thread Alexander Stein
Hi Marek, Am Freitag, 31. Mai 2024, 22:39:48 CEST schrieb Marek Vasut: > Use tc_pxl_pll_calc() to find out the exact clock frequency generated by the > Pixel PLL. Use the Pixel PLL frequency as adjusted_mode clock frequency and > pass it down the display pipeline to obtain exactly this frequency

Re: [PATCH 00/14] Add initial support for the Rockchip RK3588 HDMI TX Controller

2024-06-03 Thread Andy Yan
TX controller version detectable at runtime ? I would prefer to keep a single dw-hdmi driver if possible. The QP HDMI controller is a completely different variant with totally different registers layout, see PATCH 13/14. I think make it a separate driver will be easier for development and maintena

Re: [PATCH 3/6] drm/bridge: tc358767: Drop line_pixel_subtract

2024-06-03 Thread Alexander Stein
Hi Marek, Am Freitag, 31. Mai 2024, 22:39:49 CEST schrieb Marek Vasut: > This line_pixel_subtract is no longer needed now that the bridge can > request and obtain specific pixel clock on input to the bridge, with > clock frequency that matches the Pixel PLL frequency. > > The line_pixel_subtract

Re: [PATCH 00/20] drm/bridge: tc358775: proper bridge bringup and code cleanup

2024-06-03 Thread Michael Walle
e for this bridge, therefore, the front porch > is always ignored. > > The most controversial patch is probably "drm/bridge: add > dsi_lp11_notify mechanism" which is needed for (1) above. Some time ago > there was a series [1] to add a manual power-up, which was abandon

[PATCH v3 4/5] drm/mipi-dbi: Add support for DRM_FORMAT_RGB888

2024-06-03 Thread Noralf Trønnes via B4 Relay
From: Noralf Trønnes DRM_FORMAT_RGB888 is 24 bits per pixel and it would be natural to send it on the SPI bus using a 24 bits per word transfer. The problem with this is that not all SPI controllers support 24 bpw. Since DRM_FORMAT_RGB888 is stored in memory as little endian and the SPI bus is

[PATCH v3 3/5] drm/mipi-dbi: Make bits per word configurable for pixel transfers

2024-06-03 Thread Noralf Trønnes via B4 Relay
From: Noralf Trønnes This prepares for supporting other pixel formats than RGB565. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_mipi_dbi.c | 14 ++ include/drm/drm_mipi_dbi.h | 5 + 2 files changed, 15 insertions(+), 4 deletions(-) diff --git

[PATCH v3 1/5] dt-bindings: display: panel: mipi-dbi-spi: Add a pixel format property

2024-06-03 Thread Noralf Trønnes via B4 Relay
From: Noralf Trønnes The MIPI DBI 2.0 specification (2005) lists only two pixel formats for the Type C Interface (SPI) and that is 3-bits/pixel RGB111 with 2 options for bit layout. For Type A and B (parallel) the following formats are listed: RGB332, RGB444, RGB565, RGB666 and RGB888 (some

[PATCH v3 2/5] drm/mipi-dbi: Remove mipi_dbi_machine_little_endian()

2024-06-03 Thread Noralf Trønnes via B4 Relay
From: Noralf Trønnes mipi_dbi_machine_little_endian() should really have been called mipi_dbi_framebuffer_little_endian() because that's the function it performs. When I added support for these SPI displays I thought that the framebuffers on big endian machines were also big endian, but I have

[PATCH v3 0/5] drm/tiny: panel-mipi-dbi: Support 18 bits per color RGB666

2024-06-03 Thread Noralf Trønnes via B4 Relay
Hi, The binding and driver patches have been reviewed and I appreciate if someone can take a look at the drm_mipi_dbi patches. The first patch removes some erroneous big endian code and the 2 other makes it possible to configure bits per word for the SPI pixel transfer. It's currently hardcoded

[PATCH v3 5/5] drm/tiny: panel-mipi-dbi: Support the pixel format property

2024-06-03 Thread Noralf Trønnes via B4 Relay
From: Noralf Trønnes Add support for these pixel format property values: - r5g6b5, RGB565 - b6x2g6x2r6x2, BGR666 BGR666 is presented to userspace as RGB888. The 2 LSB in each color are discarded by the controller. The pixel is sent on the wire using 8 bits per word (little endian) so the

Re: [PATCH v3 00/12] drm/imx/ipuv3: switch LDB and parallel-display driver to use drm_bridge_connector

2024-06-03 Thread Dmitry Baryshkov
On Sun, Jun 02, 2024 at 08:25:39PM -0700, Chris Healy wrote: > On an i.MX53 QSB with HDMI daughter board, this patch series is: > > Tested-by: Chris Healy Thank you! I assume this is imx53-qsrb-hdmi ? > > HDMI output still works correctly and the bridges file reflects the chang

Re: [PATCH v4 1/9] drm/connector: hdmi: accept NULL for Audio Infoframe

2024-06-03 Thread Dmitry Baryshkov
tantly, it looks like you're not using it at all in your series? It should have been a part of msm_hdmi_audio_disable(), but it seems with all the refactorings I forgot to use it. I'll check again the behaviour and either drop this patch or add a separate helper and fix other comments below. >

<    3   4   5   6   7   8   9   10   11   12   >