Re: [RFC PATCH 1/3] drm: use flags instead of boolean in plane check

2020-09-16 Thread Daniel Vetter
On Wed, Sep 16, 2020 at 12:31:44PM +0200, Stefan Agner wrote: > On 2020-09-11 10:50, Daniel Vetter wrote: > > On Thu, Sep 10, 2020 at 11:24:23AM +0200, Stefan Agner wrote: > >> To improve readability and make it easier to add further optional checks > >> replace the boolean parameters with a

Re: [RFC PATCH 1/3] drm: use flags instead of boolean in plane check

2020-09-16 Thread Stefan Agner
On 2020-09-11 10:50, Daniel Vetter wrote: > On Thu, Sep 10, 2020 at 11:24:23AM +0200, Stefan Agner wrote: >> To improve readability and make it easier to add further optional checks >> replace the boolean parameters with a single flag bitfield as parameter >> of

Re: [RFC PATCH 1/3] drm: use flags instead of boolean in plane check

2020-09-15 Thread Laurent Pinchart
Hi Stefan, Thank you for the patch. On Thu, Sep 10, 2020 at 11:24:23AM +0200, Stefan Agner wrote: > To improve readability and make it easier to add further optional checks > replace the boolean parameters with a single flag bitfield as parameter > of drm_atomic_helper_check_plane_state. > >

Re: [RFC PATCH 1/3] drm: use flags instead of boolean in plane check

2020-09-11 Thread Daniel Vetter
On Thu, Sep 10, 2020 at 11:24:23AM +0200, Stefan Agner wrote: > To improve readability and make it easier to add further optional checks > replace the boolean parameters with a single flag bitfield as parameter > of drm_atomic_helper_check_plane_state. > > The regular call sites have been

[RFC PATCH 1/3] drm: use flags instead of boolean in plane check

2020-09-10 Thread Stefan Agner
To improve readability and make it easier to add further optional checks replace the boolean parameters with a single flag bitfield as parameter of drm_atomic_helper_check_plane_state. The regular call sites have been converted using a simple coccinelle patch. virtual patch @@ expression e1,