Re: [PATCH v2] component: do not leave master devres group open after bind

2021-10-13 Thread Greg KH
On Wed, Oct 06, 2021 at 04:47:57PM +0300, Kai Vehmanen wrote: > Hi, > > On Tue, 5 Oct 2021, Greg KH wrote: > > > On Wed, Sep 22, 2021 at 11:54:32AM +0300, Kai Vehmanen wrote: > > > In current code, the devres group for aggregate master is left open > > > after call to component_master_add_*().

Re: [PATCH v2] component: do not leave master devres group open after bind

2021-10-06 Thread Kai Vehmanen
Hi, On Tue, 5 Oct 2021, Greg KH wrote: > On Wed, Sep 22, 2021 at 11:54:32AM +0300, Kai Vehmanen wrote: > > In current code, the devres group for aggregate master is left open > > after call to component_master_add_*(). This leads to problems when the > > master does further managed allocations

Re: [PATCH v2] component: do not leave master devres group open after bind

2021-10-05 Thread Greg KH
On Wed, Sep 22, 2021 at 11:54:32AM +0300, Kai Vehmanen wrote: > In current code, the devres group for aggregate master is left open > after call to component_master_add_*(). This leads to problems when the > master does further managed allocations on its own. When any > participating driver calls

Re: [PATCH v2] component: do not leave master devres group open after bind

2021-09-28 Thread Kai Vehmanen
Hey, On Tue, 28 Sep 2021, Takashi Iwai wrote: > On Wed, 22 Sep 2021 10:54:32 +0200, Kai Vehmanen wrote: > > --- a/drivers/base/component.c > > +++ b/drivers/base/component.c > > @@ -246,7 +246,7 @@ static int try_to_bring_up_master(struct master *master, > > return 0; > > } > >

Re: [PATCH v2] component: do not leave master devres group open after bind

2021-09-28 Thread Takashi Iwai
On Wed, 22 Sep 2021 10:54:32 +0200, Kai Vehmanen wrote: (snip) > --- a/drivers/base/component.c > +++ b/drivers/base/component.c > @@ -246,7 +246,7 @@ static int try_to_bring_up_master(struct master *master, > return 0; > } > > - if (!devres_open_group(master->parent,

[PATCH v2] component: do not leave master devres group open after bind

2021-09-22 Thread Kai Vehmanen
In current code, the devres group for aggregate master is left open after call to component_master_add_*(). This leads to problems when the master does further managed allocations on its own. When any participating driver calls component_del(), this leads to immediate release of resources. This