[PATCH v2 0/4] Add HDMI jack support on RK3288

2019-07-10 Thread Cheng-Yi Chiang
This patch series supports HDMI jack reporting on RK3288, which uses DRM dw-hdmi driver and hdmi-codec codec driver. The previous discussion about reporting jack status using hdmi-notifier and drm_audio_component is at https://lore.kernel.org/patchwork/patch/1083027/ The new approach is to use a

[PATCH v2 1/4] ASoC: hdmi-codec: Add an op to set callback function for plug event

2019-07-10 Thread Cheng-Yi Chiang
Add an op in hdmi_codec_ops so codec driver can register callback function to handle plug event. Driver in DRM can use this callback function to report connector status. Signed-off-by: Cheng-Yi Chiang --- include/sound/hdmi-codec.h| 16 + sound/soc/codecs/hdmi-codec.c | 45 +

[PATCH v2 2/4] drm: bridge: dw-hdmi: Report connector status using callback

2019-07-10 Thread Cheng-Yi Chiang
Allow codec driver register callback function for plug event. The callback registration flow: dw-hdmi <--- hw-hdmi-i2s-audio <--- hdmi-codec dw-hdmi-i2s-audio implements hook_plugged_cb op so codec driver can register the callback. dw-hdmi implements set_plugged_cb op so platform device can regi

[PATCH v2 3/4] ASoC: rockchip_max98090: Add dai_link for HDMI

2019-07-10 Thread Cheng-Yi Chiang
Use two dai_links. One for HDMI and one for max98090. With this setup, audio can play to speaker and HDMI selectively. Signed-off-by: Cheng-Yi Chiang --- sound/soc/rockchip/rockchip_max98090.c | 95 +++--- 1 file changed, 72 insertions(+), 23 deletions(-) diff --git a/sound/

[PATCH v2 4/4] ASoC: rockchip_max98090: Add HDMI jack support

2019-07-10 Thread Cheng-Yi Chiang
In machine driver, create a jack and let hdmi-codec report jack status. Signed-off-by: Cheng-Yi Chiang --- sound/soc/rockchip/rockchip_max98090.c | 21 + 1 file changed, 21 insertions(+) diff --git a/sound/soc/rockchip/rockchip_max98090.c b/sound/soc/rockchip/rockchip_max98

[PATCH v8 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-07-10 Thread Brendan Higgins
## TL;DR This new patch set only contains a very minor change suggested by Masahiro to [PATCH v7 06/18] and is otherwise identical to PATCH v7. Also, with Josh's ack on the preceding patch set, I think we now have all necessary reviews and acks from all interested parties. ## Background This pa

[PATCH v8 01/18] kunit: test: add KUnit test runner core

2019-07-10 Thread Brendan Higgins
Add core facilities for defining unit tests; this provides a common way to define test cases, functions that execute code which is under test and determine whether the code under test behaves as expected; this also provides a way to group together related test cases in test suites (here we call the

[PATCH v8 04/18] kunit: test: add kunit_stream a std::stream like logger

2019-07-10 Thread Brendan Higgins
A lot of the expectation and assertion infrastructure prints out fairly complicated test failure messages, so add a C++ style log library for for logging test results. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- include/kunit/kunit-stream.h |

[PATCH v8 07/18] kunit: test: add initial tests

2019-07-10 Thread Brendan Higgins
Add a test for string stream along with a simpler example. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- kunit/Kconfig | 21 + kunit/Makefile | 4 ++ kunit/example-test.c | 88

[PATCH v8 03/18] kunit: test: add string_stream a std::stream like string builder

2019-07-10 Thread Brendan Higgins
A number of test features need to do pretty complicated string printing where it may not be possible to rely on a single preallocated string with parameters. So provide a library for constructing the string as you go similar to C++'s std::string. Signed-off-by: Brendan Higgins Reviewed-by: Greg

[PATCH v8 05/18] kunit: test: add the concept of expectations

2019-07-10 Thread Brendan Higgins
Add support for expectations, which allow properties to be specified and then verified in tests. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- include/kunit/test.h | 525 +++ kunit/test.c | 66 ++

[PATCH v8 02/18] kunit: test: add test resource management API

2019-07-10 Thread Brendan Higgins
Create a common API for test managed resources like memory and test objects. A lot of times a test will want to set up infrastructure to be used in test cases; this could be anything from just wanting to allocate some memory to setting up a driver stack; this defines facilities for creating "test r

[PATCH v8 06/18] kbuild: enable building KUnit

2019-07-10 Thread Brendan Higgins
KUnit is a new unit testing framework for the kernel and when used is built into the kernel as a part of it. Add KUnit to the root Kconfig and Makefile to allow it to be actually built. Signed-off-by: Brendan Higgins Cc: Masahiro Yamada Cc: Michal Marek Reviewed-by: Greg Kroah-Hartman Reviewed

[PATCH v8 08/18] objtool: add kunit_try_catch_throw to the noreturn list

2019-07-10 Thread Brendan Higgins
Fix the following warning seen on GCC 7.3: kunit/test-test.o: warning: objtool: kunit_test_unsuccessful_try() falls through to next function kunit_test_catch() kunit_try_catch_throw is a function added in the following patch in this series; it allows KUnit, a unit testing framework for the kern

[PATCH v8 09/18] kunit: test: add support for test abort

2019-07-10 Thread Brendan Higgins
Add support for aborting/bailing out of test cases, which is needed for implementing assertions. An assertion is like an expectation, but bails out of the test case early if the assertion is not met. The idea with assertions is that you use them to state all the preconditions for your test. Logica

[PATCH v8 13/18] kunit: tool: add Python wrappers for running KUnit tests

2019-07-10 Thread Brendan Higgins
From: Felix Guo The ultimate goal is to create minimal isolated test binaries; in the meantime we are using UML to provide the infrastructure to run tests, so define an abstract way to configure and run tests that allow us to change the context in which tests are built without affecting the user.

[PATCH v8 15/18] Documentation: kunit: add documentation for KUnit

2019-07-10 Thread Brendan Higgins
Add documentation for KUnit, the Linux kernel unit testing framework. - Add intro and usage guide for KUnit - Add API reference Signed-off-by: Felix Guo Signed-off-by: Brendan Higgins Cc: Jonathan Corbet Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- Documentation/dev-tools

[PATCH v8 12/18] kunit: test: add tests for KUnit managed resources

2019-07-10 Thread Brendan Higgins
From: Avinash Kondareddy Add unit tests for KUnit managed resources. KUnit managed resources (struct kunit_resource) are resources that are automatically cleaned up at the end of a KUnit test, similar to the concept of devm_* managed resources. Signed-off-by: Avinash Kondareddy Signed-off-by: B

[PATCH v8 16/18] MAINTAINERS: add entry for KUnit the unit testing framework

2019-07-10 Thread Brendan Higgins
Add myself as maintainer of KUnit, the Linux kernel's unit testing framework. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 677ef41cb01

[PATCH v8 17/18] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()

2019-07-10 Thread Brendan Higgins
From: Iurii Zaikin KUnit tests for initialized data behavior of proc_dointvec that is explicitly checked in the code. Includes basic parsing tests including int min/max overflow. Signed-off-by: Iurii Zaikin Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunt

[PATCH v8 18/18] MAINTAINERS: add proc sysctl KUnit test to PROC SYSCTL section

2019-07-10 Thread Brendan Higgins
Add entry for the new proc sysctl KUnit test to the PROC SYSCTL section, and add Iurii as a maintainer. Signed-off-by: Brendan Higgins Cc: Iurii Zaikin Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe Acked-by: Luis Chamberlain --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions

[PATCH v8 14/18] kunit: defconfig: add defconfigs for building KUnit tests

2019-07-10 Thread Brendan Higgins
Add defconfig for UML and a fragment that can be used to configure other architectures for building KUnit tests. Add option to kunit_tool to use a defconfig to create the kunitconfig. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- arch/um/config

[PATCH v8 10/18] kunit: test: add tests for kunit test abort

2019-07-10 Thread Brendan Higgins
Add KUnit tests for the KUnit test abort mechanism (see preceding commit). Add tests both for general try catch mechanism as well as non-architecture specific mechanism. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe --- kunit/Makefile| 3 +-

[PATCH v8 11/18] kunit: test: add the concept of assertions

2019-07-10 Thread Brendan Higgins
Add support for assertions which are like expectations except the test terminates if the assertion is not satisfied. The idea with assertions is that you use them to state all the preconditions for your test. Logically speaking, these are the premises of the test case, so if a premise isn't true,

Re: [PATCH v7 06/18] kbuild: enable building KUnit

2019-07-10 Thread Brendan Higgins
On Tue, Jul 9, 2019 at 9:00 PM Masahiro Yamada wrote: > > On Tue, Jul 9, 2019 at 3:34 PM Brendan Higgins > wrote: > > > > KUnit is a new unit testing framework for the kernel and when used is > > built into the kernel as a part of it. Add KUnit to the root Kconfig and > > Makefile to allow it to

Re: [PATCH v5 05/12] drm/modes: Rewrite the command line parser

2019-07-10 Thread Dmitry Osipenko
09.07.2019 16:28, Jon Hunter пишет: > > On 09/07/2019 14:26, Jon Hunter wrote: >> >> On 09/07/2019 13:52, Dmitry Osipenko wrote: >>> 09.07.2019 15:45, Maxime Ripard пишет: Hi, On Fri, Jul 05, 2019 at 07:54:47PM +0300, Dmitry Osipenko wrote: > 17.06.2019 17:51, Maxime Ripard пише

[GIT PULL] Please pull hmm changes

2019-07-10 Thread Jason Gunthorpe
Hi Linus, As was discussed some time ago here are the mostly -mm patches related to hmm functions. In agreement with Andrew we split this out from quilt into a git topic branch so it can be shared between the DRM and RDMA git trees. However, this cycle did not see dependencies with work in DRM or

Re: [PATCH 1/2] dt-bindings: backlight: fix vendor prefix for ArcticSand arcxcnn driver bindings

2019-07-10 Thread Brian Dodge
FYI: please note that pSemi's legal department has informed me that they do *not* want to keep the "ArcticSand" copyright notices and the single pSemi line is appropriate. On Mon, Jul 8, 2019 at 2:02 PM Dan Murphy wrote: > Brian > > On 6/30/19 7:28 PM, Brian Dodge wrote: > > The vendor-prefixes.

Re: [PATCH v2] gpu/drm_memory: fix a few warnings

2019-07-10 Thread J Lovejoy
> On Jul 8, 2019, at 1:57 PM, Thomas Gleixner wrote: > > On Mon, 8 Jul 2019, Qian Cai wrote: >> On Mon, 2019-07-08 at 15:21 -0400, Ilia Mirkin wrote: -/** +// SPDX-License-Identifier: MIT +/* * \file drm_memory.c * Memory management wrappers for DRM * @@

Re: [PATCH 5/7] drm/amd/display: Use proper enum conversion functions

2019-07-10 Thread Nathan Chancellor
On Tue, Jul 09, 2019 at 08:51:33PM +0200, Arnd Bergmann wrote: > On Thu, Jul 4, 2019 at 7:52 AM Nathan Chancellor > wrote: > > > > clang warns: > > > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_pp_smu.c:336:8: > > warning: implicit conversion from enumeration type 'enum smu_clk_typ

Re: [PATCH 0/7] amdgpu clang warning fixes on next-20190703

2019-07-10 Thread Nathan Chancellor
On Mon, Jul 08, 2019 at 11:55:50AM -0400, Alex Deucher wrote: > Applied the series. thanks! > > Alex Thank you :) I don't see the enum conversion ones in your current tree. If they indeed caused issues, could you guys please look into fixing the warnings properly yourselves (maybe something lik

[PATCH -next] drm/amdgpu: remove duplicated include from gfx_v9_0.c

2019-07-10 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c index 5ba332376710..822f45161240 100644 --- a/drivers/gpu/drm/amd/amdgp

[Bug 109955] amdgpu [RX Vega 64] system freeze while gaming

2019-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109955 --- Comment #43 from Mauro Gaspari --- Hi, No it was not always like this. I was using Kubuntu and my games were really smooth for months. Zero crashes. Then after a mesa update, I do not recall exactly the version but was around 18.5 or somethi

Re: hmm_range_fault related fixes and legacy API removal v2

2019-07-10 Thread Jason Gunthorpe
On Tue, Jul 09, 2019 at 04:30:38PM +0200, Christoph Hellwig wrote: > On Fri, Jul 05, 2019 at 09:33:36AM -0300, Jason Gunthorpe wrote: > > On Wed, Jul 03, 2019 at 03:02:08PM -0700, Christoph Hellwig wrote: > > > Hi Jérôme, Ben and Jason, > > > > > > below is a series against the hmm tree which fixe

Re: [PATCH v5 05/12] drm/modes: Rewrite the command line parser

2019-07-10 Thread Dmitry Osipenko
09.07.2019 15:45, Maxime Ripard пишет: > Hi, > > On Fri, Jul 05, 2019 at 07:54:47PM +0300, Dmitry Osipenko wrote: >> 17.06.2019 17:51, Maxime Ripard пишет: >>> From: Maxime Ripard >>> >>> Rewrite the command line parser in order to get away from the state machine >>> parsing the video mode lines.

[PATCH] drm/amdgpu: Fix build without CONFIG_HMM_MIRROR

2019-07-10 Thread YueHaibing
If CONFIG_HMM_MIRROR is not set, building may fails: In file included from drivers/gpu/drm/amd/amdgpu/amdgpu.h:72:0, from drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:40: drivers/gpu/drm/amd/amdgpu/amdgpu_mn.h:69:20: error: field mirror has incomplete type struct hmm_mirror mirro

Re: [PATCH 1/2] dt-bindings: backlight: fix vendor prefix for ArcticSand arcxcnn driver bindings

2019-07-10 Thread Dan Murphy
Brian On 7/9/19 12:48 PM, Brian Dodge wrote: FYI: please note that pSemi's legal department has informed me that they do *not* want to keep the "ArcticSand" copyright notices and the single pSemi line is appropriate. Thanks for the follow up.  Lawyers can be fickle about this stuff. On Mon

Re: [PATCH v2] gpu/drm_memory: fix a few warnings

2019-07-10 Thread J Lovejoy
> On Jul 8, 2019, at 1:57 PM, Thomas Gleixner wrote: > > On Mon, 8 Jul 2019, Qian Cai wrote: >> On Mon, 2019-07-08 at 15:21 -0400, Ilia Mirkin wrote: -/** +// SPDX-License-Identifier: MIT +/* * \file drm_memory.c * Memory management wrappers for DRM * @@

Re: [PATCH 23/60] drm/panel: Add driver for the Toppology TD028TTEC1 panel

2019-07-10 Thread Sam Ravnborg
Hi Laurent. This driver looks very good. On Sun, Jul 07, 2019 at 09:19:00PM +0300, Laurent Pinchart wrote: > This panel is used on the OpenMoko Neo FreeRunner and Neo 1973. Add info in Kconfig help entry? > > +config DRM_PANEL_TPO_TD028TTEC1 > + tristate "TPO TD028TTEC1 panel driver" Maybe

Re: [PATCH v8 06/18] kbuild: enable building KUnit

2019-07-10 Thread Masahiro Yamada
On Wed, Jul 10, 2019 at 4:16 PM Brendan Higgins wrote: > > KUnit is a new unit testing framework for the kernel and when used is > built into the kernel as a part of it. Add KUnit to the root Kconfig and > Makefile to allow it to be actually built. > > Signed-off-by: Brendan Higgins > Cc: Masahir

[Bug 111099] Green video when playing a hevc video with vdpau

2019-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111099 Bug ID: 111099 Summary: Green video when playing a hevc video with vdpau Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

[Bug 111099] Green video when playing a hevc video with vdpau

2019-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111099 Pierre-Eric Pelloux-Prayer changed: What|Removed |Added CC||christian.koe...@amd.com,

[Bug 111099] Green video when playing a hevc video with vdpau

2019-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111099 Michel Dänzer changed: What|Removed |Added CC|mic...@daenzer.net | --- Comment #1 from Michel Dänzer ---

[Bug 109955] amdgpu [RX Vega 64] system freeze while gaming

2019-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109955 --- Comment #44 from Wilko Bartels --- (In reply to Mauro Gaspari from comment #43) > Hi, > No it was not always like this. I was using Kubuntu and my games were really > smooth for months. Zero crashes. Then after a mesa update, I do not recall

Re: [PATCH v9 1/6] drm: Add Content protection type property

2019-07-10 Thread Pekka Paalanen
On Tue, 9 Jul 2019 18:17:59 +0530 Ramalingam C wrote: > On 2019-07-09 at 17:31:10 +0300, Pekka Paalanen wrote: > > On Mon, 8 Jul 2019 16:51:11 +0530 > > Ramalingam C wrote: > > > > > This patch adds a DRM ENUM property to the selected connectors. > > > This property is used for mentioning th

[Bug 109955] amdgpu [RX Vega 64] system freeze while gaming

2019-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109955 --- Comment #45 from Wilko Bartels --- (In reply to Mauro Gaspari from comment #43) > Hi, > No it was not always like this. I was using Kubuntu and my games were really > smooth for months. Zero crashes. Then after a mesa update, I do not recall

[Bug 109955] amdgpu [RX Vega 64] system freeze while gaming

2019-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109955 --- Comment #46 from Mauro Gaspari --- This is exactly the reason why I wish we could get more attention to this issue. I have seen so many people in forums on the internet replacing their AMD cards with NVIDIA due to similar issues. Or switchi

Re: kernel oops loading i915 after "x86/asm: Pin sensitive CR4 bits" (873d50d58)

2019-07-10 Thread Dmitry V. Levin
Hi, On Wed, Jul 10, 2019 at 01:44:17PM +0800, Xi Ruoyao wrote: > Hello, > > When I try to build and run the latest mainline kernel, it Oops loading i915 > module: > > BUG: unable to handle page fault for address: 9edc1598 > #PF: supervisor write access in kernel mode > #PF: error_code(0x

Re: [PATCH] drm/vkms: prime import support

2019-07-10 Thread Vasilev, Oleg
Hi Rodrigo, Thanks for the review. On Tue, 2019-07-09 at 10:39 -0300, Rodrigo Siqueira wrote: > Hi Oleg, > > First of all, thank you for your patch and for working in this issue. > > A few comments inline. > > On Thu, Jul 4, 2019 at 5:54 AM Oleg Vasilev > wrote: > > Bring dmabuf sharing throu

Re: [PATCH 00/12] treewide: Fix GENMASK misuses

2019-07-10 Thread Johannes Berg
On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > These GENMASK uses are inverted argument order and the > actual masks produced are incorrect. Fix them. > > Add checkpatch tests to help avoid more misuses too. > > Joe Perches (12): > checkpatch: Add GENMASK tests IMHO this doesn't make

[Bug 109955] amdgpu [RX Vega 64] system freeze while gaming

2019-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109955 --- Comment #47 from Sam --- The relevant issue and bug report here (the system freezing completely or if lucky just killing the X session, NOT games crashing) seems to be related exclusively to AMDGPU, and not to mesa. Whereas I got the same is

[Bug 110659] pageflipping seems to cause jittering on mouse input when running Hitman 2 in Wine/DXVK with amdgpu.dc=1

2019-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110659 --- Comment #25 from tempel.jul...@gmail.com --- Applying this MR and disabling HW cursor "fixes" the mouse skipping in the menu of Hitman 2 (as there is a cursor visible and thus pageflipping is turned off): https://gitlab.freedesktop.org/xorg/d

Re: [PATCH 00/12] treewide: Fix GENMASK misuses

2019-07-10 Thread Russell King - ARM Linux admin
On Wed, Jul 10, 2019 at 11:17:31AM +0200, Johannes Berg wrote: > On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > > These GENMASK uses are inverted argument order and the > > actual masks produced are incorrect. Fix them. > > > > Add checkpatch tests to help avoid more misuses too. > > >

Re: [PATCH v1] drm/modes: Skip invalid cmdline mode

2019-07-10 Thread Ville Syrjälä
On Tue, Jul 09, 2019 at 05:51:51PM +0300, Dmitry Osipenko wrote: > The named mode could be invalid and then cmdline parser misses to validate > mode's dimensions, happily adding 0x0 mode as a valid mode. One case where > this happens is NVIDIA Tegra devices that are using downstream bootloader > wh

Re: [PATCH 07/10] drm/i915: Implement MST Aux device registration

2019-07-10 Thread Ville Syrjälä
On Thu, Jul 04, 2019 at 03:05:16PM -0400, sunpeng...@amd.com wrote: > From: Leo Li > > Implement late_register and early_unregister hooks for MST connectors. > Call drm helpers for MST connector registration, which registers the > AUX devices. > > Signed-off-by: Leo Li > --- > drivers/gpu/drm/

Re: [PATCH v2] drm/sysfs: Add mstpath attribute to connector devices

2019-07-10 Thread Ville Syrjälä
On Fri, Jul 05, 2019 at 10:32:20AM -0400, sunpeng...@amd.com wrote: > From: Leo Li > > This can be used to create more descriptive symlinks for MST aux > devices. Consider the following udev rule: > > SUBSYSTEM=="drm_dp_aux_dev", SUBSYSTEMS=="drm", ATTRS{mstpath}=="?*", > SYMLINK+="drm_dp_

Re: [PATCH v1] drm/modes: Skip invalid cmdline mode

2019-07-10 Thread Maxime Ripard
On Tue, Jul 09, 2019 at 05:51:51PM +0300, Dmitry Osipenko wrote: > The named mode could be invalid and then cmdline parser misses to validate > mode's dimensions, happily adding 0x0 mode as a valid mode. One case where > this happens is NVIDIA Tegra devices that are using downstream bootloader > wh

[Bug 111099] Green video when playing a hevc video with vdpau

2019-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111099 --- Comment #2 from Michel Dänzer --- Created attachment 144748 --> https://bugs.freedesktop.org/attachment.cgi?id=144748&action=edit Proof-of-concept fix Does this help for you? Note that I can only reproduce this if I artificially disable

[Bug 111099] Green video when playing a hevc video with vdpau

2019-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111099 --- Comment #3 from Pierre-Eric Pelloux-Prayer --- (In reply to Michel Dänzer from comment #2) > Created attachment 144748 [details] [review] > Proof-of-concept fix > > Does this help for you? > Yes the patch fixes the issue. -- You are re

Re: [PATCH v2 7/7] arm64: dts: allwinner: a64: enable ANX6345 bridge on Teres-I

2019-07-10 Thread Maxime Ripard
On Tue, Jul 09, 2019 at 01:30:18PM -0700, Vasily Khoruzhick wrote: > On Tue, Jul 9, 2019 at 1:55 AM Maxime Ripard > wrote: > > > > On Mon, Jul 08, 2019 at 05:49:21PM -0700, Vasily Khoruzhick wrote: > > > > > Maybe instead of edp-connector one would introduce integrator's > > > > > specific > > >

Re: [PATCH 09/60] drm/bridge: Add connector-related bridge operations and data

2019-07-10 Thread Andrzej Hajda
Hi Laurent, I like the approach, current practice when almost every bridge should optionally implement connector, or alternatively downstream bridge or panel is very painful. More comments inlined. On 07.07.2019 20:18, Laurent Pinchart wrote: > To support implementation of DRM connectors on top

[RFC PATCH 0/6] Rename functions to match their entry points

2019-07-10 Thread Janusz Krzysztofik
Need for this was identified while working on split of driver unbind path into _remove() and _release() parts. Consistency in function naming has been recognized as helpful when trying to work out which phase the code is in. What I'm still not sure about is desired depth of that modification - ho

[RFC PATCH 2/6] drm/i915: Replace "_load" with "_probe" consequently

2019-07-10 Thread Janusz Krzysztofik
Use the "_probe" nomenclature not only in i915_driver_probe() helper name but also in other related function / variable names for consistency. Only the userspace exposed name of a related module parameter is left untouched. Signed-off-by: Janusz Krzysztofik --- .../gpu/drm/i915/display/intel_co

[RFC PATCH 1/6] drm/i915: Rename "_load"/"_unload" to match PCI entry points

2019-07-10 Thread Janusz Krzysztofik
Current names of i915_driver_load/unload() functions originate in legacy DRM stubs. Reduce nomenclature ambiguity by renaming them to match their current use as helpers called from PCI entry points. Suggested by: Chris Wilson Signed-off-by: Janusz Krzysztofik --- drivers/gpu/drm/i915/i915_drv.

[RFC PATCH 6/6] drm/i915: Rename "inject_load_failure" module parameter

2019-07-10 Thread Janusz Krzysztofik
Use the "probe" nomenclature for consistency with internally used names of functions and variables. Requires adjustment of IGT tests and possibly affects other user custom applications. Signed-off-by: Janusz Krzysztofik --- drivers/gpu/drm/i915/i915_drv.c| 10 +- drivers/gpu/drm/i91

[RFC PATCH 4/6] drm/i915: Propagate "_remove" function name suffix down

2019-07-10 Thread Janusz Krzysztofik
Similar to the "_release" case, consistently replace mixed "_cleanup"/"_fini"/"_fini_hw" components found in names of functions called from i915_driver_remove() with "_remove" or "_driver_remove" suffixes for better code readability. Signed-off-by: Janusz Krzysztofik --- drivers/gpu/drm/i915/dis

[RFC PATCH 3/6] drm/i915: Propagate "_release" function name suffix down

2019-07-10 Thread Janusz Krzysztofik
Replace mixed "_fini"/"_cleanup"/"_cleanup_hw" suffixes found in names of fucntions called from i915_driver_release() with "_release" suffix consistently. This provides better code readability, especially helpful when trying to work out which phase the code is in. Functions names starting with "i

[RFC PATCH 5/6] drm/i915: Propagate "_probe" function name suffix down

2019-07-10 Thread Janusz Krzysztofik
Similar to the "_release" and "_remove" cases, consequently replace "_init" components of names of functions called from i915_driver_probe() with "_probe" suffixes for better code readability. Signed-off-by: Janusz Krzysztofik --- drivers/gpu/drm/i915/i915_drv.c | 26 +-

[PATCH v3 0/4] Add a generic driver for LED-based backlight

2019-07-10 Thread Jean-Jacques Hiblot
This series aims to add a led-backlight driver, similar to pwm-backlight, but using a LED class device underneath. A few years ago (2015), Tomi Valkeinen posted a series implementing a backlight driver on top of a LED device: https://patchwork.kernel.org/patch/7293991/ https://patchwork.kernel.org

[PATCH v3 1/4] leds: Add of_led_get() and led_put()

2019-07-10 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen This patch adds basic support for a kernel driver to get a LED device. This will be used by the led-backlight driver. Only OF version is implemented for now, and the behavior is similar to PWM's of_pwm_get() and pwm_put(). Signed-off-by: Tomi Valkeinen Signed-off-by: Jean-

[PATCH v3 4/4] backlight: add led-backlight driver

2019-07-10 Thread Jean-Jacques Hiblot
From: Tomi Valkeinen This patch adds a led-backlight driver (led_bl), which is similar to pwm_bl except the driver uses a LED class driver to adjust the brightness in the HW. Multiple LEDs can be used for a single backlight. Signed-off-by: Tomi Valkeinen Signed-off-by: Jean-Jacques Hiblot ---

[PATCH v3 3/4] dt-bindings: backlight: Add led-backlight binding

2019-07-10 Thread Jean-Jacques Hiblot
Add DT binding for led-backlight. Signed-off-by: Jean-Jacques Hiblot --- .../bindings/leds/backlight/led-backlight.txt | 28 +++ 1 file changed, 28 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/backlight/led-backlight.txt diff --git a/Documentation/de

[PATCH v3 2/4] leds: Add managed API to get a LED from a device driver

2019-07-10 Thread Jean-Jacques Hiblot
If the LED is acquired by a consumer device with devm_led_get(), it is automatically release when the device is detach. Signed-off-by: Jean-Jacques Hiblot --- drivers/leds/led-class.c | 42 include/linux/leds.h | 2 ++ 2 files changed, 44 insertions(

Re: [PATCH v1] drm/modes: Skip invalid cmdline mode

2019-07-10 Thread Dmitry Osipenko
10.07.2019 13:12, Maxime Ripard пишет: > On Tue, Jul 09, 2019 at 05:51:51PM +0300, Dmitry Osipenko wrote: >> The named mode could be invalid and then cmdline parser misses to validate >> mode's dimensions, happily adding 0x0 mode as a valid mode. One case where >> this happens is NVIDIA Tegra devic

Re: [RFC PATCH 0/6] Rename functions to match their entry points

2019-07-10 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-07-10 13:36:25) > Need for this was identified while working on split of driver unbind > path into _remove() and _release() parts. Consistency in function > naming has been recognized as helpful when trying to work out which > phase the code is in. > > What I'm st

[PATCH 2/5] drm/dsc: Fix bogus cpu_to_be16() usage

2019-07-10 Thread Ville Syrjala
From: Ville Syrjälä __be16 = cpu_to_be16(__be16) is nonsense. Do it right. ../drivers/gpu/drm/drm_dsc.c:218:53: warning: incorrect type in assignment (different base types) ../drivers/gpu/drm/drm_dsc.c:218:53:expected restricted __be16 ../drivers/gpu/drm/drm_dsc.c:218:53:got int ../driv

[PATCH 3/5] drm: Include prototype for drm_need_swiotlb()

2019-07-10 Thread Ville Syrjala
From: Ville Syrjälä Sparse is not happy: ../drivers/gpu/drm/drm_memory.c:159:6: warning: symbol 'drm_need_swiotlb' was not declared. Should it be static? Include the correct header for drm_need_swiotlb() prototype. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_memory.c | 1 + 1 file c

[PATCH 4/5] drm/syncobj: Include the prototype for drm_timeout_abs_to_jiffies()

2019-07-10 Thread Ville Syrjala
From: Ville Syrjälä Sparse complains: ../drivers/gpu/drm/drm_syncobj.c:942:13: warning: symbol 'drm_timeout_abs_to_jiffies' was not declared. Should it be static? Include the correct header with the prototype. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_syncobj.c | 1 + 1 file chang

[PATCH 1/5] drm/fb-helper: Include prototype for drm_fb_helper_modinit()

2019-07-10 Thread Ville Syrjala
From: Ville Syrjälä Sparse complains: drivers/gpu/drm/drm_fb_helper.c:2409:12: warning: symbol 'drm_fb_helper_modinit' was not declared. Should it be static? Include the header with the correct prototype. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_fb_helper.c | 1 + 1 file changed,

[PATCH 5/5] drm: Fix return type of crc .poll()

2019-07-10 Thread Ville Syrjala
From: Ville Syrjälä Sparse compains: ../drivers/gpu/drm/drm_debugfs_crc.c:350:17: warning: incorrect type in initializer (different base types) ../drivers/gpu/drm/drm_debugfs_crc.c:350:17:expected restricted __poll_t ( *poll )( ... ) ../drivers/gpu/drm/drm_debugfs_crc.c:350:17:got unsig

[Bug 109538] VAAPI HEVC encoding is unstable and produces garbled output

2019-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109538 --- Comment #1 from gregory shu --- I'm doing it the other way around hevc_vaapi 10 bit to h264_vaapi and have similar results, garbled green output ffmpeg -threads 4 \ -init_hw_device vaapi=amd:/dev/dri/renderD128 -hwaccel vaapi -hwaccel_outpu

Re: [RFC PATCH 0/6] Rename functions to match their entry points

2019-07-10 Thread Janusz Krzysztofik
On Wednesday, July 10, 2019 2:47:08 PM CEST Chris Wilson wrote: > Quoting Janusz Krzysztofik (2019-07-10 13:36:25) > > Need for this was identified while working on split of driver unbind > > path into _remove() and _release() parts. Consistency in function > > naming has been recognized as helpfu

Re: [PATCH v1] drm/modes: Skip invalid cmdline mode

2019-07-10 Thread Maxime Ripard
On Wed, Jul 10, 2019 at 03:42:28PM +0300, Dmitry Osipenko wrote: > 10.07.2019 13:12, Maxime Ripard пишет: > > On Tue, Jul 09, 2019 at 05:51:51PM +0300, Dmitry Osipenko wrote: > >> The named mode could be invalid and then cmdline parser misses to validate > >> mode's dimensions, happily adding 0x0 m

Re: [PATCH v1] drm/modes: Skip invalid cmdline mode

2019-07-10 Thread Dmitry Osipenko
10.07.2019 15:55, Maxime Ripard пишет: > On Wed, Jul 10, 2019 at 03:42:28PM +0300, Dmitry Osipenko wrote: >> 10.07.2019 13:12, Maxime Ripard пишет: >>> On Tue, Jul 09, 2019 at 05:51:51PM +0300, Dmitry Osipenko wrote: The named mode could be invalid and then cmdline parser misses to validate >>

Re: [PATCH v1] drm/modes: Skip invalid cmdline mode

2019-07-10 Thread Maxime Ripard
On Wed, Jul 10, 2019 at 03:59:55PM +0300, Dmitry Osipenko wrote: > 10.07.2019 15:55, Maxime Ripard пишет: > > On Wed, Jul 10, 2019 at 03:42:28PM +0300, Dmitry Osipenko wrote: > >> 10.07.2019 13:12, Maxime Ripard пишет: > >>> On Tue, Jul 09, 2019 at 05:51:51PM +0300, Dmitry Osipenko wrote: > Th

Re: [PATCH] drm/panel: simple: fix AUO g185han01 horizontal blanking

2019-07-10 Thread Lucas Stach
Hi Sam, since you've been picking up some panel patches lately, might I ask you to take a look at this patch? Regards, Lucas Am Freitag, den 14.12.2018, 14:20 +0100 schrieb Lucas Stach: > Hi Thierry, > > can you please have a look at this one? > > Regards, > Lucas > > Am Montag, den 12.11.201

Re: [PATCH 24/60] drm/panel: Add driver for the Toppology TD043MTEA1 panel

2019-07-10 Thread Sam Ravnborg
Hi Laurent. I had assumed this driver would look like the other Topology driver, but they differ a lot. So it makes sense to have different drivers. This driver implements suspend/resume. But the correct way would be to implment prepare/unprepare. The power_on(), power_off() functions would then

Re: [PATCH v1] drm/modes: Skip invalid cmdline mode

2019-07-10 Thread Dmitry Osipenko
10.07.2019 16:06, Maxime Ripard пишет: > On Wed, Jul 10, 2019 at 03:59:55PM +0300, Dmitry Osipenko wrote: >> 10.07.2019 15:55, Maxime Ripard пишет: >>> On Wed, Jul 10, 2019 at 03:42:28PM +0300, Dmitry Osipenko wrote: 10.07.2019 13:12, Maxime Ripard пишет: > On Tue, Jul 09, 2019 at 05:51:51

Re: [PATCH v1] drm/modes: Skip invalid cmdline mode

2019-07-10 Thread Dmitry Osipenko
10.07.2019 16:11, Dmitry Osipenko пишет: > 10.07.2019 16:06, Maxime Ripard пишет: >> On Wed, Jul 10, 2019 at 03:59:55PM +0300, Dmitry Osipenko wrote: >>> 10.07.2019 15:55, Maxime Ripard пишет: On Wed, Jul 10, 2019 at 03:42:28PM +0300, Dmitry Osipenko wrote: > 10.07.2019 13:12, Maxime Ripar

Re: [PATCH] drm/panel: simple: fix AUO g185han01 horizontal blanking

2019-07-10 Thread Sam Ravnborg
On Wed, Jul 10, 2019 at 03:07:40PM +0200, Lucas Stach wrote: > Hi Sam, > > since you've been picking up some panel patches lately, might I ask you > to take a look at this patch? > > Regards, > Lucas > > Am Freitag, den 14.12.2018, 14:20 +0100 schrieb Lucas Stach: > > Hi Thierry, > > > > can yo

Re: [PATCH v1] drm/modes: Skip invalid cmdline mode

2019-07-10 Thread Dmitry Osipenko
10.07.2019 16:29, Dmitry Osipenko пишет: > 10.07.2019 16:11, Dmitry Osipenko пишет: >> 10.07.2019 16:06, Maxime Ripard пишет: >>> On Wed, Jul 10, 2019 at 03:59:55PM +0300, Dmitry Osipenko wrote: 10.07.2019 15:55, Maxime Ripard пишет: > On Wed, Jul 10, 2019 at 03:42:28PM +0300, Dmitry Osipe

[PULL] drm-intel-fixes

2019-07-10 Thread Joonas Lahtinen
Hi Dave & Daniel, Some rather important fixes that appeared after -rc6 and missed v5.2. As a PR by request of Daniel. These avoid one WARN and potential dirty pointer deref, fix a regression on saturated media loads and add missing Icelake W/As. I've manually added Cc: stable to all of them. The

Re: [PATCH v2 1/2] dt-bindings: panel: Add parallel RGB mode for Ilitek ILI9341 panels

2019-07-10 Thread Sam Ravnborg
Hi Josef. On Mon, Jul 08, 2019 at 04:56:17PM +0200, Josef Lusticky wrote: > ILI9341 supports both SPI input mode and parallel RGB input mode. > This commit adds parallel RGB input mode bindings. > > Signed-off-by: Josef Lusticky > --- > .../bindings/display/ilitek,ili9341.txt | 67 +++

Re: [PATCH v2 2/2] drm/panel: Add Ilitek ILI9341 parallel RGB panel driver

2019-07-10 Thread Sam Ravnborg
Hi Josef. Thanks for updating the driver. On Mon, Jul 08, 2019 at 04:56:18PM +0200, Josef Lusticky wrote: > Add driver for Ilitek ILI9341 panels in parallel RGB mode > > Signed-off-by: Josef Lusticky > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > + >

Re: [PATCH] drm: assure aux_dev is nonzero before using it

2019-07-10 Thread Tony Camuso
On 5/24/19 4:36 AM, Jani Nikula wrote: On Thu, 23 May 2019, tcamuso wrote: From Daniel Kwon The system was crashed due to invalid memory access while trying to access auxiliary device. crash> bt PID: 9863 TASK: 89d1bdf11040 CPU: 1 COMMAND: "ipmitool" #0 [89cedd7f3868] machine

[Bug 110659] pageflipping seems to cause jittering on mouse input when running Hitman 2 in Wine/DXVK with amdgpu.dc=1

2019-07-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110659 --- Comment #26 from Michel Dänzer --- (In reply to tempel.julian from comment #25) > I also reported the bug to the wine devs (still I think this is rather a bug > of xf86-video-amdgpu): It's a kernel issue, not an xf86-video-amdgpu one. --

Re: [PATCH v2 0/2] Add DRM ILI9341 parallel RGB panel driver

2019-07-10 Thread Sam Ravnborg
Hi Josef. On Mon, Jul 08, 2019 at 04:56:16PM +0200, Josef Lusticky wrote: > Hi, > This is the v2 of the patch-set which adds support for > Ilitek ILI9341 parallel RGB panels. > > The ILI9341 chip supports both parallel RGB input mode and SPI input mode. > This driver adds support for the parallel

Re: [PATCH] drm: assure aux_dev is nonzero before using it

2019-07-10 Thread Ville Syrjälä
On Wed, Jul 10, 2019 at 09:47:11AM -0400, Tony Camuso wrote: > On 5/24/19 4:36 AM, Jani Nikula wrote: > > On Thu, 23 May 2019, tcamuso wrote: > >> From Daniel Kwon > >> > >> The system was crashed due to invalid memory access while trying to access > >> auxiliary device. > >> > >> crash> bt > >>

Re: [PATCH v1] drm/modes: Skip invalid cmdline mode

2019-07-10 Thread Dmitry Osipenko
10.07.2019 13:00, Ville Syrjälä пишет: > On Tue, Jul 09, 2019 at 05:51:51PM +0300, Dmitry Osipenko wrote: >> The named mode could be invalid and then cmdline parser misses to validate >> mode's dimensions, happily adding 0x0 mode as a valid mode. One case where >> this happens is NVIDIA Tegra devic

Re: [PATCH v1] drm/modes: Skip invalid cmdline mode

2019-07-10 Thread Maxime Ripard
On Wed, Jul 10, 2019 at 04:29:19PM +0300, Dmitry Osipenko wrote: > This works: > > diff --git a/drivers/gpu/drm/drm_client_modeset.c > b/drivers/gpu/drm/drm_client_modeset.c > index 56d36779d213..e5a2f9c8f404 100644 > --- a/drivers/gpu/drm/drm_client_modeset.c > +++ b/drivers/gpu/drm/drm_client_mo

  1   2   >