On Fri, Jul 19, 2013 at 03:37:26PM -0600, Bjorn Helgaas wrote:
> On Tue, Jul 16, 2013 at 9:14 AM, Ian Abbott wrote:
> > The 8250_pci driver uses PCI_VENDOR_ID_ADDIDATA_OLD (0x10e8),
> > PCI_DEVICE_ID_ADDIDATA_APCI7800 (0x818e) to recognize the original
> > ADDI-DATA APCI-7800 PCI serial card. How
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/xillybus.h |2 --
drivers/staging/xillybus/xillybus_core.c |2 ++
drivers/staging/xillybus/xillybus_of.c |2 ++
drivers/staging/xillybus/xillybus_pcie.c |2 ++
4 files changed, 6 insertions(+), 2 deletions(-)
diff -
On Friday, July 26, 2013 3:08 PM, Greg Kroah-Hartman wrote:
>> Signed-off-by: H Hartley Sweeten
>> Cc: Ian Abbott
>> Signed-off-by: Greg Kroah-Hartman
>> ---
>> drivers/staging/comedi/drivers/usbdux.c | 49
>> +++--
>> 1 file changed, 22 insertions(+), 27 deletions(
On Thu, Jul 25, 2013 at 04:10:07PM -0700, H Hartley Sweeten wrote:
> This buffer is used to cache the values that are written to the
> analog output channels. Currently it only caches the single writes
> to the channels using the (*insn_write) callback. The async command
> writes are not cached. Th
On Fri, Jul 26, 2013 at 10:32:33AM +0300, Dan Carpenter wrote:
> On Fri, Jul 26, 2013 at 10:15:55AM +0800, Wei Yongjun wrote:
> > From: Wei Yongjun
> >
> > A spin lock is taken here so we should use GFP_ATOMIC.
> >
>
> Acked-by: Dan Carpenter
>
> But the locking here is really odd and pointle
On Sat, Jul 27, 2013 at 12:24:00AM +0300, Eli Billauer wrote:
>
> Signed-off-by: Eli Billauer
You forgot a "Reported-by:" line here, I'll go add it by hand, but
please do so yourself next time.
thanks,
greg k-h
___
devel mailing list
de...@linuxdrive
On Fri, 2013-07-26 at 20:59 +0800, Lilis Iskandar wrote:
> Fixed spacing/tabing issues.
two b's in tabbing.
First send the emails to yourself and make sure
they apply with git am
Remember mentioning git diff -w.
You also might try to use
$ ./scripts/checkpatch.pl -f --fix --test-only=space dri
On Fri, Jul 26, 2013 at 08:59:33PM +0800, Lilis Iskandar wrote:
> Fixed spacing/tabing issues.
>
> Signed-off-by: Lilis Iskandar
> ---
> drivers/staging/bcm/InterfaceIdleMode.c | 38
> -
> 1 file changed, 19 insertions(+), 19 deletions(-)
All of your patches are
On Friday, July 26, 2013 10:59 AM, Shaun Laing wrote:
Please make sure to copy the mailing list... ;-)
> I'm sorry Hartley,
>
> I'm really new at this so there's probably something I'm doing wrong.
> Do you have time to help me figure this out? Here's how I'm building
> this module:
>
> shaun@ri
On Friday, July 26, 2013 7:26 AM, Shaun Laing wrote:
>
> Resolves warnings from the "sparse" checker of the form "warning: cast to
> restricted __le??".
Hmm.. I don't see this sparse warning.. All I see for this file is:
CHECK drivers/staging/comedi/drivers/dt9812.c
CC [M] drivers/staging/
The following changes since commit 3b2f64d00c46e1e4e9bd0bb9bb12619adac27a4b:
Linux 3.11-rc2 (2013-07-21 12:05:29 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-3.11-rc3
for you to fetch changes up to 81b884c9dfe
Resolves warnings from the "sparse" checker of the form "warning: cast to
restricted __le??".
Signed-off-by: Shaun Laing
---
diff --git a/drivers/staging/comedi/drivers/dt9812.c
b/drivers/staging/comedi/drivers/dt9812.c
index 6c60949..fdd008c 100644
--- a/drivers/staging/comedi/drivers/dt9812.c
Fixed a pointer asterisk placement issue.
Signed-off-by: Lilis Iskandar
---
drivers/staging/bcm/LeakyBucket.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/bcm/LeakyBucket.c
b/drivers/staging/bcm/LeakyBucket.c
index fb18ae0..bc48616 100644
--- a/drivers/sta
Fixed code indent issues.
Signed-off-by: Lilis Iskandar
---
drivers/staging/bcm/LeakyBucket.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/bcm/LeakyBucket.c
b/drivers/staging/bcm/LeakyBucket.c
index 75d77c2e..fb18ae0 100644
--- a/drivers/staging/bcm/
Fixed C99 comments
Signed-off-by: Lilis Iskandar
---
drivers/staging/bcm/LeakyBucket.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/bcm/LeakyBucket.c
b/drivers/staging/bcm/LeakyBucket.c
index 52e6e05..75d77c2e 100644
--- a/drivers/staging/b
Fixed brace issues
Signed-off-by: Lilis Iskandar
---
drivers/staging/bcm/LeakyBucket.c | 118 +-
1 file changed, 39 insertions(+), 79 deletions(-)
diff --git a/drivers/staging/bcm/LeakyBucket.c
b/drivers/staging/bcm/LeakyBucket.c
index ee1d9f6..52e6e05 10064
Fixed spacing/tabing issues
Signed-off-by: Lilis Iskandar
---
drivers/staging/bcm/LeakyBucket.c | 170 +++---
1 file changed, 85 insertions(+), 85 deletions(-)
diff --git a/drivers/staging/bcm/LeakyBucket.c
b/drivers/staging/bcm/LeakyBucket.c
index 877cf0b..ee1d
Fixed brace issues
Signed-off-by: Lilis Iskandar
---
drivers/staging/bcm/InterfaceIdleMode.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceIdleMode.c
b/drivers/staging/bcm/InterfaceIdleMode.c
index 0c93048..4f88dd8 100644
--- a/drivers/sta
Fixed spacing/tabing issues.
Signed-off-by: Lilis Iskandar
---
drivers/staging/bcm/InterfaceIdleMode.c | 38
-
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceIdleMode.c
b/drivers/staging/bcm/InterfaceIdleMode.c
index 5
On 2013-07-25 17:33, H Hartley Sweeten wrote:
On Thursday, July 25, 2013 5:34 AM, Ian Abbott wrote:
On 2013-07-24 19:45, H Hartley Sweeten wrote:
Legacy (ISA) interrupts are not sharable so this driver should not
be passing the IRQF_SHARED flag when requesting the interrupts.
This driver suppo
On 2013-07-25 17:47, H Hartley Sweeten wrote:
On Thursday, July 25, 2013 6:39 AM, Ian Abbott wrote:
On 2013-07-24 19:48, H Hartley Sweeten wrote:
When updating the output channels make sure the channels configured as
inputs stay inputs.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Gre
On 2013-07-25 17:37, H Hartley Sweeten wrote:
On Thursday, July 25, 2013 5:50 AM, Ian Abbott wrote:
On 2013-07-24 19:47, H Hartley Sweeten wrote:
The comedi_subdevice pointer is not used in this function. Its simply
passed on to pcmuio_handle_intr_subdev(). That function then needs to
calculate
On 2013-07-25 18:00, H Hartley Sweeten wrote:
On Thursday, July 25, 2013 7:18 AM, Ian Abbott wrote:
On 2013-07-24 20:14, H Hartley Sweeten wrote:
Make the built-on dio subdevice 0 and the three add-on modules
subdevices 1-3. This allows the driver to consistently use the
ii20k_module_iobase() h
The COMEDI_NI_ATMIO16D configuration option causes the "ni_atmio16d"
module to be built, which handles the National Instruments AT-MIO-16 and
AT-MIO-16D cards. The configuration option currently depends on ISAPNP,
but the module doesn't use any ISAPNP functions and the cards are legacy
ISA cards w
The COMEDI_NI_ATMIO configuration option causes the "ni_atmio" module to
be built, which handles various National Instruments ISA-PNP data
acquisition cards. The configuration option currently depends on
ISAPNP.
The "ni_atmio" module is a "legacy" comedi driver with no
auto-configuration support
On Thu, Jul 25, 2013 at 04:21:13PM -0700, H Hartley Sweeten wrote:
> As pointed out by Ian Abbott, the *_cmd_running flags should be set
> before submitting the urbs. There is a possible race condition where
> an urb could complete and the flag is checked in the completion
> routine before it's set
On 2013-07-26 00:32, H Hartley Sweeten wrote:
On Thursday, July 25, 2013 3:43 AM, Ian Abbott wrote:
On 2013-07-24 19:24, H Hartley Sweeten wrote:
Embedded systems with a PC/104 bus might have a configuration that
does not have ISA enabled. This creates a problem in Comedi where
the PC/104 drive
On 2013-07-26 00:21, H Hartley Sweeten wrote:
As pointed out by Ian Abbott, the *_cmd_running flags should be set
before submitting the urbs. There is a possible race condition where
an urb could complete and the flag is checked in the completion
routine before it's set.
Signed-off-by: H Hartley
On 2013-07-26 00:02, H Hartley Sweeten wrote:
Patches 1-32 of [PATCH 00/53] staging: comedi: usbdux: cleanup driver
have already be applied to Greg Kroah-Hartman's staging tree. This
continues the cleanup of the usbdux comedi driver from that point.
Patches 1, 2, 7, 9, and 15 have been updated t
On Fri, Jul 26, 2013 at 10:15:55AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun
>
> A spin lock is taken here so we should use GFP_ATOMIC.
>
Acked-by: Dan Carpenter
But the locking here is really odd and pointless. usb_submit_urb()
returns asynchronously before the data has been sent, so th
30 matches
Mail list logo
