> Understood, however, unlike SoftRoCE, qib and hfi currently share a lot of
> code
> to drive the hardware.
>
> The underlying reason for the TODO item "Remove software processing of IB
> protocol..." is because we have a large amount of duplicated code between
> these
> drivers. _Some_ of whic
On Wed, Oct 21, 2015 at 08:41:52AM +0530, Ronit Halder wrote:
> Removing init and exit functions as they do nothing.
Really? Did you test this?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo
Removing init and exit functions as they do nothing.
Signed-off-by: Ronit Halder
---
drivers/staging/comedi/comedi_usb.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/comedi/comedi_usb.c
b/drivers/staging/comedi/comedi_usb.c
index 9c946d4..ed13bf6 100644
--- a/d
The driver interfaces are in linux_wlan_sdio.c and linux_wlan_spi.c, so
this is where the init and exit functions should be. Splitting this up
enables further cleanups, including eventually allowing both modules
to be built together.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linu
The two instances of struct wilc1000_ops reference functions that
are defined in just one file each. By moving the operations there,
we can mark all those functions as 'static' and avoid a number
of #ifdefs.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c | 43 ---
wilc_create_wiphy tries to get a pointer to a device from the
global wilc1000_sdio_func variable. This is a layering violation
and we can use the wilc1000_dev->dev pointer instead.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c | 2 +-
drivers/staging/wilc1000
The COMPLEMENT_BOOT code is used only for SDIO and is aware of
details of the SDIO implementation that don't belong into
the common linux_wlan.c file.
This moves the functions to linux_wlan_sdio.c to get them out of
the way.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c
The last remaining user of WILC_SDIO macro checks for the correct
time to wait in an interrupt for the PLL to settle. We can
replace this with a runtime check and remove both WILC_SDIO and
WILC_SPI, as we no longer need conditional compilation based on
the hardware type.
Signed-off-by: Arnd Bergma
All symbols that are only referenced in the file that defines
them can be declared 'static' to avoid namespace pollution,
to produce better object code, and to make the source more
readable.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/Makefile | 3 +-
drivers/stagi
The SPI and SDIO specific code is now separate enough that
we just need to restructure the Makefile and Kconfig logic
a bit and export a couple of symbols from the common module
to have separate bus glue drivers.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/Kconfig | 66 ++
The wilc1000_hif_spi and wilc1000_hif_sdio structures are part of
the bus specific code, and the generic code should have no knowledge
of their addresses.
This changes the code to reference them only from the bus
specific initialization code, which we can then use to split
up the driver into separ
So far, my patches tried to do equivalent conversions of the
existing code. This one goes beyond that by restructuring
how the devices get probed. In particular, the spi driver
no longer creates the netdev until the device is probed,
and I've removed the global wilc1000_sdio_func and wilc_spi_dev
'extern' declarations belong into a header file rather than
a .c file, to ensure that the definition matches the declaration.
This moves all declarations into a header file that seems
most appropriate for it.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/host_interface.c | 1
Whether the SDIO function uses an internal or external interrupt
should not be a compiletime decision but be determined at runtime.
This changes the code to pass a GPIO number from the init code
as early as possible, and leaves just one #ifdef WILC_SDIO_IRQ_GPIO
to preserve the previous behavior.
wilc_wlan_inp_t is an unnecessary indirection and requires linux_wlan.c
to have knowledge of the specific sdio and spi front-ends. This
removes the structure and places the members with a constant
'struct wilc1000_ops' pointer inside of 'struct wilc'.
Signed-off-by: Arnd Bergmann
---
drivers/sta
The driver provides an interface for custom power management
and detection that is meant to be filled by people customizing
the driver. The default implementation of this is empty, and
we don't actually want people to have to modify the source code.
If anybody needs this, they need to describe the
A number of symbols in the wilc1000 driver are completely unused
and can be removed.
This includes two variables that are only written but not read.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/host_interface.c | 311 --
drivers/staging/wilc1000/host_inte
As a preparation for turning the SDIO side of wilc1000 into a separate
module, this removes the last direct caller from the core module into
the sdio specific portion. All calls to wilc1000_sdio_enable_interrupt()
and wilc1000_sdio_disable_interrupt() now go through a function pointer
in wilc1000_o
struct wilc has two pointers to store the device, one for sdio_func
and one for spi_device. By changing the pointer to a 'struct device',
we can simplify the logic and avoid a few #ifdefs.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c | 29 +--
After I screwed up two or three times trying to get the dependencies
with the SPI and SDIO backends right, I ended up taking the time
to do the real fix and make both coexist.
This is a series of patches that address various issues with the
driver, but is mainly targetted at splitting out the spi
The wilc_wfi_cfgoperations.h header defines the ieee80211_txrx_stypes
and cipher_suites variables that are only used in wilc_wfi_cfgoperations.c
and should not be shared in a header file.
This moves over all that data into the .c file, and also moves all
the macro definitions from the file that ar
The linux_wlan.c file uses a set of enums from wilc_wlan_if.h,
with the exception of the NO_ENCRYPT that comes from
wilc_wfi_cfgoperations.h. The two sets of enums clearly have
the same intention but are defined a bit different.
To prepare to clean up the ones in wilc_wfi_cfgoperations.h, this
fir
On Monday 19 October 2015 11:53:40 Arnd Bergmann wrote:
> On Monday 19 October 2015 11:39:31 Arnd Bergmann wrote:
> > On Monday 19 October 2015 16:54:23 Tony Cho wrote:
> > > Hi Arnd Bergmann,
> > >
> > > When I apply this patch, I cannot make WILC1000 module (wilc1000.ko)
> > > because CONFIG_WI
The Backup integration service on WS2012 has appearently trouble to
negotiate with a guest which does not support the provided util version.
Currently the VSS driver supports only version 5/0. A WS2012 offers only
version 1/x and 3/x, and vmbus_prep_negotiate_resp correctly returns an
empty icframe
On Tue, Oct 13 2015 at 11:14:23 AM, Andrew wrote:
> On 2015-10-12 21:39, Mitchel Humpherys wrote:
>> On Tue, Oct 06 2015 at 05:35:41 PM, Rob Herring
>> wrote:
>>> On Tue, Oct 6, 2015 at 3:47 PM, Laura Abbott
>>> wrote:
>>
>> [...]
>>
+Example:
+
+ ion {
+
On Tue, Oct 20, 2015 at 03:45:47PM +0300, Moni Shoua wrote:
> >
> > Perhaps I did not chose my words carefully enough.
> >
> > The largest issue on the TODO list is the refactoring of the code to be
> > shared between the hfi1 and qib driver. While the hardware between hfi1
> > and qib is similar
This patch fixes a possible overflow in module hdm-dim2.
Signed-off-by: Christian Gromm
---
drivers/staging/most/hdm-dim2/dim2_hdm.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/most/hdm-dim2/dim2_hdm.c
b/drivers/staging/most/hdm-dim2/dim2_hdm.c
>
> Perhaps I did not chose my words carefully enough.
>
> The largest issue on the TODO list is the refactoring of the code to be
> shared between the hfi1 and qib driver. While the hardware between hfi1 and
> qib is similar and thus the initial code looked similar, our performance
> tuning on
The OBD_SLAB_ALLOC* and OBD_SLAB_FREE* macros are not used and can be
removed.
Signed-off-by: Mike Rapoport
---
.../staging/lustre/lustre/include/obd_support.h| 34 --
1 file changed, 34 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/obd_support.h
b/dri
Use kmem_cache_free directly instead of wrapping macro.
Signed-off-by: Mike Rapoport
---
drivers/staging/lustre/lustre/ldlm/ldlm_extent.c | 2 +-
drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 2 +-
drivers/staging/lustre/lustre/ldlm/ldlm_resource.c | 6 +++---
drivers/staging/lustre/lus
Use kmem_cache_free directly instead of wrapping macro.
Signed-off-by: Mike Rapoport
---
drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 10 +-
drivers/staging/lustre/lustre/llite/file.c | 2 +-
drivers/staging/lustre/lustre/llite/super25.c | 2 +-
drivers/staging/
The OBD_SLAB_ALLOC_PTR macro expands to call to kmem_cache_alloc,
which may be used directly.
Signed-off-by: Mike Rapoport
---
drivers/staging/lustre/lustre/osc/osc_quota.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/osc/osc_quota.c
b/driver
Use kmem_cache_free directly instead of wrapping macro.
Signed-off-by: Mike Rapoport
---
drivers/staging/lustre/lustre/llite/remote_perm.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/remote_perm.c
b/drivers/staging/lustre/lustre/lli
The OBD_SLAB_ALLOC_PTR_GFP macro expands to call to kmem_cache_alloc,
which may be used directly.
Signed-off-by: Mike Rapoport
---
drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 10 +-
drivers/staging/lustre/lustre/ldlm/ldlm_extent.c| 2 +-
drivers/staging/lustre/lustre/ldlm/
These patches replace OBD_SLAB_ALLOC/FREE and friends with direct use of
kmem_cache_alloc/free.
Mike Rapoport (10):
staging: lustre: remove unused OBD_SLAB_CPT_ALLOC* macros
staging: lustre: replace OBDO_ALLOC with kmem_cache_alloc
staging: lustre: replace OBDO_FREE with kmem_cache_free
st
Use direct call to kmem_cache_alloc instead of wrapping macro
Signed-off-by: Mike Rapoport
---
drivers/staging/lustre/lustre/llite/file.c| 2 +-
drivers/staging/lustre/lustre/llite/llite_close.c | 2 +-
drivers/staging/lustre/lustre/llite/llite_lib.c | 3 ++-
drivers/staging/lustre/
The OBDO_ALLOC and OBDO_FREE macros are not used and can be removed.
Signed-off-by: Mike Rapoport
---
drivers/staging/lustre/lustre/include/obd_class.h | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/obd_class.h
b/drivers/staging/lustre/lustr
Use kmem_cache_free directly instead of wrapping macro.
Signed-off-by: Mike Rapoport
---
drivers/staging/lustre/lustre/llite/file.c| 2 +-
drivers/staging/lustre/lustre/llite/llite_close.c | 2 +-
drivers/staging/lustre/lustre/llite/llite_lib.c | 2 +-
drivers/staging/lustre/lustre/lli
The OBD_SLAB_CPT_ALLOC* macros are not used and can be removed
Signed-off-by: Mike Rapoport
---
drivers/staging/lustre/lustre/include/obd_support.h | 11 ---
1 file changed, 11 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/obd_support.h
b/drivers/staging/lustre/lustre
On 19/10/15 21:12, H Hartley Sweeten wrote:
Clean up the analog input async command support code and the interrupt
handler.
H Hartley Sweeten (10):
staging: comedi: adl_pci9118: TRIG_INT is not vaild for scan_begin_src
staging: comedi: adl_pci9118: remove unnecessary check in
check_channe
From: Glen Lee
Use netdev private data member wilc instead of global variable g_linux_wlan.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/w
From: Glen Lee
This patch changes function argument type wilc with net_device and use
netdev private data member wilc instead of p_nic.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/linux_wlan.c | 18 +++---
1 file changed, 11 insertions(+), 7 deleti
From: Glen Lee
Use netdev private data member wilc instead of global variable g_linux_wlan.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc100
From: Glen Lee
This patch changes function argument wilc with net_device and use nic->wilc
instead of global variable g_linux_wlan. The null check codes should be placed
before it is used so move it.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/linux_wlan.c
From: Glen Lee
Use netdev private data member wilc instead of global variable g_linux_wlan.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc100
From: Glen Lee
Use netdev private data member wilc instead of global variable g_linux_wlan.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/w
From: Glen Lee
Use netdev private data member wilc instead of global variable g_linux_wlan.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wilc1000
From: Glen Lee
This patch add wilc to struct perInterface_wlan_t which is netdev private
data to access wilc via netdev_priv function. Assign wilc to nic->wilc.
The global variable g_linux_wlan will be replaced with netdev private data
member wilc step by step.
Signed-off-by: Glen Lee
Signed-of
From: Glen Lee
This patch changes function parameter type wilc with net_device and use netdev
private data member wilc instead of global variable g_linux_wlan.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/linux_wlan.c | 25 +++--
1 file chan
From: Glen Lee
Use netdev private data member wilc instead of global variable g_linux_wlan.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/linux_wlan.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/wilc1000/l
From: Glen Lee
Use netdev private data member wilc instead of global variable g_linux_wlan.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/linux_wlan.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/wilc1
From: Glen Lee
This patch use netdev private data member wilc instead of global variable
g_linux_wlan.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/linux_wlan.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/driv
From: Glen Lee
Use netdev private data member wilc instead of global variable g_linux_wlan.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 85 ---
1 file changed, 45 insertions(+), 40 deletions(-)
diff --git a/drive
This patch reverts the commit, d79fd35b8c5d927695b48fa35aa586919818cce9.
The WID_JOIN_REQ_EXTENDED among WIDs needs two parameters for the request to
be sent to the firmware, which are the SA and the BSSID. For this case, both
is the same bssid in the handle_connect function. So, it's required to
54 matches
Mail list logo