[PATCH] staging: vme/devices: vme_user.c: fix: converted decimal permissions to octal

2016-09-11 Thread Ryan Swan
From: ryan Ran checkpatch.pl -f vme_user.c Fixed: ERROR: Use 4 digit octal (0777) not decimal permissions Signed-off-by: Ryan Swan --- drivers/staging/vme/devices/vme_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] staging: vme/devices: vme_user.c: fix: converted decimal permissions to octal

2016-09-11 Thread Greg KH
On Sun, Sep 11, 2016 at 12:21:09PM -0400, Ryan Swan wrote: > From: ryan This needs to match your From: email line. > > Ran checkpatch.pl -f vme_user.c > Fixed: ERROR: Use 4 digit octal (0777) not decimal permissions No signed-off-by?

Re: [PATCH 00/26] constify local structures

2016-09-11 Thread Julia Lawall
On Sun, 11 Sep 2016, Joe Perches wrote: > On Sun, 2016-09-11 at 15:05 +0200, Julia Lawall wrote: > > Constify local structures. > > Thanks Julia. > > A few suggestions & questions: > > Perhaps the script should go into scripts/coccinelle/ > so that future cases could be caught by the robot > and

Re: [PATCH 00/26] constify local structures

2016-09-11 Thread Joe Perches
On Sun, 2016-09-11 at 15:05 +0200, Julia Lawall wrote: > Constify local structures. Thanks Julia. A few suggestions & questions: Perhaps the script should go into scripts/coccinelle/ so that future cases could be caught by the robot and commit message referenced by the patch instances. Can you

RE: [PATCH 3/3] drivers: Add visorbus to the drivers/virt directory

2016-09-11 Thread Sell, Timothy C
On Sun, 11 Sep 2016 02:17:10 -0700, Greg KH wrote: > On Tue, Aug 30, 2016 at 04:29:07PM +, Sell, Timothy C wrote: >> E.g., so even though no obvious error-recovery occurs above in-response to >> kzalloc() failures, the fact that -CONTROLVM_RESP_ERROR_KMALLOC_FAILED is >> provided to

Re: [PATCH 00/26] constify local structures

2016-09-11 Thread Jarkko Sakkinen
On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: > Constify local structures. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) Just my two cents but: 1. You *can* use a static analysis too to find bugs or other issues. 2. However, you

[PATCH] staging: gdm724x: gdm_lte: Constify gdm_netdev_ops

2016-09-11 Thread Imre Deak
Fix the following checkpatch.pl warning: WARNING: struct net_device_ops should normally be const +static struct net_device_ops gdm_netdev_ops = { Signed-off-by: Imre Deak --- drivers/staging/gdm724x/gdm_lte.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] staging: vme/devices: vme_user.c: fix: converted decimal permissions to octal

2016-09-11 Thread Ryan Swan
From: ryan Ran checkpatch.pl -f vme_user.c Fixed: ERROR: Use 4 digit octal (0777) not decimal permissions --- drivers/staging/vme/devices/vme_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c

[PATCH 03/26] staging: rtl8192e: constify local structures

2016-09-11 Thread Julia Lawall
For structure types defined in the same file or local header files, find top-level static structure declarations that have the following properties: 1. Never reassigned. 2. Address never taken 3. Not passed to a top-level macro call 4. No pointer or array-typed field passed to a function or stored

[PATCH 00/26] constify local structures

2016-09-11 Thread Julia Lawall
Constify local structures. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // // The first rule ignores some cases that posed problems @r disable optional_qualifier@ identifier s != {peri_clk_data,threshold_attr,tracer_flags,tracer}; identifier i !=

[PATCH] stagging:iio:ad9834: add devicetree property support

2016-09-11 Thread Gwenhael Goavec-Merou
ad9834 driver needs some default properties. Currently these parameters are provided through platform_data. This patch adds a function to create this pdata based on device-tree node. Signed-off-by: Gwenhael Goavec-Merou ---

Re: [PATCH 3/3] drivers: Add visorbus to the drivers/virt directory

2016-09-11 Thread 'Greg KH'
On Tue, Aug 30, 2016 at 04:29:07PM +, Sell, Timothy C wrote: > E.g., so even though no obvious error-recovery occurs above in-response to > kzalloc() failures, the fact that -CONTROLVM_RESP_ERROR_KMALLOC_FAILED is > provided to bus_epilog() is in-fact sufficient to report the error. > > Is

[GIT PULL] Staging/IIO driver fixes for 4.8-rc6

2016-09-11 Thread Greg KH
The following changes since commit c6935931c1894ff857616ff8549b61236a19148f: Linux 4.8-rc5 (2016-09-04 14:31:46 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-4.8-rc6 for you to fetch changes up to

[PATCH] Fix checkpatch.pl error in drivers:staging:ks7010:ks_wlan_net.c

2016-09-11 Thread Chinmay Nivsarkar
Fixes error foo * bar should be foo *bar in line #843 Signed-off-by: Chinmay Nivsarkar --- drivers/staging/ks7010/ks_wlan_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c

Re: [PATCH] Fix checkpatch.pl error in drivers:staging:ks7010:ks_wlan_net.cGreg Kroah-Hartman <gre...@linuxfoundation.org>

2016-09-11 Thread Greg KH
On Sun, Sep 11, 2016 at 01:39:13AM +0530, Chinmay Nivsarkar wrote: > Fixes error foo * bar should be foo *bar in line #843 > > Signed-off-by: Chinmay Nivsarkar > --- > drivers/staging/ks7010/ks_wlan_net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Your