Re: [PATCH] staging: wilc1000: use kernel define byte order macros

I don't think buff is an ieee80211_hdr struct. I think it's the rx_buffer allocated at wilc_wlan.c:1417. Regards, Perry On Wed, 2017-03-22 at 12:24 +0300, Dan Carpenter wrote: > On Tue, Mar 21, 2017 at 03:40:10PM -0600, Robert Perry Hooker wrote: > > Thanks for taking a look, Dan. Sorry if I

RE: [PATCH 1/2 v4] pci-hyperv: properly handle pci bus remove

> -Original Message- > From: Bjorn Helgaas [mailto:helg...@kernel.org] > Sent: Thursday, March 16, 2017 1:07 PM > To: Long Li > Cc: KY Srinivasan ; Haiyang Zhang > ; Bjorn Helgaas ; >

Re: [Outreachy kernel] [PATCH v2] staging: iio: Replace a bit shift by a use of BIT.

On Wed, 22 Mar 2017, Arushi Singhal wrote: > This patch replaces bit shifting on 1 with the BIT(x) macro. > This was done with coccinelle: > @@ > constant c; > @@ > > -1 << c > +BIT(c) > > Signed-off-by: Arushi Singhal > --- > changes in v2 > -remove/correct

Re: [RESEND PATCH 00/11] staging:speakup: Multiple Checkpatch issues.

On Wed, Mar 22, 2017 at 12:20:23PM -0700, Arushi Singhal wrote: > On Tuesday, March 21, 2017 at 5:12:41 PM UTC+5:30, Arushi Singhal wrote: > > Improve readability by fixing multiple checkpatch.pl > issues in speakup driver. > > Arushi Singhal (11): >   staging: speakup: Moved

Re: [PATCH] staging: iio: adc: Replace mlock with driver private lock

On 20/03/17 14:12, Arushi Singhal wrote: > The IIO subsystem is redefining iio_dev->mlock to be used by > the IIO core only for protecting device operating mode changes. > ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes. > > In this driver, mlock was being used to protect hardware

Re: [PATCH] staging: ad7759: Replace mlock with driver private lock

On 20/03/17 16:09, Arushi Singhal wrote: > The IIO subsystem is redefining iio_dev->mlock to be used by > the IIO core only for protecting device operating mode changes. > ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes. > > In this driver, mlock was being used to protect hardware

Re: [PATCH v3] staging: ad7606: Replace mlock with driver private lock

On 20/03/17 19:51, Arushi Singhal wrote: > The IIO subsystem is redefining iio_dev->mlock to be used by > the IIO core only for protecting device operating mode changes. > ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes. > > In this driver, mlock was being used to protect hardware

Re: [PATCH v3 2/2] staging: iio: ade7753: Replace mlock with driver private lock

On 21/03/17 18:03, simran singhal wrote: > The IIO subsystem is redefining iio_dev->mlock to be used by > the IIO core only for protecting device operating mode changes. > ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes. > > In this driver, mlock was being used to protect hardware

Re: [PATCH v3 1/2] staging: iio: ade7753: Remove trailing whitespaces

On 21/03/17 18:03, simran singhal wrote: > This patch removes trailing whitespaces in order to follow the Linux > coding style. > > Signed-off-by: simran singhal Applied and pushed out as testing... Jonathan > --- > drivers/staging/iio/meter/ade7753.c | 8 >

Re: [PATCH 2/2] staging: ade7754: Clean up #includes

On 20/03/17 15:15, simran singhal wrote: > Alphabetize and separate kernel and subsystem headers. > > Signed-off-by: simran singhal Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- >

Re: [PATCH 1/2] staging: ade7754: Move header content to implementation file

On 20/03/17 15:15, simran singhal wrote: > The contents of ade7754.h are only used in ade7754.c. > Move the header contents to the implementation file, > and delete the header file. > > Signed-off-by: simran singhal Unfortunately already done by sayli karnik back on the

Re: [PATCH v7] staging: adis16060_core: Replace mlock with buf_lock and refactor code

On 22/03/17 20:00, kbuild test robot wrote: > Hi simran, > > [auto build test WARNING on iio/togreg] > [also build test WARNING on v4.11-rc3 next-20170322] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url:

Re: [PATCH v7] staging: adis16060_core: Replace mlock with buf_lock and refactor code

Hi simran, [auto build test WARNING on iio/togreg] [also build test WARNING on v4.11-rc3 next-20170322] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/simran-singhal/staging-adis16060_core

Re: [PATCH v2] staging: iio: Replace a bit shift by a use of BIT.

On 22/03/17 16:42, Arushi Singhal wrote: > This patch replaces bit shifting on 1 with the BIT(x) macro. > This was done with coccinelle: > @@ > constant c; > @@ > > -1 << c > +BIT(c) > > Signed-off-by: Arushi Singhal Applied to the togreg branch of iio.git and

Re: [PATCH v8] staging: adis16060: Remove iio_dev mlock and refactor code

On 22/03/17 16:20, simran singhal wrote: > The IIO subsystem is redefining iio_dev->mlock to be used by > the IIO core only for protecting device operating mode changes. > ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes. > > In this driver, mlock was being used to protect hardware

[PATCH v2] HV: properly delay KVP packets when negotiation is in progress

The host may send multiple negotiation packets (due to timeout) before the KVP user-mode daemon is connected. We need to defer processing those packets until the daemon is negotiated and connected. It's okay for guest to respond to all negotiation packets. In addition, the host may send

Re: [PATCH v5 00/39] i.MX Media Driver

Le mardi 21 mars 2017 à 11:36 +, Russell King - ARM Linux a écrit : >     warn: v4l2-test-formats.cpp(1187): S_PARM is > supported for buftype 2, but not ENUM_FRAMEINTERVALS >     warn: v4l2-test-formats.cpp(1194): S_PARM is > supported but doesn't report

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

Hi Michael, Em Mon, 20 Mar 2017 08:40:11 -0700 Michael Zoran escreveu: > > > Are you using Eric Anholt's HDMI Audio driver that's included in > > > VC4?  > > > That could well be incompatible with the firmware driver. Or are > > > you > > > using a half mode of VC4 for

[PATCH v2] staging: fbtft: Replace a bit shift by a use of BIT.

This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal --- changes in v2 -improve the code. drivers/staging/fbtft/fb_agm1264k-fl.c | 2 +-

[PATCH v2] staging: iio: Replace a bit shift by a use of BIT.

This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal --- changes in v2 -remove/correct the wrong code. drivers/staging/iio/cdc/ad7150.c | 2 +-

Re: [PATCH] staging: fbtft: Replace a bit shift by a use of BIT.

On Wed, Mar 22, 2017 at 6:18 PM, Andy Shevchenko wrote: > On Wed, Mar 22, 2017 at 4:37 AM, Arushi Singhal > wrote: >> This patch replaces bit shifting on 1 with the BIT(x) macro. >> This was done with coccinelle: >> @@ >> constant c; >>

[PATCH v8] staging: adis16060: Remove iio_dev mlock and refactor code

The IIO subsystem is redefining iio_dev->mlock to be used by the IIO core only for protecting device operating mode changes. ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes. In this driver, mlock was being used to protect hardware state changes. In the driver, buf_lock protects both

Re: [PATCH] staging: fbtft: Replace a bit shift by a use of BIT.

On Wed, Mar 22, 2017 at 4:37 AM, Arushi Singhal wrote: > This patch replaces bit shifting on 1 with the BIT(x) macro. > This was done with coccinelle: > @@ > constant c; > @@ > > -1 << c > +BIT(c) > While using BIT() macro is a good idea, you make it inconsistent

[PATCH] staging: vt6656: removed coding style errors

The patch replaces spaces with tabs as required by kernel coding standards. Signed-off-by: Prasant Jalan --- drivers/staging/vt6656/rxtx.c | 40 ++-- 1 file changed, 22 insertions(+), 18 deletions(-) diff --git

[PATCH v2] staging: lustre: Replace a bit shift by a use of BIT.

This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal --- changes in v2 - remove the unnecessary parenthesis. - removethe wrong changes.

Re: [PATCH 1/1] board: Fixed compilation of board.c

On Wed, Mar 22, 2017 at 03:03:20PM +0100, Artur Lorincz wrote: > Implementing the find_by_address(...) function differently based on > the CONFIG_OF switch. The function of_find_all_nodes() invoked in the > function body is only available in case the CONFIG_OF switch is set. > > For the other

Re: [Outreachy kernel] [PATCH v2] staging: rts5208: Replace a bit shift by a use of BIT.

On Wed, 22 Mar 2017, Arushi Singhal wrote: > This patch replaces bit shifting on 1 with the BIT(x) macro. > This was done with coccinelle: > @@ > constant c; > @@ > > -1 << c > +BIT(c) > > Signed-off-by: Arushi Singhal Acked-by: Julia Lawall

[PATCH v2] staging: rts5208: Replace a bit shift by a use of BIT.

This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal --- changes in v2 - remove the unnecessary parenthesis. drivers/staging/rts5208/rtsx_chip.c | 4 ++-- 1

Re: [PATCH 1/1] board: Fixed compilation of board.c

On Wed, Mar 22, 2017 at 02:00:31PM +0100, Artur Lorincz wrote: > Made the compilation of board.c depend on the CONFIG_OF flag. The > source file board.c is referencing of_find_all_nodes(...) which is > included only if the CONFIG_OF flag is set. > > Signed-off-by: Artur Lorincz

Re: [PATCH] staging: lustre: Replace a bit shift by a use of BIT.

On Mar 21, 2017, at 22:39, Arushi Singhal wrote: > > This patch replaces bit shifting on 1 with the BIT(x) macro. > This was done with coccinelle: > @@ > constant c; > @@ > > -1 << c > +BIT(c) Did you take the time to look at what this Coccinelle script

Re: [PATCH] staging: media: Replace a bit shift by a use of BIT.

On Mar 22, 2017, at 00:20, Arushi Singhal wrote: > > This patch replaces bit shifting on 1 with the BIT(x) macro. > This was done with coccinelle: > @@ > constant c; > @@ > > -1 << c > +BIT(c) Hi Arushi, thanks for taking time to contribute to the kernel.

Re: [PATCH v2] staging: iio: Replace a bit shift by a use of BIT.

On 03/22/2017 09:38 AM, Arushi Singhal wrote: > This patch replaces bit shifting on 1 with the BIT(x) macro. > This was done with coccinelle: > @@ > constant c; > @@ > > -1 << c > +BIT(c) When it comes to doing this type of conversion semantics, i.e. the meaning of the value, are important. The

Re: [Outreachy kernel] [PATCH] staging: media: Replace a bit shift by a use of BIT.

On Wed, 22 Mar 2017, Arushi Singhal wrote: > This patch replaces bit shifting on 1 with the BIT(x) macro. > This was done with coccinelle: > @@ > constant c; > @@ > > -1 << c > +BIT(c) > > Signed-off-by: Arushi Singhal > --- >

Re: [PATCH] staging: rts5208: Replace a bit shift by a use of BIT.

On Wed, Mar 22, 2017 at 08:04:47AM +0530, Arushi Singhal wrote: > This patch replaces bit shifting on 1 with the BIT(x) macro. > This was done with coccinelle: > @@ > constant c; > @@ > > -1 << c > +BIT(c) > > Signed-off-by: Arushi Singhal > --- >

Re: staging: iio: Replace a bit shift by a use of BIT.

On Wed, Mar 22, 2017 at 08:19:42AM +0530, Arushi Singhal wrote: > This patch replaces bit shifting on 1 with the BIT(x) macro. > This was done with coccinelle: > @@ > constant c; > @@ > > -1 << c > +BIT(c) > > Signed-off-by: Arushi Singhal > --- >

Re: [PATCH 09/10] staging: ks7010: remove zero comparison

On Wed, Mar 22, 2017 at 10:22:24AM +1100, Tobin C. Harding wrote: > On Tue, Mar 21, 2017 at 03:49:22PM +0300, Dan Carpenter wrote: > > On Tue, Mar 21, 2017 at 01:37:11PM +1100, Tobin C. Harding wrote: > > > Comparison, equal to zero, is redundant > > > > > > 'if (foo == 0)' is equal to 'if

Re: [PATCH] staging: wilc1000: use kernel define byte order macros

On Tue, Mar 21, 2017 at 03:40:10PM -0600, Robert Perry Hooker wrote: > Thanks for taking a look, Dan. Sorry if I missed the mark here. > > Can you tell me a bit more about the bug this would introduce? > > I see that ieee80211_is_action is defined like this: static inline bool >

Re: staging: iio: Replace a bit shift by a use of BIT.

On Wed, Mar 22, 2017 at 3:49 AM, Arushi Singhal wrote: > @@ -232,7 +232,7 @@ static int ad7150_write_event_config(struct iio_dev > *indio_dev, > if (ret < 0) > goto error_ret; > > - cfg = ret & ~((0x03 << 5) | (0x1 << 7)); > +

[PATCH v2] staging: dgnc: remove tracing prints in dgnc_tty.c

Remove tracing prints in dgnc_tty_send_xchar. The same functionality could be achieved by using ftrace. Signed-off-by: Abhishek Bhardwaj --- Changes in v2: - Remove the tracing prints all together. drivers/staging/dgnc/dgnc_tty.c | 4 1 file changed, 4 deletions(-)

[PATCH] staging: ks7010: fixed a coding style issue

Fixed checkpatch.pl CHECK: Logical continuations should be on the previous line Signed-off-by: Xiangyang Zhang --- drivers/staging/ks7010/ks7010_sdio.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c

[PATCH v2] staging: iio: Replace a bit shift by a use of BIT.

This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal --- changes in v2 -change the cc list drivers/staging/iio/adc/ad7816.c | 2 +-

Re: [PATCH v2] staging: dgnc: remove tracing prints in dgnc_tty.c

On Wed, Mar 22, 2017 at 12:18:43AM -0700, Abhishek Bhardwaj wrote: > Remove tracing prints in dgnc_tty_send_xchar. The same functionality > could be achieved by using ftrace. > > Signed-off-by: Abhishek Bhardwaj > --- > drivers/staging/dgnc/dgnc_tty.c | 4 > 1 file

[PATCH] drivers/staging/dgnc: Updating dev_dbg function

Making use of __func__ instead of using function name directly in dev_dbg. Signed-off-by: Pushkar Jambhlekar --- drivers/staging/dgnc/dgnc_tty.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c

[PATCH v2] staging: dgnc: remove tracing prints in dgnc_tty.c

Remove tracing prints in dgnc_tty_send_xchar. The same functionality could be achieved by using ftrace. Signed-off-by: Abhishek Bhardwaj --- drivers/staging/dgnc/dgnc_tty.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c

Re: staging: iio: Replace a bit shift by a use of BIT.

On Wed, Mar 22, 2017 at 08:19:42AM +0530, Arushi Singhal wrote: > This patch replaces bit shifting on 1 with the BIT(x) macro. > This was done with coccinelle: > @@ > constant c; > @@ > > -1 << c > +BIT(c) > > Signed-off-by: Arushi Singhal > --- >