Re: [PATCH v2] Staging: comedi: fix multiple line dereference coding style issue in cb_pcidas64.c

On 23/03/18 10:49, Jian Zhang wrote: This is a patch to the cb_pcidas64.c file that fixes up a multiple line dereference warning found by the checkpatch.pl tool. Signed-off-by: Jian Zhang --- drivers/staging/comedi/drivers/cb_pcidas64.c | 19 ++- 1 file changed, 10 insertions

Re: [PATCH 02/30] media: imx-media-utils: fix a warning

On Fri, Mar 23, 2018 at 07:56:48AM -0400, Mauro Carvalho Chehab wrote: > The logic at find_format() is a little bit confusing even for > humans, and it tricks static code analyzers: > > drivers/staging/media/imx/imx-media-utils.c:259 find_format() error: > buffer overflow 'array' 14 <= 20

[PATCH 02/30] media: imx-media-utils: fix a warning

The logic at find_format() is a little bit confusing even for humans, and it tricks static code analyzers: drivers/staging/media/imx/imx-media-utils.c:259 find_format() error: buffer overflow 'array' 14 <= 20 Rewrite the logic in a way that it makes it clearer to understand, while preven

Re: [PATCH] staging: pi433: add descriptions for mutex locks

On Fri, Mar 23, 2018 at 11:22:39AM +0100, Marcus Wolf wrote: > could you please decribe in short words, why you think, that hte lock > isn't obsolete? > > I wasn't sure, but close to remove the lock. That's why I putted the > comment. Sure, if pi433_tx_thread runs on one CPU it might be possible

Re: [PATCH 09/12] staging: ks7010: replace MichaelBlockFunction macro with inline function

On Fri, Mar 23, 2018 at 11:56 AM, Dan Carpenter wrote: > On Fri, Mar 23, 2018 at 11:14:59AM +0100, Sergio Paracuellos wrote: >> On Fri, Mar 23, 2018 at 10:49 AM, Dan Carpenter >> wrote: >> > On Thu, Mar 22, 2018 at 08:19:20PM +0100, Sergio Paracuellos wrote: >> >> This commit replaces MichaelBloc

Re: [PATCH 09/12] staging: ks7010: replace MichaelBlockFunction macro with inline function

On Fri, Mar 23, 2018 at 11:14:59AM +0100, Sergio Paracuellos wrote: > On Fri, Mar 23, 2018 at 10:49 AM, Dan Carpenter > wrote: > > On Thu, Mar 22, 2018 at 08:19:20PM +0100, Sergio Paracuellos wrote: > >> This commit replaces MichaelBlockFunction macro with similar inline > >> function > >> renami

[PATCH v2] Staging: comedi: fix multiple line dereference coding style issue in cb_pcidas64.c

This is a patch to the cb_pcidas64.c file that fixes up a multiple line dereference warning found by the checkpatch.pl tool. Signed-off-by: Jian Zhang --- drivers/staging/comedi/drivers/cb_pcidas64.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers

Re: [PATCH] staging: pi433: add descriptions for mutex locks

Hi Valentin, could you please decribe in short words, why you think, that hte lock isn't obsolete? I wasn't sure, but close to remove the lock. That's why I putted the comment. Thanks, Marcus Am 23.03.2018 um 10:47 schrieb Valentin Vidic: > Removes TODO for tx_fifo_lock as tx_fifo is modified

Re: [PATCH 11/12] staging: ks7010: replace uint8_t in favour of u8 in michael_append

On Thu, Mar 22, 2018 at 08:19:22PM +0100, Sergio Paracuellos wrote: > This commit replaces param which is uint8_t in michael_append > function in favour of preferred one u8. > > Signed-off-by: Sergio Paracuellos > --- > drivers/staging/ks7010/michael_mic.c | 6 +++--- > 1 file changed, 3 inserti

Re: [PATCH 09/12] staging: ks7010: replace MichaelBlockFunction macro with inline function

On Fri, Mar 23, 2018 at 10:49 AM, Dan Carpenter wrote: > On Thu, Mar 22, 2018 at 08:19:20PM +0100, Sergio Paracuellos wrote: >> This commit replaces MichaelBlockFunction macro with similar inline function >> renaming it to michael_block. >> >> Signed-off-by: Sergio Paracuellos >> --- >> drivers/

Re: [PATCH 09/12] staging: ks7010: replace MichaelBlockFunction macro with inline function

On Thu, Mar 22, 2018 at 08:19:20PM +0100, Sergio Paracuellos wrote: > This commit replaces MichaelBlockFunction macro with similar inline function > renaming it to michael_block. > > Signed-off-by: Sergio Paracuellos > --- > drivers/staging/ks7010/michael_mic.c | 30 +++--

[PATCH] staging: pi433: add descriptions for mutex locks

Removes TODO for tx_fifo_lock as tx_fifo is modified from both pi433_tx_thread and pi433_write. Fixes checkpatch warning: CHECK: struct mutex definition without comment Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-

Re: [PATCH 2/2] mmc: Add mmc_force_detect_change_begin / _end functions

Hi Uffe, On Fri, Feb 09, 2018 at 03:01:00PM +0100, Ulf Hansson wrote: > [...] > > >> > I'd like to know if any progress has been made on that problem (I may > >> > have missed patches). > >> > Had you had the time to look at the issue? > >> > >> I have looked at the issue, but not manage to cook

<    1   2