Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/rtl8723bs//hal/odm_CfoTracking.c: In function
'odm_SetCrystalCap':
drivers/staging/rtl8723bs//hal/odm_CfoTracking.c:14:7: warning:
variable 'bEEPROMCheck' set but not used [-Wunused-but-set-variable]
Reported-by: Hulk Robot
On 2019/7/31 23:57, Gao Xiang wrote:
> For historical reasons, __GFP_NOFAIL was set for managed inode.
> It's no need using that since EROFS can handle it properly.
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
On 2019/7/31 23:57, Gao Xiang wrote:
> CONFIG_EROFS_FS_IO_MAX_RETRIES seems a runtime setting
> and users have no idea about the change in behaviour.
>
> Let's remove the setting currently and could turn it
> into a module parameter if it's really needed.
>
> Suggested-by: David Sterba
>
On 2019/7/31 23:57, Gao Xiang wrote:
> Because #include "internal.h" is included in xattr.h
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
de...@linuxdriverproject.org
On 2019/7/31 20:54, Gao Xiang wrote:
>
>
> On 2019/7/31 20:07, Chao Yu wrote:
>> Hi Xiang,
>>
>> On 2019/7/31 15:08, Gao Xiang wrote:
>>> Hi Chao,
>>>
>>> On 2019/7/31 15:03, Chao Yu wrote:
On 2019/7/29 14:51, Gao Xiang wrote:
> Because #include "internal.h" is included in xattr.h
ral -Wint-to-pointer-cast and -Wpointer-to-int-cast warnings
>> that appeared as a result of commit 171a9bae68c7 ("staging/octeon:
>> Allow test build on !MIPS") in these files.
>>
>> Fixes: 171a9bae68c7 ("staging/octeon: Allow test build on !MIPS")
>>
From: Adham Abozaeid
function wilc_resolve_disconnect_aberration isn't referenced, so
removing it
Signed-off-by: Adham Abozaeid
---
drivers/staging/wilc1000/wilc_hif.c | 9 -
drivers/staging/wilc1000/wilc_hif.h | 1 -
2 files changed, 10 deletions(-)
diff --git
From: Adham Abozaeid
wilc_set_wfi_drv_handler and wilc_set_operation_mode sends the same
parameters to the FW, so it's better to combine them together.
Kept wilc_set_wfi_drv_handler implementation since it sends all the
required parameters, and renamed it to wilc_set_operation_mode to be
more
i.MX7 and i.MX6UL/L have the same CSI controller. So add i.MX6UL/L support
to imx7-media-csi driver.
Signed-off-by: Sébastien Szymanski
---
Changes for v3:
- rebase on Linux v5.3-rc2
- remove csi_soc_id var as it's not needed anymore thanks to commit
e0c76a7d3428 ("media: imx7-media-csi: get
tree:
https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/driver-core.git
driver-core-testing
head: 90eb808c54acbacfb76b408036dc0fc287b46901
commit: 46c5ea62709238df9b033991882358fba099aa55 [11/17] driver core: Add
sync_state driver/bus callback
reproduce: make htmldocs
If you
arm allyesconfig warns:
WARNING: unmet direct dependencies detected for MDIO_OCTEON
Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y]
&& 64BIT && HAS_IOMEM [=y] && OF_MDIO [=y]
Selected by [y]:
- OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC &&
NETDEVICES
Bitwise OR(|) operation with 0 always yield same result.
It fixes dubious x | !y sparse warning.
Signed-off-by: Harsh Jain
---
drivers/staging/kpc2000/kpc2000_i2c.c | 16 +---
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000_i2c.c
Remove unused macro IS_MAC_ADDRESS_BROADCAST. In future if one wants use
it ,use generic API "is_broadcast_ether_addr"
Signed-off-by: Hariprasad Kelam
---
v2 - Add patch number
drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 7 ---
1 file changed, 7 deletions(-)
diff --git
htpriv.sgi_* variables are of type u8 ,instead of storing them in local
variables ,its better to read value directly from structure.
Signed-off-by: Hariprasad Kelam
---
v2 - Add patch number
drivers/staging/rtl8723bs/core/rtw_xmit.c | 11 ---
1 file changed, 4 insertions(+), 7
Remove unneeded extern variable "extern unsigned char WFD_OUI"
Signed-off-by: Hariprasad Kelam
---
v2 - Add patch number
drivers/staging/rtl8723bs/core/rtw_ap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c
b/drivers/staging/rtl8723bs/core/rtw_ap.c
init_addba_retry_timer does not use padapter, so only keep psta
Signed-off-by: Hariprasad Kelam
---
v2 - Add patch number
drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 2 +-
drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
drivers/staging/rtl8723bs/os_dep/mlme_linux.c| 2 +-
3
Remove below defines WEXT_CSCAN_AMOUNT WEXT_CSCAN_BUF_LEN
WEXT_CSCAN_NPROBE_SECTION
Signed-off-by: Hariprasad Kelam
---
v2 - Add patch number
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
Remove below unused defines RTW_CH_MAX_2G_CHANNEL rtw_a_rates
RTW_A_RATES_NUM RTW_5G_CHANNELS_NUM
Signed-off-by: Hariprasad Kelam
---
v2 - Add patch number
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 5 -
1 file changed, 5 deletions(-)
diff --git
Remove function argument "padapter" in rtl8723bs_init_recv_priv function
as its not being used
Signed-off-by: Hariprasad Kelam
---
v4 - Add patch number
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 4 ++--
drivers/staging/rtl8723bs/include/recv_osdep.h | 2 +-
Remove passing pdid as function argument to rtw_sdio_if1_init as it is
not being used
Signed-off-by: Hariprasad Kelam
---
v3 - Add patch number
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
tree:
https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/driver-core.git
driver-core-testing
head: 90eb808c54acbacfb76b408036dc0fc287b46901
commit: d4d28915bc4a5db5370387e2622b2cb5502d229a [9/17] driver core: Add
edit_links() callback for drivers
reproduce: make htmldocs
If
Inthis file all functions has below common functionality
1.Check flag padapter->bSurpriseRemoved
2.Get sdio_func structure from intf_hdl.
This patch introduces two new APIs
rtw_isadapter_removed,rtw_sdio_get_func which helps to do above common
functionality.
Signed-off-by: Hariprasad Kelam
---
This function simply returns _regdom_rd . So replace this function
with actual code
Signed-off-by: Hariprasad Kelam
---
v2 - Add patch number
drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git
Document "fsl,imx6ul-csi" entry.
Reviewed-by: Rob Herring
Signed-off-by: Sébastien Szymanski
---
Changes for v3:
- none
Changes for v2:
- New patch to document new "fsl,imx6ul-csi" entry.
Documentation/devicetree/bindings/media/imx7-csi.txt | 2 +-
1 file changed, 1 insertion(+), 1
From: Nathan Chancellor
Date: Wed, 31 Jul 2019 09:35:09 -0700
> In file included from ../drivers/net/phy/mdio-octeon.c:14:
> ../drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of
> function 'writeq'; did you mean 'writeb'?
> [-Werror=implicit-function-declaration]
> 111 |
Add csi node for i.MX6UL SoC.
Reviewed-by: Fabio Estevam
Signed-off-by: Sébastien Szymanski
---
Changes for v3:
- none
Changes for v2:
- only "mclk" clock is required now.
arch/arm/boot/dts/imx6ul.dtsi | 9 +
1 file changed, 9 insertions(+)
diff --git
gt; >>
> > >> which is triggered by the staging OCTEON_ETHERNET driver which misses a
> > >> 64BIT dependency but added COMPILE_TEST in 171a9bae68c72f2
> > >> (staging/octeon: Allow test build on !MIPS).
> > >
> > > A patch was posted fo
From: Greg KH
Date: Wed, 31 Jul 2019 18:02:19 +0200
> From: YueHaibing
>
> While do COMPILE_TEST build without CONFIG_NETDEVICES,
> we get Kconfig warning:
>
> WARNING: unmet direct dependencies detected for PHYLIB
> Depends on [n]: NETDEVICES [=n]
> Selected by [y]:
> - OCTEON_ETHERNET
From: YueHaibing
While do COMPILE_TEST build without CONFIG_NETDEVICES,
we get Kconfig warning:
WARNING: unmet direct dependencies detected for PHYLIB
Depends on [n]: NETDEVICES [=n]
Selected by [y]:
- OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC && NETDEVICES
[=n] ||
On Wed, Jul 31, 2019 at 08:48:24AM -0700, David Miller wrote:
> From: Greg Kroah-Hartman
> Date: Wed, 31 Jul 2019 13:35:22 +0200
>
> > On Wed, Jul 31, 2019 at 12:24:41PM +0100, Mark Brown wrote:
> >> On Wed, Jul 31, 2019 at 04:07:41AM -0700, kernelci.org bot wrote:
> >>
> >> Today's -next fails
Because #include "internal.h" is included in xattr.h
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/namei.c | 1 -
drivers/staging/erofs/super.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/staging/erofs/namei.c b/drivers/staging/erofs/namei.c
index
Although this patch has an amount of changes, it is hard to
separate into smaller patches.
Most changes are due to structure renaming for better understand
and straightforward,
z_erofs_vle_workgroup to z_erofs_pcluster
since it represents a physical cluster;
z_erofs_vle_work to
It was used for Linux backward compatibility, and
no use for upstream kernel.
Reviewed-by: Chao Yu
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/internal.h | 3 ---
drivers/staging/erofs/utils.c| 10 +-
2 files changed, 5 insertions(+), 8 deletions(-)
diff --git
- Use the correct style for all SPDX License Identifiers;
- Get rid of the unnecessary license boilerplate;
- Use "GPL-2.0-only" instead of "GPL-2.0" suggested-by Stephen.
Reviewed-by: Chao Yu
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/Kconfig | 2 +-
dummy functions erofs_{get,list}xattr should be inlined
without xattr enabled.
Signed-off-by: Yue Hu
[ Gao Xiang : this patch was "staging: erofs: remove needless
dummy functions of erofs_{get,list}xattr. "]
Reviewed-by: Chao Yu
Signed-off-by: Gao Xiang
---
Keep in line with erofs-outofstaging patchset as well, see
https://lore.kernel.org/linux-fsdevel/20190725095658.155779-1-gaoxian...@huawei.com/
Reviewed-by: Chao Yu
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/Makefile | 2 +-
drivers/staging/erofs/{include/linux =>
Tidy up relative order of variables / declarations in internal.h,
move some local static functions out into other files and
add tags at the end of #endif acrossing several lines.
No logic change.
Reviewed-by: Chao Yu
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/decompressor.c | 27
remove duplicated code in decompressor by introducing
failable erofs_allocpage().
Reviewed-by: Chao Yu
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/decompressor.c | 12 +++-
drivers/staging/erofs/internal.h | 2 +-
drivers/staging/erofs/utils.c| 5 +++--
Keep in line with erofs-outofstaging patchset:
- Update comments in erofs_try_to_release_workgroup;
- code style cleanup.
Reviewed-by: Chao Yu
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/utils.c | 27 +--
1 file changed, 13 insertions(+), 14 deletions(-)
diff
.kill_sb() will do that instead in order to remove duplicated code.
Note that the initialzation of managed_cache is now moved
after s_root is assigned since it's more preferred to iput()
in .put_super() and all inodes should be evicted before
the end of generic_shutdown_super(sb).
Suggested-by:
clustersize can now be set on per-file basis
rather than per-filesystem basis.
Reviewed-by: Chao Yu
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/internal.h | 5 -
drivers/staging/erofs/super.c| 9 -
drivers/staging/erofs/zmap.c | 3 +--
3 files changed, 1
Kill all kconfig cache strategies and turn them into mount options
"cache_strategy={disable|readahead|readaround}".
As the first step, cached pages can still be usable after cache
is disabled by remounting, and these pages will be fallen out
over time, which can be refined in the later version if
The main change is to reserve all checksums except for superblock,
since it's more useful to do block-based verity for read-only fs.
Some comments change as well, which is minor.
Reviewed-by: Chao Yu
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/erofs_fs.h | 39
As Al said, "the only use of sbi->dev_name is debugging
printks and all of those have sb->s_id available, with
device name stored in there. Which makes the whole
thing bloody weird".
sbi->dev_name was used for our debugging use and it's
better to just use s_id in community and delete
the whole
- rename erofs_register_super / erofs_unregister_super
to erofs_shrinker_register / erofs_shrinker_unregister;
- fold the only erofs_shrink_workstation external call
to erofs_shrinker_unregister;
- localize erofs_shrink_workstation;
- localize erofs_shrinker_info by introducing
For historical reasons, __GFP_NOFAIL was set for managed inode.
It's no need using that since EROFS can handle it properly.
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/super.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/erofs/super.c
Keep in line with erofs-outofstaging patchset:
- turn on CONFIG_EROFS_FS_ZIP by default;
- turn on CONFIG_EROFS_FS_SECURITY by default suggested by David;
- update Kconfig description.
Reviewed-by: Chao Yu
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/Kconfig | 54
- use shorter function names:
z_erofs_pagevec_enqueue and z_erofs_pagevec_dequeue;
- minor code cleanup.
In order to keep in line with erofs-outofstaging patchset.
Reviewed-by: Chao Yu
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/zdata.c | 6 +++---
drivers/staging/erofs/zpvec.h | 25
Turn into a module parameter ("use_vmap") as it
can be set at runtime.
Suggested-by: David Sterba
Reviewed-by: Chao Yu
Signed-off-by: Gao Xiang
---
.../erofs/Documentation/filesystems/erofs.txt | 4
drivers/staging/erofs/Kconfig | 8 ---
CONFIG_EROFS_FS_IO_MAX_RETRIES seems a runtime setting
and users have no idea about the change in behaviour.
Let's remove the setting currently and could turn it
into a module parameter if it's really needed.
Suggested-by: David Sterba
Signed-off-by: Gao Xiang
---
Keep in line with erofs-outofstaging patchset:
- "Chao Yu" is most commonly used in Linux community;
- quoted string split across lines.
Reviewed-by: Chao Yu
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/super.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git
Remove redundant braces in inode.c
since these are all single statements.
Reviewed-by: Chao Yu
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/inode.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/erofs/inode.c
changes from v1:
(mainly address comments from Chao:)
- keep EROFS_IO_MAX_RETRIES_NOFAIL;
- add a new patch "drop __GFP_NOFAIL for managed inode";
- kill a redundant NULL check in "__stagingpage_alloc";
- add some description in document about "use_vmap";
- rearrange erofs_vmap of
From: Greg Kroah-Hartman
Date: Wed, 31 Jul 2019 13:35:22 +0200
> On Wed, Jul 31, 2019 at 12:24:41PM +0100, Mark Brown wrote:
>> On Wed, Jul 31, 2019 at 04:07:41AM -0700, kernelci.org bot wrote:
>>
>> Today's -next fails to build an ARM allmodconfig due to:
>>
>> > allmodconfig (arm, gcc-8) ―
In rtl8192_init_priv_variable allocation for priv->pFirmware may fail,
so a null check is necessary.priv->pFirmware is accessed later in
rtl8192_adapter_start. I added the check and made appropriate changes
to propagate the errno to the caller.
Signed-off-by: Navid Emamdoost
---
Update v2:
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/rtl8723bs/hal/odm.c: In function 'odm_RSSIMonitorCheckCE':
drivers/staging/rtl8723bs/hal/odm.c:1258:7: warning:
variable 'FirstConnect' set but not used [-Wunused-but-set-variable]
Reported-by: Hulk Robot
Signed-off-by: YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/rtl8723bs/core/rtw_cmd.c: In function rtw_cmd_thread:
drivers/staging/rtl8723bs/core/rtw_cmd.c:405:16: warning: variable prspbuf set
but not used [-Wunused-but-set-variable]
drivers/staging/rtl8723bs/core/rtw_cmd.c: In function
On 2019/7/31 21:20, Gao Xiang wrote:
>struct b *ptr = tagptr_unfold_tags(tptr);
> vs
>struct b *ptr = (struct b *)((unsigned long)tptr & ~2);
Sorry ... a too stupid typo issue, I mean
struct b *ptr = tagptr_unfold_ptr(tptr);
vs
struct b *ptr = (struct b *)((unsigned long)tptr &
Signed-off-by: Geert Uytterhoeven
---
drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.h
b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.h
index
On 2019/7/31 21:20, Gao Xiang wrote:
> Yes, I think that is about coding style, but the legacy way we have to do
> type cast as well, I think...
>
>struct b *ptr = tagptr_unfold_tags(tptr);
> vs
>struct b *ptr = (struct b *)((unsigned long)tptr & ~2);
and we could do "typedef
Hi Jan,
On 2019/7/31 21:01, Jan Kara wrote:
> On Tue 30-07-19 15:14:01, Gao Xiang wrote:
>> Currently kernel has scattered tagged pointer usages
>> hacked by hand in plain code, without a unique and
>> portable functionset to highlight the tagged pointer
>> itself and wrap these hacked code in
On Tue 30-07-19 15:14:01, Gao Xiang wrote:
> Currently kernel has scattered tagged pointer usages
> hacked by hand in plain code, without a unique and
> portable functionset to highlight the tagged pointer
> itself and wrap these hacked code in order to clean up
> all over meaningless magic masks.
On 2019/7/31 20:10, Chao Yu wrote:
> Hi Xiang,
>
> On 2019/7/31 15:11, Gao Xiang wrote:
>> Hi Chao,
>>
>> On 2019/7/31 15:05, Chao Yu wrote:
>>> On 2019/7/29 14:51, Gao Xiang wrote:
CONFIG_EROFS_FS_IO_MAX_RETRIES seems a runtime setting
and users have no idea about the change in
On 2019/7/31 20:07, Chao Yu wrote:
> Hi Xiang,
>
> On 2019/7/31 15:08, Gao Xiang wrote:
>> Hi Chao,
>>
>> On 2019/7/31 15:03, Chao Yu wrote:
>>> On 2019/7/29 14:51, Gao Xiang wrote:
Because #include "internal.h" is included in xattr.h
>>>
>>> I think it would be better to remove
Hi Chao,
On 2019/7/31 16:15, Chao Yu wrote:
> On 2019/7/29 14:51, Gao Xiang wrote:
>> .kill_sb() will do that instead in order to remove duplicated code.
>>
>> Note that the initialzation of managed_cache is now moved
>> after s_root is assigned since it's more preferred to iput()
>> in
Hi,
On Tue 30 Jul 19, 09:27, Hans Verkuil wrote:
> On 7/27/19 11:57 AM, Paul Kocialkowski wrote:
> > Hi Hans,
> >
> > On Fri 26 Jul 19, 10:33, Hans Verkuil wrote:
> >> On 7/25/19 8:55 PM, Paul Kocialkowski wrote:
> >>> HEVC/H.265 stateless support for V4L2 and Cedrus
> >>>
> >>> This is early
Hi Xiang,
On 2019/7/31 15:11, Gao Xiang wrote:
> Hi Chao,
>
> On 2019/7/31 15:05, Chao Yu wrote:
>> On 2019/7/29 14:51, Gao Xiang wrote:
>>> CONFIG_EROFS_FS_IO_MAX_RETRIES seems a runtime setting
>>> and users have no idea about the change in behaviour.
>>>
>>> Let's remove the setting currently
Hi Xiang,
On 2019/7/31 15:08, Gao Xiang wrote:
> Hi Chao,
>
> On 2019/7/31 15:03, Chao Yu wrote:
>> On 2019/7/29 14:51, Gao Xiang wrote:
>>> Because #include "internal.h" is included in xattr.h
>>
>> I think it would be better to remove "internal.h" in xattr.h, and include
>> them
>> both in .c
On Tue, Jul 30, 2019 at 05:01:39PM -0500, Navid Emamdoost wrote:
> In rtl8192_init_priv_variable allocation for priv->pFirmware may fail,
> so a null check is necessary.priv->pFirmware is accessed later in
> rtl8192_adapter_start. I added the check and made appropriate changes
> to propagate the
On Wed, Jul 31, 2019 at 12:24:41PM +0100, Mark Brown wrote:
> On Wed, Jul 31, 2019 at 04:07:41AM -0700, kernelci.org bot wrote:
>
> Today's -next fails to build an ARM allmodconfig due to:
>
> > allmodconfig (arm, gcc-8) — FAIL, 1 error, 40 warnings, 0 section mismatches
> >
> > Errors:
> >
On Wed, Jul 31, 2019 at 04:07:41AM -0700, kernelci.org bot wrote:
Today's -next fails to build an ARM allmodconfig due to:
> allmodconfig (arm, gcc-8) — FAIL, 1 error, 40 warnings, 0 section mismatches
>
> Errors:
> drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of
>
The Realtek RTL8723BS only connects successfully at the very first
time, then it always fails attempting to switch to another AP. No
authentication/association observed from the air capture for each
attempt due to the cfg80211 believes the device is still connected.
Fix this by forcing to
From: Colin Ian King
Variable rtstatus is being initialized with a value that is never read
and rtstatus is being re-assigned a little later on. The assignment is
redundant and hence can be removed. Also, make rtstatus a bool to
match the function return type.
Addresses-Coverity: ("Unused
On 2019/7/29 14:51, Gao Xiang wrote:
> Keep in line with erofs-outofstaging patchset:
> - turn on CONFIG_EROFS_FS_ZIP by default;
> - turn on CONFIG_EROFS_FS_SECURITY by default suggested by David;
> - update Kconfig description.
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
On 2019/7/29 14:51, Gao Xiang wrote:
> Keep in line with erofs-outofstaging patchset:
> - "Chao Yu" is most commonly used in Linux community;
Either is okay to me, anyway, thanks for the correction. :)
BTW, I notice that .mailmap can map different email or name to single one on
git-shortlog or
On 2019/7/29 14:51, Gao Xiang wrote:
> keep in line with erofs-outofstaging patchset:
> - remove an extra #ifdef CONFIG_EROFS_FS_ZIP;
> - add tags at the end of #endif acrossing several lines.
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
On 2019/7/29 14:51, Gao Xiang wrote:
> keep in line with erofs-outofstaging patchset:
> - Update comments in erofs_try_to_release_workgroup;
> - code style cleanup.
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
On 2019/7/29 14:51, Gao Xiang wrote:
> Kill all kconfig cache strategies and turn them into mount options
> "cache_strategy={disable|readahead|readaround}".
>
> As the first step, cached pages can still be usable after cache
> is disabled by remounting, and these pages will be fallen out
> over
On 2019/7/29 14:51, Gao Xiang wrote:
> clustersize can now be set on per-file basis
> rather than per-filesystem basis.
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
de...@linuxdriverproject.org
On 2019/7/29 14:51, Gao Xiang wrote:
> Although this patch has an amount of changes, it is hard to
> separate into smaller patches.
>
> Most changes are due to structure renaming for better understand
> and straightforward,
> z_erofs_vle_workgroup to z_erofs_pcluster
> since it
On Tue, 30 Jul 2019 21:50:28 +0200
Arnd Bergmann wrote:
> Each of these drivers has a copy of the same trivial helper function to
> convert the pointer argument and then call the native ioctl handler.
>
> We now have a generic implementation of that, so use it.
>
> Acked-by: Greg Kroah-Hartman
On 2019/7/29 14:51, Gao Xiang wrote:
> Remove redundant braces in inode.c since
> these are all single statements.
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
de...@linuxdriverproject.org
On 2019/7/29 14:51, Gao Xiang wrote:
> - use shorter function names:
> z_erofs_pagevec_enqueue and z_erofs_pagevec_dequeue;
> - minor code cleanup.
>
> In order to keep in line with erofs-outofstaging patchset.
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
On 2019/7/29 14:51, Gao Xiang wrote:
> Turn into a module parameter ("use_vmap") as it
> can be set at runtime.
>
> Suggested-by: David Sterba
> Signed-off-by: Gao Xiang
> ---
> drivers/staging/erofs/Kconfig| 8 --
> drivers/staging/erofs/decompressor.c | 37
On 2019/7/29 14:51, Gao Xiang wrote:
> remove duplicated code in decompressor by introducing
> failable erofs_allocpage().
>
> Signed-off-by: Gao Xiang
> ---
> drivers/staging/erofs/decompressor.c | 12 +++-
> drivers/staging/erofs/internal.h | 2 +-
> drivers/staging/erofs/utils.c
On 2019/7/29 14:51, Gao Xiang wrote:
> .kill_sb() will do that instead in order to remove duplicated code.
>
> Note that the initialzation of managed_cache is now moved
> after s_root is assigned since it's more preferred to iput()
> in .put_super() and all inodes should be evicted before
> the
On 2019/7/29 14:51, Gao Xiang wrote:
> As Al said, "the only use of sbi->dev_name is debugging
> printks and all of those have sb->s_id available, with
> device name stored in there. Which makes the whole
> thing bloody weird".
>
> sbi->dev_name was used for our debugging use and it's
> better
On 2019/7/29 14:51, Gao Xiang wrote:
> - rename erofs_register_super / erofs_unregister_super
> to erofs_shrinker_register / erofs_shrinker_unregister;
> - fold the only erofs_shrink_workstation external call
> to erofs_shrinker_unregister;
> - localize erofs_shrink_workstation;
> - localize
Hi Chao,
On 2019/7/31 15:05, Chao Yu wrote:
> On 2019/7/29 14:51, Gao Xiang wrote:
>> CONFIG_EROFS_FS_IO_MAX_RETRIES seems a runtime setting
>> and users have no idea about the change in behaviour.
>>
>> Let's remove the setting currently and fold it into code,
>> turn it into a module parameter
Hi Chao,
On 2019/7/31 15:03, Chao Yu wrote:
> On 2019/7/29 14:51, Gao Xiang wrote:
>> Because #include "internal.h" is included in xattr.h
>
> I think it would be better to remove "internal.h" in xattr.h, and include them
> both in .c file in where we need xattr definition.
It seems that all
On 2019/7/29 14:51, Gao Xiang wrote:
> CONFIG_EROFS_FS_IO_MAX_RETRIES seems a runtime setting
> and users have no idea about the change in behaviour.
>
> Let's remove the setting currently and fold it into code,
> turn it into a module parameter if it's really needed.
>
> Suggested-by: David
On 2019/7/29 14:51, Gao Xiang wrote:
> Because #include "internal.h" is included in xattr.h
I think it would be better to remove "internal.h" in xattr.h, and include them
both in .c file in where we need xattr definition.
Thanks,
___
devel mailing
On 2019/7/29 14:51, Gao Xiang wrote:
> Tidy up relative order of variables / declarations in internal.h,
> and moving some local static functions out to other files.
>
> No logic change.
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
On 2019/7/29 14:51, Gao Xiang wrote:
> It was used for Linux backward compatibility, and no use
> for upstream kernel.
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
de...@linuxdriverproject.org
On 2019/7/29 14:51, Gao Xiang wrote:
> The main change is to reserve all checksums except for superblock,
> since it's more useful to do block-based verity for read-only fs.
>
> Some comments change as well, which is minor.
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
On 2019/7/29 14:51, Gao Xiang wrote:
> dummy functions erofs_{get,list}xattr should be inlined
> without xattr enabled.
>
> Signed-off-by: Yue Hu
> [ Gao Xiang : this patch was "staging: erofs: remove needless
> dummy functions of erofs_{get,list}xattr. "]
> Signed-off-by: Gao
On 2019/7/29 14:51, Gao Xiang wrote:
> Keep in line with erofs-outofstaging patchset as well, see
> https://lore.kernel.org/linux-fsdevel/20190725095658.155779-1-gaoxian...@huawei.com/
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
On 2019/7/29 14:51, Gao Xiang wrote:
> - Use the correct style for all SPDX License Identifiers;
> - Get rid of the unnecessary license boilerplate;
> - Use "GPL-2.0-only" instead of "GPL-2.0" suggested-by Stephen.
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
98 matches
Mail list logo
