Re: [PATCH v2 1/1] binder: fix freeze race

2021-09-09 Thread Li Li
On Thu, Sep 9, 2021 at 10:38 PM Greg KH wrote: > > On Thu, Sep 09, 2021 at 08:53:16PM -0700, Li Li wrote: > > struct binder_frozen_status_info { > > __u32pid; > > + > > + /* process received sync transactions since last frozen > > + * bit 0: received sync transaction af

Re: [PATCH v1 1/1] binder: fix freeze race

2021-09-09 Thread Dan Carpenter
On Thu, Sep 09, 2021 at 04:21:41PM -0700, Li Li wrote: > @@ -4648,6 +4647,22 @@ static int binder_ioctl_get_node_debug_info(struct > binder_proc *proc, > return 0; > } > > +static int binder_txns_pending(struct binder_proc *proc) > +{ > + struct rb_node *n; > + struct binder_threa

Re: [PATCH v2 1/1] binder: fix freeze race

2021-09-09 Thread Greg KH
On Thu, Sep 09, 2021 at 08:53:16PM -0700, Li Li wrote: > From: Li Li > > Currently cgroup freezer is used to freeze the application threads, and > BINDER_FREEZE is used to freeze the corresponding binder interface. > There's already a mechanism in ioctl(BINDER_FREEZE) to wait for any > existing t

Re: [PATCH v1 1/1] binder: fix freeze race

2021-09-09 Thread Todd Kjos
On Thu, Sep 9, 2021 at 4:21 PM Li Li wrote: > > From: Li Li > > Currently cgroup freezer is used to freeze the application threads, and > BINDER_FREEZE is used to freeze binder interface. There's already a > mechanism for BINDER_FREEZE to wait for any existing transactions to > drain out before a

[PATCH v2 1/1] binder: fix freeze race

2021-09-09 Thread Li Li
From: Li Li Currently cgroup freezer is used to freeze the application threads, and BINDER_FREEZE is used to freeze the corresponding binder interface. There's already a mechanism in ioctl(BINDER_FREEZE) to wait for any existing transactions to drain out before actually freezing the binder interf

[PATCH v2 0/1] binder: fix freeze race

2021-09-09 Thread Li Li
From: Li Li As there isn't an atomic operation to freeze the main thread and binder interface together, it's possible the main thread initiates a new binder transaction while the binder interfaces are already frozen. This race issue will result in failed binder transaction and unexpectedly crash

Re: [PATCH v1 1/1] binder: fix freeze race

2021-09-09 Thread Li Li
Hi Todd, Thanks for reviewing the patch! Please see my reply below. And I'll send out v2 soon addressing your concerns. On Thu, Sep 9, 2021 at 4:54 PM Todd Kjos wrote: > > On Thu, Sep 9, 2021 at 4:21 PM Li Li wrote: > > > > From: Li Li > > > > Currently cgroup freezer is used to freeze the ap

[PATCH v1 1/1] binder: fix freeze race

2021-09-09 Thread Li Li
From: Li Li Currently cgroup freezer is used to freeze the application threads, and BINDER_FREEZE is used to freeze binder interface. There's already a mechanism for BINDER_FREEZE to wait for any existing transactions to drain out before actually freezing the binder interface. But freezing an ap

[PATCH v1 0/1] binder: fix freeze race

2021-09-09 Thread Li Li
From: Li Li As there isn't an atomic operation to freeze the main thread and binder interface together, it's possible the main thread initiates a new binder transaction while the binder interfaces are already frozen. This race issue will result in failed binder transaction and unexpectedly crash

ATTENTION : BENEFICIARY ,

2021-09-09 Thread Mr. Ashley Sherlock.
-- -- INTERNATIONAL MONETARY FUND (IMF) HEAD OFFICE NO: 23 ADEBOYE ST,APAPA Abuja. ATTN:BENEFICIARY This is to intimate you of a very important information which will be of a great help to redeem you from all the difficulties you have been experiencing in getting your long over due payment due

Fwd:

2021-09-09 Thread JENET ADARA
-- Forwarded message -- From: JENET ADARA Date: Thu, 9 Sep 2021 15:48:31 +0200 Subject: To: judge.udo@gmail.com HELLO, DID YOU RECEIVE MY MAIL? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.o