Hi,
Since I'm the original author of fbtft I thought I'd highlight a couple
of issues that's probably not well known.
Right after fbtft was added, fbdev was closed for new drivers[1] and
the fbdev maintainer wanted to remove fbtft as a consequence of that
decision, but Greg KH said he'd keep fbtf
Den 02.02.2020 16.41, skrev Noralf Trønnes:
> Hi,
>
> Since I'm the original author of fbtft I thought I'd highlight a couple
> of issues that's probably not well known.
>
> Right after fbtft was added, fbdev was closed for new drivers[1] and
> the fbdev ma
Den 20.11.2019 15.43, skrev Noralf Trønnes:
>
>
> Den 20.11.2019 10.57, skrev Andy Shevchenko:
>> First of all there is no need to guard GPIO request by CONFIG_OF.
>> It works for everybody independently on resource provider. While here,
>> rename the fu
Den 20.11.2019 10.57, skrev Andy Shevchenko:
> First of all there is no need to guard GPIO request by CONFIG_OF.
> It works for everybody independently on resource provider. While here,
> rename the function to reflect the above.
>
> Moreover, since we have a global dependency to OF, the rest o
flexfb was an attempt to write a generic fbtft driver that was abandoned.
All the displays it supports are supported by other fbtft drivers.
Signed-off-by: Noralf Trønnes
---
drivers/staging/fbtft/Kconfig | 6 -
drivers/staging/fbtft/Makefile | 1 -
drivers/staging/fbtft/flexfb.c | 851
Just remove the module since it's the responsibility of Device Tree, ACPI
or platform code to add devices.
Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor interface")
Signed-off-by: Noralf Trønnes
---
drivers/staging/fbtft/Kconfig|4 -
drivers/stagi
t_gpios is not set in that case anymore.
Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor interface")
Cc: stable
Signed-off-by: Noralf Trønnes
---
drivers/staging/fbtft/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbt
Den 02.03.2017 14.04, skrev simran singhal:
This patch fixes the following sparse warnings:
drivers/staging/fbtft/fbtft-bus.c:166:36: warning: incorrect type in assignment
(different base types)
drivers/staging/fbtft/fbtft-bus.c:166:36:expected unsigned short [unsigned]
[short] [usertype]
Den 26.02.2017 19.11, skrev Stefan Wahren:
Eric Anholt hat am 26. Februar 2017 um 18:16 geschrieben:
...
For staging, Greg has been taking patches without platform maintainer
ack. I think this is great -- the staging code needs *lots* of work,
and it generally doesn't need any platform knowl
Due to personal reasons I'm unable to continue as fbtft maintainer.
Signed-off-by: Noralf Trønnes
---
For a long time I have wanted to convert the fbtft drivers to drm.
There's now a foundation in place to do so in drivers/gpu/drm/tinydrm.
Because of a worsening fatigue illness, I
arkfun for Intel Edison) OLED displays at their maximum speed
(25MHz and
10MHz).
Noralf, are you okay with this version of series?
Yes, Greg applies them without my ack, unless it touches core stuff.
Series:
Acked-by: Noralf Trønnes
Since v2:
- fix kbuild bot warning
- remove duplication of m
Hi,
I'm working on a drivers/gpu/drm version of drivers/staging/fbtft which
are drivers for tiny, usually SPI connected, displays. Now I'm wondering
if I can be backwards compatible and support Device Trees written for the
fbtft drivers. The main obstacle as I understand it, is the init property
Den 02.01.2017 12:35, skrev Andy Shevchenko:
There is 64x48 display exists. In order to support that set multiplexer
to 48 pixels and window address to proper position in the graphic display
data RAM.
Signed-off-by: Andy Shevchenko
---
Patches 5 and 6:
Acked-by: Noralf Trønnes
drivers
Den 03.01.2017 17:12, skrev Andy Shevchenko:
On Mon, 2017-01-02 at 13:35 +0200, Andy Shevchenko wrote:
Fall back to usual allocation method if DMA coherent allocation fails.
SPI framework will map and use DMA mapped memory when possible.
Locally I have re-done DMA approach and thus this patch
return;
+
+ might_sleep();
gpio_set_value_cansleep() already does might_sleep().
So with that removed:
Reviewed-by: Noralf Trønnes
+
fbtft_par_dbg(DEBUG_RESET, par, "%s()\n", __func__);
- gpio_set_value(par->gpio.reset, 0);
- udelay(20);
- gp
Den 03.01.2017 14:58, skrev Andy Shevchenko:
On Tue, 2017-01-03 at 12:51 +0200, Andy Shevchenko wrote:
On Mon, 2017-01-02 at 19:14 +0100, Noralf Trønnes wrote:
Den 02.01.2017 12:35, skrev Andy Shevchenko:
Usually it's not consumer's business to override resources passed
from
pr
Den 02.01.2017 12:35, skrev Andy Shevchenko:
Usually it's not consumer's business to override resources passed from
provider, in particularly DMA coherent mask.
Signed-off-by: Andy Shevchenko
---
drivers/staging/fbtft/fbtft-core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/s
[resending got rejected on the list for html format]
Den 09.06.2016 19:18, skrev Michal Suchanek:
Hello,
On 9 June 2016 at 18:20, Noralf Trønnes wrote:
Den 09.06.2016 17:08, skrev Michal Suchanek:
txbuflen can be set to arbitrary value by user and it is also set
automagically to the maximum
Den 09.06.2016 17:08, skrev Michal Suchanek:
txbuflen can be set to arbitrary value by user and it is also set
automagically to the maximum transfer size of the SPI master controller.
AFAICT this is a result of your previous patch. Please make a new version of
your previous patch with this fix
each time I'm confronted with it.)
You have even taken care of the special txbuflen == -1 value I see,
so I guess this is as good as it gets without any major refactoring, so:
Acked-by: Noralf Trønnes
And there's no point in doing any refactoring since I'm working on a DR
Den 11.10.2015 09:31, skrev Dennis Menschel:
Am 10.10.2015 um 17:36 schrieb Noralf Trønnes:
Den 07.10.2015 22:15, skrev Dennis Menschel:
This patch adds support for the Sitronix ST7789V display controller.
The controller is intended for small color displays with a resolution
of up to 320x240
Den 07.10.2015 22:15, skrev Dennis Menschel:
This patch adds support for the Sitronix ST7789V display controller.
The controller is intended for small color displays with a resolution
of up to 320x240 pixels.
Signed-off-by: Dennis Menschel
---
The future of fbtft is uncertain after fbdev mai
10.09.2015 06:54, skrev Sudip Mukherjee:
On Wed, Sep 09, 2015 at 11:20:08PM +0200, Noralf Trønnes wrote:
Den 09.09.2015 20:35, skrev Greg Kroah-Hartman:
On Sat, Sep 05, 2015 at 07:13:45PM +0530, Sudip Mukherjee wrote:
Instead of defining DRVNAME and using it in all calls to pr_* family of
Den 09.09.2015 20:35, skrev Greg Kroah-Hartman:
On Sat, Sep 05, 2015 at 07:13:45PM +0530, Sudip Mukherjee wrote:
Instead of defining DRVNAME and using it in all calls to pr_* family of
macros lets start using pr_fmt.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/fbtft/fbtft_device.c |
Den 01.09.2015 19:52, skrev Brüns, Stefan:
On Tuesday, September 01, 2015 16:57:14 Noralf Trønnes wrote:
IMHO, this is a bad idea. A controller supporting more than 32 bpw can
not set the bpw mask, as the mask is limited to 32 bits. Thus it has to
check the bpw in its own setup function, and
Den 01.09.2015 01:28, skrev Stefan Bruens:
On Monday 24 August 2015 01:24:59 Noralf Trønnes wrote:
Den 24.08.2015 00:24, skrev Stefan Brüns:
Avoid a crash, as master->setup may be NULL (e.g. xilinx controller).
Even if master->setup is set, spi_setup does several compatibility/
sanity
ahren
---
drivers/staging/fbtft/fbtft-core.c | 10 +++---
drivers/staging/fbtft/flexfb.c | 11 ---
2 files changed, 7 insertions(+), 14 deletions(-)
Thanks Stefan.
Both patches:
Acked-by: Noralf Trønnes
___
devel mailing li
Den 25.08.2015 19:34, skrev Stefan Wahren:
Noralf Trønnes hat am 25. August 2015 um 00:00
geschrieben:
Den 24.08.2015 20:33, skrev Stefan Wahren:
Since bits_per_word isn't usually checked during SPI setup the 9-bit
support must be checked manually.
Signed-off-by: Stefan W
Den 24.08.2015 20:33, skrev Stefan Wahren:
Since bits_per_word isn't usually checked during SPI setup the 9-bit
support must be checked manually.
Signed-off-by: Stefan Wahren
---
drivers/staging/fbtft/fbtft-core.c |7 +++
drivers/staging/fbtft/flexfb.c |7 +++
2 files c
Den 24.08.2015 00:24, skrev Stefan Brüns:
Avoid a crash, as master->setup may be NULL (e.g. xilinx controller).
Even if master->setup is set, spi_setup does several compatibility/
sanity checks which should not be skipped (fixes problems with
displays/controllers needing emulation for bits_per_w
a new LCD chip controller simply defining a new
flexfb_lcd_controller struct.
Signed-off-by: Fabio Falzoi
Acked-by: Noralf Trønnes
---
Seems I wasn't clear enough, you could use my ack if you put
struct flexfb_lcd_controller inside the driver and not in
f
to freed memory.
Signed-off-by: Noralf Trønnes
---
drivers/staging/fbtft/fbtft-core.c | 12 +---
drivers/staging/fbtft/fbtft.h | 5 +++--
drivers/staging/fbtft/flexfb.c | 2 +-
3 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-core.c
Den 14.07.2015 14:59, skrev Henri Chain:
This is a driver chip for 240x160 4-bit greyscale LCDs.
It is capable of 4-wire (8 bit) or 3-wire (9 bit) SPI that have both been
tested. (It also has a 6800 or 8080-style parallel interface, but I have
not included support for it.)
Signed-off-by: Henri
Den 15.07.2015 11:36, skrev Paul Bolle:
On di, 2015-07-14 at 14:59 +0200, Henri Chain wrote:
--- /dev/null
+++ b/drivers/staging/fbtft/fb_uc1611.c
+#define DRVNAME"fb_uc1611"
+MODULE_ALIAS("spi:" DRVNAME);
+MODULE_ALIAS("platform:" DRVNAME);
+MODULE_ALIAS("spi:uc1611");
+MODULE_
Den 15.07.2015 04:14, skrev Greg KH:
On Tue, Jun 30, 2015 at 08:43:13AM +0200, Fabio Falzoi wrote:
Use a helper function to choose which set_addr_win implementation to
use, based on the value of the setaddrwin module parameter.
Signed-off-by: Fabio Falzoi
---
drivers/staging/fbtft/flexfb.c
.height = 160,
+ .init_seq = st7735r_init,
+ .init_seq_sz = ARRAY_SIZE(st7735r_init),
+ },
+ {
Can this be put on one line? }, {
With the struct moved:
Acked-by: Noralf Trønnes
___
devel mailing list
de...@li
When an init sequence is present in the Device Tree,
fbtft_init_display_dt() is used to initialize the display.
Add missing reset function call and activation of
chip select for parallel bus.
Signed-off-by: Noralf Trønnes
---
drivers/staging/fbtft/fbtft-core.c | 5 +
1 file changed, 5
Den 02.03.2015 11:54, skrev Noralf Trønnes:
Hi,
This patchset introduces a new API to minimize the coupling to the
fbdev graphics subsystem. There have been calls to deprecate fbdev and
new fbdev drivers are discouraged.
Currently the FBTFT drivers are tightly coupled to fbdev through the
Den 03.03.2015 11:19, skrev Drew Fustini:
Move extern declartions from fbtft-core.c to fbtft header file. This resovles
the warning from checkpatch.pl that "externs should be avoided in .c files".
Signed-off-by: Drew Fustini
---
drivers/staging/fbtft/fbtft-core.c | 5 -
drivers/staging/
Den 03.03.2015 13:04, skrev Dan Carpenter:
On Tue, Mar 03, 2015 at 12:57:29PM +0100, Noralf Trønnes wrote:
+ ret = ctrl->rotate(ctrl, rotation);
+ if (!ret)
+ ctrl->rotation = rotation;
+
+ return ret;
Better to check "if (ret)" consistently (e
Den 02.03.2015 13:25, skrev Dan Carpenter:
On Mon, Mar 02, 2015 at 11:54:23AM +0100, Noralf Trønnes wrote:
diff --git a/drivers/staging/fbtft/lcdreg/lcdreg-debugfs.c
b/drivers/staging/fbtft/lcdreg/lcdreg-debugfs.c
[snip]
+static int lcdreg_userbuf_to_u32(const char __user *user_buf, size_t
Den 02.03.2015 12:48, skrev Dan Carpenter:
[snip]
+ if (ctrl->power_supply) {
+ ret = regulator_enable(ctrl->power_supply);
+ if (ret) {
+ dev_err(ctrl->lcdreg->dev,
+ "failed to enable power supply: %d\n", r
Den 02.03.2015 12:31, skrev Dan Carpenter:
On Mon, Mar 02, 2015 at 11:54:27AM +0100, Noralf Trønnes wrote:
Add dummy platform data when it's not present.
Signed-off-by: Noralf Trønnes
---
drivers/staging/fbtft/fbtft-core.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
Den 02.03.2015 20:21, skrev Andrey Skvortsov:
On 02 Mar, Joe Perches wrote:
On Mon, 2015-03-02 at 12:37 +0300, Dan Carpenter wrote:
On Sat, Feb 28, 2015 at 06:59:19AM -0800, Joe Perches wrote:
If you're really going to change these, please
remove the unnecessary \ line continuations
indent th
Add LCD register abstraction for MIPI DCS like controllers. This
hides LCD controller interface implementation details.
When built with debugfs, the register is available to userspace.
Signed-off-by: Noralf Trønnes
---
drivers/staging/fbtft/Kconfig | 2 +
drivers/staging/fbtft
Add abstraction for MIPI DCS/DBI like LCD controllers.
Signed-off-by: Noralf Trønnes
---
drivers/staging/fbtft/Kconfig | 1 +
drivers/staging/fbtft/Makefile | 1 +
drivers/staging/fbtft/lcdctrl/Kconfig | 3 +
drivers/staging/fbtft/lcdctrl/Makefile | 1 +
drivers
The Adafuit SSD1306 based displays comes in either 128x32 or 128x64
resolutions and uses I2C or SPI interface. This driver has support
for the I2C interface. Support for SPI can be added when lcdreg has
SPI support.
Signed-off-by: Noralf Trønnes
---
drivers/staging/fbtft/Kconfig | 9
Add lcdctrl support in core fbtft module.
Provide new API for drivers to use.
Signed-off-by: Noralf Trønnes
---
drivers/staging/fbtft/Makefile| 1 +
drivers/staging/fbtft/fbtft-lcdctrl.c | 311 ++
drivers/staging/fbtft/fbtft.h | 13 ++
3 files
Add dummy platform data when it's not present.
Signed-off-by: Noralf Trønnes
---
drivers/staging/fbtft/fbtft-core.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-core.c
b/drivers/staging/fbtft/fbtft-core.c
index ac4287f..59c17c1 1
Add I2C bus support to lcdreg.
Signed-off-by: Noralf Trønnes
---
drivers/staging/fbtft/lcdreg/Kconfig | 6 ++
drivers/staging/fbtft/lcdreg/Makefile | 2 +
drivers/staging/fbtft/lcdreg/lcdreg-i2c.c | 129 ++
drivers/staging/fbtft/lcdreg/lcdreg.h | 3
gmane.linux.drivers.devicetree/109103
Regards,
Noralf Trønnes
Noralf Trønnes (7):
staging: fbtft: add lcd register abstraction
staging: fbtft: lcdreg: add i2c support
staging: fbtft: add lcd controller abstraction
staging: fbtft: lcdctrl: add ssd1306 support
staging: fbtft: don'
Add support for Solomon SSD1306 Monochrome OLED controller.
The controller supports up to 128x64 pixles and supports interfaces:
Parallel 6800, parallel 8080, SPI (3/4), I2C.
Signed-off-by: Noralf Trønnes
---
drivers/staging/fbtft/lcdctrl/Kconfig | 5 +
drivers/staging/fbtft/lcdctrl
Add MAINTAINERS entry for staging/fbtft/
FBTFT is a framework for writing framebuffer drivers
for displays with LCD controllers having onchip RAM.
Signed-off-by: Noralf Trønnes
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 2fa3853
Add missing static keyword to function reset().
This was detected by the kbuild test robot.
Signed-off-by: Noralf Trønnes
---
drivers/staging/fbtft/fb_agm1264k-fl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c
b/drivers/staging
ARCH_BCM2708 is not present in mainline so remove optimization.
Signed-off-by: Noralf Trønnes
---
drivers/staging/fbtft/fbtft-io.c | 170 ---
1 file changed, 170 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-io.c b/drivers/staging/fbtft/fbtft-io.c
Hi,
I can't get my name: Noralf Trønnes, to come out correctly in From when I
format and send a patch. The 'ø' becomes a question mark when received
in my email client.
This is the head of the patch generated by git format-patch:
From b2a4f6abdb097c4dc092b56995a2af8e42fbea79 M
Den 20.01.2015 09:46, skrev Paul Bolle:
Thomas, Noralf,
Your commit c296d5f9957c ("staging: fbtft: core support") is included in
today's linux-next (ie, next-20150120). I noticed because a script I use
to check linux-next spotted a problem in it.
See, that commit adds two checks for CONFIG_ARCH
57 matches
Mail list logo