the NULL check for memregion is not required as it has already been
checked for NULL after kzalloc. so we can reach this part of the code
only if memregion is not NULL.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/unisys/visorutil/memregion_direct.c | 6 ++
1 file
we can reach the label Away in total five situation and in four of
of them pDevInfo is NULL. so we were basically dereferencing a NULL
pointer.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/unisys/visorchipset/visorchipset_main.c | 3 ++-
1 file changed, 2 insertions
On Tue, Nov 04, 2014 at 11:43:07PM +0200, Aya Mahfouz wrote:
This patches replaces one pr_debug call by dev_dbg and
changes the device used by one of the dev_err calls.
i think you should mention in the commit message why you are changing the
device.
and also for revised patch its better if
On Tue, Nov 04, 2014 at 02:13:19AM +0200, Aya Mahfouz wrote:
This patch replaces dev_err by pr_err since the value
of ir is NULL when the message is displayed.
Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com
---
drivers/staging/media/lirc/lirc_zilog.c | 2 +-
1 file changed, 1
On Tue, Nov 04, 2014 at 11:48:26PM +0200, Aya Mahfouz wrote:
On Tue, Nov 04, 2014 at 03:06:53PM +0530, Sudip Mukherjee wrote:
On Tue, Nov 04, 2014 at 02:13:19AM +0200, Aya Mahfouz wrote:
This patch replaces dev_err by pr_err since the value
of ir is NULL when the message is displayed
On Sat, Nov 01, 2014 at 10:09:39PM +0800, Chen Weixiang wrote:
On Sat, Nov 01, 2014 at 10:35:35AM +0530, Sudip Mukherjee wrote:
many whitespace errors in the patch.
checkpatch gives total: 8 errors, 23 warnings, 125 lines checked
thanks
sudip
Hi sudip,
Yes, I also run
On Fri, Oct 31, 2014 at 10:06:46PM +0100, Mariusz Gorski wrote:
Remove Lindent and checkpatch.pl tasks from TODO file as the first one
is obsolete and the other one is already done.
when i checked panel.c with checkpatch and with --strict option, i got 20
checks.
thanks
sudip
On Fri, Oct 31, 2014 at 11:08:34PM +0100, Konrad Zapalowicz wrote:
On 10/31, Mariusz Gorski wrote:
Remove Lindent and checkpatch.pl tasks from TODO file as the first one
is obsolete and the other one is already done.
when i checked panel.c with checkpatch and with --strict option, i got
On Sat, Nov 01, 2014 at 10:47:22AM +0800, Chen Weixiang wrote:
Remove following code style errors from ft1000/ft1000-usb/ft1000_debug.c
and ft1000/ft1000-pcmcia/ft1000_hw.c:
ERROR: spaces required around that '=' (ctx:VxV)
ERROR: spaces required around that '' (ctx:VxV)
ERROR: spaces required
On Sat, Nov 01, 2014 at 10:47:24AM +0800, Chen Weixiang wrote:
Remove following code style error from ft1000/ft1000-usb/ft1000_debug.c:
ERROR: (foo*) should be (foo *)
again checkpatch gives total: 4 errors, 3 warnings, 16 lines checked.
this includes whitespace errors.
thanks
sudip
On Sat, Nov 01, 2014 at 10:47:23AM +0800, Chen Weixiang wrote:
Remove following code style errors from ft1000/ft1000-pcmcia/ft1000_hw.c:
ERROR: space prohibited after that open parenthesis '('
ERROR: space prohibited before that close parenthesis ')'
ERROR: space prohibited after that ''
On Sat, Nov 01, 2014 at 10:47:26AM +0800, Chen Weixiang wrote:
Remove code style error from ft1000/ft1000-pcmcia/ft1000_hw.c:
ERROR: else should follow close brace '}'
from checkpatch:
total: 1 errors, 2 warnings, 44 lines checked
NOTE: whitespace errors detected, you may wish to use
On Sat, Nov 01, 2014 at 10:47:27AM +0800, Chen Weixiang wrote:
Remove following code style error from ft1000/ft1000-usb/ft1000_debug.c:
ERROR: space required after that ',' (ctx:VxV)
from checkpatch:
total: 11 errors, 15 warnings, 46 lines checked
NOTE: whitespace errors detected, you may
On Fri, Oct 31, 2014 at 10:14:30PM -0700, Joe Perches wrote:
On Sat, 2014-11-01 at 10:35 +0530, Sudip Mukherjee wrote:
On Sat, Nov 01, 2014 at 10:47:22AM +0800, Chen Weixiang wrote:
Remove following code style errors from ft1000/ft1000-usb/ft1000_debug.c
and ft1000/ft1000-pcmcia
On Sat, Nov 01, 2014 at 10:55:01AM +0530, Sudip Mukherjee wrote:
On Fri, Oct 31, 2014 at 10:14:30PM -0700, Joe Perches wrote:
On Sat, 2014-11-01 at 10:35 +0530, Sudip Mukherjee wrote:
On Sat, Nov 01, 2014 at 10:47:22AM +0800, Chen Weixiang wrote:
Remove following code style errors from
On Sat, Nov 01, 2014 at 10:55:01AM +0530, Sudip Mukherjee wrote:
On Fri, Oct 31, 2014 at 10:14:30PM -0700, Joe Perches wrote:
On Sat, 2014-11-01 at 10:35 +0530, Sudip Mukherjee wrote:
On Sat, Nov 01, 2014 at 10:47:22AM +0800, Chen Weixiang wrote:
Remove following code style errors from
to be that Thunderbird thrashes empty lines when
double clicking the e-mail in Drafts or selecting Edit as new.
When forwarding the e-mail it doesn't seem to affect the empty lines,
very weird behaviour.
Regards,
Mikael
On 2014-10-29 06:25, Sudip Mukherjee wrote:
On Tue, Oct 28, 2014 at 09:07:00PM
On Wed, Oct 29, 2014 at 04:47:25PM +0800, Greg Kroah-Hartman wrote:
On Wed, Oct 22, 2014 at 02:24:46PM +0530, Sudip Mukherjee wrote:
we should be using DMA API rather than using bus specific DMA API.
Why?
as given in the DMA-API-HOWTO.txt :
the DMA API works with any bus independent
On Tue, Oct 28, 2014 at 09:07:00PM +0100, Mikael Svantesson wrote:
Signed-off-by: Mikael Svantesson mik...@distopic.net
still the same problem.
ERROR: patch seems to be corrupt (line wrapped?)
---
drivers/staging/skein/skein_api.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On Mon, Oct 27, 2014 at 03:12:57PM +0300, Dan Carpenter wrote:
On Mon, Oct 27, 2014 at 05:22:21PM +0530, Sudip Mukherjee wrote:
On Mon, Oct 27, 2014 at 02:13:12PM +0300, Dan Carpenter wrote:
On Sun, Oct 26, 2014 at 06:03:33PM +0530, Sudip Mukherjee wrote:
@@ -262,7 +257,7 @@ static u8
unused variables are removed. These variables were only assigned some
values and after that they were never being used. So they are safe to
be removed , and it has been build tested.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/rtl8712/hal_init.c| 9
On Sat, Oct 25, 2014 at 01:05:13AM +0100, Paul McQuade wrote:
ERROR: that open brace { should be on the previous line
Signed-off-by: Paul McQuade paulmcq...@gmail.com
---
drivers/staging/rtl8723au/core/rtw_ap.c | 130
++--
1 file changed, 40 insertions(+), 90
On Sat, Oct 25, 2014 at 12:22:32AM +0100, Paul McQuade wrote:
ERROR: that open brace { should be on the previous line
patch is corrupt.
thanks
sudip
Signed-off-by: Paul McQuade paulmcq...@gmail.com
---
drivers/staging/rtl8723au/core/rtw_ap.c | 137
++--
1
we should be using DMA API rather than using bus specific DMA API.
converted the occurrence of pci_map_*() to dma_map_*(),
and at the same time used the dma_mapping_error().
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 12
On Fri, Oct 10, 2014 at 11:09:20AM +0400, Igor Bogomazov wrote:
checkpatch.pl tiny fix
get rid of 2 warnings and 2 errors for hal/fw.c:
WARNING: braces {} are not necessary for single statement blocks
WARNING: line over 80 characters
ERROR: space required before the open brace '{'
ERROR:
On Thu, Oct 09, 2014 at 01:40:11PM +0900, Daeseok Youn wrote:
The dgap_init_module() need to unwind for cleanup variables properly.
Because dgap_init_module() calls dgap_cleanup_module() for freeing
variables but this function is possible to free variables
which are not allocated.
On Thu, Oct 09, 2014 at 05:03:07PM +0800, Jia He wrote:
Signed-off-by: Jia He hejia...@gmail.com
This fixes all coding style error problems at rtl8188eu which
makes checkpatch.pl unhappy
your commit message should be above your Signed-off line.
mention what type of error you are fixing.
you
On Thu, Oct 09, 2014 at 06:25:10PM +0800, WANG Chao wrote:
This fixes the following sparse error:
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.c:393:9: error:
incompatible types in comparison expression (different address spaces)
Signed-off-by: WANG Chao
On Fri, Sep 26, 2014 at 12:11:56AM +0100, Mike Roocroft wrote:
you forgot to write the commit message and also mention there what kind of
warning you have fixed.
thanks
sudip
Signed-off-by: Mike Roocroft mike.li...@btinternet.com
---
drivers/staging/android/sw_sync.c | 2 ++
1 file
On Sat, Sep 20, 2014 at 12:09:11PM +0100, Grzegorz Swirski wrote:
Signed-off-by: Grzegorz Swirski grzeg...@swirski.name
you have not mentioned any commit log
---
drivers/staging/wlan-ng/prism2mib.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git
fixed sparse warning : context imbalance in 'destroy_device'
unexpected unlock
this patch will generate warning from checkpatch for
lines over 80 character , but since those are user-visible strings
so it was not modified.
Signed-off-by: Sudip Mukherjee su
On Wed, Sep 10, 2014 at 08:29:26AM -0500, Romer, Benjamin M wrote:
On Tue, 2014-09-09 at 16:11 +0530, Sudip Mukherjee wrote:
fixed sparse warning : context imbalance in 'resume_device'
unexpected unlock
this patch will generate warning from checkpatch for
lines
fixed sparse warning : context imbalance in 'resume_device'
unexpected unlock
this patch will generate warning from checkpatch for
lines over 80 character , but since those are user-visible strings
so it was not modified.
Signed-off-by: Sudip Mukherjee su
On Mon, Sep 08, 2014 at 10:57:08AM -0500, Romer, Benjamin M wrote:
On Fri, 2014-09-05 at 14:52 +0530, Sudip Mukherjee wrote:
fixed sparse warning : context imbalance in 'pause_device'
unexpected unlock
this patch will generate warning from checkpatch for
lines over
On Mon, Sep 08, 2014 at 11:30:48AM -0500, Romer, Benjamin M wrote:
On Mon, 2014-09-08 at 21:57 +0530, Sudip Mukherjee wrote:
Hi Ben,
thanks. the same file is having two more similar warnings. if you want i can
resend a patch fixing all the three warnings , or i can send two separate
On Mon, Sep 08, 2014 at 11:48:44AM -0500, Romer, Benjamin M wrote:
On Mon, 2014-09-08 at 22:08 +0530, Sudip Mukherjee wrote:
Hi Ben,
sorry to disturb you again. i got confused , which one is perfect one
combined patch or
separate patches?
thanks
sudip
Two patches, as you
On Thu, Sep 04, 2014 at 07:16:11PM +0200, Lars-Peter Clausen wrote:
On 09/04/2014 07:12 PM, Sudip Mukherjee wrote:
On Thu, Sep 04, 2014 at 06:50:05PM +0200, Lars-Peter Clausen wrote:
On 09/04/2014 06:45 PM, Sudip Mukherjee wrote:
fixed sparse warning : incorrect type in argument 1
On Fri, Sep 05, 2014 at 12:34:13PM +0300, Dan Carpenter wrote:
On Thu, Sep 04, 2014 at 10:15:42PM +0530, Sudip Mukherjee wrote:
fixed sparse warning : incorrect type in argument 1
(different address spaces)
The change log is not clear. It's the IS_ERR() which
On Mon, Sep 01, 2014 at 08:47:12AM -0400, Dipak Zope wrote:
you have not mentioned any commit message .
thanks
sudip
Signed-off-by: Dipak Zope dipakzope.kernel@gmail.com
---
drivers/staging/android/uapi/binder.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Wed, Sep 03, 2014 at 12:59:50PM +0300, Dan Carpenter wrote:
On Wed, Sep 03, 2014 at 02:59:21PM +0530, Sudip Mukherjee wrote:
1) removed unused variables
2) fixed sparse warning of context imbalance in 'do_locked_client_insert'
different lock contexts for basic
fixed sparse warning : incorrect type in argument 1
(different address spaces)
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/iio/adc/mxs-lradc.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/iio/adc
please discard the patch. It generates additional sparse warning.
sorry for it.
thanks
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Thu, Sep 04, 2014 at 06:50:05PM +0200, Lars-Peter Clausen wrote:
On 09/04/2014 06:45 PM, Sudip Mukherjee wrote:
fixed sparse warning : incorrect type in argument 1
(different address spaces)
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging
From: Sudip Mukherjee sudipm.mukher...@gmail.com
removed unused variables
fixed sparse warning of context imbalance in 'do_locked_client_insert'
different lock contexts for basic block
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
v1 of the patch
On Wed, Sep 03, 2014 at 11:40:38AM +0300, Dan Carpenter wrote:
On Tue, Sep 02, 2014 at 11:46:35PM +0530, Sudip Mukherjee wrote:
From: Sudip Mukherjee su...@vectorindia.org
I really would prefer if you just figured out your email settings so
this isn't needed. The From: header is mostly
value
of the function is not beeing used, so it is safe to remove.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
v1 of the patch of the patch just fixed the sparse warning.
On suggestion of Dan Carpenter v2 is the total rewrite of the function.
change from v2 to v3 : i messed up
hi,
please do not consider this patch. v4 has been sent with some changes as
suggested by Dan Carpenter.
thanks
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Sep 03, 2014 at 02:29:44PM +0530, Sudip Mukherjee wrote:
On Wed, Sep 03, 2014 at 11:40:38AM +0300, Dan Carpenter wrote:
On Tue, Sep 02, 2014 at 11:46:35PM +0530, Sudip Mukherjee wrote:
From: Sudip Mukherjee su...@vectorindia.org
I really would prefer if you just figured out your
On Wed, Sep 03, 2014 at 04:09:59PM +0200, Piotr Witoslawski wrote:
Done as Eudyptula task 10.
use proper commit message mentioning what changes you have done.
and you have not sent the patch to all the people who were
supposed to be sent.
thanks
sudip
Signed-off-by: Piotr Witoslawski
On Wed, Sep 03, 2014 at 06:41:30PM +0300, Dan Carpenter wrote:
On Wed, Sep 03, 2014 at 08:13:25PM +0530, Sudip Mukherjee wrote:
On Wed, Sep 03, 2014 at 02:29:44PM +0530, Sudip Mukherjee wrote:
On Wed, Sep 03, 2014 at 11:40:38AM +0300, Dan Carpenter wrote:
On Tue, Sep 02, 2014 at 11:46
fixed sparse warning : context imbalance in 'do_locked_client_insert'
different lock contexts for basic block
spin_unlock_irqrestore is called at a later stage before returning
from the function if locked is 1.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
fixed sparse warning: incompatible types in comparison expression
(different address spaces)
wolw and reg both are being used only for the initialization of
the __iomem area.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/et131x/et131x.c | 4
On Tue, Sep 02, 2014 at 05:05:32PM +0300, Dan Carpenter wrote:
On Tue, Sep 02, 2014 at 04:39:47PM +0530, Sudip Mukherjee wrote:
fixed sparse warning : context imbalance in 'do_locked_client_insert'
different lock contexts for basic block
spin_unlock_irqrestore
On Tue, Sep 02, 2014 at 06:23:27PM +0300, Dan Carpenter wrote:
On Tue, Sep 02, 2014 at 08:44:27PM +0530, Sudip Mukherjee wrote:
On Tue, Sep 02, 2014 at 05:05:32PM +0300, Dan Carpenter wrote:
On Tue, Sep 02, 2014 at 04:39:47PM +0530, Sudip Mukherjee wrote:
fixed sparse warning : context
From: Sudip Mukherjee su...@vectorindia.org
removed unused variables
fixed sparse warning of context imbalance in 'do_locked_client_insert'
different lock contexts for basic block
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
v1 of the patch of the patch just
On Tue, Sep 02, 2014 at 11:24:02AM -0700, Greg Kroah-Hartman wrote:
On Tue, Sep 02, 2014 at 11:46:35PM +0530, Sudip Mukherjee wrote:
From: Sudip Mukherjee su...@vectorindia.org
removed unused variables
fixed sparse warning of context imbalance in 'do_locked_client_insert
On Mon, Sep 01, 2014 at 12:35:14PM +0300, Dan Carpenter wrote:
On Sun, Aug 31, 2014 at 09:46:22PM +0530, Sudip Mukherjee wrote:
@@ -133,9 +134,15 @@ static ssize_t goldfish_audio_read(struct file *fp,
char __user *buf,
AUDIO_READ_BUFFER_AVAILABLE
fixed sparse warning of following symbol not declared:
warning: symbol 'lnet_ptl_cleanup' was not declared. Should it be static?
warning: symbol 'lnet_ptl_setup' was not declared. Should it be static?
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
As of now these functions
fixed sparse warning of incorrect type in argument 1 and incorrect type in
argument 2
it was directly dereferencing a __iomem pointer , which will work in x86 but
will fail in other architectures.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
hi,
can you please reveiew the patch
Signed-off-by: Sudip Mukherjee sudipm.mukher...@gmail.com
---
drivers/staging/bcm/DDRInit.c | 59 ---
1 file changed, 39 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c
index 4564f40..4226c93
---
drivers/staging/bcm/DDRInit.c | 59 ---
1 file changed, 39 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c
index 4564f40..4226c93 100644
--- a/drivers/staging/bcm/DDRInit.c
+++
Signed-off-by: Sudip Mukherjee sudipm.mukher...@gmail.com
---
drivers/staging/bcm/Transmit.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/bcm/Transmit.c b/drivers/staging/bcm/Transmit.c
index 05fae92..622a482 100644
--- a/drivers/staging/bcm
901 - 962 of 962 matches
Mail list logo
