Re: [PATCH] staging: ks7010: replace DPRINTK traces in favour of preferred netdev_*

2018-03-13 Thread Dan Carpenter
On Tue, Mar 13, 2018 at 11:57:35AM +0100, Sergio Paracuellos wrote: > On Tue, Mar 13, 2018 at 11:04 AM, Dan Carpenter > wrote: > > It takes a long time to review this, not because it's hard but because > > I have to look at each line and think "Is this really a

Re: [PATCH] staging: ks7010: replace DPRINTK traces in favour of preferred netdev_*

2018-03-13 Thread Sergio Paracuellos
On Tue, Mar 13, 2018 at 11:04 AM, Dan Carpenter wrote: > It takes a long time to review this, not because it's hard but because > I have to look at each line and think "Is this really a worthwhile line > to keep?" and a lot of them are marginal but perhaps not

Re: [PATCH] staging: ks7010: replace DPRINTK traces in favour of preferred netdev_*

2018-03-13 Thread Dan Carpenter
It takes a long time to review this, not because it's hard but because I have to look at each line and think "Is this really a worthwhile line to keep?" and a lot of them are marginal but perhaps not necessarily bad? You've deleted some obviously rubbish printks but I feel you could have gone