Re: [PATCH 91/93] Staging: comedi: 8253.h fixed by removing 'return' from generic func

Oh, wow. No. All these patches are wrong but there are too many to discuss them individually. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

integer overflow in ll_fid2path()

Hi Oleg, The patch d7e09d0397e8: "staging: add Lustre file system client support" from May 2, 2013, leads to the following static checker warning: drivers/staging/lustre/lustre/llite/file.c:1730 ll_fid2path() error: memcpy() 'gfout' too small drivers/staging/lustre/lustre/llite/f

Re: [PATCH 6/8] staging: dgap: remove unneeded dgap_err()

Hi, Dan. 2014-07-15 15:47 GMT+09:00 Dan Carpenter : > On Tue, Jul 15, 2014 at 12:02:23PM +0900, Daeseok Youn wrote: >> The dgap_err() is printing a message with pr_err(), >> so all those are replaced. >> > > Take a look at how pr_fmt works. > > #define pr_fmt(fmt) "dgap: " fmt > > Then you can rem

Re: [PATCH 7/8] staging: dgap: introduce dgap_cleanup_nodes()

2014-07-15 15:41 GMT+09:00 Dan Carpenter : > On Tue, Jul 15, 2014 at 12:04:02PM +0900, Daeseok Youn wrote: >> When a configration file is parsed with dgap_parsefile(), >> makes nodes for saving configrations for board. >> >> Making a node will allocate node memory and strings for saving >> configra

[PATCH 01/22] Staging: bcm: PHSModule.c: Whitespace & Indentation cleanup

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/PHSModule.c | 589 ++-- 1 file changed, 384 insertions(+), 205 deletions(-) diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c index 4b6de76..79d84d7 100644 --- a/drivers/staging

[PATCH 02/22] Staging: bcm: PHSModule.c: Outsourced debug printing in own function

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/PHSModule.c | 95 - 1 file changed, 56 insertions(+), 39 deletions(-) diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c index 79d84d7..a6f0bf4 100644 --- a/drivers/staging/b

[PATCH 00/22] drivers/staging/bcm/PHSModule.c cleanup patches

Hi, this is my patchset for the drivers/staging/bcm/PHSModule.c file. It contains cleanup patches for * Replacing object->member->member constructs by variables * Shortenings of long lines * Whitespace cleanup * Chaining of nested if statements (if (foo) if (bar) => if (foo

[PATCH 08/22] Staging: bcm: PHSModule.c: Reduced indentation by using jump label in PhsDeleteSFRules()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/PHSModule.c | 66 + 1 file changed, 34 insertions(+), 32 deletions(-) diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c index 7ced228..4e6bcef 100644 --- a/drivers/staging/b

[PATCH 04/22] Staging: bcm: PHSModule.c: Replaced member accessing with variable in PhsDeletePHSRule()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/PHSModule.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c index f726f2e..55421ef 100644 --- a/drivers/staging/bcm/PHSModule.c +++ b/driver

[PATCH 06/22] Staging: bcm: PHSModule.c: Reduced indentation level by using jump label

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/PHSModule.c | 65 + 1 file changed, 34 insertions(+), 31 deletions(-) diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c index 89cc90c..a11474c 100644 --- a/drivers/staging/b

[PATCH 09/22] Staging: bcm: PHSModule.c: Replaced member accessing with variables

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/PHSModule.c | 40 1 file changed, 24 insertions(+), 16 deletions(-) diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c index 4e6bcef..6431912 100644 --- a/drivers/staging/bc

[PATCH 05/22] Staging: bcm: PHSModule.c: Replaced nested if statements with logical AND concatenation of the conditions

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/PHSModule.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c index 55421ef..89cc90c 100644 --- a/drivers/staging/bcm/PHSModule.c +++ b/

[PATCH 03/22] Staging: bcm: PHSModule.c: Outsourced debug printing for phs classifier entry

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/PHSModule.c | 47 + 1 file changed, 29 insertions(+), 18 deletions(-) diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c index a6f0bf4..f726f2e 100644 --- a/drivers/staging/b

[PATCH 07/22] Staging: bcm: PHSModule.c: Shortened lines

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/PHSModule.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c index a11474c..7ced228 100644 --- a/drivers/staging/bcm/PHSModule.c

[PATCH 10/22] Staging: bcm: PHSModule.c: Whitespace cleanup in PhsCompress()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/PHSModule.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c index 6431912..e01c5cf 100644 --- a/drivers/staging/bcm/PHSModule.c +++ b/drivers/stagin

[PATCH 11/22] Staging: bcm: PHSModule.c: Added missing braces around else block

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/PHSModule.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c index e01c5cf..e3db972 100644 --- a/drivers/staging/bcm/PHSModule.c +++ b/drivers/staging/bcm/P

[PATCH 12/22] Staging: bcm: PHSModule.c: Replaced member accessing with variable in free_phs_service()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/PHSModule.c | 32 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c index e3db972..d2aa9c9 100644 --- a/drivers/staging/bcm/PHSMod

[PATCH 16/22] Staging: bcm: PHSModule.c: Replaced member accessing with variable in GetServiceFlowEntry()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/PHSModule.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c index 47eff76..83bd12b 100644 --- a/drivers/staging/bcm/PHSModule.c +++ b/drivers/stagin

[PATCH 14/22] Staging: bcm: PHSModule.c: Rewrote ValidatePHSRuleComplete()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/PHSModule.c | 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c index c290178..9a24845 100644 --- a/drivers/staging/bcm/PHSModule.c +++ b

[PATCH 18/22] Staging: bcm: PHSModule.c: Simplified nested if statements by linking them with logical AND in GetServiceFlowEntry()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/PHSModule.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c index 5eec706..4074eb8 100644 --- a/drivers/staging/bcm/PHSModule.c +++ b/drivers/stagin

[PATCH 15/22] Staging: bcm: PHSModule.c: Added const keyword to ValidatePHSRUleComplete() argument

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/PHSModule.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c index 9a24845..47eff76 100644 --- a/drivers/staging/bcm/PHSModule.c +++ b/drivers/staging/bcm

[PATCH 19/22] Staging: bcm: PHSModule.c: Simplified nested if statements by linking them with logical AND in GetPhsRuleEntry()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/PHSModule.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c index 4074eb8..ceb5758 100644 --- a/drivers/staging/bcm/PHSModule.c +++ b/drivers/stagin

[PATCH 17/22] Staging: bcm: PHSModule.c: Simplified nested if statements by linking them with logical AND in GetServiceFlowEntry()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/PHSModule.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c index 83bd12b..5eec706 100644 --- a/drivers/staging/bcm/PHSModule.c +++ b/drivers/staging

[PATCH 20/22] Staging: bcm: PHSModule.c: Replaced member accessing with variable in CreateSFToClassifierRuleMapping()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/PHSModule.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c index ceb5758..bdc29a5 100644 --- a/drivers/staging/bcm/PHSModule.c +++ b/dr

Re: [PATCH 7/8] staging: dgap: introduce dgap_cleanup_nodes()

On Tue, Jul 15, 2014 at 04:32:27PM +0900, DaeSeok Youn wrote: > 2014-07-15 15:41 GMT+09:00 Dan Carpenter : > > On Tue, Jul 15, 2014 at 12:04:02PM +0900, Daeseok Youn wrote: > >> When a configration file is parsed with dgap_parsefile(), > >> makes nodes for saving configrations for board. > >> > >>

[PATCH 21/22] Staging: bcm: PHSModule.c: Replaced if-else return code with simple return assertion

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/PHSModule.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c index bdc29a5..805ecb0 100644 --- a/drivers/staging/bcm/PHSModule.c +++ b/drivers/stagi

[PATCH 22/22] Staging: bcm: PHSModule.c: Shortened lines

This patch shortenes all lines where possible without code refactoring, as well as comment lines. It does not change the wording of comments. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/PHSModule.c | 143 +--- 1 file changed, 89 insertions(+), 54 del

[PATCH 13/22] Staging: bcm: PHSModule.c: Replaced indentation level with goto jump on bad condition

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/PHSModule.c | 61 + 1 file changed, 32 insertions(+), 29 deletions(-) diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c index d2aa9c9..c290178 100644 --- a/drivers/staging/b

Re: [PATCH 06/22] Staging: bcm: PHSModule.c: Reduced indentation level by using jump label

On Tue, Jul 15, 2014 at 09:42:59AM +0200, Matthias Beyer wrote: > + > +out: > return 0; Don't do these do-nothing gotos. Just return directly. When you are reading the code and you see a goto then you have to think "Oh, I wonder what the goto does?" If has a good name like "err_free_foo"

Re: [PATCH 06/22] Staging: bcm: PHSModule.c: Reduced indentation level by using jump label

Btw, a jump label is something different. This is just a regular goto. http://lwn.net/Articles/412072/ http://lwn.net/Articles/436041/ regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/m

Re: [PATCH 8/8] staging: dgap: fix memory leak in dgap_parsefile()

2014-07-15 15:51 GMT+09:00 Dan Carpenter : > On Tue, Jul 15, 2014 at 12:05:14PM +0900, Daeseok Youn wrote: >> The p->u.board.status is allocated and set a string as >> "No" once within allocating a node of BNODE type. >> But it also set again with kstrdup() in case of "STATUS" >> or "ID". If it is

[PATCH 6/8 V2] staging: dgap: remove unneeded dgap_err()

The dgap_err() is printing a message with pr_err(), so all those are replaced. Use definition "pr_fmt" and then all of "dgap:" in the beginning of print messages are removed. And also removed "out of memory" message because the kernel has own message for that. Signed-off-by: Daeseok Youn --- V2

[PATCH 7/8 RESEND] staging: dgap: introduce dgap_cleanup_nodes()

When a configration file is parsed with dgap_parsefile(), makes nodes for saving configrations for board. Making a node will allocate node memory and strings for saving configrations with kstrdup(). So these are freed when dgap is unloaded or failed to initialize. Signed-off-by: Daeseok Youn --

[PATCH 8/8 V2] staging: dgap: fix memory leak in dgap_parsefile()

The p->u.board.status is allocated and set a string as "No" once within allocating a node of BNODE type. But it also set again with kstrdup() in case of "STATUS" or "ID". So just free this buffer and allocate again with kstrdup(). Signed-off-by: Daeseok Youn --- V2: just use kfree for buffers whi

Re: [PATCH 8/8] staging: dgap: fix memory leak in dgap_parsefile()

On Tue, Jul 15, 2014 at 06:05:35PM +0900, DaeSeok Youn wrote: > 2014-07-15 15:51 GMT+09:00 Dan Carpenter : > > On Tue, Jul 15, 2014 at 12:05:14PM +0900, Daeseok Youn wrote: > >> The p->u.board.status is allocated and set a string as > >> "No" once within allocating a node of BNODE type. > >> But it

Re: [PATCH 92/93] Staging: comedi: 8255: fixed by adding an empthy line

On 2014-07-15 04:15, sam-the-6 wrote: From: Sam Asadi fixed a coding style issue. Signed-off-by: Sam Asadi modified: drivers/staging/comedi/drivers/8255.c --- drivers/staging/comedi/drivers/8255.c | 150 - 1 file changed, 74 insertions(+), 76 dele

Re: [PATCH 8/8] staging: dgap: fix memory leak in dgap_parsefile()

2014-07-15 18:21 GMT+09:00 Dan Carpenter : > On Tue, Jul 15, 2014 at 06:05:35PM +0900, DaeSeok Youn wrote: >> 2014-07-15 15:51 GMT+09:00 Dan Carpenter : >> > On Tue, Jul 15, 2014 at 12:05:14PM +0900, Daeseok Youn wrote: >> >> The p->u.board.status is allocated and set a string as >> >> "No" once wi

[PATCH 1/8 RESEND] staging: dgap: remove redundant error value check

The retval in dgap_block_til_ready() is initialized to zero, and if no error has occurred in this function, the retval has a zero. So it doesn't need to check "retval" itself. Signed-off-by: Daeseok Youn --- RESEND: Adds Mark to TO list and CC list for checking send this email properly to him.

[PATCH 2/8 RESEND] staging: dgap: remove unused case value in dgap_parsefile()

If rc is zero, this function will returns with an error and cannot reach switch-case statement. Signed-off-by: Daeseok Youn --- RESEND : Adds Mark to TO list and CC list for checking send this email properly to him. drivers/staging/dgap/dgap.c |4 1 files changed, 0 insertions(+), 4 de

[PATCH 3/8 RESEND] staging: dgap: fix a typo in dgap_gettok()

The "boar" should be "board". Signed-off-by: Daeseok Youn --- RESEND : Adds Mark to TO list and CC list for checking send this email properly to him. drivers/staging/dgap/dgap.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/stagi

[PATCH 4/8 RESEND] staging: dgap: remove unused a parameter in dgap_gettok()

The "p" as parameter is unused. Signed-off-by: Daeseok Youn --- RESEND : Adds Mark to TO list and CC list for checking send this email properly to him. drivers/staging/dgap/dgap.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drive

[PATCH 5/8 RESEND] staging: dgap: remove dgap_newnode()

The dgap_newnode() is useless for creating new node. So just use kzalloc and set a type in case statement. Signed-off-by: Daeseok Youn --- RESEND : Adds Mark to TO list and CC list for checking send this email properly to him. drivers/staging/dgap/dgap.c | 104 ++---

Re: [PATCH 93/93] Staging: comedi: adl_pci9118: fixed style issues

On 2014-07-15 04:17, sam-the-6 wrote: From: Sam Asadi several style issues fixed. Signed-off-by: Sam Asadi modified: drivers/staging/comedi/drivers/adl_pci9118.c --- drivers/staging/comedi/drivers/adl_pci9118.c | 124 +- 1 file changed, 62 insertions(+),

Re: [PATCH 2/2] staging: comedi: addi_apci_1564: use addi_watchdog module to init watchdog subdevice

On 2014-07-15 05:00, Chase Southwood wrote: On Mon, Jul 14, 2014 at 4:22 AM, Ian Abbott wrote: On 2014-07-12 23:44, Chase Southwood wrote: Use the addi_watchdog module to provide support for the watchdog subdevice. Also, rearrange the subdevice init blocks so that the order makes sense. Digi

Re: [PATCH 91/93] Staging: comedi: 8253.h fixed by removing 'return' from generic func

On 2014-07-15 04:13, sam-the-6 wrote: From: Sam Asadi Signed-off-by: Sam Asadi modified: drivers/staging/comedi/drivers/8253.h --- drivers/staging/comedi/drivers/8253.h |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/8253.h

[PATCH v4 0/5] staging:iio:hmc5843: Few adjustments and support for hmc5983

This patch series modifies the hmc5843 driver to support the hmc5983 i2c and spi interfaces. v2: * Reverted the changed order of iio unregister and setting hmc mode to sleep v3: * Fixed bug introduced in the first patch * Readded few comment lines which have gone missing

[PATCH v4 2/5] staging:iio:hmc5843: Split hmc5843.c to multiple files

This patch splits hmc5843.c to multiple files - the interface-agnostic hmc5843_core.c, i2c specific hmc5843_i2c.c and header file hmc5843.h. This is another step to add support of SPI-enabled hmc5983. Signed-off-by: Josef Gajdusek --- drivers/staging/iio/magnetometer/Kconfig | 14 +-

[PATCH v4 3/5] staging:iio:hmc5843: register <-> value arrays now can have different lengths

Changed structure of struct hmc5843_chip_info to include length of translation arrays. Code previously using #defined constant has been changed accordingly. This allows to integrate devices which do have different amounts of available rates/scales. Signed-off-by: Josef Gajdusek --- drivers/stagi

[PATCH v4 1/5] staging:iio:hmc5843: Added regmap support

This patch changes hmc5843.c to use regmap. This provides transparent caching to the code as well as abstraction necessary to add support for SPI-based hmc5983. Signed-off-by: Josef Gajdusek --- drivers/staging/iio/magnetometer/Kconfig | 1 + drivers/staging/iio/magnetometer/hmc5843.c | 140

[PATCH v4 4/5] staging:iio:hmc5843: Add support for i2c hmc5983

This patch adds support for the hmc5983 i2c interface. This chip is almost identical to the hmc5883. The difference being added temperature compensation, additional available sample rate (220Hz) and an SPI interface. Signed-off-by: Josef Gajdusek --- drivers/staging/iio/magnetometer/Kconfig

[PATCH v4 5/5] staging:iio:hmc5843: Add support for spi hmc5983

This patch adds support for the hmc5983 spi interface. This chip is almost identical to the hmc5883. The difference being added temperature compensation, additional available sample rate (220Hz) and an SPI interface. Signed-off-by: Josef Gajdusek --- drivers/staging/iio/magnetometer/Kconfig

Re: [PATCH 00/22] drivers/staging/bcm/PHSModule.c cleanup patches

Looks good. Don't bother resending those patches I complained about, those are fine for now. Reviewed-by: Dan Carpenter regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinf

[PATCH 94/94] Staging: comedi: 3 files revised fixed style issues

From: Sam Asadi 3 files in 'staging/comedi/drivers/' revised again and style issues fixed Signed-off-by: Sam Asadi modified: drivers/staging/comedi/drivers/8253.h modified: drivers/staging/comedi/drivers/8255.c modified: drivers/staging/comedi/drivers/adl_pci9118.

Re: [PATCH 91/93] Staging: comedi: 8253.h fixed by removing 'return' from generic func

On Tue, Jul 15, 2014 at 06:13:19AM +0300, sam-the-6 wrote: > From: Sam Asadi > > Signed-off-by: Sam Asadi Where are the other 90 patches in this series, I only received 91, 92, 93, and 94. Wait, 94 out of 93 What is going on here? > > modified: drivers/staging/comedi/drivers/825

Re: [PATCH 92/93] Staging: comedi: 8255: fixed by adding an empthy line

On Tue, Jul 15, 2014 at 06:15:44AM +0300, sam-the-6 wrote: > From: Sam Asadi > > fixed a coding style issue. Your Subject: does not match the body of the patch at all, why not? Please be descriptive as to what you are doing. Also, only do one thing per patch, and "one thing" is NOT "fix all co

Re: [PATCH 94/94] Staging: comedi: 3 files revised fixed style issues

On Tue, Jul 15, 2014 at 04:19:22PM +0300, sam-the-6 wrote: > From: Sam Asadi > > 3 files in 'staging/comedi/drivers/' revised again > and style issues fixed > > Signed-off-by: Sam Asadi > > modified: drivers/staging/comedi/drivers/8253.h > modified: drivers/staging/comedi/drive

[PATCH] staging: unisys: added virtpci info entry

This patch adds the virtpci debugfs directory and the info entry inside of it. Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- v4: Fixed comments, upper bound buffer, removed #define for virtpci and info, modified printvbus to work with scnprintf and added and extra element t

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

On 07/15/2014 09:11 AM, Chen Gang wrote: > > > On 07/15/2014 08:53 AM, Guenter Roeck wrote: >> On 07/14/2014 05:34 PM, Chen Gang wrote: >>> On 07/14/2014 05:22 PM, Chen Gang wrote: 在 2014年7月14日，下午4:57，Richard Weinberger 写道： > Am 14.07.2014 10:48, schrieb Lars-Peter Clausen: >>

[PATCH 1/1] staging: comedi: fixes of checkpatch.pl warnings

From: kinka Signed-off-by: Kinka Huang --- drivers/staging/comedi/comedi.h | 8 drivers/staging/comedi/comedi_fops.c | 9 - drivers/staging/comedi/comedidev.h | 4 ++-- 3 files changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/staging/comedi/comedi.h b/dri

Re: [PATCH 1/1] staging: comedi: fixes of checkpatch.pl warnings

On Tue, Jul 15, 2014 at 10:39:02PM +0800, Kinka Huang wrote: > From: kinka Don't put this line. Which kind of checkpatch warning? Also put mention that in the subject as well. > > Signed-off-by: Kinka Huang regards, dan carpenter ___ devel mailin

Re: [PATCH] staging: unisys: added virtpci info entry

On Tue, Jul 15, 2014 at 10:36:43AM -0400, Erik Arfvidson wrote: > This patch adds the virtpci debugfs directory and the info entry > inside of it. > > Signed-off-by: Erik Arfvidson > Signed-off-by: Benjamin Romer > --- > v4: Fixed comments, upper bound buffer, removed #define for virtpci and inf

Re: [PATCH 1/1] staging: comedi: fixes of checkpatch.pl warnings

On Tue, Jul 15, 2014 at 10:39:02PM +0800, Kinka Huang wrote: > From: kinka I need a "real" name here please. Also, describe what fixes you are doing in this patch, be descriptive. care to try it again? thanks, greg k-h ___ devel mailing list de...@l

Re: [PATCH V4 1/6] staging: vt6556: Cleanup trivial coding style issues

On Mon, Jul 14, 2014 at 09:15:28PM +0200, Peter Senna Tschudin wrote: > This patch cleans up the following checkpatch issues: > - tabs instead of spaces on the beginning of a line > - use correct /* */ comment style > - put { and } on the correct places > - line over 80 chars > - indentation s

Re: [PATCH V4 4/6] staging: vt6556: Remove typedefs

On Mon, Jul 14, 2014 at 09:15:31PM +0200, Peter Senna Tschudin wrote: > This patch removes uneeded typedefs reported by chackpatch and removes > one enum. The removed enum from card.h: > > typedef enum _CARD_PHY_TYPE { > PHY_TYPE_AUTO = 0, > PHY_TYPE_11B, > PHY_TYPE_11G, > PHY_TYPE

Re: [PATCH V4 6/6] staging: vt6556: Replace printk by pr_warn

On Mon, Jul 14, 2014 at 09:15:33PM +0200, Peter Senna Tschudin wrote: > This patch fixes a checkpatch warning by replacing printk by pr_warn. > > Tested by compilation only. > > Signed-off-by: Peter Senna Tschudin > --- > Cahnges from V3: > - Splitted the patches by change type > > drivers/st

Re: [PATCH V4 5/6] staging: vt6556: Cleanup indentation on statements

On Mon, Jul 14, 2014 at 09:15:32PM +0200, Peter Senna Tschudin wrote: > Use tabs instead of spaces in a set of statements and fix lines > over 80 chars. Reported by checkpatch. > > Tested by compilation only. > > Signed-off-by: Peter Senna Tschudin > --- > Cahnges from V3: > - Splitted the patc

[PATCH 1/1] staging: comedi: removing not useful `else` after return

Signed-off-by: Kinka Huang --- drivers/staging/comedi/comedi.h | 8 drivers/staging/comedi/comedi_fops.c | 9 - drivers/staging/comedi/comedidev.h | 4 ++-- 3 files changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/c

Re: [PATCH 6/8 V2] staging: dgap: remove unneeded dgap_err()

On Tue, Jul 15, 2014 at 06:11:44PM +0900, Daeseok Youn wrote: > The dgap_err() is printing a message with pr_err(), > so all those are replaced. > > Use definition "pr_fmt" and then all of "dgap:" in > the beginning of print messages are removed. > > And also removed "out of memory" message becau

Re: [PATCH] staging: unisys: added virtpci info entry

On 07/15/2014 10:45 AM, Greg KH wrote: [SNIP] +#define MAX_BUF 16384 Lovely magic number, care to explain why this is this size? Assuming we have the maximum possible configuration: 4 busses, 32 devices per bus, and we assume max of 80 characters per linegives us 10,560 bytes which rounds up t

Re: [PATCH 7/8 RESEND] staging: dgap: introduce dgap_cleanup_nodes()

On Tue, Jul 15, 2014 at 06:14:25PM +0900, Daeseok Youn wrote: > When a configration file is parsed with dgap_parsefile(), > makes nodes for saving configrations for board. configuration files should not be parsed in the kernel at all. That logic should be removed as it should not be needed. Mark

[PATCH] staging: unisys: added virtpci info entry

This patch adds the virtpci debugfs directory and the info entry inside of it. Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- v5: Adjusted comments and formatting, remove unused function v4: Fixed comments, upper bound buffer, removed #define for virtpci and info, modified p

Re: [PATCH] staging: unisys: added virtpci info entry

On Tue, Jul 15, 2014 at 11:31:03AM -0400, Erik Arfvidson wrote: > > On 07/15/2014 10:45 AM, Greg KH wrote: > >[SNIP] > >+#define MAX_BUF 16384 > >Lovely magic number, care to explain why this is this size? > > Assuming we have the maximum possible configuration: > 4 busses, 32 devices per bus, an

Re: [PATCH] staging: unisys: added virtpci info entry

On Tue, Jul 15, 2014 at 11:38:16AM -0400, Erik Arfvidson wrote: > This patch adds the virtpci debugfs directory and the info entry > inside of it. > > Signed-off-by: Erik Arfvidson > Signed-off-by: Benjamin Romer > --- > v5: Adjusted comments and formatting, remove unused function What unused f

[PATCH] Staging:tidspbridge Fix checkpatch.pl warning char * array declaration might be better as static const

From: Adithya Krishnamurthy Fixed checkpatch "WARNING: char * array declaration might be better as static const" Signed-off-by: Adithya Krishnamurthy --- drivers/staging/tidspbridge/core/io_sm.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/tidspb

[PATCH] Staging:tidspbridge Fix minor checkpatch.pl warning unnecessary whitespace before a quoted newline

From: Adithya Krishnamurthy Fixed checkpatch "WARNING: unnecessary whitespace before a quoted newline" Signed-off-by: Adithya Krishnamurthy --- drivers/staging/tidspbridge/core/tiomap3430.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/tidspbridge/core/

[PATCH] Staging:tidspbridge Fix minor checkpatch.pl warining Unnecessary parentheses

From: Adithya Krishnamurthy Fixed checkpatch "WARNING: Unnecessary parentheses" Signed-off-by: Adithya Krishnamurthy --- drivers/staging/tidspbridge/dynload/cload.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/tidspbridge/dynload/cload.c b/drivers/sta

[PATCH 01/94] ARM: shmobile: Add DT and defconfigs to MAINTAINERS

From: Simon Horman There are a number of DT and defconfig files which are maintained as part of shmobile but have not been listed as such in the MAINTAINERS file. This creates confusion from time to time. Signed-off-by: Simon Horman Signed-off-by: sam-the-6 --- MAINTAINERS | 14

Re: [PATCH 01/94] ARM: shmobile: Add DT and defconfigs to MAINTAINERS

On Tue, Jul 15, 2014 at 07:53:07PM +0300, Sam Asadi wrote: > From: Simon Horman > > There are a number of DT and defconfig files which > are maintained as part of shmobile but have not been > listed as such in the MAINTAINERS file. This creates > confusion from time to time. > > Signed-off-by: S

[PATCH 01/94] ARM: shmobile: Add DT and defconfigs to MAINTAINERS

From: Simon Horman There are a number of DT and defconfig files which are maintained as part of shmobile but have not been listed as such in the MAINTAINERS file. This creates confusion from time to time. Signed-off-by: Simon Horman Signed-off-by: sam-the-6 --- MAINTAINERS | 14

[PATCH 05/94] clk: ti: set CLK_SET_RATE_NO_REPARENT for ti,mux-clock

From: Tomi Valkeinen When setting the rate of a clock, by default the clock framework will change the parent of the clock to the most suitable one in __clk_mux_determine_rate() (most suitable by looking at the clock rate). This is a rather dangerous default, and causes problems on AM43x when usi

[PATCH 04/94] clk: ti: am43x: Fix boot with CONFIG_SOC_AM33XX disabled

From: Roger Quadros Define ti_clk_register_dpll_x2() and of_ti_am3_dpll_x2_setup() if AM43XX is defined. Fixes the below boot issue. [2.157258] gpmc_l3_clk not enabled [2.161194] gpmc_l3_clk not enabled [2.164896] Division by zero in kernel. [2.169055] CPU: 0 PID: 321 Comm: kwor

[PATCH 07/94] clk: samsung: add more aliases for s3c24xx

From: Vasily Khoruzhick Without these aliases clock lookup fails in s3c2410fb, s3cmci, s3c2410-nand, s3c24xx-i2s, and i2c-s3c2410 drivers. Signed-off-by: Vasily Khoruzhick Reviewed-by: Heiko Stuebner Signed-off-by: Tomasz Figa Signed-off-by: sam-the-6 --- drivers/clk/samsung/clk-s3c2410.c |

[PATCH 03/94] clk: ti: dra7: return error code in failure case

From: Julia Lawall Add a returned error code in the MAX_APLL_WAIT_TRIES case. Remove the updating of the return variable r to 0 if MAX_APLL_WAIT_TRIES is not yet reached, because r is already 0 at this point. Signed-off-by: Julia Lawall Signed-off-by: Tero Kristo Signed-off-by: sam-the-6 ---

[PATCH 12/94] dma: cppi41: handle 0-length packets

From: Daniel Mack When a 0-length packet is received on the bus, desc->pd0 yields 1, which confuses the driver's users. This information is clearly wrong and not in accordance to the datasheet, but it's been observed on an AM335x board, very reproducible. Fix this by looking at bit 19 in PD2 of

[PATCH 09/94] clk: s3c64xx: Hookup SPI clocks correctly

From: Charles Keepax In the move to this clock driver the hookups for the SPI clocks were dropped, which causes my system Cragganmore (s3c6410 based) to be unable to locate any spibus clocks. This patch adds them back in. When taking the clock from the epll clock (SCLK) the rates on the SPI bus

[PATCH 08/94] clk: samsung: exynos4: Remove SRC_MASK_ISP gates

From: Tomasz Figa ISP special clocks have dedicated gating registers and so MUX SRC_MASK register should not be used. This patch fixes the problem of Exynos4x12-based boards freezing on system suspend, because those mux outputs need not to be masked while suspending. Signed-off-by: Tomasz Figa

[PATCH 15/94] clk: sunxi: fix devm_ioremap_resource error detection code

From: Himangi Saraogi devm_ioremap_resource returns an ERR_PTR value, not NULL, on failure. A simplified version of the semantic match that finds this problem is as follows: // @@ expression e,e1; statement S; @@ *e = devm_ioremap_resource(...); if (!e1) S // Signed-off-by: Himangi Saraogi

[PATCH 11/94] clk: exynos5420: Remove aclk66_peric from the clock tree description

From: Doug Anderson The "aclk66_peric" clock is a gate clock with a whole bunch of gates underneath it. This big gate isn't very useful to include in our clock tree. If any of the children need to be turned on then the big gate will need to be on anyway. ...and there are plenty of other "big g

[PATCH 32/94] ext4: clarify error count warning messages

From: Theodore Ts'o Make it clear that values printed are times, and that it is error since last fsck. Also add note about fsck version required. Signed-off-by: Pavel Machek Signed-off-by: Theodore Ts'o Reviewed-by: Andreas Dilger Cc: sta...@vger.kernel.org Signed-off-by: sam-the-6 --- fs/e

[PATCH 22/94] ARM: dts: fix pwm-cells in pwm node for exynos4

From: Jaewon Kim pwm-cells should be 3. Third cell is optional PWM flags. And This flag supported by this binding is PWM_POLARITY_INVERTED. Signed-off-by: Jaewon Kim Reviewed-by: Sachin Kamat Signed-off-by: Kukjin Kim Signed-off-by: sam-the-6 --- arch/arm/boot/dts/exynos4.dtsi |2 +- 1

[PATCH 24/94] clocksource: exynos_mct: Register the timer for stable udelay

From: Amit Daniel Kachhap This patch registers the exynos mct clocksource as the current timer as it has constant clock rate. This will generate correct udelay for the exynos platform and avoid using unnecessary calibrated jiffies. This change has been tested on exynos5420 based board and udelay

[PATCH 21/94] ARM: EXYNOS: Fix the check for non-smp configuration

From: Abhilash Kesavan Commit 1754c42e3db5("ARM: exynos: move sysram info to exynos.c") missed out the CONFIG_ prefix causing exynos_sysram_init() to get called twice for SMP configurations. Signed-off-by: Abhilash Kesavan Reviewed-by: Sachin Kamat Signed-off-by: Kukjin Kim Signed-off-by: sam

[PATCH 82/94] ext4: fix a potential deadlock in __ext4_es_shrink()

From: Theodore Ts'o This fixes the following lockdep complaint: [ INFO: possible circular locking dependency detected ] 3.16.0-rc2-mm1+ #7 Tainted: G O --- kworker/u24:0/4356 is trying to acquire lock: (&(&sbi->s_es_lru_lock)->rlock)

[PATCH 10/94] clk/exynos5250: fix bit number for tv sysmmu clock

From: Rahul Sharma Change bit from 2 to 9 for tv (mixer) sysmmu clock. Signed-off-by: Rahul Sharma Reviewed-by: Sachin Kamat Acked-by: Kukjin Kim Signed-off-by: Tomasz Figa Signed-off-by: sam-the-6 --- drivers/clk/samsung/clk-exynos5250.c |2 +- 1 file changed, 1 insertion(+), 1 deleti

[PATCH 36/94] ARM: DRA7: hwmod: Fixup SATA hwmod

From: Roger Quadros Get rid of optional clock as that is now managed by the AHCI platform driver. Correct .mpu_rt_idx to 1 as the module register space (SYSCONFIG..) is passed as the second memory resource in the device tree. Signed-off-by: Roger Quadros Reviewed-by: Rajendra Nayak Tested-by:

[PATCH 28/94] iio: hid-sensor-als: Fix return values

From: Sachin Kamat IIO_CHAN_INFO_SAMP_FREQ and IIO_CHAN_INFO_HYSTERESIS cases ignored the actual return values (which could be -EINVAL) and instead returned IIO_VAL_INT_PLUS_MICRO always. Return the actual value obtained from the functions. Both functions return IIO_VAL_INT_PLUS_MICRO upon succes

[PATCH 77/94] Documentation/Changes: clean up mcelog paragraph

From: Paul Bolle The paragraph on mcelog currently describes kernel v2.6.31. In that kernel the mce code (for i386, that is) was in transition. Ever since v2.6.32 the situation is much simpler (eg, mcelog is now needed to process events on almost all x86 machines, i386 and x86-64). Since this "do

[PATCH 19/94] clk: qcom: HDMI source sel is 3 not 2

From: Stephen Boyd The HDMI PLL input to the tv mux is supposed to be 3, not 2. Fix the code so that we can properly select the HDMI PLL. Fixes: 6d00b56fe "clk: qcom: Add support for MSM8960's multimedia clock controller (MMCC)" Reported-by: Rob Clark Signed-off-by: Stephen Boyd Signed-off-by

[PATCH 90/94] Staging: comedi: 8253.h fixed by removing 'return' from generic func

Signed-off-by: Sam Asadi modified: drivers/staging/comedi/drivers/8253.h Signed-off-by: sam-the-6 --- drivers/staging/comedi/drivers/8253.h |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/8253.h b/drivers/staging/comedi/drivers/

[PATCH 86/94] parisc: drop unused defines and header includes

From: Helge Deller Signed-off-by: Helge Deller Cc: sta...@vger.kernel.org # 3.13+ Signed-off-by: sam-the-6 --- arch/parisc/kernel/sys_parisc32.c | 36 1 file changed, 36 deletions(-) diff --git a/arch/parisc/kernel/sys_parisc32.c b/arch/parisc/kernel/sy

  1   2   3   >