On Sun, Aug 09, 2015 at 05:08:41PM +0300, Tomas Melin wrote:
> Return NULL instead of 0 for invalid input.
>
> Signed-off-by: Tomas Melin
Signed-off-by: Andrey Shvetsov
> ---
> drivers/staging/most/hdm-dim2/dim2_hal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dri
On Mon, Aug 10, 2015 at 02:51:22PM -0700, Joe Perches wrote:
> Using 'extern' is not necessary for function prototypes.
>
We use them to mark dependency inversions (callbacks).
I thought about comments instead of, but I'm not sure what is worse.
--
Regards,
Andrey
___
Hello Ondrej Zary,
The patch e161a440af56: "staging: ft1000-pcmcia: remove support for
v5 firmware" from Jul 1, 2011, leads to the following static checker
warning:
drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c:513 card_download()
warn: condition implies we already warned.
d
This was supposed to bitwise AND but there is a typo.
Fixes: 1a02387063fb ('staging: comedi: me4000: remove 'board' from
me4000_ai_insn_read()')
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/comedi/drivers/me4000.c
b/drivers/staging/comedi/drivers/me4000.c
index 5aa1780..15a5320 10
This is a patch to the mostcore/core.c file. It makes
several local functions and structures static to prevent global
visibility.
Signed-off-by: Adrian Remonda
---
v6: fixed warning "line over 80 characters" as pointed out by
Sudip Mukherjee
drivers/staging/most/mostcore/core.c | 15
This is a patch to the most/hdm-usb/hdm_usb.c file. It
makes several local functions and structures static to prevent global
visibility.
Signed-off-by: Adrian Remonda
---
v6: fixed alignment with parameter list of a function.
drivers/staging/most/hdm-usb/hdm_usb.c | 16
1 fil
This patch fixes the warning generated by sparse: "Using plain integer
as NULL pointer" by replacing the offending 0 with NULL.
Signed-off-by: Adrian Remonda
---
drivers/staging/most/hdm-dim2/dim2_hal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/hdm-
This patch fixes the warning generated by sparse: "Using plain integer
as NULL pointer" by replacing the offending 0 with NULL.
Signed-off-by: Adrian Remonda
---
v6: styling. Change the NULL test to comply with the Kernel coding style
drivers/staging/most/mostcore/core.c | 2 +-
1 file changed
This patch series fix several warnings reported by the Sparse tool
v2: Fixed patch format and comments as noted by
Greg Kroah-Hartman and clear a few more warnings
v3: Fixed patch format as noted by Greg Kroah-Hartman
v4: Fixed patch format as noted by Greg Kr
This is a patch to the most/aim_cdev.c file. It makes several
local functions and structures static to prevent global visibility.
Signed-off-by: Adrian Remonda
---
drivers/staging/most/aim-cdev/cdev.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/
Without including ptlrpc_internal.h, GCC gives prototype warnings
"pack_generic.c:642:5: warning: no previous prototype for ..."
and sparse also complains "pack_generic.c:642:5: warning: symbol
'lustre_unpack_req_ptlrpc_body' was not declared. ..."
Signed-off-by: Ioan-Adrian Ratiu
---
drivers/st
On Fri, Aug 14, 2015 at 11:42 AM, Adrian Remonda
wrote:
> This patch fixes the warning generated by sparse: "Using plain integer
> as NULL pointer" by replacing the offending 0 with NULL.
>
> Signed-off-by: Adrian Remonda
> ---
> v6: styling. Change the NULL test to comply with the Kernel coding
This patch series fix several warnings reported by the Sparse tool
v2: Fixed patch format and comments as noted by
Greg Kroah-Hartman and clear a few more warnings
v3: Fixed patch format as noted by Greg Kroah-Hartman
v4: Fixed patch format as noted by Greg Kr
This is a patch to the mostcore/core.c file. It makes
several local functions and structures static to prevent global
visibility.
Signed-off-by: Adrian Remonda
---
drivers/staging/most/mostcore/core.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/sta
This is a patch to the most/hdm-usb/hdm_usb.c file. It
makes several local functions and structures static to prevent global
visibility.
Signed-off-by: Adrian Remonda
---
drivers/staging/most/hdm-usb/hdm_usb.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/d
This is a patch to the most/aim_cdev.c file. It makes several
local functions and structures static to prevent global visibility.
Signed-off-by: Adrian Remonda
---
drivers/staging/most/aim-cdev/cdev.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/
This patch fixes the warning generated by sparse: "Using plain integer
as NULL pointer" by replacing the offending 0 with NULL.
Signed-off-by: Adrian Remonda
---
drivers/staging/most/hdm-dim2/dim2_hal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/hdm-
This patch fixes the warning generated by sparse: "Using plain integer
as NULL pointer" by replacing the pointer test against 0 with a logical test.
Signed-off-by: Adrian Remonda
---
drivers/staging/most/mostcore/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/
On 14/08/15 09:54, Dan Carpenter wrote:
This was supposed to bitwise AND but there is a typo.
Fixes: 1a02387063fb ('staging: comedi: me4000: remove 'board' from
me4000_ai_insn_read()')
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/comedi/drivers/me4000.c
b/drivers/staging/comedi/
Hi Mauro,
On Wed, Aug 12, 2015 at 05:14:51PM -0300, Mauro Carvalho Chehab wrote:
> Currently, media_entity_init() creates an array with the links,
> allocated at init time. It provides a parameter (extra_links)
> that would allocate more links than the current needs, but this
> is not used by any
On Fri, Aug 14, 2015 at 10:36:35AM +0200, Andrey Shvetsov wrote:
> On Mon, Aug 10, 2015 at 02:51:22PM -0700, Joe Perches wrote:
> > Using 'extern' is not necessary for function prototypes.
> >
> We use them to mark dependency inversions (callbacks).
> I thought about comments instead of, but I'm n
Em Fri, 14 Aug 2015 13:33:48 +0300
Sakari Ailus escreveu:
> Hi Mauro,
>
> On Wed, Aug 12, 2015 at 05:14:51PM -0300, Mauro Carvalho Chehab wrote:
> > Currently, media_entity_init() creates an array with the links,
> > allocated at init time. It provides a parameter (extra_links)
> > that would al
Hi,
On Thu, Aug 13, 2015 at 12:16:43PM -0700, David Daney wrote:
> On 08/13/2015 06:21 AM, Aaro Koskinen wrote:
> >Currently mainline Linux is unusable on OCTEON II CN68XX SOCs due to
> >issues in Ethernet driver initialization. Some boards are hanging during
> >init, and all the needed register d
On Fri, 14 Aug 2015, Moritz Fischer wrote:
> Hi Alan,
>
> I've updated my Zynq driver (it can be found in an older version
> against your v8 in the Xilinx tree, too)
>
> https://github.com/mfischer/linux/tree/alan-fpga-mgr-v10
Since we are both already using this and have been for a while now,
On Thu, 13 Aug 2015, Moritz Fischer wrote:
Hi Moritz,
Thanks for the review. Will include your two nits in v11.
> Hi Alan,
>
> thanks for continuing to work on this :) A couple of minor nits ...
>
> On Thu, Aug 13, 2015 at 10:37 AM, wrote:
> > From: Alan Tull
> >
> > Add a document on the
Currently, media_entity_init() creates an array with the links,
allocated at init time. It provides a parameter (extra_links)
that would allocate more links than the current needs, but this
is not used by any driver.
As we want to be able to do dynamic link allocation/removal,
we'll need to change
On 08/14/2015 04:56 PM, Mauro Carvalho Chehab wrote:
> Currently, media_entity_init() creates an array with the links,
> allocated at init time. It provides a parameter (extra_links)
> that would allocate more links than the current needs, but this
> is not used by any driver.
>
> As we want to be
Hi Mauro,
Thank you for the patch.
On Friday 14 August 2015 11:56:38 Mauro Carvalho Chehab wrote:
> Currently, media_entity_init() creates an array with the links,
> allocated at init time. It provides a parameter (extra_links)
> that would allocate more links than the current needs, but this
> i
On Fri, 14 Aug 2015, atull wrote:
> On Fri, 14 Aug 2015, Moritz Fischer wrote:
>
> > Hi Alan,
> >
> > I've updated my Zynq driver (it can be found in an older version
> > against your v8 in the Xilinx tree, too)
> >
> > https://github.com/mfischer/linux/tree/alan-fpga-mgr-v10
>
> Since we are
dm_odm was being checked for NULL after dereferencing it. Lets check for
NULL first before derefenrencing it.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl818
On Thursday, August 13, 2015 2:29 AM, Ian Abbott wrote:
> On 13/08/15 01:00, H Hartley Sweeten wrote:
>> The comedi_offset_munge() helper is used to convert unsigned int data
>> values from the comedi offset binary format to two's complement values
>> for hardware that needs the data in that format
Fix a macro with complex value coding style error.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/gdm72xx/usb_ids.h | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/gdm72xx/usb_ids.h
b/drivers/staging/gdm72xx/usb_ids.h
index 8ce544d..7afb9ba 100644
-
On Thursday, August 13, 2015 2:42 AM, Ian Abbott wrote:
> On 12/08/15 21:25, H Hartley Sweeten wrote:
>> The watchdog is stopped in apci3501_write_insn_timer() by writing a 0 to
>> the timer control register. There is no need to read the register first
>> and mask it (as done when the timer is used
This patch enables setting the module's debug options WARN and INFO in the
debugfs file 'wilc_debug_level'. This enables the user to enable logging
of warning and other information. Before this change writes to this
debugfs file sets only one option DGB. This is additional to the default
option
On Thursday, August 13, 2015 7:29 AM, Ian Abbott wrote:
> On 12/08/15 19:39, Dan Carpenter wrote:
>> On Wed, Aug 12, 2015 at 10:30:47AM -0700, H Hartley Sweeten wrote:
>>> @@ -1061,6 +1061,14 @@ static int do_chaninfo_ioctl(struct comedi_device
>>> *dev,
>>> if (it.maxdata_list) {
>>>
On Friday, August 14, 2015 3:29 AM, Ian Abbott wrote:
> On 14/08/15 09:54, Dan Carpenter wrote:
>> This was supposed to bitwise AND but there is a typo.
>>
>> Fixes: 1a02387063fb ('staging: comedi: me4000: remove 'board' from
>> me4000_ai_insn_read()')
>> Signed-off-by: Dan Carpenter
>>
>> diff -
On 14/08/15 18:03, Hartley Sweeten wrote:
On Thursday, August 13, 2015 2:29 AM, Ian Abbott wrote:
On 13/08/15 01:00, H Hartley Sweeten wrote:
The comedi_offset_munge() helper is used to convert unsigned int data
values from the comedi offset binary format to two's complement values
for hardware
Add some missing space to quiet the checkpatch.pl issues about:
CHECK: spaces preferred around that '/' (ctx:VxV)
CHECK: spaces preferred around that '+' (ctx:VxV)
CHECK: spaces preferred around that '*' (ctx:VxV)
CHECK: spaces preferred around that '-' (ctx:VxV)
Signed-off-by: H Hartley Sweeten
Fix some minor checkpatch.pl issues and use the comedi_offset_munge()
helper to do the two's complement to offset binary munging.
v2: drop patch 4 from the orignal series
Ian Abbott did not want to add the mask to comedi_offset_munge()
H Hartley Sweeten (4):
staging: comedi: usbduxsigma: ad
As suggested by checkpatch.pl:
CHECK: Prefer kernel type 'u8' over 'uint8_t'
CHECK: Prefer kernel type 'u32' over 'uint32_t'
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxsigma.c | 39 ++--
1 file change
Use the comedi_offset_munge() helper to convert the hardware two's
complement values to the offset binary format expected by comedi.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxsigma.c | 11 ---
1 file changed, 4 inser
Merge the two comments and format it in the kernel CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxsigma.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/usb
On Friday, August 14, 2015 10:53 AM, Ian Abbott wrote:
> My argument is that comedi_offset_munge() shouldn't be responsible for
> stripping these extra bits, it should be the driver's responsibility to
> do that before calling comedi_offset_munge().
OK. I dropped this patch from the series and j
Fix some minor checkpatch.pl issues and use the comedi_offset_munge()
helper to do the two's complement to offset binary munging.
v2: drop patch 4 from the orignal series
Ian Abbott did not want to add the mask to comedi_offset_munge()
v3: remove an extra ';' in patch 4. Sorry about the noise
Add some missing space to quiet the checkpatch.pl issues about:
CHECK: spaces preferred around that '/' (ctx:VxV)
CHECK: spaces preferred around that '+' (ctx:VxV)
CHECK: spaces preferred around that '*' (ctx:VxV)
CHECK: spaces preferred around that '-' (ctx:VxV)
Signed-off-by: H Hartley Sweeten
As suggested by checkpatch.pl:
CHECK: Prefer kernel type 'u8' over 'uint8_t'
CHECK: Prefer kernel type 'u32' over 'uint32_t'
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxsigma.c | 39 ++--
1 file change
Hi Alan,
On Fri, Aug 14, 2015 at 8:46 AM, atull wrote:
> On Fri, 14 Aug 2015, atull wrote:
>
>> On Fri, 14 Aug 2015, Moritz Fischer wrote:
>>
>> > Hi Alan,
>> >
>> > I've updated my Zynq driver (it can be found in an older version
>> > against your v8 in the Xilinx tree, too)
>> >
>> > https://gi
Merge the two comments and format it in the kernel CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxsigma.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/usb
Use the comedi_offset_munge() helper to convert the hardware two's
complement values to the offset binary format expected by comedi.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxsigma.c | 11 ---
1 file changed, 4 inser
Replace C99 // comments by /* comments */ to follow the kernel
coding style.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/vt6655/rf.c | 535 ++--
1 file changed, 269 insertions(+), 266 deletions(-)
diff --git a/drivers/staging/vt6655/rf.c b/drivers
On Friday 14 August 2015 10:50:17 Dan Carpenter wrote:
> Hello Ondrej Zary,
>
> The patch e161a440af56: "staging: ft1000-pcmcia: remove support for
> v5 firmware" from Jul 1, 2011, leads to the following static checker
> warning:
>
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c:513 card
Rather than hard coding the number of elements in the array, use the
ARRAY_SIZE()
macro to compute the number of elements in the array. This would minimize the
changes needed when we have to extend the protocols supported.
This was suggested by Johannes Thumshirn .
Signed-off-by: K. Y. Srinivasa
> -Original Message-
> From: Johannes Thumshirn [mailto:jthumsh...@suse.de]
> Sent: Thursday, August 13, 2015 11:46 PM
> To: KY Srinivasan
> Cc: Keith Mange ;
> gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; oher...@suse.com;
> jbottom...@parall
This patch fixes the checkpatch.pl warnings:
WARNING: Block comments use a trailing */ on a separate line
WARNING: Block comments use * on subsequent lines
Signed-off-by: Aleksey Fedotov
---
drivers/staging/speakup/buffers.c | 3 +-
drivers/staging/speakup/i18n.c | 3 +-
drivers
On 08/14/2015 06:09 AM, Aaro Koskinen wrote:
Hi,
On Thu, Aug 13, 2015 at 12:16:43PM -0700, David Daney wrote:
On 08/13/2015 06:21 AM, Aaro Koskinen wrote:
Currently mainline Linux is unusable on OCTEON II CN68XX SOCs due to
issues in Ethernet driver initialization. Some boards are hanging duri
The channel list should be checked in Step 5 of the (*do_cmdtest) not
as part of the (*do_cmd). Factor the check out of usbduxfast_ai_cmd().
Tidy up the factored out code. The channel number 'i' will never be
greater than NUMCHANNELS due to the subdevice setup and the checks
done in the code. The
Fix a couple minor checkpatch.pl issues.
Tidy up the ai (*do_cmdtest) and (*do_cmd) a bit.
H Hartley Sweeten (9):
staging: comedi: usbduxfast: chanlist check is Step 5 of (*do_cmdtest)
staging: comedi: usbduxfast: only chanlist of 1,2,3, or 16 are supported
staging: comedi: usbduxfast: remo
The analog input (*do_cmd) only supports channel lists of 1, 2, 3, or 16
channels. Add a check for this to usbduxfast_ai_check_chanlist() and remove
the check from usbduxfast_ai_cmd().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usb
As suggested by checkpatch.pl:
CHECK: Prefer kernel type 'u8' over 'uint8_t'
CHECK: Prefer kernel type 's8' over 'int8_t'
For consistency, also change the uint16_t types to u16.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxfa
The private data 'devpriv' is allocated in the (*auto_attach) before
the subdevices are initialized and the (*auto_attach) has to complete
successfully before the core will call any of the subdevice operations.
Because of this the (!devpriv) checks in the subdevice code can never
fail. Remove them.
This comment does not need to be multi-line. Fix it to remove the
checkpatch warning.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxfast.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/com
The (*do_cmdtest) properly checks the MIN_SAMPLE_PERIOD. Remove the
redundant check in the (*do_cmd).
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxfast.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/stagin
Move this check from the (*do_cmd) to the (*do_cmdtest).
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxfast.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/comedi/drivers/usbdux
The (*do_cmdtest) properly checks the MAX_SAMPLE_PERIOD. Remove the
redundant check in the (*do_cmd).
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxfast.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/c
For aesthetics, use 'goto' and a common exit point in this function so
that the up of the semaphore is not overlooked.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxfast.c | 21 +
1 file changed, 9 insertions
For aesthetics, use tabs instead of spaces for the whitespace.
Convert the bit defines to use the preferred BIT macro.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/vmk80xx.c | 92
1 file changed, 46
Tidy up this driver to remove the last checkpatch.pl issues.
H Hartley Sweeten (2):
staging: comedi: vmk80xx: cleanup multi-line comment
staging: comedi: vmk80xx: tidy up defines
drivers/staging/comedi/drivers/vmk80xx.c | 127 ---
1 file changed, 64 insertions(+),
Reformat the multi-line comment in the kernel CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/vmk80xx.c | 35
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/
Fix a couple minor checkpatch.pl issues and tidy up the driver a bit.
H Hartley Sweeten (6):
staging: comedi: usbdux: use preferred kernel types
staging: comedi: usbdux: add missing spaces
staging: comedi: usbdux: use common code path to check the cmd->scan_begin_arg
staging: comedi: usbdu
As suggested by checkpatch.pl:
CHECK: Prefer kernel type 'u8' over 'uint8_t'
CHECK: Prefer kernel type 'u16' over 'uint16_t'
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbdux.c | 22 +++---
1 file changed, 11 inser
Add some missing space to quiet the checkpatch.pl issues about:
CHECK: spaces preferred around that '/' (ctx:VxV)
CHECK: spaces preferred around that '*' (ctx:VxV)
CHECK: spaces preferred around that '+' (ctx:VxV)
For aesthetics, use tabs instead of spaces in all the defines and
ensure they have
The comedi core can only call this subdevice function is the private
data was successfully allocated during the (*auto_attach). Remove
the unnecessary check.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbdux.c | 4
1 file chan
Use the comedi_offset_munge() helper to convert the hardware two's
complement values to the offset binary format expected by comedi.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbdux.c | 4 ++--
1 file changed, 2 insertions(+), 2 d
There are currently separate code paths to check the scan_begin_arg based
of the USB speed. Refactor the code to use a common code path and simplify
the code.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbdux.c | 40 +--
For aesthetics, consistently use the same name. 'devpriv', for the
local variable used to reference the private data, 'dev->private'.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbdux.c | 12 ++--
1 file changed, 6 insertio
Format the multi-line comments in the kernel CodingStyle.
Move the comment about the I/O ports in dnp_attach() to the start
of the function. This is typically where the resources are reserved.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/dr
Format the multi-line comments in the kernel CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/serial2002.c | 47 ++---
1 file changed, 23 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/c
Fix all the remaining checkpatch.pl issues.
H Hartley Sweeten (3):
staging: comedi: serial2002: tidy up multi-line comments
staging: comedi: serial2002: usleep_range is preferred over udelay
staging: comedi: serial2002: use proper errno
drivers/staging/comedi/drivers/serial2002.c | 51
Fix checkpatch issue: "CHECK: usleep_range is preferred over udelay;
see Documentation/timers/timers-howto.txt". Replace the udelay() with
usleep_range() with a reasonable upper limit.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ser
checkpatch.pl reports:
WARNING: ENOSYS means 'invalid syscall nr' and nothing else
Change the error code to -ENOIOCTLCMD/
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/serial2002.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-
On Fri, Aug 14, 2015 at 12:57:06PM +0300, Ioan-Adrian Ratiu wrote:
> Without including ptlrpc_internal.h, GCC gives prototype warnings
> "pack_generic.c:642:5: warning: no previous prototype for ..."
It does? What version of gcc give you that, I don't see that here.
_
On Fri, Aug 14, 2015 at 11:56:13AM +0530, Sudip Mukherjee wrote:
> On Thu, Aug 13, 2015 at 01:41:20PM +0900, Tony Cho wrote:
> > From: Johnny Kim
> >
> > This patch changes the void pointer member of the tstrHostIFmsg to the
> > real data type because the void pointer type is ambiguous and not
>
On Thu, Aug 13, 2015 at 01:41:22PM +0900, Tony Cho wrote:
> From: Johnny Kim
>
> This patch changes the type of gu8FlushedJoinReqDrvHandler with his real
> data type becasue typecasting is not necessary. In result, typecasting
> which is not necessary and some building warnings is removed.
>
> S
On Fri, Aug 14, 2015 at 10:50:07PM +0530, Chandra S Gorentla wrote:
> This patch enables setting the module's debug options WARN and INFO in the
> debugfs file 'wilc_debug_level'. This enables the user to enable logging
> of warning and other information. Before this change writes to this
> debug
On Fri, Aug 14, 2015 at 02:46:57PM -0400, Raphaël Beamonte wrote:
> Replace C99 // comments by /* comments */ to follow the kernel
> coding style.
>
> Signed-off-by: Raphaël Beamonte
> ---
> drivers/staging/vt6655/rf.c | 535
> ++--
> 1 file changed, 269
This patch enables setting the module's debug options WARN and INFO in the
debugfs file 'wilc_debug_level'. This functionality allows the user to
enable logging of warnings and other information. Before this change,
writes to this debugfs file set only one option - DEBUG. Another option
that is
86 matches
Mail list logo
