Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-31 Thread Wang, Jian J
ang, Jian J Sent: Friday, September 01, 2017 10:27 AM To: Yao, Jiewen ; Johnson, Brian (EXL - Eagan) ; af...@apple.com Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature Let me summarize the changes to this feature. If no new comments, I

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-31 Thread Wang, Jian J
jian.j.w...@intel.com>>; edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> Subject: Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature > On Aug 30, 2017, at 7:55 AM, Yao, Jiewen > mailto:jiewen@intel.com>> wrote: > > Hi Brian > Good feedback

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-30 Thread Yao, Jiewen
el@lists.01.org<mailto:edk2-devel@lists.01.org> Subject: Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature > On Aug 30, 2017, at 7:55 AM, Yao, Jiewen > mailto:jiewen@intel.com>> wrote: > > Hi Brian > Good feedback. > Comment in line. > > From:

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-30 Thread Yao, Jiewen
.org Subject: Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature > On Aug 30, 2017, at 7:55 AM, Yao, Jiewen > mailto:jiewen@intel.com>> wrote: > > Hi Brian > Good feedback. > Comment in line. > > From: Johnson, Brian (EXL - Eagan) [mailto:brian.jo

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-30 Thread Johnson, Brian (EXL - Eagan)
Wednesday, August 30, 2017 11:27 AM To: Yao, Jiewen Cc: Johnson, Brian (EXL - Eagan) ; Wang, Jian J ; edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature > On Aug 30, 2017, at 7:55 AM, Yao, Jiewen wrote: > > Hi Brian > Good feedback. &g

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-30 Thread Andrew Fish
gt; HPE > > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yao, > Jiewen > Sent: Sunday, August 27, 2017 10:39 PM > To: Wang, Jian J mailto:jian.j.w...@intel.com>>; > edk2-devel@lists.01.org<mailto:edk2-devel@l

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-30 Thread Yao, Jiewen
Hi Brian Good feedback. Comment in line. From: Johnson, Brian (EXL - Eagan) [mailto:brian.john...@hpe.com] Sent: Tuesday, August 29, 2017 11:17 PM To: Yao, Jiewen ; Wang, Jian J ; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH 0/2] Implement NULL pointer detection feature Thank you for

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-29 Thread Tim Lewis
: [edk2] [PATCH 0/2] Implement NULL pointer detection feature It makes no difference to me. But it sounds more flexible and less cumbersome to use 4 PCDs. That way you don't have to define the meanings of individual bits, in the code or in the .dec file. And you could use different PCD types

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-29 Thread Johnson, Brian (EXL - Eagan)
Michael D [mailto:michael.d.kin...@intel.com] Sent: Tuesday, August 29, 2017 11:02 AM To: Johnson, Brian (EXL - Eagan) ; Yao, Jiewen ; Wang, Jian J ; edk2-devel@lists.01.org; Kinney, Michael D Subject: RE: [edk2] [PATCH 0/2] Implement NULL pointer detection feature Brian, Do you prefer 4 new PCDs or o

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-29 Thread Kinney, Michael D
AM > To: Yao, Jiewen ; Wang, Jian J > ; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH 0/2] Implement NULL pointer > detection feature > > Thank you for implementing this feature! It is very helpful > for catching pointer-related problems. We have used a similar >

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-29 Thread Johnson, Brian (EXL - Eagan)
PATCH 0/2] Implement NULL pointer detection feature Comment in line. From: Wang, Jian J Sent: Monday, August 28, 2017 11:24 AM To: Yao, Jiewen ; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH 0/2] Implement NULL pointer detection feature 1) I think this feature should be 'FALSE'

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-27 Thread Yao, Jiewen
Comment in line. From: Wang, Jian J Sent: Monday, August 28, 2017 11:24 AM To: Yao, Jiewen ; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH 0/2] Implement NULL pointer detection feature 1) I think this feature should be 'FALSE' by default. I forgot to reset its default v

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-27 Thread Wang, Jian J
ange in page table. Then the usage of feature will be limited in such case. From: Yao, Jiewen Sent: Monday, August 28, 2017 11:10 AM To: Wang, Jian J ; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH 0/2] Implement NULL pointer detection feature Thank you to enable this feature. I have 2 comme

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-27 Thread Yao, Jiewen
; Subject: [edk2] [PATCH 0/2] Implement NULL pointer detection feature > > This patch is the implementation of NULL pointer detection feature, > which is one of the small features of Special Pool. > > Wang, Jian J (2): > Implement NULL pointer detection for EDK-II Core > Impleme

[edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-27 Thread Wang, Jian J
This patch is the implementation of NULL pointer detection feature, which is one of the small features of Special Pool. Wang, Jian J (2): Implement NULL pointer detection for EDK-II Core Implement NULL pointer detection for EDK-II SMM Core and driver MdeModulePkg/Core/Dxe/DxeMain.inf