Thanks, Leif.
Some interesting points, and I agree and will strive to comply.
I only point out that there MAY be a general pressure to not bother "tidying"
where trivia are observed.
That is, of course, difficult to prove or quantify.
Regards,
Evan
>-Original Message-
>From: Leif Lindhol
On 10/11/16 12:23, Evan Lloyd wrote:
> Hi Leif.
> Please feel free to fix the space change as you see fit and proper,
> as it was just incidental tidying up.
I would simply drop that hunk for now. While I personally prefer the
no-space form, and stick with it consistently in all code I write, othe
On Tue, Oct 11, 2016 at 10:23:12AM +, Evan Lloyd wrote:
> Please feel free to fix the space change as you see fit and proper,
> as it was just incidental tidying up.
Thanks.
> It would be good to have a discussion about the general position,
> though.
> There are, I am sure, sound reasons for
Hi Leif.
Please feel free to fix the space change as you see fit and proper, as it was
just incidental tidying up.
It would be good to have a discussion about the general position, though.
There are, I am sure, sound reasons for not rolling these things together (and
I knew that, and shouldn't h
On Wed, Sep 21, 2016 at 09:33:15PM +0100, evan.ll...@arm.com wrote:
> From: Alexei
>
> SerialPortInitialize() set the BaudRate variable (type UINT64) as:
> BaudRate = (UINTN)FixedPcdGet64 (PcdUartDefaultBaudRate);
>
> This commit fixes a potential problem on ARM 32-bit builds, where the
> UINTN
From: Alexei
SerialPortInitialize() set the BaudRate variable (type UINT64) as:
BaudRate = (UINTN)FixedPcdGet64 (PcdUartDefaultBaudRate);
This commit fixes a potential problem on ARM 32-bit builds, where the
UINTN type is defined as UINT32, by removing the cast:
BaudRate = FixedPcdGet64 (PcdUar
6 matches
Mail list logo