subject:"\"\\\[edk2\\\] \\\[Patch 2\\\/2\\\] UefiCpuPkg\\\/PiSmmCpuDxeSmm\\\: Refine code to avoid duplicated code.\""

Re: [edk2] [Patch 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Refine code to avoid duplicated code.

2017-09-28 Thread Yao, Jiewen

nks/Ray > >> -Original Message- >> From: Zeng, Star >> Sent: Thursday, September 28, 2017 5:31 PM >> To: Dong, Eric ; edk2-devel@lists.01.org >> Cc: Ni, Ruiyu ; Yao, Jiewen ; Zeng, >> Star >> Subject: RE: [edk2] [Patch 2/2] UefiCpuPkg/PiSmmCp

Re: [edk2] [Patch 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Refine code to avoid duplicated code.

2017-09-28 Thread Ni, Ruiyu

; Zeng, > Star > Subject: RE: [edk2] [Patch 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Refine code to > avoid duplicated code. > > Just FYI, another idea is to declare SetProcessorRegister() like below, then > the > caller of SetProcessorRegister() has no need to touch mAcpiCpuData. >

Re: [edk2] [Patch 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Refine code to avoid duplicated code.

2017-09-28 Thread Zeng, Star

Eric Dong Sent: Thursday, September 28, 2017 5:15 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Yao, Jiewen Subject: [edk2] [Patch 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Refine code to avoid duplicated code. Refine code to avoid duplicate code to set processor register. Cc: Jiewen Yao Cc: Ruiyu Ni

[edk2] [Patch 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Refine code to avoid duplicated code.

2017-09-28 Thread Eric Dong

Refine code to avoid duplicate code to set processor register. Cc: Jiewen Yao Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 78 ++- 1 file changed, 20 insertions(+), 58 d