Re: [edk2] ASSERT and static code analysis

2016-06-01 Thread Gao, Liming
> de...@lists.01.org > Subject: Re: [edk2] ASSERT and static code analysis > > On 06/01/16 22:41, Marvin H?user wrote: > > Hey Laszlo, > > > > Thank you very much for your comment! > > > > About the comment in CpuDeadLoop(), once more, I wasn't aware,

Re: [edk2] ASSERT and static code analysis

2016-06-01 Thread Shi, Steven
gt; [mailto:af...@apple.com] > > Sent: Wednesday, June 1, 2016 10:56 PM > > To: Marvin H?user > > mailto:marvin.haeu...@outlook.com>> > > Cc: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> > > Subject: Re: [edk2] ASSERT and static code an

Re: [edk2] ASSERT and static code analysis

2016-06-01 Thread Marvin H?user
morrow, I think. Regards, Marvin. > -Original Message- > From: af...@apple.com [mailto:af...@apple.com] > Sent: Wednesday, June 1, 2016 10:56 PM > To: Marvin H?user > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] ASSERT and static code analysis > > >

Re: [edk2] ASSERT and static code analysis

2016-06-01 Thread Andrew Fish
> On Jun 1, 2016, at 1:12 PM, Marvin H?user wrote: > > Recently I was told that ASSERT() calls to check whether a variable is NULL > breaks the Clang Static Analyzer in terms of generating wrong warnings. The > reason is that, when a variable/parameter is checked for NULL, this analyzer > ass

Re: [edk2] ASSERT and static code analysis

2016-06-01 Thread Laszlo Ersek
-Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Wednesday, June 1, 2016 10:38 PM >> To: Marvin H?user >> Cc: edk2-devel@lists.01.org >> Subject: Re: [edk2] ASSERT and static code analysis >> >> On 06/01/16 22:12, Marvin

Re: [edk2] ASSERT and static code analysis

2016-06-01 Thread Marvin H?user
devel@lists.01.org > Subject: Re: [edk2] ASSERT and static code analysis > > On 06/01/16 22:12, Marvin H?user wrote: > > Recently I was told that ASSERT() calls to check whether a variable is > > NULL breaks the Clang Static Analyzer in terms of generating wrong > > war

Re: [edk2] ASSERT and static code analysis

2016-06-01 Thread Laszlo Ersek
On 06/01/16 22:12, Marvin H?user wrote: > Recently I was told that ASSERT() calls to check whether a variable > is NULL breaks the Clang Static Analyzer in terms of generating wrong > warnings. The reason is that, when a variable/parameter is checked > for NULL, this analyzer assumes that it can be

[edk2] ASSERT and static code analysis

2016-06-01 Thread Marvin H?user
Recently I was told that ASSERT() calls to check whether a variable is NULL breaks the Clang Static Analyzer in terms of generating wrong warnings. The reason is that, when a variable/parameter is checked for NULL, this analyzer assumes that it can be. As it doesn't support EDK2 ASSERTs, but onl