Re: [O] [PATCH]: BUG fix and Add header-args property to source block info

2015-02-13 Thread Rainer M Krug
Sebastien Vauban sva-news-D0wtAvR13HarG/idocf...@public.gmane.org writes: Rainer M Krug wrote: what do you mean by ECM? http://orgmode.org/worg/org-faq.html#ecm Ah - learned something. Merci beaucoup, Rainer Best regards, Seb -- Rainer M. Krug email: Raineratkrugsdotde PGP:

Re: [O] [PATCH]: BUG fix and Add header-args property to source block info

2015-02-13 Thread Sebastien Vauban
Rainer M Krug wrote: what do you mean by ECM? http://orgmode.org/worg/org-faq.html#ecm Best regards, Seb -- Sebastien Vauban

Re: [O] [PATCH]: BUG fix and Add header-args property to source block info

2015-02-13 Thread Rainer M Krug
Nicolas Goaziou m...@nicolasgoaziou.fr writes: Rainer M Krug rai...@krugs.de writes: I think I will skip the bonus points this time - sorry. OK. You may also send me a couple of ECM, so I can turn them into tests. Sorry - what do you mean by ECM? I would be very grateful if you could

Re: [O] [PATCH]: BUG fix and Add header-args property to source block info

2015-02-12 Thread Charles C. Berry
On Thu, 12 Feb 2015, Rainer M Krug wrote: Rainer M Krug rai...@krugs.de writes: Nicolas Goaziou m...@nicolasgoaziou.fr writes: Hello, Rainer M Krug rai...@krugs.de writes: Please find attached the below described patch including the fix for the error reported - function raises error

Re: [O] [PATCH]: BUG fix and Add header-args property to source block info

2015-02-12 Thread Rainer M Krug
Rainer M Krug rai...@krugs.de writes: Nicolas Goaziou m...@nicolasgoaziou.fr writes: Hello, Rainer M Krug rai...@krugs.de writes: Please find attached the below described patch including the fix for the error reported - function raises error when property value is numeric. Looks good.

Re: [O] [PATCH]: BUG fix and Add header-args property to source block info

2015-02-12 Thread Nicolas Goaziou
Rainer M Krug rai...@krugs.de writes: I think I will skip the bonus points this time - sorry. OK. You may also send me a couple of ECM, so I can turn them into tests. I would be very grateful if you could submit the patch without a test. Applied. Thank you. Regards.

Re: [O] [PATCH]: BUG fix and Add header-args property to source block info

2015-02-12 Thread Rainer M Krug
Alan Schmitt alan.schm...@polytechnique.org writes: Hello, On 2015-02-10 22:58, Rainer M Krug rai...@krugs.de writes: Are there some guidelines on how to write tests? Never done this before... I recently wrote my first test, so here is how I did it. - find a similar test in

Re: [O] [PATCH]: BUG fix and Add header-args property to source block info

2015-02-11 Thread Alan Schmitt
Hello, On 2015-02-10 22:58, Rainer M Krug rai...@krugs.de writes: Are there some guidelines on how to write tests? Never done this before... I recently wrote my first test, so here is how I did it. - find a similar test in testing/lisp/el (maybe in test-ob-exp.el) - load the file

Re: [O] [PATCH]: BUG fix and Add header-args property to source block info

2015-02-10 Thread Rainer M Krug
Please find attached the below described patch including the fix for the error reported - function raises error when property value is numeric. Cheers, Rainer diff --git a/lisp/ob-core.el b/lisp/ob-core.el index ceda1aa..aa39c11 100644 --- a/lisp/ob-core.el +++ b/lisp/ob-core.el @@ -409,12

Re: [O] [PATCH]: BUG fix and Add header-args property to source block info

2015-02-10 Thread Nicolas Goaziou
Hello, Rainer M Krug rai...@krugs.de writes: Please find attached the below described patch including the fix for the error reported - function raises error when property value is numeric. Looks good. Thank you. Could you provide an appropriate commit message? Bonus points if you also add a

Re: [O] [PATCH]: BUG fix and Add header-args property to source block info

2015-02-10 Thread Rainer M Krug
Nicolas Goaziou m...@nicolasgoaziou.fr writes: Hello, Rainer M Krug rai...@krugs.de writes: Please find attached the below described patch including the fix for the error reported - function raises error when property value is numeric. Looks good. Thank you. Thanks. From