Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

Good catch, I will write a EDBus_Connection_Event_Type for Disconnection. On Sun, Nov 11, 2012 at 6:59 PM, Enlightenment SVN wrote: > Log: > efreet: shutdown on error and disconnect > > When bus stops it send Disconnect signal. Trap and die. > > Author: englebass > Date: 2012-11-1

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

> > > On Wed, 16 Mar 2011, Sebastian Dransfeld wrote: > >> On 03/15/2011 11:55 PM, Vincent Torri wrote: >>> >>> >>> On Tue, 15 Mar 2011, Enlightenment SVN wrote: >>> Log: Efreet: And revert logging, no longer needed >>> >>> eina_log support is enabled, but it seems that it is disabled in

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

On Wed, 16 Mar 2011, Sebastian Dransfeld wrote: > On 03/15/2011 11:55 PM, Vincent Torri wrote: >> >> >> On Tue, 15 Mar 2011, Enlightenment SVN wrote: >> >>> Log: >>> Efreet: And revert logging, no longer needed >> >> eina_log support is enabled, but it seems that it is disabled in efreet. >> See

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

On 03/15/2011 11:55 PM, Vincent Torri wrote: > > > On Tue, 15 Mar 2011, Enlightenment SVN wrote: > >> Log: >> Efreet: And revert logging, no longer needed > > eina_log support is enabled, but it seems that it is disabled in efreet. > See efreet_private.h lines 72 and after and efreet.c line 36. On

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

On Wed, 16 Mar 2011 00:08:28 +0200 Tom Hacohen said: i don't see a problem with quick and dirty printfs in trunk when working on an issue. if you want more permanent logging abilities - eina_log is probably good as u can turn it on and off at will. > :))) > > discomfitor: no one is fighting (or

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

On Tue, 15 Mar 2011, Enlightenment SVN wrote: > Log: > Efreet: And revert logging, no longer needed eina_log support is enabled, but it seems that it is disabled in efreet. See efreet_private.h lines 72 and after and efreet.c line 36. On the other hand, it's enabled in efreet_mime (see efreet

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

:))) discomfitor: no one is fighting (or at least I wasn't). On Tue, Mar 15, 2011 at 8:51 PM, Sebastian Dransfeld wrote: > Code gone, I'll never do it again. > > S. > > On 03/15/2011 07:32 PM, Tom Hacohen wrote: > > "Because I don't do the testing, someone else is. And that person is no > > cod

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

On Tue, 15 Mar 2011 19:51:26 +0100 Sebastian Dransfeld wrote: > Code gone, I'll never do it again. > > S. > > On 03/15/2011 07:32 PM, Tom Hacohen wrote: > > "Because I don't do the testing, someone else is. And that person is no > > coder." - > > What's wrong with a patch? > > > > Maybe it's ju

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

Code gone, I'll never do it again. S. On 03/15/2011 07:32 PM, Tom Hacohen wrote: > "Because I don't do the testing, someone else is. And that person is no > coder." - > What's wrong with a patch? > > Maybe it's just me, but I don't think debugging should happen through > SVN. :) > > -- > Tom. > >

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

"Because I don't do the testing, someone else is. And that person is no coder." - What's wrong with a patch? Maybe it's just me, but I don't think debugging should happen through SVN. :) -- Tom. On Tue, Mar 15, 2011 at 8:24 PM, Sebastian Dransfeld wrote: > On 03/15/2011 07:15 PM, Tom Hacohen w

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

On 03/15/2011 07:15 PM, Tom Hacohen wrote: > On Tue, Mar 15, 2011 at 7:54 PM, Sebastian Dransfeld > wrote: > > Because I needed quick and dirty logging to track down the Mac OS X > issue, and eina logging is still not enabled here which is the same > reason

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

On Tue, Mar 15, 2011 at 7:54 PM, Sebastian Dransfeld wrote: > Because I needed quick and dirty logging to track down the Mac OS X > issue, and eina logging is still not enabled here which is the same > reason as last time. > > Do you have an auto script to check for added printf's? > > Maybe I m

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

You dont need any enablement to use eina_log, just use the global macros and you'll get it. Of couse it would be desirable to have one domain for efreet On Tuesday, March 15, 2011, Sebastian Dransfeld wrote: > On 03/15/2011 06:12 PM, Vincent Torri wrote: >> >> >> On Tue, 15 Mar 2011, Enlightenmen

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

On 03/15/2011 06:12 PM, Vincent Torri wrote: > > > On Tue, 15 Mar 2011, Enlightenment SVN wrote: > >> Log: >> Efreet: Add some logging > > why not using eina_log ? Because I needed quick and dirty logging to track down the Mac OS X issue, and eina logging is still not enabled here which is the sa

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

On Tue, 15 Mar 2011, Enlightenment SVN wrote: > Log: > Efreet: Add some logging why not using eina_log ? Vincent > > Author: englebass > Date: 2011-03-15 10:07:19 -0700 (Tue, 15 Mar 2011) > New Revision: 57769 > Trac: http://trac.enlightenment.org/e/changeset/57769 > > M

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

On 02/22/2011 08:45 PM, Sebastian Dransfeld wrote: > On 02/22/2011 04:22 PM, Atton Jonathan wrote: >> If the problem is in e why you don't fix e instead of revert a fix in efreet >> ? > > E always wants to wait for desktop cache to be updated. So we always > need to wait there. What we need to do i

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

On 02/22/2011 04:22 PM, Atton Jonathan wrote: > If the problem is in e why you don't fix e instead of revert a fix in efreet > ? E always wants to wait for desktop cache to be updated. So we always need to wait there. What we need to do is to differentiate between "cache build done and change",

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

If the problem is in e why you don't fix e instead of revert a fix in efreet ? 2011/2/22 Enlightenment SVN > Log: > Efreet: Reset changed before scanning fallback > > Changed must be EINA_FALSE before scanning fallback to not create false > positive. > > Author: englebass > Date:

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

On 02/19/2011 10:01 PM, Vincent Torri wrote: > > > On Sat, 19 Feb 2011, Enlightenment SVN wrote: > >> Log: >> Only print if verbose and TODO++ > > why using fprintf(stder ***) and not eina_log ? Ask cedric, he wrote it. A lot of other printf's are older than eina, and I haven't bothered fixing t

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

On Sat, 19 Feb 2011, Enlightenment SVN wrote: > Log: > Only print if verbose and TODO++ why using fprintf(stder ***) and not eina_log ? Vincent > > Author: englebass > Date: 2011-02-19 12:54:03 -0800 (Sat, 19 Feb 2011) > New Revision: 57175 > Trac: http://trac.enlightenm

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

Vincent Torri h: > > On Sun, 28 Mar 2010, Enlightenment SVN wrote: > >> Log: >> efreet: Only read data from disk when modified > > what about using file monitoring for that ? Well, we need to build the complete cache every time the bin is executed. So we need all information, the patch just m

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

On Sun, 28 Mar 2010, Enlightenment SVN wrote: > Log: > efreet: Only read data from disk when modified what about using file monitoring for that ? Vincent > Author: englebass > Date: 2010-03-28 12:31:37 -0700 (Sun, 28 Mar 2010) > New Revision: 47539 > > Modified: > trunk/efreet

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

On Thu, Mar 11, 2010 at 3:33 PM, Sebastian Dransfeld wrote: >>>  static int >>> +strcmplen(const void *data1, const void *data2) >>> +{ >>> +    return strncmp(data1, data2, strlen(data2)); >>> +} >> >> If you used stringshare, you could use much faster eina_stringshare_len() >> here. > > Well, s

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

>> static int >> +strcmplen(const void *data1, const void *data2) >> +{ >> +return strncmp(data1, data2, strlen(data2)); >> +} > > If you used stringshare, you could use much faster eina_stringshare_len() > here. Well, since one of the parameters isn't stringshared, it can't be done. > >>

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

On Wed, Mar 10, 2010 at 6:33 PM, Enlightenment SVN wrote: > Log: >  read user dir cache > Author:       englebass > Date:         2010-03-10 13:33:43 -0800 (Wed, 10 Mar 2010) > New Revision: 47120 > > Modified: >  trunk/efreet/src/bin/efreet_desktop_cache_create.c > > Modified: trunk/efreet/src/bi

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

On Tue, 02 Mar 2010 10:09:30 +0100 Sebastian Dransfeld said: > Gustavo Sverzut Barbieri wrote: > > On Mon, Mar 1, 2010 at 3:42 PM, Enlightenment SVN > > wrote: > >> Log: > >> truncate old cache so we don't read cached values > >> Author: englebass > >> Date: 2010-03-01 10:42:24 -0

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

Gustavo Sverzut Barbieri wrote: > On Mon, Mar 1, 2010 at 3:42 PM, Enlightenment SVN > wrote: >> Log: >> truncate old cache so we don't read cached values >> Author: englebass >> Date: 2010-03-01 10:42:24 -0800 (Mon, 01 Mar 2010) >> New Revision: 46727 >> >> Modified: >> trunk/efree

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

On Mon, Mar 1, 2010 at 3:42 PM, Enlightenment SVN wrote: > Log: >  truncate old cache so we don't read cached values > Author:       englebass > Date:         2010-03-01 10:42:24 -0800 (Mon, 01 Mar 2010) > New Revision: 46727 > > Modified: >  trunk/efreet/src/bin/efreet_desktop_cache_create.c > >