Re: [FFmpeg-devel] [PATCH] lavf/mux: allow unofficial extension by default for spatial data in mp4

2020-08-27 Thread Linjie Fu
On Fri, Aug 28, 2020 at 11:18 AM Linjie Fu wrote: > > Hi, > > On Fri, Aug 28, 2020 at 8:46 AM Andreas Rheinhardt > wrote: > > > > Linjie Fu: > > > Mp4 unofficial extension allows Stereo3D and Spherical Mapping data > > > in header if users explicitly set "-strict unofficial" or values less > > >

[FFmpeg-devel] [PATCH v4 2/2] libavformat/webp: add WebP demuxer

2020-08-27 Thread Josef Zlomek
Adds the demuxer of animated WebP files. It supports non-animated, animated, truncated, and concatenated files. Reading from a pipe (and other non-seekable inputs) is also supported. The WebP demuxer splits the input stream into packets containing one frame. It also sets the timing information and

[FFmpeg-devel] [PATCH v4 1/2] libavcodec/webp: add support for animated WebP decoding

2020-08-27 Thread Josef Zlomek
Fixes: 4907 Adds support for decoding of animated WebP. The WebP parser now splits the input stream into packets containing one frame. The WebP decoder adds the animation related features according to the specs: https://developers.google.com/speed/webp/docs/riff_container#animation The frames of

Re: [FFmpeg-devel] [PATCH] lavf/mux: allow unofficial extension by default for spatial data in mp4

2020-08-27 Thread Linjie Fu
Hi, On Fri, Aug 28, 2020 at 8:46 AM Andreas Rheinhardt wrote: > > Linjie Fu: > > Mp4 unofficial extension allows Stereo3D and Spherical Mapping data > > in header if users explicitly set "-strict unofficial" or values less > > than "-1". > > > > Currently side_data like stereo3D and spherical dat

[FFmpeg-devel] [PATCH] avcodec/v4l2_buffers: remove unused function argument

2020-08-27 Thread Andriy Gelman
From: Andriy Gelman Signed-off-by: Andriy Gelman --- libavcodec/v4l2_buffers.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/v4l2_buffers.c b/libavcodec/v4l2_buffers.c index 02f23d954b..4b2679eb38 100644 --- a/libavcodec/v4l2_buffers.c +++ b/libavcodec/v

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: move pthread_cond_signal after add buffer to the queue

2020-08-27 Thread zhilizhao
> On Aug 28, 2020, at 9:13 AM, Steven Liu wrote: > > From: Tian Qi > > In the VT encoding insertion by FFmpeg, > and vtenc_q_push is callback to add the encoded data > to the singly linked list group in VTEncContext, > and consumers are notified to fetch it. > However, because it first inform

[FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: move pthread_cond_signal after add buffer to the queue

2020-08-27 Thread Steven Liu
From: Tian Qi In the VT encoding insertion by FFmpeg, and vtenc_q_push is callback to add the encoded data to the singly linked list group in VTEncContext, and consumers are notified to fetch it. However, because it first informs consumers of pthread_cond_signal, and then inserts the data into th

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/videotoolboxenc: fix use after destroy

2020-08-27 Thread Steven Liu
于2020年8月27日周四 下午5:39写道: > > From: Zhao Zhili > > The lock is used in clear_frame_queue(). > --- > libavcodec/videotoolboxenc.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c > index 988782f10d..758d

Re: [FFmpeg-devel] [PATCH] lavf/mux: allow unofficial extension by default for spatial data in mp4

2020-08-27 Thread Andreas Rheinhardt
Linjie Fu: > Mp4 unofficial extension allows Stereo3D and Spherical Mapping data > in header if users explicitly set "-strict unofficial" or values less > than "-1". > > Currently side_data like stereo3D and spherical data in mp4 would be > dropped by default in a transcoding procedure even if use

Re: [FFmpeg-devel] [PATCH] avformat/wavdec: allow to change max size of single demuxed packet

2020-08-27 Thread Andreas Rheinhardt
Paul B Mahol: > Can make demuxing much faster, expecially for files with > huge number of channels. > > Signed-off-by: Paul B Mahol > --- > libavformat/wavdec.c | 21 ++--- > 1 file changed, 18 insertions(+), 3 deletions(-) > > diff --git a/libavformat/wavdec.c b/libavformat/wav

[FFmpeg-devel] [PATCH] avformat/wavdec: allow to change max size of single demuxed packet

2020-08-27 Thread Paul B Mahol
Can make demuxing much faster, expecially for files with huge number of channels. Signed-off-by: Paul B Mahol --- libavformat/wavdec.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c index e1b2115434..5b3c4814

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: Check transform type

2020-08-27 Thread Paul B Mahol
On 8/28/20, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 24823/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CFHD_fuzzer-4855119863349248 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Nie

Re: [FFmpeg-devel] Forward frame wall clock time from avdevice to HLS muxer

2020-08-27 Thread Jim DeLaHunt
On 2020-08-27 13:05, Marton Balint wrote: On Thu, 27 Aug 2020, Nicolas George wrote: Marton Balint (12020-08-27): +1, this seems like the right thing. PTS is not really suitable, as that is based (or at least should be based) on monotonic clock, not realtime clock. PTS are based on what w

[FFmpeg-devel] [PATCH] avcodec/cfhd: Check transform type

2020-08-27 Thread Michael Niedermayer
Fixes: out of array access Fixes: 24823/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CFHD_fuzzer-4855119863349248 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/cfhd.c | 2 +- 1 file cha

[FFmpeg-devel] [PATCH] avformat/wavdec: add support for demuxing Broadcast Wave 64Bit

2020-08-27 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/wavdec.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c index c35966f970..a2d563ba68 100644 --- a/libavformat/wavdec.c +++ b/libavformat/wavdec.c @@ -6,6 +6,8 @@ * RF64

[FFmpeg-devel] [PATCH] avformat/wavdec: add support for demuxing Broadcast Wave 64Bit

2020-08-27 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/wavdec.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c index c35966f970..e1b2115434 100644 --- a/libavformat/wavdec.c +++ b/libavformat/wavdec.c @@ -6,6 +6,8 @@ * RF64

Re: [FFmpeg-devel] [PATCH v6 1/4] lavc: add FLIF decoding support

2020-08-27 Thread Lynne
Aug 27, 2020, 10:17 by barsn...@gmx.net: > On Wed, Aug 26, 2020 at 16:31:46 +, Anamitra Ghorui wrote: > >> >> +uint8_t ff_flif16_rac_read_bit(FLIF16RangeCoder *rc, >> >> + uint8_t *target) >> >> +{ >> >> +return ff_flif16_rac_get(rc, rc->range >> 1, target); >

Re: [FFmpeg-devel] Forward frame wall clock time from avdevice to HLS muxer

2020-08-27 Thread Marton Balint
On Thu, 27 Aug 2020, Nicolas George wrote: Marton Balint (12020-08-27): +1, this seems like the right thing. PTS is not really suitable, as that is based (or at least should be based) on monotonic clock, not realtime clock. PTS are based on what we decide they are based. Realtime clock is

[FFmpeg-devel] [RFC PATCH v7 4/4] libavcodec/jpeg2000: fix tag tree reset

2020-08-27 Thread gautamramk
From: Gautam Ramakrishnan The implementation of the tag tree did not set the correct reset value for the encoder. This lead to inefficent tag tree being encoded. This patch fixes the implementation of the ff_tag_tree_zero() function. --- libavcodec/j2kenc.c | 4 ++-- libavco

[FFmpeg-devel] [RFC PATCH v7 3/4] libavcodec/j2kenc: Support for multiple layers

2020-08-27 Thread gautamramk
From: Gautam Ramakrishnan This patch allows setting a compression ratio and to set multiple layers. The user has to input a compression ratio for each layer. The per layer compression ration can be set as follows: -layer_rates "r1,r2,...rn" for to create 'n' layers. --- doc/encoders.texi

[FFmpeg-devel] [RFC PATCH v7 1/4] libavcodec/jpeg2000: Make tag tree functions non static

2020-08-27 Thread gautamramk
From: Gautam Ramakrishnan This patch makes the tag_tree_zero() and tag_tree_size() functions non static and callable from other files. --- libavcodec/jpeg2000.c | 12 ++-- libavcodec/jpeg2000.h | 3 +++ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/libavcodec/jpeg2000.c

[FFmpeg-devel] [RFC PATCH v7 2/4] libavcodec/j2kenc: Fix tag tree coding

2020-08-27 Thread gautamramk
From: Gautam Ramakrishnan The implementation of tag tree encoding was incorrect. However, this error was not visible as the current j2k encoder encodes only 1 layer. This patch fixes tag tree coding for JPEG2000 such tag tree coding would work for multi layer encoding. --- libavcodec/j2kenc.c

Re: [FFmpeg-devel] Forward frame wall clock time from avdevice to HLS muxer

2020-08-27 Thread Nicolas George
Marton Balint (12020-08-27): > +1, this seems like the right thing. PTS is not really suitable, as that is > based (or at least should be based) on monotonic clock, not realtime clock. PTS are based on what we decide they are based. For ALSA, they default to monotonic, but wall is an option. Frank

Re: [FFmpeg-devel] [PATCH v6 1/4] lavc: add FLIF decoding support

2020-08-27 Thread Nicolas George
Moritz Barsnick (12020-08-27): > I understand this justification. I just wanted to point out that the > code was not parsable to my brain, due to the macros (which I do > relaize have "goto"s in them, which is okay to me) and the "case" > labels in the middle of code blocks. > > I suggest others c

Re: [FFmpeg-devel] [PATCH v6 1/4] lavc: add FLIF decoding support

2020-08-27 Thread Nicolas George
Lynne (12020-08-27): > We always inline bitstream reading functions, and this one is no different. > Its really necessary for speed, and well worth the additional binary size. > There's no memory cache gains to be had here, not with the huge > several hundred instruction lookaheads modern CPUs have

Re: [FFmpeg-devel] [mov] See if mfra makes up the difference for an incomplete sidx.

2020-08-27 Thread Dale Curtis
Bump to get this applied. Thanks! - dale On Wed, Aug 19, 2020 at 6:13 AM Michael Niedermayer wrote: > On Tue, Aug 18, 2020 at 02:04:04PM +0100, Derek Buitenhuis wrote: > > On 18/08/2020 04:57, Dale Curtis wrote: > > > Can't be an else statement since the prior clause modifies is_complete. > > >

Re: [FFmpeg-devel] [RFC PATCH v6 3/4] libavcodec/j2kenc: Support for multiple layers

2020-08-27 Thread Gautam Ramakrishnan
On Thu, Aug 27, 2020 at 3:16 PM Moritz Barsnick wrote: > > On Wed, Aug 26, 2020 at 21:28:17 +0530, gautamr...@gmail.com wrote: > > > +@item layer_rates @var{string} > > +By default, compression is done using the quality metric. This option > > allows for > > +compression using compression ratio.

Re: [FFmpeg-devel] [PATCH v2] avcodec/cfhd: Remove unused-but-set variable

2020-08-27 Thread Paul B Mahol
On 8/27/20, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > V2 because of 389cc142fb00c23ac1a8d2ba95a9db5d8be473cd. > > libavcodec/cfhd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > LGTM ___ ffmpeg-devel mailing l

[FFmpeg-devel] [PATCH] lavf/mux: allow unofficial extension by default for spatial data in mp4

2020-08-27 Thread Linjie Fu
Mp4 unofficial extension allows Stereo3D and Spherical Mapping data in header if users explicitly set "-strict unofficial" or values less than "-1". Currently side_data like stereo3D and spherical data in mp4 would be dropped by default in a transcoding procedure even if user uses streamcopy to ge

Re: [FFmpeg-devel] Forward frame wall clock time from avdevice to HLS muxer

2020-08-27 Thread Jesper Ek
Den ons 26 aug. 2020 kl 12:56 skrev Andreas Rheinhardt < andreas.rheinha...@gmail.com>: > Jesper Ek: > > Hi, > > > > I have implemented a libavdevice to capture audio and video from an AJA > > Kona card (similar to decklink). I'm then using the HLS muxer to encode > my > > stream. Now I need the H

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: don't wait when flushing data

2020-08-27 Thread zhilizhao
> On Aug 27, 2020, at 10:53 AM, Steven Liu wrote: > > From: Tian Qi > > because there is run in thread mode, few times will block > the workflow at the wait, so check the status is flushing data, > don't wait when flushing data. > > Signed-off-by: Tian Qi > Signed-off-by: Steven Liu > ---

Re: [FFmpeg-devel] [RFC PATCH v6 3/4] libavcodec/j2kenc: Support for multiple layers

2020-08-27 Thread Moritz Barsnick
On Wed, Aug 26, 2020 at 21:28:17 +0530, gautamr...@gmail.com wrote: > +@item layer_rates @var{string} > +By default, compression is done using the quality metric. This option allows > for > +compression using compression ratio. The compression ratio for each level > could > +be specified. The co

[FFmpeg-devel] [PATCH 2/2] avcodec/videotoolboxenc: fix use after destroy

2020-08-27 Thread quinkblack
From: Zhao Zhili The lock is used in clear_frame_queue(). --- libavcodec/videotoolboxenc.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index 988782f10d..758db9641f 100644 --- a/libavcodec/videotoolbox

[FFmpeg-devel] [PATCH 1/2] avcodec/videotoolboxenc: fix align issue

2020-08-27 Thread quinkblack
From: Zhao Zhili bool a53_cc is accessed as int: src/libavutil/opt.c:129:9: runtime error: store to misaligned address 0x7fbf454121a3 for type 'int', which requires 4 byte alignment --- libavcodec/videotoolboxenc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec

Re: [FFmpeg-devel] Forward frame wall clock time from avdevice to HLS muxer

2020-08-27 Thread Marton Balint
On Wed, 26 Aug 2020, Andreas Rheinhardt wrote: Jesper Ek: Hi, I have implemented a libavdevice to capture audio and video from an AJA Kona card (similar to decklink). I'm then using the HLS muxer to encode my stream. Now I need the HLS EXT-X-PROGRAM-DATE-TIME tag to specify exactly when the

Re: [FFmpeg-devel] [PATCH] ffplay: fix autoexit doesn't work in the case of pb->error

2020-08-27 Thread Marton Balint
On Thu, 27 Aug 2020, Zhao Zhili wrote: --- Goto fail will make ffplay exit immediately. I'm not sure it is the expected behavior. How about just remove the check on pb->error so decoders can drain normally? I think it is fine as is, if we simply ignored the error, then looping would start a

Re: [FFmpeg-devel] [PATCH v6 1/4] lavc: add FLIF decoding support

2020-08-27 Thread Moritz Barsnick
On Wed, Aug 26, 2020 at 16:31:46 +, Anamitra Ghorui wrote: > >> +uint8_t ff_flif16_rac_read_bit(FLIF16RangeCoder *rc, > >> + uint8_t *target) > >> +{ > >> +return ff_flif16_rac_get(rc, rc->range >> 1, target); > >> +} > > > > If this is called often, you may wa

Re: [FFmpeg-devel] [PATCH v8 2/5] lavc/avs3: add AVS3 related definitions

2020-08-27 Thread myp...@gmail.com
On Thu, Aug 27, 2020 at 1:34 PM wrote: > > From: hwren > > Signed-off-by: hwren > --- > libavcodec/Makefile | 2 + > libavcodec/avs3.c | 95 + > libavcodec/avs3.h | 52 + > 3 files changed, 149 insertions(+) > create mode

Re: [FFmpeg-devel] [PATCH v6 1/4] lavc: add FLIF decoding support

2020-08-27 Thread Anamitra Ghorui
On Thu, 27 Aug 2020 08:46:00 +0530 Anamitra Ghorui wrote: > (I apologise if this mail gets sent to the wrong thread and other > errors. I'm trying out a new mail client) > > On Wed, 26 Aug 2020 16:31:46 + > "Anamitra Ghorui" wrote: > > [...] > > > I agree that the case statements between

Re: [FFmpeg-devel] [PATCH v6 1/4] lavc: add FLIF decoding support

2020-08-27 Thread Anamitra Ghorui
(I apologise if this mail gets sent to the wrong thread and other errors. I'm trying out a new mail client) On Wed, 26 Aug 2020 16:31:46 + "Anamitra Ghorui" wrote: [...] > I agree that the case statements between if statements and while > statements are not very good looking, but this allow