[FFmpeg-devel] [PATCH v5 0/2] animated WebP support

2020-09-10 Thread Zlomek, Josef
Adds support for animated WebP v5: * added version bumps v4: * using av_packet_new_side_data instead of av_packet_add_side_data v3: * generalized alpha blending to a common method * added support for seeking * updated existing tests for fate suite for WebP v2: * multi-threading support in decod

Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/webp: add support for animated WebP decoding

2020-09-10 Thread Zlomek, Josef
On Thu, Sep 10, 2020 at 1:27 PM Moritz Barsnick wrote: > On Wed, Sep 09, 2020 at 09:57:24 +0200, Zlomek, Josef wrote: > > On Tue, Sep 8, 2020 at 3:19 PM Moritz Barsnick wrote: > > > Missing version bumps. > > There is a version bump for libavformat, as new demuxer was added. > > I didn't see tha

[FFmpeg-devel] [PATCH v5 1/2] libavcodec/webp: add support for animated WebP decoding

2020-09-10 Thread Josef Zlomek
Fixes: 4907 Adds support for decoding of animated WebP. The WebP parser now splits the input stream into packets containing one frame. The WebP decoder adds the animation related features according to the specs: https://developers.google.com/speed/webp/docs/riff_container#animation The frames of

[FFmpeg-devel] [PATCH v5 2/2] libavformat/webp: add WebP demuxer

2020-09-10 Thread Josef Zlomek
Adds the demuxer of animated WebP files. It supports non-animated, animated, truncated, and concatenated files. Reading from a pipe (and other non-seekable inputs) is also supported. The WebP demuxer splits the input stream into packets containing one frame. It also marks the key frames properly.

Re: [FFmpeg-devel] [PATCH v2 0/7] HEVC native support for Screen content coding

2020-09-10 Thread Xiang, Haihao
Hi James, Your concerns about SCC PPS were addressed in the new version. http://ffmpeg.org/pipermail/ffmpeg-devel/2020-July/266037.html http://ffmpeg.org/pipermail/ffmpeg-devel/2020-July/266038.html Could you please take a look when you have time? Thanks Haihao > Resend Linjie's patchset wit

Re: [FFmpeg-devel] [PATCH] avfilter: add http video filter.

2020-09-10 Thread Timo Rothenpieler
Entirely outside of this filter being acceptable at all, pulling in libcurl is not an option without major safeguards for every single overlapping tls library both ffmpeg and curl support. If both are using the same library, there is a huge potential for libcurl being linked at all breaks ffmpeg

[FFmpeg-devel] [PATCH] avfilter: add http video filter.

2020-09-10 Thread Alex
Signed-off-by: alex_qt <3.1...@ukr.net> --- Changelog| 1 + configure| 4 + doc/filters.texi | 28 + libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/version.h| 2 +- libavfilter/vf_http.c| 221 ++

[FFmpeg-devel] [PATCH 3/3] avfilter/formats: Remove pointless checks

2020-09-10 Thread Andreas Rheinhardt
ff_formats_ref() takes a pointer to an AVFilterFormats and a pointer to a pointer to an AVFilterFormats as arguments and adds the latter as an owner to the list pointed to by the former; the latter is hereby always the address of a list contained in an AVFilterFormatsConfig and can therefore not be

[FFmpeg-devel] [PATCH 2/3] avfilter/af_aformat, formats: Unify freeing AVFilterFormatsConfig

2020-09-10 Thread Andreas Rheinhardt
AVFilterFormats and AVFilterChannelLayouts always exist together, namely in the aformat filter as well as in AVFilterLinks. Now that they are grouped together in a single structure in AVFilterLinks, the same can be done in aformat and then this structure can be freed on its own, replacing the freei

[FFmpeg-devel] [PATCH 1/3] avfilter/formats: Don't typedef structure a second time

2020-09-10 Thread Andreas Rheinhardt
Before commit 2f76476549a01ae2c4ec2a440e4b14c5aba64869, avfilter.h contained no typedef for AVFilterChannelLayouts; all references to it were done using its struct tag. formats.h meanwhile contained the definition of the struct and a typedef for it. Said commit now added a typedef in avfilter.h, to

[FFmpeg-devel] [PATCH] avcodec/mobiclip: Check quantizer before table setup

2020-09-10 Thread Michael Niedermayer
Fixes: index -1 out of bounds for type 'const uint8_t [6][16]' Fixes: out of array read Fixes: shift exponent -21 is negative Fixes: 25422/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MOBICLIP_fuzzer-5748258226569216 Fixes: shift exponent 8039082 is too large for 32-bit type 'int' Fixes: 254

Re: [FFmpeg-devel] [FFmpeg-cvslog] fate: disable automatic conversions on many tests.

2020-09-10 Thread James Almer
On 9/10/2020 3:47 PM, Michael Niedermayer wrote: > On Thu, Sep 10, 2020 at 07:35:12PM +0200, Nicolas George wrote: >> Michael Niedermayer (12020-09-10): >>> this breaks several tests on big endian as that needs converts at diffferent >>> places. >>> >>> heres a list of failures >> >> Thanks for poi

[FFmpeg-devel] [PATCH 5/9] avfilter/vf_subtitles: Fix leaks on failure

2020-09-10 Thread Andreas Rheinhardt
init_subtitles() sometimes returned directly upon error without cleaning up after itself. The easiest way to trigger this is by using picture-based subtitles; it is also possible to run into this in case of missing decoders or allocation failures. Furthermore, return the proper error code in case

[FFmpeg-devel] [PATCH 8/9] avfilter/vf_subtitles: Return early upon avformat_open_input() failure

2020-09-10 Thread Andreas Rheinhardt
There is nothing to free at this point. Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_subtitles.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_subtitles.c b/libavfilter/vf_subtitles.c index 08b4d4efca..f9733c3935 100644 --- a/libavfilter/vf_subtitles.

[FFmpeg-devel] [PATCH 6/9] avfilter/vf_subtitles: Remove unnecessary initialization of AVPacket

2020-09-10 Thread Andreas Rheinhardt
av_read_frame() can handle uninitialized packets. Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_subtitles.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavfilter/vf_subtitles.c b/libavfilter/vf_subtitles.c index 2d3145bf2d..a045375b2d 100644 --- a/libavfilter/vf_subtitles.c ++

[FFmpeg-devel] [PATCH 7/9] avfilter/vf_subtitles: Remove obsolete LIBAVCODEC_VERSION_INT checks

2020-09-10 Thread Andreas Rheinhardt
libavcodec major version is already 58. Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_subtitles.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/libavfilter/vf_subtitles.c b/libavfilter/vf_subtitles.c index a045375b2d..08b4d4efca 100644 --- a/libavfilter/vf

[FFmpeg-devel] [PATCH 4/9] avfilter/vf_uspp: Fix potential leak of dict on error

2020-09-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_uspp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_uspp.c b/libavfilter/vf_uspp.c index f6fb193433..72a0f562af 100644 --- a/libavfilter/vf_uspp.c +++ b/libavfilter/vf_uspp.c @@ -362,9 +362,9 @@ static int

[FFmpeg-devel] [PATCH 9/9] fftools, libavcodec, libavfilter: Add const to some AVCodec *

2020-09-10 Thread Andreas Rheinhardt
The user has no business modifying the underlying AVCodec. Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg.h | 5 +++-- fftools/ffmpeg_filter.c| 5 +++-- libavcodec/avrndec.c | 2 +- libavcodec/utils.c | 4 ++-- libavfilter/lavfutils.c| 2 +- libavfilter/src_

[FFmpeg-devel] [PATCH 3/9] avfilter/lavfutils: Avoid initializing packet

2020-09-10 Thread Andreas Rheinhardt
av_read_frame() can handle uninitialized packets. Signed-off-by: Andreas Rheinhardt --- libavfilter/lavfutils.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavfilter/lavfutils.c b/libavfilter/lavfutils.c index d7de89f4b3..57af5ebfdc 100644 --- a/libavfilter/lavfutils

[FFmpeg-devel] [PATCH 2/9] avfilter/lavfutils: Fix memleak when avformat_find_stream_info() fails

2020-09-10 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/lavfutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/lavfutils.c b/libavfilter/lavfutils.c index 84dd4c0704..d7de89f4b3 100644 --- a/libavfilter/lavfutils.c +++ b/libavfilter/lavfutils.c @@ -46,7 +46,7 @@ int

[FFmpeg-devel] [PATCH 1/9] avfilter/lavfutils: Don't use uninitialized pointers for freeing

2020-09-10 Thread Andreas Rheinhardt
Happened on several error conditions, e.g. if there is just no decoder for the format (like with svg images). Signed-off-by: Andreas Rheinhardt --- libavfilter/lavfutils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/lavfutils.c b/libavfilter/lavfutils.c in

Re: [FFmpeg-devel] [PATCH 2/2] avformat/moflex: make seeking more useful

2020-09-10 Thread Andreas Rheinhardt
Paul B Mahol: > Signed-off-by: Paul B Mahol > --- > libavformat/moflex.c | 19 ++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/libavformat/moflex.c b/libavformat/moflex.c > index 747e32f079..257408 100644 > --- a/libavformat/moflex.c > +++ b/libavformat

[FFmpeg-devel] [PATCH 1/2] avcodec/mobiclip: add missing flush

2020-09-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/mobiclip.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavcodec/mobiclip.c b/libavcodec/mobiclip.c index d147eddbae..c296ce3c78 100644 --- a/libavcodec/mobiclip.c +++ b/libavcodec/mobiclip.c @@ -1389,6 +1389,14 @@ static int mobiclip_d

[FFmpeg-devel] [PATCH 2/2] avformat/moflex: make seeking more useful

2020-09-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/moflex.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/libavformat/moflex.c b/libavformat/moflex.c index 747e32f079..257408 100644 --- a/libavformat/moflex.c +++ b/libavformat/moflex.c @@ -327,7 +327,13 @@ s

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/fastaudio: Remove redundant % 32

2020-09-10 Thread Michael Niedermayer
On Wed, Sep 09, 2020 at 03:01:41AM +0200, Paul B Mahol wrote: > On Tue, Sep 08, 2020 at 11:29:20PM +0200, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/fastaudio.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > ok will apply thx [

Re: [FFmpeg-devel] [PATCH] avcodec/agm: Fix off by 1 error in decode_inter_plane()

2020-09-10 Thread Michael Niedermayer
On Thu, Sep 10, 2020 at 09:15:22PM +0200, Paul B Mahol wrote: > On Thu, Sep 10, 2020 at 07:04:54PM +0200, Michael Niedermayer wrote: > > Fixes: Regression since 1f2096945709a32315da740691b5716da55893c3 > > Found-by: > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/agm.c | 4 ++-- > >

Re: [FFmpeg-devel] [PATCH] avcodec/agm: Fix off by 1 error in decode_inter_plane()

2020-09-10 Thread Paul B Mahol
On Thu, Sep 10, 2020 at 07:04:54PM +0200, Michael Niedermayer wrote: > Fixes: Regression since 1f2096945709a32315da740691b5716da55893c3 > Found-by: > Signed-off-by: Michael Niedermayer > --- > libavcodec/agm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > lgtm _

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mips: [loongson] Fixed mmi optimization

2020-09-10 Thread Michael Niedermayer
On Thu, Sep 03, 2020 at 02:29:51PM +0800, Shiyou Yin wrote: > From: gxw > > Test case fate-checkasm-h264pred failed in latest community code. > This patch fixed the bug. will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "I am not trying to be any

Re: [FFmpeg-devel] [PATCH 2/2] Fix msa can't be disabled when '--cpu=loongson3a' assigned.

2020-09-10 Thread Michael Niedermayer
On Thu, Sep 10, 2020 at 07:05:38PM +0800, Shiyou Yin wrote: > >-Original Message- > >From: ffmpeg-devel-boun...@ffmpeg.org > >[mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > >Shiyou Yin > >Sent: Thursday, September 3, 2020 2:30 PM > >To: ffmpeg-devel@ffmpeg.org > >Subject: [FFmpeg-

Re: [FFmpeg-devel] [FFmpeg-cvslog] fate: disable automatic conversions on many tests.

2020-09-10 Thread Michael Niedermayer
On Thu, Sep 10, 2020 at 07:35:12PM +0200, Nicolas George wrote: > Michael Niedermayer (12020-09-10): > > this breaks several tests on big endian as that needs converts at diffferent > > places. > > > > heres a list of failures > > Thanks for pointing it. I do not see these archs on fate.ffmpeg.or

Re: [FFmpeg-devel] [FFmpeg-cvslog] fate: disable automatic conversions on many tests.

2020-09-10 Thread Nicolas George
Michael Niedermayer (12020-09-10): > this breaks several tests on big endian as that needs converts at diffferent > places. > > heres a list of failures Thanks for pointing it. I do not see these archs on fate.ffmpeg.org. Is there a way to get the error output? Anyway, I will try to find a big-e

[FFmpeg-devel] [PATCH] avcodec/agm: Fix off by 1 error in decode_inter_plane()

2020-09-10 Thread Michael Niedermayer
Fixes: Regression since 1f2096945709a32315da740691b5716da55893c3 Found-by: Signed-off-by: Michael Niedermayer --- libavcodec/agm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/agm.c b/libavcodec/agm.c index 19490c5456..f60cbf1a18 100644 --- a/libavcodec/agm.

Re: [FFmpeg-devel] [FFmpeg-cvslog] fate: disable automatic conversions on many tests.

2020-09-10 Thread Michael Niedermayer
On Tue, Sep 08, 2020 at 12:20:25PM +, Nicolas George wrote: > ffmpeg | branch: master | Nicolas George | Fri Aug 14 > 18:58:27 2020 +0200| [f08e024ac7d249064648a43bab06ed545f8827c7] | committer: > Nicolas George > > fate: disable automatic conversions on many tests. > > Explicitly insert t

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/videotoolboxenc: fix use after destroy

2020-09-10 Thread Zhao Zhili
> 在 2020年9月10日,下午10:21,Richard Kern 写道: > >  > >> On Sep 10, 2020, at 8:57 AM, zhilizhao wrote: >> >>  >> On Aug 28, 2020, at 8:55 AM, Steven Liu wrote: >>> >>> 于2020年8月27日周四 下午5:39写道: From: Zhao Zhili The lock is used in clear_frame_queue(). --- li

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/videotoolboxenc: fix use after destroy

2020-09-10 Thread Richard Kern
> On Sep 10, 2020, at 8:57 AM, zhilizhao wrote: > >  > >> On Aug 28, 2020, at 8:55 AM, Steven Liu wrote: >> >> 于2020年8月27日周四 下午5:39写道: >>> >>> From: Zhao Zhili >>> >>> The lock is used in clear_frame_queue(). >>> --- >>> libavcodec/videotoolboxenc.c | 11 +++ >>> 1 file changed,

Re: [FFmpeg-devel] [PATCH v4 1/1] avformat: add mca demuxer

2020-09-10 Thread Paul B Mahol
On Thu, Sep 03, 2020 at 04:32:37PM -0600, liush...@aosc.io wrote: > From: Zixing Liu > > Signed-off-by: liushuyu > --- > Changelog| 1 + > doc/general.texi | 2 + > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/mca.c| 226

[FFmpeg-devel] [PATCH] avcodec/utils: make the src paramater for ff_thread_ref_frame const

2020-09-10 Thread James Almer
Signed-off-by: James Almer --- libavcodec/thread.h | 2 +- libavcodec/utils.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/thread.h b/libavcodec/thread.h index 540135fbc9..87bf154da9 100644 --- a/libavcodec/thread.h +++ b/libavcodec/thread.h @@ -129,7 +129,7

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/videotoolboxenc: fix use after destroy

2020-09-10 Thread zhilizhao
> On Aug 28, 2020, at 8:55 AM, Steven Liu wrote: > > 于2020年8月27日周四 下午5:39写道: >> >> From: Zhao Zhili >> >> The lock is used in clear_frame_queue(). >> --- >> libavcodec/videotoolboxenc.c | 11 +++ >> 1 file changed, 7 insertions(+), 4 deletions(-) >> >> diff --git a/libavcodec/videot

[FFmpeg-devel] [PATCH] dnn/native: add native support for dense

2020-09-10 Thread Mingyu Yin
Signed-off-by: Mingyu Yin --- libavfilter/dnn/Makefile | 1 + libavfilter/dnn/dnn_backend_native.h | 2 + .../dnn/dnn_backend_native_layer_conv2d.h | 1 - .../dnn/dnn_backend_native_layer_dense.c | 151 ++ .../dnn/dnn_backend_native_lay

[FFmpeg-devel] [PATCH 2/2] avcodec/utils: Require a non zero channels unless AV_CODEC_CAP_CHANNEL_CONF is set

2020-09-10 Thread Michael Niedermayer
This avoids per codec checks for channels not being 0 Fixes: division by 0 Fixes: 25419/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FASTAUDIO_fuzzer-5632544761184256 Fixes: 25433/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FASTAUDIO_fuzzer-6215671900536832 Found-by: continuous fuzzi

[FFmpeg-devel] [PATCH 1/2] avcodec: Set AV_CODEC_CAP_CHANNEL_CONF in more decoders

2020-09-10 Thread Michael Niedermayer
Suggested-by: Paul B Mahol See: [FFmpeg-devel] [PATCH 1/3] avcodec/fastaudio: Check channels Signed-off-by: Michael Niedermayer --- libavcodec/ac3dec_fixed.c | 3 ++- libavcodec/ac3dec_float.c | 6 -- libavcodec/adxdec.c | 3 ++- libavcodec/flacdec.c|

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/fastaudio: Check channels

2020-09-10 Thread Michael Niedermayer
On Wed, Sep 09, 2020 at 03:00:51AM +0200, Paul B Mahol wrote: > On Tue, Sep 08, 2020 at 11:29:19PM +0200, Michael Niedermayer wrote: > > Fixes: division by 0 > > Fixes: > > 25419/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FASTAUDIO_fuzzer-5632544761184256 > > Fixes: > > 25433/clusterfuzz-t

Re: [FFmpeg-devel] [PATCH 2/3] avfilter/src_movie: Remove unnecessary secondary AVPacket

2020-09-10 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12020-09-10): >> The movie and amovie filters currently use two packets. One of the two, >> pkt0, is the owner of the returned packet; it is also the destination >> packet for av_read_frame(). The other one pkt is initially (i.e. after >> av_read_frame()) a cop

[FFmpeg-devel] [PATCH] avformat/flic: add support for seeking to start

2020-09-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/flic.c | 38 +++--- 1 file changed, 35 insertions(+), 3 deletions(-) diff --git a/libavformat/flic.c b/libavformat/flic.c index e65c15..4552bff69c 100644 --- a/libavformat/flic.c +++ b/libavformat/flic.c @@ -202,6 +2

Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/webp: add support for animated WebP decoding

2020-09-10 Thread Moritz Barsnick
On Wed, Sep 09, 2020 at 09:57:24 +0200, Zlomek, Josef wrote: > On Tue, Sep 8, 2020 at 3:19 PM Moritz Barsnick wrote: > > Missing version bumps. > There is a version bump for libavformat, as new demuxer was added. I didn't see that in v4. > I did not know that version should be increased also whe

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mips: [loongson] Fixed mmi optimization

2020-09-10 Thread Shiyou Yin
>-Original Message- >From: ffmpeg-devel-boun...@ffmpeg.org [mailto:ffmpeg-devel-boun...@ffmpeg.org] >On Behalf Of >Shiyou Yin >Sent: Thursday, September 3, 2020 2:30 PM >To: ffmpeg-devel@ffmpeg.org >Cc: gxw >Subject: [FFmpeg-devel] [PATCH 1/2] avcodec/mips: [loongson] Fixed mmi >optimizat

Re: [FFmpeg-devel] [PATCH 2/2] Fix msa can't be disabled when '--cpu=loongson3a' assigned.

2020-09-10 Thread Shiyou Yin
>-Original Message- >From: ffmpeg-devel-boun...@ffmpeg.org [mailto:ffmpeg-devel-boun...@ffmpeg.org] >On Behalf Of >Shiyou Yin >Sent: Thursday, September 3, 2020 2:30 PM >To: ffmpeg-devel@ffmpeg.org >Subject: [FFmpeg-devel] [PATCH 2/2] Fix msa can't be disabled when >'--cpu=loongson3a' ass

Re: [FFmpeg-devel] [PATCH] libavcodec/options_table: Add missing colorspace options

2020-09-10 Thread Gyan Doshi
On 08-09-2020 08:31 pm, Harry Mallon wrote: On 8 Sep 2020, at 14:29, Gyan Doshi wrote: On 08-09-2020 06:23 pm, Harry Mallon wrote: On 8 Sep 2020, at 13:08, Gyan Doshi wrote: Hi Harry, On 06-09-2020 04:24 pm, Gyan Doshi wrote: On 06-09-2020 02:59 pm, Harry Mallon wrote: Is there anyt

Re: [FFmpeg-devel] [PATCH] avformat/utils: Avoid duplicating extradata from extract_extradata BSF

2020-09-10 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Instead move the extradata contained in packet side-data to its > destination. This is possible because the side data already has zeroed > padding. > > Notice that the check for FF_MAX_EXTRADATA_SIZE has been dropped, > because said constant is from libavcodec/internal.h. If

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/extract_extradata: Remove always-true check

2020-09-10 Thread Andreas Rheinhardt
Andreas Rheinhardt: > If a sequence header has already been found, it is certain that the next > startcode (being disjoint from the sequence header startcode) can begin > at index four at the earliest. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/extract_extradata_bsf.c | 2 -- > 1 f

Re: [FFmpeg-devel] [PATCH 1/1] avfilter/vf_premultiply: add support for gbrapf32 format

2020-09-10 Thread Paul B Mahol
On Wed, Sep 09, 2020 at 08:36:08PM -0700, mindm...@gmail.com wrote: > From: Mark Reid > > --- > libavfilter/vf_premultiply.c | 118 ++- > 1 file changed, 115 insertions(+), 3 deletions(-) > LGTM, applied. ___ ffmpeg-de

Re: [FFmpeg-devel] [PATCH 2/3] avfilter/src_movie: Remove unnecessary secondary AVPacket

2020-09-10 Thread Nicolas George
Andreas Rheinhardt (12020-09-10): > The movie and amovie filters currently use two packets. One of the two, > pkt0, is the owner of the returned packet; it is also the destination > packet for av_read_frame(). The other one pkt is initially (i.e. after > av_read_frame()) a copy of pkt0; copy means