Re: [FFmpeg-devel] [PATCH] avformat: implement SChannel SSP TLS protocol

2015-10-28 Thread Hendrik Leppkes
On Wed, Oct 21, 2015 at 1:52 PM, Hendrik Leppkes wrote: > This implementation does not support TLS listen sockets and loading > CA/Certs from files. > > The Windows API does not support loading PEM certs, and would either > require a manual loader or instead be limited to

Re: [FFmpeg-devel] [PATCH] avformat: implement SChannel SSP TLS protocol

2015-10-28 Thread Hendrik Leppkes
On Wed, Oct 28, 2015 at 6:07 PM, Derek Buitenhuis wrote: > Enjoy my half-assed / useless review. > >> +#ifndef SECBUFFER_ALERT >> +#define SECBUFFER_ALERT17 >> +#endif > > Why? I think it was needed on some configuration, I'll verify. > >> +

Re: [FFmpeg-devel] [PATCH] avformat: implement SChannel SSP TLS protocol

2015-10-28 Thread Derek Buitenhuis
Enjoy my half-assed / useless review. > +#ifndef SECBUFFER_ALERT > +#define SECBUFFER_ALERT17 > +#endif Why? > +SecPkgContext_StreamSizes Sizes; Accidental capital? > +if (c->enc_buf == NULL) { > +c->enc_buf_offset = 0; > +c->enc_buf_size =

[FFmpeg-devel] [PATCH] avformat: implement SChannel SSP TLS protocol

2015-10-21 Thread Hendrik Leppkes
This implementation does not support TLS listen sockets and loading CA/Certs from files. The Windows API does not support loading PEM certs, and would either require a manual loader or instead be limited to loading Windows PFX certificates TLS listen sockets would have to be implemented quite