Re: [FFmpeg-devel] [PATCH 09/11] aaccoder: add a new perceptual noise substitution implementation

2015-06-29 Thread Claudio Freire
On Tue, Jun 30, 2015 at 1:33 AM, Rostislav Pehlivanov wrote: > > Why the need to have "sce->pns_ener[w*16+g] = energy / > sce->ics.group_len[w];", normalization? The energy value is log2'd during > scalefactor indices calculation so it's hardly going to change much. Will do > some tests to see if

Re: [FFmpeg-devel] [PATCH 09/11] aaccoder: add a new perceptual noise substitution implementation

2015-06-29 Thread Rostislav Pehlivanov
As lambda increases (more quality) the chance to get PNS decreases with your suggestion to use "spread > (NOISE_SPREAD_THRESHOLD * 120.f / lambda)". It's more correct to have spread > (NOISE_SPREAD_THRESHOLD * (lambda / 120.0f)) here. The spectrums showed a hole right in between the PNS and normal

Re: [FFmpeg-devel] [PATCH 09/11] aaccoder: add a new perceptual noise substitution implementation

2015-06-29 Thread Claudio Freire
On Mon, Jun 29, 2015 at 10:58 PM, Claudio Freire wrote: > On Fri, Jun 26, 2015 at 5:16 PM, Rostislav Pehlivanov > wrote: >> +if (spread > NOISE_SPREAD_THRESHOLD && >> +((sce->zeroes[w*16+g] && energy >= threshold) || >> +energy < threshold*(

Re: [FFmpeg-devel] [PATCH 09/11] aaccoder: add a new perceptual noise substitution implementation

2015-06-29 Thread Claudio Freire
On Fri, Jun 26, 2015 at 5:16 PM, Rostislav Pehlivanov wrote: > +if (spread > NOISE_SPREAD_THRESHOLD && > +((sce->zeroes[w*16+g] && energy >= threshold) || > +energy < threshold*(NOISE_LAMBDA_NUMERATOR/lambda))) { > +sce->b

[FFmpeg-devel] [PATCH 09/11] aaccoder: add a new perceptual noise substitution implementation

2015-06-26 Thread Rostislav Pehlivanov
This commit finalizes the PNS implementation previously added to the encoder by moving it to a seperate function search_for_pns() and thus making it coder-generic. This new implementation makes use of the spread field of the psy bands and the lambda quality feedback paremeter. The spread of the