Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018.08.06. 16:20 keltezéssel, Steven Liu írta: On Aug 6, 2018, at 19:29, Ronak Patel wrote: On Aug 6, 2018, at 7:19 AM, Liu Steven wrote: 在 2018年8月6日，下午7:12，Ronak Patel 写道： On Aug 5, 2018, at 10:54 PM, Liu Steven wrote: 在 2018年8月4日，上午2:17，Ronak 写道： I have read this patch s

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

> On Aug 14, 2018, at 05:06, Ronak wrote: > >> >> On Aug 13, 2018, at 10:49 AM, Steven Liu wrote: >>> Hi Steven, Did you have a chance to review this patch? I haven't seen your feedback yet. Did you have a chance to try it out? I would like to get this merged

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

> On Aug 13, 2018, at 4:48 PM, Ronak wrote: > > On Aug 13, 2018, at 10:49 AM, Steven Liu wrote: >> >>> >>> Hi Steven, >>> >>> Did you have a chance to review this patch? I haven't seen your feedback >>> yet. Did you have a chance to try it out? >>> I would like to get this merged this week

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

On Aug 13, 2018, at 10:49 AM, Steven Liu wrote: > >> >> Hi Steven, >> >> Did you have a chance to review this patch? I haven't seen your feedback >> yet. Did you have a chance to try it out? >> I would like to get this merged this week. > 1. you MUST update the TARGET DURATION if the new fragm

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

> > Hi Steven, > > Did you have a chance to review this patch? I haven't seen your feedback yet. > Did you have a chance to try it out? > I would like to get this merged this week. 1. you MUST update the TARGET DURATION if the new fragment is long than old fragment, don't only test your audio file

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

> On Aug 10, 2018, at 6:31 AM, Ronak Patel > wrote: > >> >> On Aug 8, 2018, at 5:37 PM, Ronak wrote: >> >> >> >>> On Aug 8, 2018, at 3:52 PM, Ronak wrote: >>> >>> >>> On Aug 6, 2018, at 10:20 AM, Steven Liu wrote: >> On Aug 6, 2018, at 19:29, Ronak Patel >

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

On Aug 10, 2018, at 7:30 AM, Liu Steven wrote: >>> >>> Hi Steven, >>> >>> Please see my new patch taking your feedback into account. >>> >>> Ronak >> >> Hi Steven, >> >> Did you have a chance to review? I’m going to send you a new patch for >> dashenc.c shortly. > Don’t worry, i will

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

>>> >> >> Hi Steven, >> >> Please see my new patch taking your feedback into account. >> >> Ronak > > Hi Steven, > > Did you have a chance to review? I’m going to send you a new patch for > dashenc.c shortly. Don’t worry, i will review it weekend, but i think your ways is not a better way,

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

> On Aug 8, 2018, at 5:37 PM, Ronak wrote: > > > >> On Aug 8, 2018, at 3:52 PM, Ronak wrote: >> >> >> >>> On Aug 6, 2018, at 10:20 AM, Steven Liu wrote: >>> >>> >>> > On Aug 6, 2018, at 19:29, Ronak Patel > wrote: > > > On Aug 6, 2018, at 7:19 AM, Liu Steven wr

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

> On Aug 8, 2018, at 3:52 PM, Ronak wrote: > > > >> On Aug 6, 2018, at 10:20 AM, Steven Liu wrote: >> >> >> >>> On Aug 6, 2018, at 19:29, Ronak Patel >>> wrote: >>> On Aug 6, 2018, at 7:19 AM, Liu Steven wrote: >> 在 2018年8月6日，下午7:12，Ronak Patel 写道： >>

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

> On Aug 6, 2018, at 10:20 AM, Steven Liu wrote: > > > >> On Aug 6, 2018, at 19:29, Ronak Patel >> wrote: >> >>> >>> On Aug 6, 2018, at 7:19 AM, Liu Steven wrote: >>> >>> >>> > 在 2018年8月6日，下午7:12，Ronak Patel 写道： > > > On Aug 5, 2018, at 10:54 PM, Liu Steven wrote:

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

> On Aug 6, 2018, at 19:29, Ronak Patel > wrote: > >> >> On Aug 6, 2018, at 7:19 AM, Liu Steven wrote: >> >> >> 在 2018年8月6日，下午7:12，Ronak Patel 写道： On Aug 5, 2018, at 10:54 PM, Liu Steven wrote: > 在 2018年8月4日，上午2:17，Ronak 写道： > >>

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

> On Aug 6, 2018, at 7:19 AM, Liu Steven wrote: > > > >>> 在 2018年8月6日，下午7:12，Ronak Patel 写道： >>> >>> >>> On Aug 5, 2018, at 10:54 PM, Liu Steven wrote: >>> >>> >>> 在 2018年8月4日，上午2:17，Ronak 写道： >> I have read this patch some problem for this patch. >> >>>

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

> 在 2018年8月6日，下午7:12，Ronak Patel 写道： > >> >> On Aug 5, 2018, at 10:54 PM, Liu Steven wrote: >> >> >> >>> 在 2018年8月4日，上午2:17，Ronak 写道： >>> > I have read this patch some problem for this patch. > > 1. maybe there will have a problem when duration is not same when

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

> On Aug 5, 2018, at 10:54 PM, Liu Steven wrote: > > > >> 在 2018年8月4日，上午2:17，Ronak 写道： >> I have read this patch some problem for this patch. 1. maybe there will have a problem when duration is not same when every fragment, for example: liuqideM

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

> 在 2018年8月4日，上午2:17，Ronak 写道： > >>> I have read this patch some problem for this patch. >>> >>> 1. maybe there will have a problem when duration is not same when every >>> fragment, for example: >>> liuqideMacBook-Pro:xxx liuqi$ ./ffmpeg -v quiet -i >>> ~/Movies/Test

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

> I'm attaching a new patch that resolves all of these issues, while still > resolving this bug for VOD playlists. > > Can you please review? > > <0001-libavformat-hlsenc-Fix-HLS-Manifest-Generation-from-.patch> Hi Steven, Can you please have a look at the updated patch and tell me what you t

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

>> I have read this patch some problem for this patch. >> >> 1. maybe there will have a problem when duration is not same when every >> fragment, for example: >> liuqideMacBook-Pro:xxx liuqi$ ./ffmpeg -v quiet -i >> ~/Movies/Test/bbb_sunflower_1080p_30fps_normal.mp4 -c co

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

> On Aug 1, 2018, at 9:30 PM, Ronak Patel > wrote: > > >> On Aug 1, 2018, at 7:30 PM, Steven Liu wrote: >> >> >> >>> On Aug 2, 2018, at 07:22, Steven Liu wrote: >>> >>> >>> > On Aug 2, 2018, at 06:20, Ronak wrote: > > > On Aug 1, 2018, at 4:41 PM, Steven Liu wrote:

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

> On Aug 1, 2018, at 7:30 PM, Steven Liu wrote: > > > >> On Aug 2, 2018, at 07:22, Steven Liu wrote: >> >> >> On Aug 2, 2018, at 06:20, Ronak wrote: On Aug 1, 2018, at 4:41 PM, Steven Liu wrote: > On Aug 2, 2018, at 03:50, Ronak wrote: >

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

> On Aug 2, 2018, at 07:22, Steven Liu wrote: > > > >> On Aug 2, 2018, at 06:20, Ronak wrote: >> >>> >>> On Aug 1, 2018, at 4:41 PM, Steven Liu wrote: >>> >>> >>> On Aug 2, 2018, at 03:50, Ronak wrote: <0001-libavformat-hlsenc-Fix-HLS-Manifest-Generation-from-.patch> >

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

> On Aug 2, 2018, at 06:20, Ronak wrote: > >> >> On Aug 1, 2018, at 4:41 PM, Steven Liu wrote: >> >> >> >>> On Aug 2, 2018, at 03:50, Ronak wrote: >>> >>> <0001-libavformat-hlsenc-Fix-HLS-Manifest-Generation-from-.patch> >> From e7ff03ed52c709d647a112833427b44c41e3ed12 Mon Sep 17 00:00:0

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

> On Aug 1, 2018, at 4:41 PM, Steven Liu wrote: > > > >> On Aug 2, 2018, at 03:50, Ronak wrote: >> >> <0001-libavformat-hlsenc-Fix-HLS-Manifest-Generation-from-.patch> > From e7ff03ed52c709d647a112833427b44c41e3ed12 Mon Sep 17 00:00:00 2001 > From: "Ronak Patel (Audible)" > Date: Tue, 31 Ju

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

> On Aug 2, 2018, at 03:50, Ronak wrote: > > <0001-libavformat-hlsenc-Fix-HLS-Manifest-Generation-from-.patch> From e7ff03ed52c709d647a112833427b44c41e3ed12 Mon Sep 17 00:00:00 2001 From: "Ronak Patel (Audible)" Date: Tue, 31 Jul 2018 19:05:18 -0400 Subject: [PATCH] libavformat/hlsenc: Fix HLS

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

> On Aug 1, 2018, at 2:14 PM, Carl Eugen Hoyos wrote: > > 2018-08-01 20:02 GMT+02:00, Ronak : >> I'm re-sending the attachment. > > Your patch contains tabs that cannot be committed to FFmpeg's repository - > please remove them. > Sounds good. Tabs are now removed. 0001-libavformat-hlsenc-F

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-01 20:02 GMT+02:00, Ronak : > I'm re-sending the attachment. Your patch contains tabs that cannot be committed to FFmpeg's repository - please remove them. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailma

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

I'm re-sending the attachment. Not sure why it's not showing up. 0001-libavformat-hlsenc-Fix-HLS-Manifest-Generation-from-.patch Description: Binary data > On Aug 1, 2018, at 1:56 PM, Carl Eugen Hoyos wrote: > > 2018-08-01 18:39 GMT+02:00, Ronak : > >> Here's my first proposed patch for fix

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-01 18:39 GMT+02:00, Ronak : > Here's my first proposed patch for fixing > https://trac.ffmpeg.org/ticket/7281 No patch visible here: http://ffmpeg.org/pipermail/ffmpeg-devel/2018-August/232785.html Carl Eugen ___ ffmpeg-devel mailing list ffmpe

[FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

Hi all, Here's my first proposed patch for fixing https://trac.ffmpeg.org/ticket/7281 . I'm going to send a second patch that will apply the same set of fixes to dashenc.c. Thanks, Ronak ___ ffmpeg-devel mailing