Re: [Freedreno] [PATCH v2 3/4] drm/msm: get rid of msm_iomap_size

2021-04-27 Thread Bjorn Andersson
On Mon 26 Apr 19:18 CDT 2021, Dmitry Baryshkov wrote: [..] > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index 92fe844b517b..be578fc4e54f 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -124,7 +124,7 @@ struct clk

Re: [Freedreno] [PATCH 1/2] drm/msm/dp: service only one irq_hpd if there are multiple irq_hpd pending

2021-04-27 Thread Stephen Boyd
Quoting aravi...@codeaurora.org (2021-04-21 11:55:21) > On 2021-04-21 10:26, khs...@codeaurora.org wrote: > >> > >>> + > >>> mutex_unlock(>event_mutex); > >>> > >>> return 0; > >>> @@ -1496,6 +1502,9 @@ int msm_dp_display_disable(struct msm_dp *dp, > >>> struct drm_encoder

Re: [Freedreno] [PATCH v2 4/4] drm/msm/dsi: add DSI PHY registers to snapshot data

2021-04-27 Thread abhinavk
On 2021-04-26 17:18, Dmitry Baryshkov wrote: Add DSI PHY registers to the msm state snapshots to be able to check their contents. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi.c | 1 + drivers/gpu/drm/msm/dsi/dsi.h | 1 +

Re: [Freedreno] [PATCH v2 3/4] drm/msm: get rid of msm_iomap_size

2021-04-27 Thread abhinavk
On 2021-04-27 13:32, Dmitry Baryshkov wrote: On Tue, 27 Apr 2021 at 22:30, wrote: Hi Dmitry On 2021-04-26 17:18, Dmitry Baryshkov wrote: > Instead of looping throught the resources each time to get the DSI CTRL > area size, get it at the ioremap time. > > Signed-off-by: Dmitry Baryshkov We

Re: [Freedreno] [PATCH v2 2/4] drm/msm: make msm_disp_state transient data struct

2021-04-27 Thread abhinavk
On 2021-04-27 13:29, Dmitry Baryshkov wrote: On Tue, 27 Apr 2021 at 22:19, wrote: Hi Dmitry On 2021-04-26 17:18, Dmitry Baryshkov wrote: > Instead of allocating snapshotting structure at the driver probe time > and later handling concurrent access, actual state, etc, make > msm_disp_state

Re: [Freedreno] [PATCH v2 3/4] drm/msm: get rid of msm_iomap_size

2021-04-27 Thread Dmitry Baryshkov
On Tue, 27 Apr 2021 at 22:30, wrote: > > Hi Dmitry > > On 2021-04-26 17:18, Dmitry Baryshkov wrote: > > Instead of looping throught the resources each time to get the DSI CTRL > > area size, get it at the ioremap time. > > > > Signed-off-by: Dmitry Baryshkov > We will have to call into the

Re: [Freedreno] [PATCH v2 2/4] drm/msm: make msm_disp_state transient data struct

2021-04-27 Thread Dmitry Baryshkov
On Tue, 27 Apr 2021 at 22:19, wrote: > > Hi Dmitry > > On 2021-04-26 17:18, Dmitry Baryshkov wrote: > > Instead of allocating snapshotting structure at the driver probe time > > and later handling concurrent access, actual state, etc, make > > msm_disp_state transient struct. Allocate one when

Re: [Freedreno] [PATCH v2 3/4] drm/msm: get rid of msm_iomap_size

2021-04-27 Thread abhinavk
Hi Dmitry On 2021-04-26 17:18, Dmitry Baryshkov wrote: Instead of looping throught the resources each time to get the DSI CTRL area size, get it at the ioremap time. Signed-off-by: Dmitry Baryshkov We will have to call into the individual modules anyway everytime we take a snapshot as only

Re: [Freedreno] [PATCH v2 2/4] drm/msm: make msm_disp_state transient data struct

2021-04-27 Thread abhinavk
Hi Dmitry On 2021-04-26 17:18, Dmitry Baryshkov wrote: Instead of allocating snapshotting structure at the driver probe time and later handling concurrent access, actual state, etc, make msm_disp_state transient struct. Allocate one when snapshotting happens and free it after coredump data is

Re: [Freedreno] [PATCH v2 0/4] drm/msm: improve register snapshotting

2021-04-27 Thread abhinavk
On 2021-04-26 17:18, Dmitry Baryshkov wrote: Rework MSM coredump support: add DSI PHY registers, simplify snapshotting code. Changes since v1: - Readd mutex serializing register snapshot calls - Add DSI PHY register dumping support Need to mention the dependency here , got missed from the