nt for atomic_enable() and also
> use drm_atomic_get_new_connector_for_encoder() to get the connector from
> the atomic_state.
>
> Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
> Reported-by: Dmitry Baryshkov
> Suggested-by: Dmitry Baryshkov
> Signed-off-by: Abhinav Kumar
provide a summary of features actually tested with the
DPU driver? Have you tested YUV output? Have you tested RGB planes?
Which LMs have you tested?
> Signed-off-by: Barnabás Czémán
> ---
> Dmitry Baryshkov (1):
> drm/msm/dpu: add support for MSM8953
>
> Konrad Dybcio (1
gt; >
> >Note, by default these platforms are still handled by the MDP5 driver
> >unless the `msm.prefer_mdp5=false' parameter is provided.
> >
> >Signed-off-by: Barnabás Czémán
> >---
> >Dmitry Baryshkov (1):
> > drm/msm/dpu: add suppor
On Wed, 31 Jul 2024 at 22:36, Abhinav Kumar wrote:
>
>
>
> On 6/26/2024 2:45 PM, Dmitry Baryshkov wrote:
> > YUV formats require only CSC to be enabled. Even decimated formats
> > should not require scaler. Relax the requirement and don't check for the
> >
On Mon, Jul 29, 2024 at 09:38:48PM GMT, Richard Acayan wrote:
> The Snapdragon 670 has the Adreno A615 GPU. Add it along with its device
> tree dependencies.
>
> Signed-off-by: Richard Acayan
> ---
> arch/arm64/boot/dts/qcom/sdm670.dtsi | 168 +++
> 1 file changed, 168 in
On Wed, 31 Jul 2024 at 01:27, Bjorn Andersson wrote:
>
> On Tue, Jul 30, 2024 at 11:58:19PM +0300, Dmitry Baryshkov wrote:
> > Hi Abhinav,
> >
> > On Tue, 30 Jul 2024 at 22:50, Abhinav Kumar
> > wrote:
> > >
> > > Hardware document indicates tha
;drm/msm/dp: enable widebus feature for display port")
Fixes: 1b2d98bdd7b7 ("drm/msm/dp: Add DisplayPort controller for SM8650")
> Signed-off-by: Abhinav Kumar
> Reviewed-by: Dmitry Baryshkov
> ---
> drivers/gpu/drm/msm/dp/dp_display.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
--
With best wishes
Dmitry
I think that in mode_valid() the driver should filter out modes that
result in BPP being less than 18. Then the max_t can be dropped
completely.
Nevertheless this indeed fixes an issue with the screen corruption,
this is great!
Tested-by: Dmitry Baryshkov # SM8350-HDK
> +
> drm_dbg_dp(panel->drm_dev, "updated bpp = %d\n",
> dp_panel->dp_mode.bpp);
>
> --
> 2.44.0
>
--
With best wishes
Dmitry
Abhinav Kumar
> ---
> drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Dmitry Baryshkov
Tested-by: Dmitry Baryshkov # SM8350-HDK
--
With best wishes
Dmitry
ures.
>
> Fixes: 8ede2ecc3e5e ("drm/msm/dp: Add DP compliance tests on Snapdragon
> Chipsets")
> Signed-off-by: Abhinav Kumar
Reviewed-by: Dmitry Baryshkov
Tested-by: Dmitry Baryshkov # SM8350-HDK
--
With best wishes
Dmitry
On Tue, 23 Jul 2024 at 15:57, Marc Gonzalez wrote:
>
> On 23/07/2024 13:45, Konrad Dybcio wrote:
>
> > On 23.07.2024 11:59 AM, Dmitry Baryshkov wrote:
> >
> >> On Tue, 23 Jul 2024 at 12:48, Marc Gonzalez wrote:
> >>
> >>> On 16/07/2024 18:37, D
On Tue, 23 Jul 2024 at 12:48, Marc Gonzalez wrote:
>
> On 16/07/2024 18:37, Dmitry Baryshkov wrote:
>
> > No, that's fine. It is the SMMU issue that Konrad has been asking you
> > to take a look at.
>
> Context:
>
> [4.911422] arm-smmu cd0.iommu: F
On Wed, 17 Jul 2024 at 23:15, Abhinav Kumar wrote:
>
>
>
> On 6/24/2024 2:13 PM, Dmitry Baryshkov wrote:
> > The struct dpu_hw_fmt_layout defines hardware data layout (addresses,
> > sizes and pitches. Drop format field from this structure as it's not a
>
On Wed, Jul 17, 2024 at 03:42:46PM GMT, Maxime Ripard wrote:
> Hi,
>
> On Mon, Jul 15, 2024 at 09:33:02AM GMT, Dmitry Baryshkov wrote:
> > Document that DRM_MODE_PROP_IMMUTABLE must be set for the properties
> > that are immutable by definition - e.g. ranges with min == ma
On Wed, 17 Jul 2024 at 02:15, Abhinav Kumar wrote:
>
>
>
> On 7/16/2024 4:10 PM, Dmitry Baryshkov wrote:
> > On Wed, 17 Jul 2024 at 01:43, Abhinav Kumar
> > wrote:
> >>
> >>
> >>
> >> On 7/16/2024 2:50 PM, Rob Clark wrote:
>
On Wed, 17 Jul 2024 at 01:43, Abhinav Kumar wrote:
>
>
>
> On 7/16/2024 2:50 PM, Rob Clark wrote:
> > On Tue, Jul 16, 2024 at 2:45 PM Abhinav Kumar
> > wrote:
> >>
> >>
> >>
> >> On 7/15/2024 12:51 PM, Rob Clark wrote:
> &g
On Wed, 17 Jul 2024 at 01:40, Abhinav Kumar wrote:
>
>
>
> On 6/24/2024 2:13 PM, Dmitry Baryshkov wrote:
> > Historically CRTC resources (LMs and CTLs) were assigned in
> > dpu_crtc_atomic_begin(). The commit 9222cdd27e82 ("drm/msm/dpu: move hw
> > resource tr
On Tue, Jul 16, 2024 at 06:48:12PM GMT, Thomas Zimmermann wrote:
> Hi
>
> Am 16.07.24 um 18:35 schrieb Dmitry Baryshkov:
> > On Tue, 16 Jul 2024 at 18:58, Thomas Zimmermann wrote:
> > > Hi
> > >
> > > Am 27.02.24 um 23:40 schrieb Dmitry Baryshk
. But not when
> there is, but without a firmware-name property. This case we want to
> treat as-if the needed fw is not found.
>
> Signed-off-by: Rob Clark
> ---
> drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewe
On Tue, 16 Jul 2024 at 17:34, Marc Gonzalez wrote:
>
> On 16/07/2024 15:11, Konrad Dybcio wrote:
>
> > On 27.06.2024 5:54 PM, Marc Gonzalez wrote:
> >
> >> arch/arm64/boot/dts/qcom/msm8998.dtsi | 100
> >> +-
> >> 1 file changed, 99 insertions(+), 1 deletion(-)
>
On Tue, 16 Jul 2024 at 18:58, Thomas Zimmermann wrote:
>
> Hi
>
> Am 27.02.24 um 23:40 schrieb Dmitry Baryshkov:
> > Hello,
> >
> > We are currently looking at checking and/or possibly redesigning the
> > way the MSM DRM driver handles the HPD events and
On Mon, 15 Jul 2024 at 18:28, Conor Dooley wrote:
>
> On Mon, Jul 15, 2024 at 04:26:12PM +0100, Conor Dooley wrote:
> > On Mon, Jul 15, 2024 at 02:21:16PM +0200, Marc Gonzalez wrote:
> > > Current driver already supports the msm8998 HDMI TX.
> > > We just need to add the compatible string.
> >
> >
; +
> drivers/gpu/drm/msm/registers/display/hdmi.xml | 89 +++
> 5 files changed, 882 insertions(+)
>
Reviewed-by: Dmitry Baryshkov
--
With best wishes
Dmitry
on(+)
>
Reviewed-by: Dmitry Baryshkov
--
With best wishes
Dmitry
bridge_hdmi.
It is impossible to call this function from HDMI bridges, none of the
bridge callbacks correspond to the drm_connector_funcs::reset().
Fixes: 6b4468b0c6ba ("drm/bridge-connector: implement glue code for HDMI
connector")
Reviewed-by: Maxime Ripard
Signed-off-by: Dmitry
db3e16b8f3 ("drm/connector: hdmi: Add output BPC to the connector
state")
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/drm_connector.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.
drm_bridge_connector is a "leaf" driver, belonging to the display
helper, rather than the "CRTC" drm_kms_helper module. Move the driver
to the drm/display and add necessary Kconfig selection clauses.
Suggested-by: Maxime Ripard
Signed-off-by: Dmitry Baryshk
().
Signed-off-by: Dmitry Baryshkov
---
include/drm/drm_property.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/drm/drm_property.h b/include/drm/drm_property.h
index 082f29156b3e..d78ec42de42f 100644
--- a/include/drm/drm_property.h
+++ b/include/drm/drm_property.h
@@ -162,6
igned-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/display/Kconfig | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/display/Kconfig b/drivers/gpu/drm/display/Kconfig
index a2e42014ffe0..9c2da1e48b75 100644
--- a/drivers/gpu/drm/display/Kconfig
idge_funcs::connector_reset() and call it from
__drm_atomic_helper_connector_reset().
Depends on
https://lore.kernel.org/dri-devel/20240704-panel-sw43408-fix-v6-1-3ea1c94bb...@linaro.org
Signed-off-by: Dmitry Baryshkov
---
Changes in v4:
- Fixed DRM_MODE_PROP_IMMUTABLE to use MUST in the single-value clau
cumentation).
With the Fixes tags in place:
Reviewed-by: Dmitry Baryshkov
--
With best wishes
Dmitry
On Thu, Jul 11, 2024 at 11:03:15AM GMT, Abhinav Kumar wrote:
>
>
> On 7/10/2024 12:40 AM, Dmitry Baryshkov wrote:
> > On Tue, 9 Jul 2024 at 22:39, Abhinav Kumar
> > wrote:
> > >
> > >
> > >
> > > On 7/9/2024 6:48 AM, Dmitry Baryshkov
On Sat, 13 Jul 2024 at 03:25, Abhinav Kumar wrote:
>
>
>
> On 7/12/2024 4:11 PM, Dmitry Baryshkov wrote:
> > On Fri, 12 Jul 2024 at 22:41, Abhinav Kumar
> > wrote:
> >> On 6/24/2024 2:13 PM, Dmitry Baryshkov wrote:
> >>> The commit b954fa6baaca
On Fri, 12 Jul 2024 at 22:41, Abhinav Kumar wrote:
> On 6/24/2024 2:13 PM, Dmitry Baryshkov wrote:
> > The commit b954fa6baaca ("drm/msm/dpu: Refactor rm iterator") removed
> > zero-init of the hw_ctl array, but didn't change the error condition,
> > that c
On Thu, 11 Jul 2024 at 03:04, Stephen Boyd wrote:
>
> Quoting Dmitry Baryshkov (2024-07-10 16:32:18)
> > On Tue, 9 Jul 2024 at 01:30, Stephen Boyd wrote:
> > >
> > > Quoting Dmitry Baryshkov (2024-06-27 22:20:22)
> > > > The GPU clock controllers use
On Tue, 9 Jul 2024 at 01:30, Stephen Boyd wrote:
>
> Quoting Dmitry Baryshkov (2024-06-27 22:20:22)
> > The GPU clock controllers use memory region that is a part of the GMU's
> > memory region. Add qcom_cc_map_norequest() to be used by GPUCC, so that
> > GPU driver
On Tue, 9 Jul 2024 at 22:39, Abhinav Kumar wrote:
>
>
>
> On 7/9/2024 6:48 AM, Dmitry Baryshkov wrote:
> > DPU debugging macros need to be converted to a proper drm_debug_*
> > macros, however this is a going an intrusive patch, not suitable for a
> > fix. Wire DPU
controlled via the usual drm.debug mask.
Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 14 ++
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1
k.c")
Cc: sta...@vger.kernel.org
Reported-by: Leonard Lausen
Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/57
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu
Leonard Lausen reported an issue with suspend/resume of the sc7180
devices. Fix the WB atomic check, which caused the issue. Also make sure
that DPU debugging logs are always directed to the drm_debug / DRIVER so
that usual drm.debug masks work in an expected way.
Signed-off-by: Dmitry Baryshkov
On Tue, 9 Jul 2024 at 00:27, Konrad Dybcio wrote:
>
> On 8.07.2024 2:49 PM, Dmitry Baryshkov wrote:
> > On Mon, 8 Jul 2024 at 14:07, Marc Gonzalez wrote:
> >>
> >> On 05/07/2024 16:34, Dmitry Baryshkov wrote:
>
> [...]
>
> >>> I'm not going
On Mon, 8 Jul 2024 at 14:07, Marc Gonzalez wrote:
>
> On 05/07/2024 16:34, Dmitry Baryshkov wrote:
>
> > On Thu, Jul 04, 2024 at 06:45:36PM GMT, Marc Gonzalez wrote:
> >
> >> From: Arnaud Vrac
> >>
> >> Ported from the downstream driver.
&
On Thu, Jul 04, 2024 at 06:45:36PM GMT, Marc Gonzalez wrote:
> From: Arnaud Vrac
>
> Ported from the downstream driver.
Please write some sensible commit message.
>
> Signed-off-by: Arnaud Vrac
> Signed-off-by: Marc Gonzalez
> ---
> drivers/gpu/drm/msm/Makefile | 1 +
>
x-firmware fw paths")
> Signed-off-by: Aleksandr Mishin
> ---
> v1->v2: Fix incorrect 'Fixes' tag
>
> drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov
--
With best wishes
Dmitry
symbol.
Reviewed-by: Jessica Zhang
Reviewed-by: Marijn Suijten
Acked-by: Rodrigo Vivi #i915
Signed-off-by: Dmitry Baryshkov
---
Changes in v6:
- Moved the Makefile entry to follow the sorting order (Thomas
Zimmermann)
- Link to v5:
https://lore.kernel.org/r/20240623-panel-sw43408-fix-v5-1
On Thu, 4 Jul 2024 at 15:54, Maxime Ripard wrote:
>
> On Tue, Jul 02, 2024 at 12:48:54PM GMT, Dmitry Baryshkov wrote:
> > drm_bridge_connector is a "leaf" driver, belonging to the display
> > helper, rather than the "CRTC" drm_kms_helper module. Move the
On Thu, 4 Jul 2024 at 15:56, Maxime Ripard wrote:
>
> hi,
>
> On Tue, Jul 02, 2024 at 12:48:55PM GMT, Dmitry Baryshkov wrote:
> > On HDMI connectors which use drm_bridge_connector and DRM_BRIDGE_OP_HDMI
> > IGT chokes on the max_bpc property in several kms_properties
On 04/07/2024 12:30, Aleksandr Mishin wrote:
In adreno_request_fw() when debugging information is printed to the log
after firmware load, an incorrect filename is printed. 'newname' is used
instead of 'fwname', so prefix "qcom/" is being added to filename.
Looks like "copy-paste" mistake.
Fix th
bridge_hdmi.
It is impossible to call this function from HDMI bridges, there is is no
function that corresponds to the drm_connector_funcs::reset().
Fixes: 6b4468b0c6ba ("drm/bridge-connector: implement glue code for HDMI
connector")
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/d
drm_bridge_connector is a "leaf" driver, belonging to the display
helper, rather than the "CRTC" drm_kms_helper module. Move the driver
to the drm/display and add necessary Kconfig selection clauses.
Suggested-by: Maxime Ripard
Signed-off-by: Dmitry Baryshkov
---
driv
().
Signed-off-by: Dmitry Baryshkov
---
include/drm/drm_property.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/drm/drm_property.h b/include/drm/drm_property.h
index 082f29156b3e..7d0f793f50ca 100644
--- a/include/drm/drm_property.h
+++ b/include/drm/drm_property.h
@@ -162,6
idge_funcs::connector_reset() and call it from
__drm_atomic_helper_connector_reset().
Signed-off-by: Dmitry Baryshkov
---
Changes in v3:
- Document the DRM_MODE_PROP_IMMUTABLE requirements currently exposed
only via IGT tests (Maxime).
- Move drm_bridge_connector to drm_display_helper.
- Link to
db3e16b8f3 ("drm/connector: hdmi: Add output BPC to the connector
state")
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/drm_connector.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.
1.rfunrbsx-...@intel.com/
> Signed-off-by: Rob Clark
> ---
> drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov
--
With best wishes
Dmitry
> 2 files changed, 27 insertions(+)
>
Reviewed-by: Dmitry Baryshkov
--
With best wishes
Dmitry
ta instead of catalog
> to decide if ubwc is supported
>
> Signed-off-by: Abhinav Kumar
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov
--
With best wishes
Dmitry
On Fri, Jun 28, 2024 at 02:48:47PM GMT, Abhinav Kumar wrote:
> There is no recovery mechanism in place yet to recover from mmu
> faults for DPU. We can only prevent the faults by making sure there
> is no misconfiguration.
>
> Rate-limit the snapshot capture for mmu faults to once per
> msm_kms_in
On Fri, Jun 28, 2024 at 02:48:42PM GMT, Abhinav Kumar wrote:
> To debug display mmu faults, this series introduces a display fault
> handler similar to the gpu one.
>
> This series has been tested on sc7280 chromebook by using triggering
> a smmu fault by forcing an incorrect stride on the planes.
On Fri, 28 Jun 2024 at 08:44, Abhinav Kumar wrote:
>
>
>
> On 6/27/2024 4:22 PM, Dmitry Baryshkov wrote:
> > On Fri, 28 Jun 2024 at 00:21, Abhinav Kumar
> > wrote:
> >>
> >>
> >>
> >> On 6/27/2024 2:13 PM, Rob Clark wrote:
>
quest(),
allowing GMU driver to use devm_ioremap_resource().
Signed-off-by: Dmitry Baryshkov
---
drivers/clk/qcom/gpucc-qcm2290.c | 2 +-
drivers/clk/qcom/gpucc-sa8775p.c | 2 +-
drivers/clk/qcom/gpucc-sc7180.c | 2 +-
drivers/clk/qcom/gpucc-sc7280.c | 2 +-
drivers/clk/qcom/gpucc-sc8280xp.
gpucc's one, make gpucc drivers use non-requesting
helper, allowing GPU to take over the bigger memory region.
[1] https://patchwork.freedesktop.org/series/134401/
Signed-off-by: Dmitry Baryshkov
---
Dmitry Baryshkov (2):
clk: qocm: add qcom_cc_map_norequest
clk: qcom: gpucc-*
The GPU clock controllers use memory region that is a part of the GMU's
memory region. Add qcom_cc_map_norequest() to be used by GPUCC, so that
GPU driver can use devm_ioremap_resource for GMU resources.
Signed-off-by: Dmitry Baryshkov
---
drivers/clk/qcom/common.c
On Fri, 28 Jun 2024 at 00:21, Abhinav Kumar wrote:
>
>
>
> On 6/27/2024 2:13 PM, Rob Clark wrote:
> > On Thu, Jun 27, 2024 at 1:53 PM Abhinav Kumar
> > wrote:
> >>
> >> On QCM2290 chipset DPU does not support UBWC.
> >>
> >> Add a dpu cap to indicate this and do not expose compressed formats
> >
On Thu, Jun 27, 2024 at 03:22:18AM GMT, Akhil P Oommen wrote:
> << snip >>
>
> > > > > > > @@ -1503,7 +1497,7 @@ static void __iomem
> > > > > > > *a6xx_gmu_get_mmio(struct platform_device *pdev,
> > > > > > > return ERR_PTR(-EINVAL);
> > > > > > > }
> > > > > > >
> > > >
resolution.
Note #2: By default support for virtual planes is turned off and the
driver still uses old code path with preallocated SSPP block for each
plane. To enable virtual planes, pass 'msm.dpu_use_virtual_planes=1'
kernel parameter.
Signed-off-by: Dmitry Baryshkov
---
drivers/g
Make dpu_rm_print_state() also output the SSPP allocation state.
Reviewed-by: Abhinav Kumar
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
b/drivers/gpu/drm/msm/disp
Split dpu_plane_atomic_check() function into two pieces:
dpu_plane_atomic_check_nopipe() performing generic checks on the pstate,
without touching the associated pipe,
and
dpu_plane_atomic_check_pipes(), which takes into account used pipes.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm
cases and allows all planes to go up to 2*max_linewidth (at the cost of
making some of the planes unavailable to the user).
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 161 ++
1 file changed, 117 insertions(+), 44 deletions(-)
diff
is supported for tiled
formats. However it's better to fix this now rather than stumbling upon
it later.
Fixes: 80e8ae3b38ab ("drm/msm/dpu: add support for wide planes")
Reviewed-by: Abhinav Kumar
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 12
Move a call to dpu_plane_check_inline_rotation() to the
dpu_plane_atomic_check_pipe() function, so that the rot90 constraints
are checked for both pipes. Also move rotation field from struct
dpu_plane_state to struct dpu_sw_pipe_cfg.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp
-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 8
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 4
2 files changed, 12 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
index
, this will have to be handled separately, after
the plane refactoring.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 12
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 4
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 16
Use the drm_rect_fp_to_int() helper instead of using the hand-written
code.
Reviewed-by: Abhinav Kumar
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1
In preparation for virtualized planes support, move pstate->pipe
initialization from dpu_plane_reset() to dpu_plane_atomic_check(). In
case of virtual planes the plane's pipe will not be known up to the
point of atomic_check() callback.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu
YUV formats require only CSC to be enabled. Even decimated formats
should not require scaler. Relax the requirement and don't check for the
scaler block while checking if YUV format can be enabled.
Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
Signed-off-by: D
The QCM2290 doesn't have CSC blocks, so it can not support YUV formats
even on ViG blocks. Fix the formats declared by _VIG_SBLK_NOSCALE().
Fixes: 5334087ee743 ("drm/msm: add support for QCM2290 MDSS")
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_h
rotation and reflection of the
wide plane. However rot90 is still not tested: it is enabled on sc7280
and it only supports UBWC (tiled) framebuffers, it was quite low on my
priority list.
[1] https://patchwork.freedesktop.org/series/99909/
To: Rob Clark
To: Abhinav Kumar
To: Dmitry Baryshkov
To
m/msm/adreno/adreno_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Dmitry Baryshkov
--
With best wishes
Dmitry
On Tue, Jun 25, 2024 at 04:51:27PM GMT, Rob Herring wrote:
> On Sun, Jun 23, 2024 at 02:59:30PM +0200, Krzysztof Kozlowski wrote:
> > dtschema v2024.4, v2024.5 and maybe earlier do not select device nodes for
>
> That should be just since db9c05a08709 ("validator: Rework selecting
> schemas for v
INTF 0 to PHY 0 on all
platforms, so perhaps this is needed in order to get DisplayPort working
on some other platforms as well.
Signed-off-by: Bjorn Andersson
Co-developed-by: Bjorn Andersson
Signed-off-by: Dmitry Baryshkov
---
Changes in v3:
- Expanded the commit message and in-code comment
On Tue, 25 Jun 2024 at 22:28, Abhinav Kumar wrote:
>
>
>
> On 6/25/2024 12:26 PM, Abhinav Kumar wrote:
> >
> >
> > On 6/24/2024 6:39 PM, Abhinav Kumar wrote:
> >>
> >>
> >> On 6/13/2024 4:17 AM, Dmitry Baryshkov wrote:
> >>> F
On Tue, 25 Jun 2024 at 21:54, Konrad Dybcio wrote:
>
> Commit c9707bcbd0f3 ("drm/msm/adreno: De-spaghettify the use of memory
ID is not present in next
> barriers") made some fixups relating to write arrival, ensuring that
> the GPU's memory interface has *really really really* been told to come
ab.freedesktop.org/lumag/msm/-/commit/399af57ccca2
Best regards,
--
Dmitry Baryshkov
On Tue, Jun 25, 2024 at 05:49:54PM GMT, Maxime Ripard wrote:
> On Tue, Jun 25, 2024 at 06:05:33PM GMT, Dmitry Baryshkov wrote:
> > On Tue, 25 Jun 2024 at 18:02, Maxime Ripard wrote:
> > >
> > > Hi,
> > >
> > > On Sun, Jun 23, 2024 at 08:40:12AM
On Tue, 25 Jun 2024 at 18:02, Maxime Ripard wrote:
>
> Hi,
>
> On Sun, Jun 23, 2024 at 08:40:12AM GMT, Dmitry Baryshkov wrote:
> > On HDMI connectors which use drm_bridge_connector and DRM_BRIDGE_OP_HDMI
> > IGT chokes on the max_bpc property in several kms_properties
msm/dsi: Add phy configuration for MSM8937
https://gitlab.freedesktop.org/lumag/msm/-/commit/2df0161959d1
Best regards,
--
Dmitry Baryshkov
On Tue, 25 Jun 2024 01:38:25 +0300, Dmitry Baryshkov wrote:
> The frame event callback is always set to dpu_crtc_frame_event_cb() (or
> to NULL) and the data is always either the CRTC itself or NULL
> (correpondingly). Thus drop the event callback registration, call the
> dpu_crtc_fr
rg/lumag/msm/-/commit/a3a6b350eb6c
Best regards,
--
Dmitry Baryshkov
On Tue, Jun 25, 2024 at 03:58:25PM GMT, Maxime Ripard wrote:
> On Tue, Jun 25, 2024 at 10:23:14AM GMT, Dmitry Baryshkov wrote:
> > On Tue, 25 Jun 2024 at 10:19, Maxime Ripard wrote:
> > >
> > > Hi,
> > >
> > > On Tue, Jun 25, 2024 at 09:21:27AM GMT, D
On Tue, 25 Jun 2024 at 10:19, Maxime Ripard wrote:
>
> Hi,
>
> On Tue, Jun 25, 2024 at 09:21:27AM GMT, Dmitry Baryshkov wrote:
> > On Tue, 25 Jun 2024 at 01:56, Abhinav Kumar
> > wrote:
> > >
> > >
> > >
> > > On 6/24/2024 3:46 PM,
On Tue, 25 Jun 2024 at 01:56, Abhinav Kumar wrote:
>
>
>
> On 6/24/2024 3:46 PM, Dmitry Baryshkov wrote:
> > On Tue, 25 Jun 2024 at 01:39, Abhinav Kumar
> > wrote:
> >>
> >> + IGT dev
> >>
> >> On 6/22/2024 10:40 PM, Dmitry Barysh
On Tue, 25 Jun 2024 at 01:39, Abhinav Kumar wrote:
>
> + IGT dev
>
> On 6/22/2024 10:40 PM, Dmitry Baryshkov wrote:
> > With the introduction of the HDMI Connector framework the driver might
> > end up creating the max_bpc property with min = max = 8. IGT insists
> &
ing dpu_encoder_assign_crtc().
Signed-off-by: Dmitry Baryshkov
---
Changes in v3:
- Fixed documentation for dpu_crtc_frame_event_cb() to stop mentioning
registration. (Abhinav)
- Link to v2:
https://lore.kernel.org/dri-devel/20231005220659.2404199-1-dmitry.barysh...@linaro.org/
Changes in v2:
- Rebased on
On Tue, 25 Jun 2024 at 01:28, Abhinav Kumar wrote:
>
>
>
> On 6/22/2024 10:40 PM, Dmitry Baryshkov wrote:
> > On HDMI connectors which use drm_bridge_connector and DRM_BRIDGE_OP_HDMI
> > IGT chokes on the max_bpc property in several kms_properties tests due
> > t
The _dpu_format_get_plane_sizes_linear() already compares pitches of
the framebuffer with the calculated pitches. Move the check to the same
place, demoting DPU_ERROR to DPU_DEBUG to prevent user from spamming the
kernel log.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1
only for the visible planes: the .prepare_fb callback is
called for not visible planes too, so keeping dpu_format_populate_addrs
in dpu_plane_prepare_fb() will require dpu_format_populate_plane_sizes()
to be called for !visible planes too.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm
Instead of passing width / height / pitches, pass drm_framebuffer
directly. This allows us to drop the useless check for !pitches, since
an array can not be NULL.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 73 ++---
1 file changed
Check that the plane pitch doesn't overflow the maximum pitch size
allowed by the hardware.
Reviewed-by: Abhinav Kumar
Tested-by: Abhinav Kumar # sc7280
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 2 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
The struct dpu_hw_fmt_layout defines hardware data layout (addresses,
sizes and pitches. Drop format field from this structure as it's not a
part of the data layout.
Signed-off-by: Dmitry Baryshkov
---
.../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c| 31 +++---
driver
dpu_formats.c defines DPU_MAX_IMG_WIDTH and _HEIGHT, while
dpu_hw_catalog.h defines just MAX_IMG_WIDTH and _HEIGHT. Merge these
constants to remove duplication.
Reviewed-by: Abhinav Kumar
Tested-by: Abhinav Kumar # sc7280
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1
201 - 300 of 3713 matches
Mail list logo
