No need to have this in msm_drv, so move it into dpu. While we're at
it, remove the other CONFIG_DRM_MSM_DPU ifdef gates.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 18 ++-
drivers/gpu/drm/msm/msm_drv.c | 41 -
2
Revert the component_bind function back to upstream.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/msm_drv.c | 30 +-
1 file changed, 5 insertions(+), 25 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 561617db7338
It's unused.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 8
drivers/gpu/drm/msm/msm_kms.h | 4
2 files changed, 12 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
index 1f21634
We don't use it for anything else, so hide it in dpu. A few other
whitespace/trivial fixes to revert dpu changes in msm.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 37 ++---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 1 +
drivers/gpu/dr
This time the iomap/iounmap helper functions. Move map into dpu and
refactor it to reflect their actual use. iounmap wasn't useful, so
delete it and call iounmap directly.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 38 +---
drivers/gpu/dr
This patch is removing a bunch more dpu changes that
touch msm core.
Signed-off-by: Sean Paul
Change-Id: I1c82454ad372b34ca5b0d6db2af1b513a5ba2fe1
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 77 +--
drivers/gpu/drm/msm/msm_atomic.c | 3 +-
drivers/gpu/drm/msm/msm_drv.c
It's the only change in that file, so... remove it.
Signed-off-by: Sean Paul
---
include/video/mipi_display.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/video/mipi_display.h b/include/video/mipi_display.h
index c83f8a35d765..49a53ef8da96 100644
--- a/include/video/mipi_disp
Same old thing here, more cleanup patches to reduce the amount of dpu
code leaking into msm core. Most of this has already been squashed into
for-next, because it should be (mostly) uncontraversial and (mostly)
code removal.
Sean
Sean Paul (15):
drm/msm: Remove more dpu changes from msm core
On Wed, May 30, 2018 at 10:50 AM Rajesh Yadav wrote:
>
> From: Jordan Crouse
>
> Remove unused code from dpu_io_util.c. The functions are only
> used inside of the msm driver so remove the EXPORT_SYMBOL
> tags and move the header dpu_io_util.h from include/linux.
>
> Signed-off-by: Jordan Crouse
This patch is removing a bunch more dpu changes that
touch msm core. I'm pretty sure the event_thread stuff can go, but
I might be wrong about that aspect.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 242 +---
drivers/gpu/drm/msm/disp
It's unused, so let's get rid of it.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 31 -
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h | 16 ---
2 files changed, 47 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_fo
Well, that was a lot stickier than I thought it would be! This patch
removes dpu_rect and its helpers in favor of drm_rect and its helpers.
Signed-off-by: Sean Paul
---
Based on my tracepoints set.
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 86
drivers/gpu/drm/msm/disp/dpu1
Leftover from dsi-staging, it looks like.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/dpu_dbg.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/msm/dpu_dbg.c b/drivers/gpu/drm/msm/dpu_dbg.c
index 2a9b8c732e33..51d46975cc27 100644
--- a/drivers/gpu/drm/msm/dpu_dbg.c
Now that dpu_dbg is cleaned up, move it into dpu directory with the
rest of dpu things.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/Makefile | 2 +-
drivers/gpu/drm/msm/{ => disp/dpu1}/dpu_dbg.c | 0
drivers/gpu/drm/msm/{ => disp/dpu1}/dpu_dbg.h | 0
3 files chan
This can be achieved via /dev/mem.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.c| 3 -
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c| 3 -
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 3 -
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 3 -
.../gpu/drm
Now that we don't have arbitrary register dumping, remove the macro and
just call dpu_dbg_dump directly.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +-
.../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 2 +-
.../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c
This patch converts all DPU_EVTs in dpu_core_irq with either a DRM_* log
message or a linux tracepoint.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 52
drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h| 50 +++
2 files changed, 71
dpu_dbg.[ch] a bit and removes the arbitrary register reads, and evtlog
duplication. Finally, the dpu_dbg files are moved into the dpu1
directory.
Sean
Sean Paul (19):
drm/msm: dpu_encoder: Replace DPU_EVT with tracepoints
drm/msm: dpu_crtc: Replace DPU_EVT with tracepoints
drm/msm: dpu_plane
This patch converts all DPU_EVTs in dpu_crtc with either a DRM_* log
message or a linux tracepoint.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 122 ++--
drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 166 ++
2 files changed, 210
This patch converts all DPU_EVTs in dpu_core_perf with either a DRM_* log
message or a linux tracepoint.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 2 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 17 +
2 files changed, 18 insertions(+), 1
This patch converts all DPU_EVTs in dpu_vbif with either a DRM_* log
message or a linux tracepoint.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 15 +++
drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c | 7 +++
2 files changed, 18 insertions(+), 4 deletions
The events are only issued in error cases, so use DRM_ERROR instead.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c
b/drivers/gpu/drm/msm/disp/dpu1
This patch converts all DPU_EVTs in dpu_rm with either a DRM_* log
message or a linux tracepoint.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c| 65 ++-
drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 49 +
2 files changed, 78 insertions
This patch converts all DPU_EVTs in dpu_plane with either a DRM_* log
message or a linux tracepoint.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 19 +++---
drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 44 +++
2 files changed, 49 insertions
This patch converts all DPU_EVTs in dpu_encoder_phys_vid with either a DRM_* log
message or a linux tracepoint.
Signed-off-by: Sean Paul
---
.../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 36 ---
drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 35 ++
2 files
This can be accomplished via /dev/mem
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +-
.../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 2 +-
.../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 2 +-
drivers/gpu/drm/msm/dpu_dbg.c | 34
This patch converts all DPU_EVTs in dpu_kms with either a DRM_* log
message or a linux tracepoint.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 19 ---
drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 16
2 files changed, 28 insertions
Better not to allow arbitrary panics of the kernel when poking debugfs
files.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +-
.../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 2 +-
.../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 2 +-
drivers/gpu/drm/msm
This patch converts all DPU_EVTs in dpu_encoder_phys_cmd with either a DRM_* log
message or a linux tracepoint.
Signed-off-by: Sean Paul
---
.../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 79 +--
drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 68
2 files
This patch converts all DPU_EVTs in dpu_encoder with either a DRM_* log
message or a linux tracepoint.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 290 -
drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 329
2 files changed, 464
This patch converts all DPU_EVTs in dpu_pingpong with either a DRM_* log
message or a linux tracepoint.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 3 ++-
drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 14 ++
2 files changed, 16 insertions
Now that everything has been converted to tracepoints, remove the dpu
evtlog.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/Makefile | 1 -
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 5 -
drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 33 ---
drivers/gpu/drm/msm/dpu_dbg.c
c->state);
> mode = &cstate->base.adjusted_mode;
> priv = crtc->dev->dev_private;
> + dpu_kms = to_dpu_kms(priv->kms);
> +
> + /* accessing after swap state. piv_obj.state is the current state */
s/piv_obj/priv_obj/
> + dpu_priv_st
15 insertions(+), 1659 deletions(-)
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
--
Sean Paul, Software Engineer, Google / Chromium OS
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
an 2 mixers. With
> the new state based RM, its very unlikely we hit this condition.
>
In this case, add a comment with "/* This should never happen */"
I'm just kidding, that would virtually guarantee that it does happen and we
certainly don't n
4 drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.c
> delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.h
> delete mode 100644 drivers/gpu/drm/msm/msm_prop.c
> delete mode 100644 drivers/gpu/drm/msm/msm_prop.h
> delete mode 100644 include/uapi/drm/dpu_drm.h
> delete mode
On Tue, Jun 05, 2018 at 08:45:33PM -0700, Jeykumar Sankaran wrote:
> This change removes all the dpu plane custom properties
> and its handlers.
>
> changs in v2:
> - remove stale code in blend config(Sean Paul)
> - Makefile changes to remove warning flags(Sean Pau
pu_reg_dma.c
> delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_reg_dma.h
> delete mode 100644 drivers/gpu/drm/msm/msm_prop.c
> delete mode 100644 drivers/gpu/drm/msm/msm_prop.h
> delete mode 100644 include/uapi/drm/dpu_drm.h
> delete mode 100644 include/uapi/drm/msm_drm_pp.h
driver and create a separate edp panel drivers to handle panel
>specific mode information and HW resources (Sean Paul).
> - Replace pr_* APIs to DRM_* APIs to log error or debug information
>(Sean Paul).
> - Remove some of the unnecessary structure/variable from driver (
truct drm_bridge *bridge)
> > +{
> > + struct ti_sn_bridge *pdata = bridge_to_ti_sn_bridge(bridge);
> > + unsigned int val = 0;
>
> here as well
>
> > +static void ti_sn_bridge_pre_enable(struct drm_bridge *bridge)
> > +{
> > + struct ti_sn_bridge *pdata = bridge_to_ti_sn_bridge(bridge);
> > +
> > + pm_runtime_get_sync(pdata->dev);
>
> error check required
> --
> ~Vinod
--
Sean Paul, Software Engineer, Google / Chromium OS
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
On Tue, Jun 05, 2018 at 11:10:17AM +0530, Sandeep Panda wrote:
> Add support for Innolux TV123WAM, which is a 12.3" eDP
> display panel with 2160x1440 resolution.
>
> Changes in v1:
> - Add the compatibility string, display_mode and panel_desc
>structures in alphab
be true.
> so
> printing the return value isn't interesting.
Also if I was reviewing or casual reading this without the ret print, I would
probably leave a comment such as "print the return value" since I don't
generally keep track of all possible return values.
So printing the return value seems reasonable to me.
Sean
>
> > /* success! finalize initialization */
> > drm_plane_helper_add(plane, &dpu_plane_helper_funcs);
> >
> > --
> > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> > a Linux Foundation Collaborative Project
> >
> > ___
> > Freedreno mailing list
> > Freedreno@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/freedreno
>
> --
> The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project
--
Sean Paul, Software Engineer, Google / Chromium OS
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
zpos_max = DPU_STAGE_MAX - DPU_STAGE_0 - 1;
> + }
> +
> + ret = drm_plane_create_zpos_property(plane, 0, 0, zpos_max);
> + if (ret)
> + DPU_ERROR("failed to install zpos property, rc = %d\n", ret);
> +
> /* success! finalize initialization */
> drm_plane_helper_add(plane, &dpu_plane_helper_funcs);
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
--
Sean Paul, Software Engineer, Google / Chromium OS
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
On Wed, May 23, 2018 at 12:31:02PM -0700, Jeykumar Sankaran wrote:
> remove unwanted dpu uapi headers exposing custom
> payload layouts for custom properties
>
> Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
> ---
> include/uapi/drm/
On Wed, May 23, 2018 at 12:31:01PM -0700, Jeykumar Sankaran wrote:
> Remove hand rolled msm property caching to handle DPU
> custom properties. This change also cleans up all its
> dependencies to cache and restore respective drm
> states.
>
> Signed-off-by: Jeykumar Sankaran
On Wed, May 23, 2018 at 12:31:00PM -0700, Jeykumar Sankaran wrote:
> Remove dpu crtc custom properties and its handlers.
>
> Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
> ---
> drivers/gpu/drm/msm/Makefile | 1 -
> drivers/gpu/drm/msm/disp/dp
On Wed, May 23, 2018 at 12:30:58PM -0700, Jeykumar Sankaran wrote:
> Enable drm core zpos normalization for planes.
>
> Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
> ---
> drivers/gpu/drm/msm/msm_drv.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff
On Wed, May 23, 2018 at 12:30:56PM -0700, Jeykumar Sankaran wrote:
> Cleanup residual connector property enumerations.
>
> Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
> ---
> drivers/gpu/drm/msm/msm_drv.h | 27 ---
> 1 file cha
> /* default to opaque blending */
> - fg_alpha = dpu_plane_get_property(pstate, PLANE_PROP_ALPHA);
> + fg_alpha = 0XFF;
> bg_alpha = 0xFF - fg_alpha;
This goes to 0 and the fg_alpha != 0xff checks are always false. So let's clean
the rest of the function
ack and display port drivers
> - compile out dsi-staging driver (separate patch submitted to
> remove the driver)
> - adapt upstream device hierarchy
>
> changes in v2:
> - remove files not applicable upstream (Sean Paul)
> - remove compiled out non-dsi disp
s commit to ensure the
arguments to msm_gem_put_iova() are correct (even though that
function has been a stub for ~5 years). Correctness FTW! \o/
Fixes: b01884a286b0 drm/msm: use correct aspace pointer in msm_gem_put_iova()
Cc: Daniel Mack
Cc: Rob Clark
Signed-off-by: Sean Paul
---
drivers/gpu
ack and display port drivers
> - compile out dsi-staging driver (separate patch submitted to
> remove the driver)
> - adapt upstream device hierarchy
>
> changes in v2:
> - remove files not applicable upstream (Sean Paul)
> - remove compiled out non-dsi disp
;
> > It implements runtime_pm support for resource management.
> > Child nodes can control these resources via runtime_pm
> > get/put calls on their corresponding devices due to parent
> > child relationship defined in dt.
> >
> > Changes in v2:
> >
his function
> so there is no way caller can know if the perf request fails.
> This change adds error handling code in dpu_core_perf_crtc_update().
> The caller side error handling is not added in this patch.
>
> Signed-off-by: Rajesh Yadav
Cool! Thanks for doing this
lict in dpu_unbind
> - dropped (Reviewed-by: Sean Paul) due to above change
>
Reviewed-by: Sean Paul
> Signed-off-by: Rajesh Yadav
> ---
> drivers/gpu/drm/msm/Makefile | 2 +-
> drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 1 -
> driver
er access).
>
> Changes in v2:
> - resolved conflict in dpu_core_perf_init
> - dropped (Reviewed-by: Sean Paul) due to above change
Reviewed-by: Sean Paul
>
> Signed-off-by: Rajesh Yadav
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 7 ---
> drivers/g
> Changes in v2:
> - resolved merge conflict in dpu_power_resource_init
> - dropped (Reviewed-by: Sean Paul) due to above change
>
> Signed-off-by: Rajesh Yadav
> ---
> drivers/gpu/drm/msm/dpu_power_handle.c | 194
> +
> drivers/gpu/drm
>
> Changes in v2:
> - remove local variable to hold and return error code
> in _dpu_core_perf_set_core_clk_rate() instead return
> retcode directly from msm_dss_clk_set_rate() call (Sean Paul)
> - dpu_core_perf_init() is called from dpu_kms_hw_init() and
unctionality.
>
> The dpu driver implements runtime_pm support for managing clocks
> and bus bandwidth etc.
>
> Changes in v2:
> - remove redundant param check from _dpu_kms_hw_destroy (Sean Paul)
> - remove explicit calls to devm_kfree (Sean Paul)
> -
evices due to parent
> child relationship defined in dt.
>
> Changes in v2:
> - merge _dpu_mdss_hw_rev_init to dpu_mdss_init (Sean Paul)
> - merge _dpu_mdss_get_intr_sources to dpu_mdss_irq (Sean Paul)
> - fix indentation for irq_find_mapping call (Sean Paul)
>
kms->base, &kms_funcs);
> @@ -1876,6 +1882,7 @@ static int dpu_init(struct platform_device *pdev,
> struct drm_device *dev)
>
> return ret;
>
> +power_init_fail:
Nit: No need to add an empty label, just use clk_rate_error above.
With that fixed,
Re
t;
> Signed-off-by: Rajesh Yadav
Reviewed-by: Sean Paul
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 4 +---
> drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 4
> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 3 +--
> drivers/gpu/drm/msm/dpu_dbg.c
P device.
> For same reason, clock and power management code is
> removed from dpu_power_handle. Hence, remove the
> dpu_power_handle calls from dp driver.
>
> Signed-off-by: Rajesh Yadav
Reviewed-by: Sean Paul
> ---
> drivers/gpu/drm/msm/dp/dp_power.c | 32 +--
f-by: Rajesh Yadav
Reviewed-by: Sean Paul
> ---
> drivers/gpu/drm/msm/dpu_power_handle.c | 190
> +
> drivers/gpu/drm/msm/dpu_power_handle.h | 2 -
> 2 files changed, 1 insertion(+), 191 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/
goto end;
> - }
> -
> rc = dpu_power_parse_dt_supply(pdev, mp);
> if (rc) {
> pr_err("device vreg supply parsing failed\n");
> - goto parse_vreg_err;
> + goto end;
Just return directly and remove the end label
or all child nodes
> (mdp5/dpu, dsi, dp etc) is done by parent MDSS device/driver
> via runtime_pm due to parent child relationship.
>
> Signed-off-by: Rajesh Yadav
Reviewed-by: Sean Paul
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 8 ++---
> drivers/gp
> Signed-off-by: Rajesh Yadav
Reviewed-by: Sean Paul
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 68
> +++
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 18 +++---
> 2 files changed, 43 insertions(+), 43 deletions(-)
>
> dif
_enable call from msm_drv.
>
> Signed-off-by: Rajesh Yadav
Reviewed-by: Sean Paul
> ---
> drivers/gpu/drm/msm/msm_drv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
> index ebc40a9..9bb436f 100644
>
t; + bool rpm_enabled;
> + struct dss_module_power mp;
> };
>
> struct vsync_info {
> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
> index a0e73ea..5470529 100644
> --- a/drivers/gpu/drm/msm/msm_drv.c
> +++ b/drivers/gpu/drm/msm/msm_drv.c
dev_err(dev, "failed to populate children devices\n");
> @@ -1686,7 +1698,7 @@ static int msm_pdev_remove(struct platform_device *pdev)
> { .compatible = "qcom,mdp4", .data = (void *)KMS_MDP4 },
> { .compatible = "qcom,mdss", .data = (void *)KMS
t; Signed-off-by: Rajesh Yadav
Hi Rajesh,
Thanks for the patch, everything looks good to me aside from one tiny indent
fix. With that resolved, please add my
Reviewed-by: Sean Paul
> ---
> drivers/gpu/drm/msm/disp/mdp5/mdp5_mdss.c | 154
> --
> drivers/gp
; .data = &winstar_wf35ltiacd,
> }, {
> + .compatible = "innolux,tv123wam",
> + .data = &innolux_tv123wam,
> + }, {
These are alphabetically ordered, as are the drm_display_mode/panel_desc
structs.
Sean
>
driver and create a separate edp panel drivers to handle panel
>specific mode information and HW resources (Sean Paul).
> - Replace pr_* APIs to DRM_* APIs to log error or debug information
>(Sean Paul).
> - Remove some of the unnecessary structure/variable from driver (
dev);
> +
> + drm_panel_detach(&pdata->base);
> + drm_panel_remove(&pdata->base);
> +
> + innolux_edp_2k_panel_disable(&pdata->base);
> + innolux_edp_2k_panel_unprepare(&pdata->base);
> +
> + if (pdata->backlight)
> +
driver and create a separate edp panel drivers to handle panel
>specific mode information and HW resources (Sean Paul).
> - Replace pr_* APIs to DRM_* APIs to log error or debug information
>(Sean Paul).
> - Remove some of the unnecessary structure/variable from driver (
Signed-off-by: Sean Paul
---
.../gpu/drm/msm/disp/dpu1/dpu_color_processing.c | 5 +++--
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 4 ++--
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.c | 14 +++---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 9
ector/bridge.
>
> Changes in V2:
> -Removed Change-Id from the commit text tags.
> -Remove extra parentheses
>
> Changes in V3:
> -None
>
> Signed-off-by: Chandan Uddaraju
Reviewed-by: Sean Paul
> ---
> drivers/gpu/drm/msm/dsi/dsi.c | 3 +
&
ector/bridge.
>
> Changes in V2:
> -Removed Change-Id from the commit text tags.
> -Remove extra parentheses
>
> Changes in V3:
> -None
>
> Signed-off-by: Chandan Uddaraju
Reviewed-by: Sean Paul
> ---
> drivers/gpu/drm/msm/dsi/dsi.c | 3 +
&
; --Removed Change-Id from the commit text tags.
>
> Changes in V3:
> --Instead of adjusting the DRM mode structure, divide
> the clocks and horizontal timings in DSI host just
> before configuring the values.
>
> Signed-off-by: Chandan Uddaraju
Reviewed-by: Sean Pau
_calc.c | 676
> .../gpu/drm/msm/dsi-staging/dsi_phy_timing_calc.h | 144 -
> .../gpu/drm/msm/dsi-staging/dsi_phy_timing_v2_0.c | 126 -
> .../gpu/drm/msm/dsi-staging/dsi_phy_timing_v3_0.c | 107 -
> drivers/gpu/drm/msm/dsi-staging/dsi_pwr.c | 365 --
> drivers/gpu/drm/m
t; @@ -1521,6 +1420,7 @@ static int dpu_kms_atomic_check(struct msm_kms *kms,
> dpu_kms->aspace[domain] : NULL;
> }
>
> +#ifdef CONFIG_DRM_MSM_DISPLAYPORT
This seems suspicious. Why different behavior depending on DisplayPort? The
function loops through all connectors, so
value for video done waits
drm/msm/dsi: check video mode engine status before waiting
drm/msm/dsi: implement auto PHY timing calculator for 10nm PHY
Jeykumar Sankaran (1):
drm/msm: Add modifier to mdp_get_format arguments
Sean Paul (1):
drm/msm: Mark the crtc->sta
> create mode 100644 drivers/gpu/drm/bridge/ti-sn65dsi86.c
> create mode 100644 drivers/gpu/drm/panel/panel-innolux-tv123wam.c
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
--
S
goto err_dt_parse;
> + }
> +
> + ret = ti_sn_bridge_parse_gpios(pdata);
> + if (ret) {
> + DRM_ERROR("failed to parse gpios from DT\n");
> + goto err_dt_parse;
> + }
> +
> + ret = ti_sn_bridge_parse_regulators(pdata);
dp_bridge_in: endpoint {
> + remote-endpoint = <&dsi_out>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> +
> + edp_bridge_out: endpoint {
> +
hing fancy in the kernel aside from scaling the brightness
level down twice. I assume the magic is in userspace. My initial reaction was
that the scaling factor should just be applied in userspace. Especially since
the scaling factor reduces the resolution of the backlight, and that's not
immediately
;s hard enough to accommodate open
source u/s as it is.
Sean
>
> If this isnt a convincing reason enough to have its own sysfs node path, I
> will use
> your approach.
>
> Let me know your comments or if this is still not clear.
>
> > _____
On Mon, Apr 16, 2018 at 11:22:19AM -0700, Jeykumar Sankaran wrote:
> Remove custom ioctl support in SDM845 which allows
> user space to register/unregister for hw events.
>
> Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
> ---
> drivers/gpu/drm/msm/disp/dpu
ESH_CONFIG, refresh_cfg);
> - DPU_EVT32(pp->idx - PINGPONG_0, refresh_cfg);
> -
> - return 0;
> -}
> -
> -static int dpu_hw_pp_get_autorefresh_config(struct dpu_hw_pingpong *pp,
> - struct dpu_hw_autorefresh *cfg)
> -{
> - struct dpu_hw_
mply the driver programming, striping off the support
> for SDM845.
>
> Signed-off-by: Jeykumar Sankaran
Reviewed-by: Sean Paul
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_connector.c | 2 +-
> drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 19 ---
> drivers/
enum msm_display_compression_type comp_type;
> spinlock_t *enc_spinlock;
> };
>
> @@ -479,8 +475,7 @@ static inline enum dpu_3d_blend_mode
> dpu_encoder_helper_get_3d_blend_mode(
>
> topology = dpu_connector_get_topology_name(phys_enc->con
if (other_dsi)
> + msm_dsi_host_adjust_timing_config(other_dsi->host);
> + }
> +
> }
>
> static const struct drm_connector_funcs dsi_mgr_connector_funcs = {
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
--
Sean Paul, Software Engineer, Google / Chromium OS
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
i_sw_reset(msm_host);
> -
> + msm_host->enabled = false;
I thought this was moving to the start of the function?
> return 0;
> }
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
--
Sean Paul, Software Engineer, Google / Chromium OS
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
On Mon, Apr 16, 2018 at 10:44:57AM -0700, abhin...@codeaurora.org wrote:
> Hi Sean
>
> Thanks for reviewing.
>
> Reply inline.
>
> On 2018-04-16 10:07, Sean Paul wrote:
> > On Fri, Apr 13, 2018 at 03:04:48PM -0700, abhin...@codeaurora.org wrote:
>
On Fri, Apr 13, 2018 at 03:04:48PM -0700, abhin...@codeaurora.org wrote:
> On 2018-04-13 14:10, abhin...@codeaurora.org wrote:
> > Hi Sean
> >
> > Thanks for the review.
> >
> > Reply inline.
> >
> > On 2018-04-13 13:26, Sean Paul wrote:
> >
On Fri, Apr 13, 2018 at 01:52:17PM -0700, abhin...@codeaurora.org wrote:
> On 2018-04-13 13:29, Sean Paul wrote:
> > On Tue, Apr 10, 2018 at 06:54:07PM -0700, Abhinav Kumar wrote:
> > > Currently the DSI PHY timings are hard-coded for a specific panel
> > > for the 10n
On Fri, Apr 13, 2018 at 01:59:29PM -0700, abhin...@codeaurora.org wrote:
> Hi Sean
>
> Thanks for the comments.
>
> Some replies inline.
>
> On 2018-04-13 13:46, Sean Paul wrote:
> > On Sat, Apr 07, 2018 at 12:06:53AM -0700, Abhinav Kumar wrote:
> > > Reg
On Mon, Apr 16, 2018 at 11:32:50AM +0530, spa...@codeaurora.org wrote:
> On 2018-04-14 00:59, Sean Paul wrote:
> > On Fri, Apr 13, 2018 at 10:53:00AM +0530, Sandeep Panda wrote:
> > > Add support for TI's sn65dsi86 dsi2edp bridge chip.
> > > The chip converts DSI
On Mon, Apr 16, 2018 at 12:41 PM Bjorn Andersson
wrote:
> On Sat 14 Apr 00:25 PDT 2018, Abhinav Kumar wrote:
> > Register truly panel as a backlight led device and
> > provide methods to control its backlight operation.
> >
> > Changes in v2:
> > - Removed redundant NULL checks
> > - Arranged he
put_device(&secondary->dev);
> return ret;
> }
> +
> + ret = truly_backlight_setup(ctx);
> + if (ret) {
> + put_device(&secondary->dev);
> + return ret;
> +
601 - 700 of 847 matches
Mail list logo
