Re: [Freedreno] [PATCH] drm/msm/dp: Simplify dp_debug_init() and dp_debug_get()

2022-01-05 Thread Stephen Boyd
Quoting Christophe JAILLET (2021-12-22 11:33:47) > dp_debug_init() always returns 0. So, make it a void function and simplify > the only caller accordingly. > > While at it remove a useless 'rc' initialization in dp_debug_get() > > Signed-off-by: Christophe JAILLET

Re: [Freedreno] [PATCH v2] drm/msm/dp: populate connector of struct dp_panel

2022-01-05 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-12-29 11:17:02) > There is kernel crashed due to unable to handle kernel NULL > pointer dereference of dp_panel->connector while running DP link > layer compliance test case 4.2.2.6 (EDID Corruption Detection). Can you explain how we get into that situation? Like "We ne

Re: [Freedreno] [PATCH] drm/msm/dp: stop link training after link training 2 failed

2022-01-05 Thread Stephen Boyd
is failed so that next > link training 1 can start freshly. This patch fixes link compliance > test case 4.3.1.13 (Source Device Link Training EQ Fallback Test). > > Fixes: 2e0adc765d88 ("drm/msm/dp: do not end dp link training until video is > ready") > Signed-off-by: K

Re: [Freedreno] [PATCH v2] drm/msm/dp: add support of tps4 (training pattern 4) for HBR3

2022-01-05 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-12-29 10:15:45) > diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.h > b/drivers/gpu/drm/msm/dp/dp_catalog.h > index 6965afa..7dea101 100644 > --- a/drivers/gpu/drm/msm/dp/dp_catalog.h > +++ b/drivers/gpu/drm/msm/dp/dp_catalog.h > @@ -94,7 +94,7 @@ void dp_catalog_ctrl_mai

Re: [Freedreno] [PATCH] drm/msm/dp: Fix a potential double free in an error handling path

2022-01-05 Thread Stephen Boyd
ot;) > Signed-off-by: Christophe JAILLET > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v3 0/2] Use "ref" clocks from firmware for DSI PLL VCO parent

2021-12-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-12-15 12:02:37) > On 14/12/2021 22:46, Marijn Suijten wrote: > > Hi all, > > > > On 2021-09-18 16:40:38, Marijn Suijten wrote: > >> On 2021-09-14 14:44:01, Stephen Boyd wrote: > >>> Quoting Marijn Suijten (2021-09-11 06:

Re: [Freedreno] [PATCH] drm/msm/dp: remove unneeded variable

2021-12-15 Thread Stephen Boyd
Quoting cgel@gmail.com (2021-12-15 00:55:54) > From: Changcheng Deng > > Remove unneeded variable used to store return value. > > Reported-by: Zeal Robot > Signed-off-by: Changcheng Deng > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH 2/2] drm/msm/dpu: add dpu_plane_atomic_print_state

2021-12-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-12-15 08:09:12) > Implement plane's atomic_print_state() callback, printing DPU-specific > plane state: blending stage, SSPP and multirect mode and index. > > Signed-off-by: Dmitry Baryshkov > --- Same const comment applies here Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH 1/2] drm/msm/dpu: add dpu_crtc_atomic_print_state

2021-12-15 Thread Stephen Boyd
*state) > +{ > + struct dpu_crtc_state *cstate = to_dpu_crtc_state(state); const? Then we know at a glance that this isn't changing the state. Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH] drm/msm: Don't use autosuspend for display

2021-12-15 Thread Stephen Boyd
about why it's not a good idea to use autosuspend for display things. Then this commit can be dug out of the history and someone new can quickly understand the reasoning behind it. Just saying it's not a good idea doesn't really help. > > Signed-off-by: Rob Clark > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v7 2/2] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-12-14 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-12-09 13:35:07) > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index 0766752..cfbc5e4 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -83,6 +83,7 @@ struct dp_display_privat

Re: [Freedreno] [PATCH v4 00/34] component: Make into an aggregate bus

2021-12-13 Thread Stephen Boyd
Quoting Daniel Vetter (2021-12-07 10:22:15) > On Thu, Dec 02, 2021 at 02:26:58PM -0800, Stephen Boyd wrote: > > This series is from discussion we had on reordering the device lists for > > drm shutdown paths[1]. I've introduced an 'aggregate' bus that we put > >

Re: [Freedreno] [PATCH v6] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-12-09 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-12-08 12:36:24) > Current DP drivers have regulators, clocks, irq and phy are grouped > together within a function and executed not in a symmetric manner. > This increase difficulty of code maintenance and limited code scalability. > This patch divided the driver life cyc

Re: [Freedreno] [PATCH v4 14/14] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

2021-12-09 Thread Stephen Boyd
Quoting Sean Paul (2021-11-04 20:04:31) > From: Sean Paul > > This patch adds HDCP 1.x support to msm DP connectors using the new HDCP $ git grep "This patch" -- Documentation/process/ > helpers. > > Cc: Stephen Boyd > Cc: Abhinav Kumar > Signed-o

Re: [Freedreno] [PATCH v5] drm/msm/dp: dp_link_parse_sink_count() return immediately if aux read failed

2021-12-09 Thread Stephen Boyd
his patch as stand alone patch > > Changes in v5: > -- rebase on msm-next branch > > Signed-off-by: Kuogee Hsieh > Remove this newline please. > Reviewed-by: Stephen Boyd > Tested-by: Stephen Boyd > --- > drivers/gpu/drm/msm/dp/dp_display.c | 12

Re: [Freedreno] [PATCH] drm/msm/dp: Add "qcom, sc7280-dp" to support display port.

2021-12-06 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-12-03 14:02:39) > Signed-off-by: Kuogee Hsieh > --- > drivers/gpu/drm/msm/dp/dp_display.c | 1 + > 1 file changed, 1 insertion(+) One nit Reviewed-by: Stephen Boyd > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp

Re: [Freedreno] [PATCH v4] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-12-02 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-11-09 13:38:13) > From: Kuogee Hsieh > > Current DP drivers have regulators, clocks, irq and phy are grouped > together within a function and executed not in a symmetric manner. > This increase difficulty of code maintenance and limited code scalability. > This patch div

Re: [Freedreno] [PATCH v4] phy: qcom-qmp: add support for display port voltage and pre-emphasis swing

2021-12-02 Thread Stephen Boyd
Quoting Stephen Boyd (2021-09-14 12:49:13) > Quoting Kuogee Hsieh (2021-09-14 09:45:01) > > Both voltage and pre-emphasis swing level are set during link training > > negotiation between host and sink. There are totally four tables added. > > A voltage swing table for both hb

[Freedreno] [PATCH v4 34/34] component: Remove component_master_ops and friends

2021-12-02 Thread Stephen Boyd
The struct is unused now so drop it along with the functions that use it. Cc: Daniel Vetter Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/componen

[Freedreno] [PATCH v4 32/34] mei: pxp: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/misc/mei/pxp/mei_pxp.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/misc/mei/pxp/mei_pxp.c b/drivers/mi

[Freedreno] [PATCH v4 27/34] mei: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
ael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/misc/mei/hdcp/mei_hdcp.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/misc/mei/hdcp/mei_hdcp.c b/drivers/misc/mei/hdcp/mei_hd

[Freedreno] [PATCH v4 29/34] fbdev: omap2: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/video/fbdev/omap2/omapfb/dss/dss.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dss.c b/drivers/video/fbdev/omap2/omapfb/dss/dss.c index a6b1c1598040..f1

[Freedreno] [PATCH v4 33/34] component: Get rid of drm_of_component_probe()

2021-12-02 Thread Stephen Boyd
There aren't any users anymore so drop it. Cc: Laurent Pinchart Cc: Daniel Vetter Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/dr

[Freedreno] [PATCH v4 26/34] iommu/mtk: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
; Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/iommu/mtk_iommu.c| 14 +- drivers/iommu/mtk_iommu.h| 6 -- drivers/iommu/mtk_iommu_v1.c | 14 +- 3 files changed, 22 insertions(+), 12 deletions(-) diff --git

[Freedreno] [PATCH v4 30/34] sound: hdac: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
socki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- sound/hda/hdac_component.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/sound/hda/hdac_component.c b/sound/hda/hdac_component.c index bb37e7e0bd79..9e

[Freedreno] [PATCH v4 31/34] ASoC: codecs: wcd938x: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
; Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- sound/soc/codecs/wcd938x.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index 52de7d14b139..f44f5d41bfdb 100644 -

[Freedreno] [PATCH v4 28/34] power: supply: ab8500: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/power/supply/ab8500_charger.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charg

[Freedreno] [PATCH v4 23/34] drm/sun4i: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/sun4i/sun4i_drv.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c index 54

[Freedreno] [PATCH v4 25/34] drm/vc4: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/vc4/vc4_drv.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c index 16abc3a3d601..82a44ebf9121 10

[Freedreno] [PATCH v4 24/34] drm/tilcdc: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
; Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_d

[Freedreno] [PATCH v4 21/34] drm/rockchip: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
; Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchi

[Freedreno] [PATCH v4 22/34] drm/sti: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
ana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/sti/sti_drv.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c index c7efb43b83ee..b277cc679154 100644 --- a/drivers/gpu/drm/sti/sti_d

[Freedreno] [PATCH v4 19/34] drm/meson: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
l King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/meson/meson_drv.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c index 7f41a33592c8..3028f2a45f66 10

[Freedreno] [PATCH v4 20/34] drm/omap: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
l King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/omapdrm/dss/dss.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c b/drivers/gpu/drm/omapdrm/dss/dss.c index d6a5862b4dbf..9328d97f19ab 10

[Freedreno] [PATCH v4 15/34] drm/imx: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
l King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/imx/imx-drm-core.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c index cb685fe2039b..9e28bb16364c 10

[Freedreno] [PATCH v4 12/34] drm/etnaviv: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
socki" Cc: Rob Clark Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c index 7d

[Freedreno] [PATCH v4 17/34] drm/mcde: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
ana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/mcde/mcde_drv.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/mcde/mcde_drv.c b/drivers/gpu/drm/mcde/mcde_drv.c index 5b5afc6aaf8e..1652f9e0601d 100644 --- a/drivers/gp

[Freedreno] [PATCH v4 13/34] drm/kirin: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 20 --- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_dr

[Freedreno] [PATCH v4 18/34] drm/mediatek: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index ae

[Freedreno] [PATCH v4 16/34] drm/ingenic: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 25 +-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/ingenic/ingenic-dr

[Freedreno] [PATCH v4 11/34] drm/armada: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
ana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/armada/armada_drv.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm/armada/armada_drv.c index 8e3e98f13db4..b3559363ea43 100644 --- a/drive

[Freedreno] [PATCH v4 14/34] drm/exynos: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drive

[Freedreno] [PATCH v4 09/34] drm/arm/hdlcd: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
l King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/arm/hdlcd_drv.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c index 479c2422a2e0..5c03eb98d814 100644 --- a/drive

[Freedreno] [PATCH v4 10/34] drm/malidp: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
: Laurent Pinchart Cc: Liviu Dudau Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/arm/malidp_drv.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git

[Freedreno] [PATCH v4 07/34] drm/msm: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
play pipeline is called before any of the component device driver shutdown hooks are called. Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/msm_drv.c | 46 +++--

[Freedreno] [PATCH v4 08/34] drm/komeda: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
; Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- .../gpu/drm/arm/display/komeda/komeda_drv.c | 20 --- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c b/drivers/gpu/drm/arm/disp

[Freedreno] [PATCH v4 06/34] drm/of: Add a drm_of_aggregate_probe() API

2021-12-02 Thread Stephen Boyd
c: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/drm_of.c | 85 +++- include/drm/drm_of.h | 12 ++ 2 files changed, 78 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_

[Freedreno] [PATCH v4 04/34] component: Move struct aggregate_device out to header file

2021-12-02 Thread Stephen Boyd
: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/component.c | 15 --- include/linux/component.h | 19 --- 2 files changed, 16 insertions(+), 18 deletions(-) diff --git a/drivers/base/component.c b/drivers/base/component.c index eec82caeae5e..dc38a8939ae6 10

[Freedreno] [PATCH v4 05/34] component: Add {bind, unbind}_component() ops that take aggregate device

2021-12-02 Thread Stephen Boyd
Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/component.c | 14 +++--- include/linux/component.h | 22 ++ 2 files changed, 33 insertions(+), 3 deletions(-) diff --git a/drivers/base/component.c b/drivers/base/component

[Freedreno] [PATCH v4 03/34] component: Introduce the aggregate bus_type

2021-12-02 Thread Stephen Boyd
s to attach shutdown logic (and in the future runtime PM logic) to the aggregate driver so that it runs the hooks in the correct order. Cc: Daniel Vetter Cc: Greg Kroah-Hartman Cc: Laurent Pinchart Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Cc: Kai

[Freedreno] [PATCH v4 01/34] component: Introduce struct aggregate_device

2021-12-02 Thread Stephen Boyd
Cc: Daniel Vetter Cc: Greg Kroah-Hartman Cc: Laurent Pinchart Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/component.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/d

[Freedreno] [PATCH v4 02/34] component: Remove most references to 'master'

2021-12-02 Thread Stephen Boyd
ravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/component.c | 250 +++--- include/linux/component.h | 2 +- 2 files changed, 124 insertions(+), 128 deletions(-) diff --git a/drivers/base/component.c b/drivers/base/component.c index d25048d04b70..

[Freedreno] [PATCH v4 00/34] component: Make into an aggregate bus

2021-12-02 Thread Stephen Boyd
e aggregate driver approach - Allow one aggregate driver to be used for multiple aggregate devices [1] https://lore.kernel.org/r/20210508074118.1621729-1-swb...@chromium.org Stephen Boyd (34): component: Introduce struct aggregate_device component: Remove most references to 'master&#

Re: [Freedreno] [PATCH v4] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-11-18 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-11-09 13:38:13) > From: Kuogee Hsieh > > Current DP drivers have regulators, clocks, irq and phy are grouped > together within a function and executed not in a symmetric manner. > This increase difficulty of code maintenance and limited code scalability. > This patch div

Re: [Freedreno] [PATCH v1 3/3] phy: qcom: Program SSC only if supported by sink

2021-11-16 Thread Stephen Boyd
gt; --- I suppose as long as the existing user has already chosen to set the opts in the controller driver then this is fine. Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v1 2/3] phy: qcom: Add support for eDP PHY on sc7280

2021-11-16 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2021-11-15 23:07:37) > The sc7280 platform supports native eDP controller and PHY. > This change will add support for the eDP PHY on sc7280. > > Signed-off-by: Sankeerth Billakanti > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v1 1/3] dt-bindings: phy: Add eDP PHY compatible for sc7280

2021-11-16 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2021-11-15 23:07:36) > Add compatible string for the supported eDP PHY on sc7280 platform. > > Signed-off-by: Sankeerth Billakanti > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v3] arm64: dts: qcom: sc7280: Add Display Port node

2021-11-16 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-11-16 08:43:38) > > On 11/15/2021 3:39 PM, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2021-11-02 16:44:33) > > From: Kuogee Hsieh > > Signed-off-by: Kuogee Hsieh > --- > > What tree is this based on?

Re: [Freedreno] [PATCH linux-next] drm/msm/dp: remove unneeded variable

2021-11-15 Thread Stephen Boyd
Quoting cgel@gmail.com (2021-11-10 04:05:12) > From: Changcheng Deng > > Fix the following coccicheck review: > ./drivers/gpu/drm/msm/dp/dp_debug.c: Unneeded variable > > Remove unneeded variable used to store return value. > > Reported-by: Zeal Robot > Signed-off-by: Changcheng Deng > --- >

Re: [Freedreno] [PATCH] drm/msm: Fix mmap to include VM_IO and VM_DONTDUMP

2021-11-15 Thread Stephen Boyd
> NOTE: it was confirmed that VM_IO was the important flag to fix the > problem I was seeing, but adding back VM_DONTDUMP seems like a sane > thing to do so I'm doing that too. > > Fixes: 510410bfc034 ("drm/msm: Implement mmap as GEM object function") > Reported-by: Stephen Boyd > Signed-off-by: Douglas Anderson > --- Reviewed-by: Stephen Boyd Tested-by: Stephen Boyd

Re: [Freedreno] [PATCH v3] arm64: dts: qcom: sc7280: Add Display Port node

2021-11-15 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-11-02 16:44:33) > From: Kuogee Hsieh > > Signed-off-by: Kuogee Hsieh > --- What tree is this based on? I don't see edp_phy upstream for sc7280 Otherwise, looks good to me. Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v3] drm/msm: use compatible lists to find mdp node

2021-11-09 Thread Stephen Boyd
ed-off-by: Krishna Manikandan > > Changes in v2: > - Use compatible lists instead of duplicate string > check (Stephen Boyd) > > Changes in v3: > - Use match tables to find the mdp node (Stephen Boyd) > --- With the export symbol dropped Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH] drm/msm/dp: Drop now unused hpd_high member

2021-11-09 Thread Stephen Boyd
tes as well. > > Signed-off-by: Bjorn Andersson > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-11-05 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-11-05 10:28:11) > From: Kuogee Hsieh > > Combo phy supports both USB and DP simultaneously. There may has a > possible conflict during phy initialization phase between USB and > DP driver which may cause USB phy timeout when USB tries to power > up its phy. This patch ha

Re: [Freedreno] [PATCH] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-11-05 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-11-05 10:48:37) > On Fri 05 Nov 10:28 PDT 2021, Kuogee Hsieh wrote: > > > From: Kuogee Hsieh > > > > Combo phy supports both USB and DP simultaneously. There may has a > > possible conflict during phy initialization phase between USB and > > DP driver which may cause

Re: [Freedreno] [PATCH] drm/msm/dp: employ bridge mechanism for display enable and disable

2021-11-03 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-11-02 15:13:44) > Current display mode_set, enable and disable functions are implemented > as function called directly from drm encoder. This patch have display > mode_set, enable and disable be implemented as callback function of drm > bridge. Why is it important? Pleas

Re: [Freedreno] [PATCH] drm/msm/dsi: set default num_data_lanes

2021-11-01 Thread Stephen Boyd
; > According to the binding document of msm dsi controller, the > input/output endpoint of the controller is expected to have 4 lanes. > So let's set num_data_lanes to 4 by default. > > Signed-off-by: Philip Chen > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [v2] drm/msm/disp/dpu1: set default group ID for CTL.

2021-10-29 Thread Stephen Boyd
escritpion for the change (Stephen) > > Signed-off-by: Kalyan Thota > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [v1] drm/msm/disp/dpu1: set default group ID for CTL.

2021-10-28 Thread Stephen Boyd
Quoting Kalyan Thota (2021-10-28 07:05:01) > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h > b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h > index 4ade44b..57b9be1 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h

Re: [Freedreno] [PATCH v3 6/6] drm/msm/dp: Remove the hpd init delay for eDP

2021-10-27 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2021-10-27 18:54:48) > DP driver needs a 10 second delay before phy_init so that > the usb combo phy initializes and sets up the necessary > clocks for usb devices such as keyboard and mouse. > > eDP controller uses a standalone phy and need not wait for > phy initiali

Re: [Freedreno] [PATCH v3 5/6] drm/msm/dp: Enable ASSR for supported DP sinks

2021-10-27 Thread Stephen Boyd
le ASSR > if supported in the sink device. > > Signed-off-by: Sankeerth Billakanti > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v3 4/6] drm/msm/dp: Enable downspread for supported DP sinks

2021-10-27 Thread Stephen Boyd
. > > Signed-off-by: Sankeerth Billakanti > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v3 3/6] drm/dp: Add macro to check max_downspread capability

2021-10-27 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2021-10-27 18:54:45) > Add a macro to check for the max_downspread capability in > drm_dp_helper. > > Signed-off-by: Sankeerth Billakanti > --- Looks OK to me. One question below Reviewed-by: Stephen Boyd > include/drm/drm_dp_helper.h |

Re: [Freedreno] [PATCH v3 2/6] drm/msm/dp: Add DP controllers for sc7280

2021-10-27 Thread Stephen Boyd
r sc7280-dp (Dmitry Baryshkov) > - Add macro in drm_helper.h for checking ssc capability (Stephen Boyd) > - Use existing macro to check assr capability (Stephen Boyd) > - Add comment for HPD_INIT_SETUP delay (Stephen Boyd) > > changes in v2: > - Don't initialize v

Re: [Freedreno] [PATCH v3 1/6] dt-bindings: msm/dp: Add DP compatible strings for sc7280

2021-10-27 Thread Stephen Boyd
ned-off-by: Sankeerth Billakanti > > changes in v3: > - Modify the subject (Doug Anderson) > - Add sc7280-dp also to the list (Stephen Boyd) > > changes in v2: > - Sort alphabetically (Stephen Boyd) > - Cleanup residual stale changes in the patch (Matthias Kaehlc

Re: [Freedreno] [PATCH v3 03/34] component: Introduce the aggregate bus_type

2021-10-26 Thread Stephen Boyd
mutex_lock(&component_mutex); > 2a41e6070dd7ef Russell King 2014-01-10 871 > list_add_tail(&component->node, &component_list); > 2a41e6070dd7ef Russell King 2014-01-10 872 > mutex_unlock(&component_mutex); > 2a41e6070dd7ef Russell King 2014-01-10 873 >

[Freedreno] [PATCH v3 34/34] component: Remove component_master_ops and friends

2021-10-25 Thread Stephen Boyd
The struct is unused now so drop it along with the functions that use it. Cc: Daniel Vetter Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/componen

[Freedreno] [PATCH v3 18/34] drm/mediatek: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index ae

[Freedreno] [PATCH v3 31/34] sound: hdac: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
socki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- sound/hda/hdac_component.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/sound/hda/hdac_component.c b/sound/hda/hdac_component.c index bb37e7e0bd79..9e

[Freedreno] [PATCH v3 33/34] component: Get rid of drm_of_component_probe()

2021-10-25 Thread Stephen Boyd
There aren't any users anymore so drop it. Cc: Laurent Pinchart Cc: Daniel Vetter Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/dr

[Freedreno] [PATCH v3 23/34] drm/sun4i: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/sun4i/sun4i_drv.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c index 54

[Freedreno] [PATCH v3 32/34] ASoC: codecs: wcd938x: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
; Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- sound/soc/codecs/wcd938x.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index f0daf8defcf1..6033de7f57ef 100644 -

[Freedreno] [PATCH v3 28/34] mei: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
ael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/misc/mei/hdcp/mei_hdcp.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/misc/mei/hdcp/mei_hdcp.c b/drivers/misc/mei/hdcp/mei_hd

[Freedreno] [PATCH v3 30/34] fbdev: omap2: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/video/fbdev/omap2/omapfb/dss/dss.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dss.c b/drivers/video/fbdev/omap2/omapfb/dss/dss.c index a6b1c1598040..f1

[Freedreno] [PATCH v3 24/34] drm/tilcdc: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c index 6b

[Freedreno] [PATCH v3 17/34] drm/mcde: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
ana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/mcde/mcde_drv.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/mcde/mcde_drv.c b/drivers/gpu/drm/mcde/mcde_drv.c index e60566a5739c..84fcfe77540e 100644 --- a/drivers/gp

[Freedreno] [PATCH v3 26/34] drm/zte: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
ana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/zte/zx_drm_drv.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c b/drivers/gpu/drm/zte/zx_drm_drv.c index 064056503ebb..b46f677ea51d 100644 --- a/drivers/g

[Freedreno] [PATCH v3 16/34] drm/ingenic: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 25 +-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/ingenic/ingenic-dr

[Freedreno] [PATCH v3 19/34] drm/meson: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
l King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/meson/meson_drv.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c index bc0d60df04ae..109fb9d057e3 10

[Freedreno] [PATCH v3 29/34] power: supply: ab8500: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/power/supply/ab8500_charger.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charg

[Freedreno] [PATCH v3 27/34] iommu/mtk: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
; Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/iommu/mtk_iommu.c| 14 +- drivers/iommu/mtk_iommu.h| 6 -- drivers/iommu/mtk_iommu_v1.c | 14 +- 3 files changed, 22 insertions(+), 12 deletions(-) diff --git

[Freedreno] [PATCH v3 21/34] drm/rockchip: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
; Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchi

[Freedreno] [PATCH v3 25/34] drm/vc4: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/vc4/vc4_drv.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c index f6c16c5aee68..bccbde7a2f59 10

[Freedreno] [PATCH v3 22/34] drm/sti: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
ana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/sti/sti_drv.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c index c7efb43b83ee..b277cc679154 100644 --- a/drivers/gpu/drm/sti/sti_d

[Freedreno] [PATCH v3 20/34] drm/omap: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
l King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/omapdrm/dss/dss.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c b/drivers/gpu/drm/omapdrm/dss/dss.c index d6a5862b4dbf..6a6ae2786d7a 100644 ---

[Freedreno] [PATCH v3 15/34] drm/imx: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
l King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/imx/imx-drm-core.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c index 9558e9e1b431..dbf5cca5201d 10

[Freedreno] [PATCH v3 09/34] drm/arm/hdlcd: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
l King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/arm/hdlcd_drv.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c index 479c2422a2e0..5c03eb98d814 100644 --- a/drive

[Freedreno] [PATCH v3 14/34] drm/exynos: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drive

[Freedreno] [PATCH v3 10/34] drm/malidp: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
: Laurent Pinchart Cc: Liviu Dudau Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/arm/malidp_drv.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git

[Freedreno] [PATCH v3 13/34] drm/kirin: Migrate to aggregate driver

2021-10-25 Thread Stephen Boyd
Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 20 --- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_dr

<    1   2   3   4   5   6   7   8   9   10   >