Re: [Freeipa-devel] [PATCH] 518 handle errors in uninstall better

2010-09-09 Thread Rob Crittenden
Rob Crittenden wrote: Dmitri Pal wrote: Adam Young wrote: On 08/31/2010 05:27 PM, Rob Crittenden wrote: # Always start certmonger. We can't untrack something if it isn't Is this really necessary? This is the only thing that jumped out at me in the patch. Assuming it really is: Ack I have n

Re: [Freeipa-devel] [PATCH] 518 handle errors in uninstall better

2010-09-07 Thread Rob Crittenden
Dmitri Pal wrote: Adam Young wrote: On 08/31/2010 05:27 PM, Rob Crittenden wrote: # Always start certmonger. We can't untrack something if it isn't Is this really necessary? This is the only thing that jumped out at me in the patch. Assuming it really is: Ack I have not looked at the patch

Re: [Freeipa-devel] [PATCH] 518 handle errors in uninstall better

2010-09-01 Thread Dmitri Pal
Adam Young wrote: > On 08/31/2010 05:27 PM, Rob Crittenden wrote: >> # Always start certmonger. We can't untrack something if it isn't > Is this really necessary? This is the only thing that jumped out at me > in the patch. > > Assuming it really is: Ack > I have not looked at the patch but I suspe

Re: [Freeipa-devel] [PATCH] 518 handle errors in uninstall better

2010-09-01 Thread Adam Young
On 08/31/2010 05:27 PM, Rob Crittenden wrote: # Always start certmonger. We can't untrack something if it isn't Is this really necessary? This is the only thing that jumped out at me in the patch. Assuming it really is: Ack ___ Freeipa-devel

[Freeipa-devel] [PATCH] 518 handle errors in uninstall better

2010-08-31 Thread Rob Crittenden
This patch attempts to make the uninstaller less scary. We were throwing a lot of odd errors about the client uninstall failing and certmonger failures. The problem was the leap of faith I was taking when untracking certs. I'm a lot more careful about how I do it. I've moved certmonger.py to i