Re: [Freeipa-devel] [PATCH 0053] Implement OTP token importing

2014-06-25 Thread Alexander Bokovoy
On Wed, 18 Jun 2014, Nathaniel McCallum wrote: On Wed, 2014-06-18 at 17:48 -0400, Simo Sorce wrote: On Wed, 2014-06-18 at 17:34 -0400, Nathaniel McCallum wrote: On Tue, 2014-05-13 at 12:38 -0400, Nathaniel McCallum wrote: This patch adds support for importing tokens using RFC 6030 key

Re: [Freeipa-devel] [PATCH 0053] Implement OTP token importing

2014-06-25 Thread Martin Kosek
On 06/25/2014 12:40 PM, Alexander Bokovoy wrote: On Wed, 18 Jun 2014, Nathaniel McCallum wrote: On Wed, 2014-06-18 at 17:48 -0400, Simo Sorce wrote: On Wed, 2014-06-18 at 17:34 -0400, Nathaniel McCallum wrote: On Tue, 2014-05-13 at 12:38 -0400, Nathaniel McCallum wrote: This patch adds

Re: [Freeipa-devel] [PATCH 0053] Implement OTP token importing

2014-06-18 Thread Simo Sorce
On Wed, 2014-06-18 at 17:34 -0400, Nathaniel McCallum wrote: On Tue, 2014-05-13 at 12:38 -0400, Nathaniel McCallum wrote: This patch adds support for importing tokens using RFC 6030 key container files. This includes decryption support. For sysadmin sanity, any tokens which fail to add will

Re: [Freeipa-devel] [PATCH 0053] Implement OTP token importing

2014-06-16 Thread Alexander Bokovoy
On Fri, 13 Jun 2014, Simo Sorce wrote: On Fri, 2014-06-13 at 15:39 -0400, Nathaniel McCallum wrote: I am CC'ing Simo because he wants to review my PBKDF2 implementation. Thank you. I am a bit concerned you are using etree.parse(self.args[0]) directly with the default parser configuration. I

Re: [Freeipa-devel] [PATCH 0053] Implement OTP token importing

2014-06-16 Thread Petr Viktorin
On 06/14/2014 12:05 AM, Simo Sorce wrote: On Fri, 2014-06-13 at 15:39 -0400, Nathaniel McCallum wrote: I am CC'ing Simo because he wants to review my PBKDF2 implementation. Thank you. I am a bit concerned you are using etree.parse(self.args[0]) directly with the default parser configuration.

Re: [Freeipa-devel] [PATCH 0053] Implement OTP token importing

2014-06-16 Thread Nathaniel McCallum
On Fri, 2014-06-13 at 18:05 -0400, Simo Sorce wrote: On Fri, 2014-06-13 at 15:39 -0400, Nathaniel McCallum wrote: I am CC'ing Simo because he wants to review my PBKDF2 implementation. Thank you. I am a bit concerned you are using etree.parse(self.args[0]) directly with the default parser

Re: [Freeipa-devel] [PATCH 0053] Implement OTP token importing

2014-06-16 Thread Petr Viktorin
On 06/16/2014 06:23 PM, Nathaniel McCallum wrote: On Fri, 2014-06-13 at 18:05 -0400, Simo Sorce wrote: On Fri, 2014-06-13 at 15:39 -0400, Nathaniel McCallum wrote: I am CC'ing Simo because he wants to review my PBKDF2 implementation. Thank you. I am a bit concerned you are using

Re: [Freeipa-devel] [PATCH 0053] Implement OTP token importing

2014-06-16 Thread Nathaniel McCallum
On Mon, 2014-06-16 at 11:53 +0300, Alexander Bokovoy wrote: On Fri, 13 Jun 2014, Simo Sorce wrote: On Fri, 2014-06-13 at 15:39 -0400, Nathaniel McCallum wrote: I am CC'ing Simo because he wants to review my PBKDF2 implementation. Thank you. I am a bit concerned you are using

Re: [Freeipa-devel] [PATCH 0053] Implement OTP token importing

2014-06-13 Thread Nathaniel McCallum
I am CC'ing Simo because he wants to review my PBKDF2 implementation. On Wed, 2014-06-11 at 17:41 -0400, Nathaniel McCallum wrote: On Wed, 2014-06-11 at 14:24 +0200, Jan Cholasta wrote: Hi, On 13.5.2014 18:40, Nathaniel McCallum wrote: On Tue, 2014-05-13 at 12:38 -0400, Nathaniel

Re: [Freeipa-devel] [PATCH 0053] Implement OTP token importing

2014-06-13 Thread Simo Sorce
On Fri, 2014-06-13 at 15:39 -0400, Nathaniel McCallum wrote: I am CC'ing Simo because he wants to review my PBKDF2 implementation. Thank you. I am a bit concerned you are using etree.parse(self.args[0]) directly with the default parser configuration. I think we should, at least, do something

Re: [Freeipa-devel] [PATCH 0053] Implement OTP token importing

2014-06-11 Thread Jan Cholasta
Hi, On 13.5.2014 18:40, Nathaniel McCallum wrote: On Tue, 2014-05-13 at 12:38 -0400, Nathaniel McCallum wrote: This patch adds support for importing tokens using RFC 6030 key container files. This includes decryption support. For sysadmin sanity, any tokens which fail to add will be written to

Re: [Freeipa-devel] [PATCH 0053] Implement OTP token importing

2014-06-11 Thread Nathaniel McCallum
On Wed, 2014-06-11 at 14:24 +0200, Jan Cholasta wrote: Hi, On 13.5.2014 18:40, Nathaniel McCallum wrote: On Tue, 2014-05-13 at 12:38 -0400, Nathaniel McCallum wrote: This patch adds support for importing tokens using RFC 6030 key container files. This includes decryption support. For

Re: [Freeipa-devel] [PATCH 0053] Implement OTP token importing

2014-05-13 Thread Nathaniel McCallum
On Tue, 2014-05-13 at 12:38 -0400, Nathaniel McCallum wrote: This patch adds support for importing tokens using RFC 6030 key container files. This includes decryption support. For sysadmin sanity, any tokens which fail to add will be written to the output file for examination. The main use