Re: [PATCH] Make std::list::iterator == and != global inline friend

2018-10-09 Thread François Dumont
On 10/09/2018 01:31 PM, Jonathan Wakely wrote: On 09/10/18 07:25 +0200, François Dumont wrote: As we talked one day I would like to make all iterator operators global for consistency. So here is the patch to do so for std::list iterators. By "global" you mean "non-member", right? Yes, commi

Re: introduce --enable-mingw-full32 to default to --large-address-aware

2018-10-09 Thread Alexandre Oliva
On Oct 10, 2018, JonY <10wa...@gmail.com> wrote: > On 10/10/2018 03:24 AM, Alexandre Oliva wrote: >> On Oct 9, 2018, JonY <10wa...@gmail.com> wrote: >> Now, if you wish it to affect Cygwin as well, I could implement that, >> and drop -mingw from the option name. I'd retain the current defaults

Re: introduce --enable-mingw-full32 to default to --large-address-aware

2018-10-09 Thread JonY
On 10/10/2018 03:24 AM, Alexandre Oliva wrote: > On Oct 9, 2018, JonY <10wa...@gmail.com> wrote: > >> It is fine to turn it on by default in 32bit MinGW (i686-*-mingw*), but >> leave the defaults as is for others like Cygwin, I am not too sure of >> the effects for Cygwin. > > Cygwin already has

Re: introduce --enable-mingw-full32 to default to --large-address-aware

2018-10-09 Thread Alexandre Oliva
On Oct 9, 2018, JonY <10wa...@gmail.com> wrote: > It is fine to turn it on by default in 32bit MinGW (i686-*-mingw*), but > leave the defaults as is for others like Cygwin, I am not too sure of > the effects for Cygwin. Cygwin already has --large-address-aware enabled, without an option to disab

[committed] Cleanup of libcpp diagnostic callbacks

2018-10-09 Thread David Malcolm
This patch renames the "error" callback within libcpp to "diagnostic", and uses the pair of enums in cpplib.h, rather than passing two different kinds of "int" around. Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Committed to trunk as r264999. gcc/c-family/ChangeLog: *

[PATCH] Optimize sin(atan(x)) and cos(atan(x)), take 3 (PR tree-optimization/86829)

2018-10-09 Thread Giuliano Augusto Faulin Belinassi
Fixed all issues pointed in the previous iteration. There is now a significant change regarding how the sin(atan(x)) constant is calculated, as now it checks for which values such that computing 1 + x*x won't overflow. There are two reasons for this change: (1) Avoid an intermediate infinity value

Re: [RFC][PATCH IRA] Fix PR87507, IRA unnecessarily uses non-volatile registers during register assignment

2018-10-09 Thread Vladimir Makarov
On 10/08/2018 03:36 PM, Peter Bergner wrote: PR87507 shows a problem where IRA assigns a non-volatile TImode reg pair to a pseudo when there is a volatile reg pair available to use. This then causes us to emit save/restore code for the non-volatile reg usage. The problem here is that the only v

Re: [PATCH] C++: simplify output from suggest_alternatives_for

2018-10-09 Thread Jason Merrill
On Tue, Oct 9, 2018 at 1:19 PM David Malcolm wrote: > + /* Emulation of a "move" constructor, but really a copy > + constructor. */ > + > + name_hint (const name_hint &other) > + : m_suggestion (other.m_suggestion), > +m_deferred (const_cast (other).take_deferred ()) > + { > + } > +

Re: [PATCH] Remove dead functions and fix VMS target by moving back some functions.

2018-10-09 Thread Martin Jambor
On Tue, Oct 09 2018, Martin Liška wrote: > Hi. > > Utilizing rtags' --find-dead-functions I'm suggesting a removal of part > of the functions reported with the script. I built all cross compilers > defined in contrib/config-list.mk and I fixed VMS targets that I broke > in previous removal. > > If

Re: [PATCH] PR libgcc/60790: Avoid IFUNC resolver access to uninitialized data

2018-10-09 Thread Florian Weimer
* Jeff Law: > On 03/29/2018 08:00 AM, Florian Weimer wrote: >> This patch performs lazy initialization of the relevant CPUID feature >> register value.  It will needlessly invoke the CPUID determination code >> on architectures which lack CPUID support or support for the feature >> register, but I

Re: [C++ Patch] PR 84423 ("[6/7/8/9 Regression] [concepts] ICE with invalid using declaration")

2018-10-09 Thread Jason Merrill
OK. On Tue, Oct 9, 2018 at 1:49 PM Paolo Carlini wrote: > > Hi, > > On 09/10/18 17:17, Jason Merrill wrote: > > On Sat, Sep 29, 2018 at 3:27 PM Paolo Carlini > > wrote: > >> Hi again, > >> > >> On 9/28/18 9:15 PM, Paolo Carlini wrote: > >>> Thanks. About the location, you are certainly right, bu

Re: [C++ Patch] PR 84423 ("[6/7/8/9 Regression] [concepts] ICE with invalid using declaration")

2018-10-09 Thread Paolo Carlini
Hi, On 09/10/18 17:17, Jason Merrill wrote: On Sat, Sep 29, 2018 at 3:27 PM Paolo Carlini wrote: Hi again, On 9/28/18 9:15 PM, Paolo Carlini wrote: Thanks. About the location, you are certainly right, but doesn't seem trivial. Something we can do *now* is using declspecs->locations[ds_typede

[PATCH] C++: simplify output from suggest_alternatives_for

2018-10-09 Thread David Malcolm
In the C++ FE, after emitting various errors about unrecognized names, the parser can call suggest_alternatives_for and/or suggest_alternative_in_explicit_scope. These can issue zero or more suggestions for the unrecognized name, or various other "note" diagnostics suggesting how to fix the pro

Re: [patch] Fix PR tree-optimization/86659

2018-10-09 Thread Eric Botcazou
> 2018-09-28 Eric Botcazou > > PR tree-optimization/86659 > * gimple-match.h (struct gimple_match_op): Add reverse field. Jonathan privately remarked that the new member should probably be initialized in the constructors (thanks!). Done thusly, applied on mainline as obvious.

Re: [PATCHv2] Handle not explicitly zero terminated strings in merge sections

2018-10-09 Thread Eric Botcazou
> Which version exactly (pkg list entire) of Solaris 11 are you running? > I'm using gas 2.31 and /bin/ld on Solaris 11.4 resp. 11.5 Beta, where > Bernd's patch in PR bootstrap/87551 fixed the remaining regressions. Solaris 11.3 with Gas 2.30. -- Eric Botcazou

libgo patch committed: Skip testSetPanicOnFault when using LLVM

2018-10-09 Thread Ian Lance Taylor
This patch by Cherry Zhang skips the testSetPanicOnFault tests when using gollvm. LLVM doesn't support non-call exceptions. This test was passing more or less by luck: if the faulting instruction is between two calls with the same landing pad (in instruction layout order, not the program's logic o

Re: [C++ Patch] PR 84423 ("[6/7/8/9 Regression] [concepts] ICE with invalid using declaration")

2018-10-09 Thread Jason Merrill
On Sat, Sep 29, 2018 at 3:27 PM Paolo Carlini wrote: > Hi again, > > On 9/28/18 9:15 PM, Paolo Carlini wrote: > > Thanks. About the location, you are certainly right, but doesn't seem > > trivial. Something we can do *now* is using > > declspecs->locations[ds_typedef] and declspecs->locations[ds_a

[Ada] Fix spurious -Wuninitialized warnings for small records

2018-10-09 Thread Pierre-Marie de Rodat
This change is aimed at getting rid of spurious -Wuninitialized warnings issued for small records passed by copy and containing default values for some of their components. The source of the problem is that the _Init parameter of the initialization routine is declared as an in/out parameter, so th

[Ada] Ignore pragmas Compile_Time_Error/Warning in GNATprove mode

2018-10-09 Thread Pierre-Marie de Rodat
GNATprove does not have sometimes the precise information of the compiler about size of types and objects, so that it cannot evaluate the expressions in pragma Compile_Time_Error/Warning the same way the compiler does. Thus, these pragmas should be ignored in GNATprove mode, as it can neither veri

[Ada] Fix spurious error on derived record passed as Out parameter

2018-10-09 Thread Pierre-Marie de Rodat
This fixlet gets rid of a spurious error issued in the specific case of a call to a subprogram taking an Out parameter of a discriminated record type without default discriminants, if the actual parameter is the result of the conversion to the record type of a variable whose type is derived from th

[Ada] Fix strange warning when using Ada.Iterator_Interface

2018-10-09 Thread Pierre-Marie de Rodat
The back-end was recently changed to issue more -Wuninitialized warnings on Out parameters and this has caught a case related to Ada.Iterator_Interface.: This patchlet simply kills this uninteresting warning. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-10-09 Eric Botcazou gcc/ada/

[Ada] Internal error on inlined renaming of subprogram instance

2018-10-09 Thread Pierre-Marie de Rodat
This fixes a recent regression introduced in the compiler for the inlined renaming of a subprogram instantiated in a package body. It was wrongly clearing the Is_Public flag on the entity associated with the body. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-10-09 Eric Botcazou gcc

[Ada] Spurious error message on visibiliy change in aspect expression

2018-10-09 Thread Pierre-Marie de Rodat
This patch removes an improper error message on a visibility change in an aspect expression between the freeze point and the end of the declaration list, when the expression involves a call to a instance of Unchecked_Conversion and the enclosing package declaration has a package body with multiple

Re: [PATCH][i386] Split reductions (was: Re: [PATCH][RFC][i386] Change sminmax reduction patterns)

2018-10-09 Thread Uros Bizjak
On Tue, Oct 9, 2018 at 3:28 PM Richard Biener wrote: > > On Mon, 8 Oct 2018, Richard Biener wrote: > > > On Fri, 5 Oct 2018, Uros Bizjak wrote: > > > > > On Thu, Oct 4, 2018 at 2:05 PM Richard Biener wrote: > > > > > > > > > > > > This tries to apply the same trick to sminmax reduction patterns >

Re: [PATCH] v2: C++: suggestions for misspelled private members (PR c++/84993)

2018-10-09 Thread David Malcolm
On Mon, 2018-09-24 at 10:56 -0600, Martin Sebor wrote: > On 09/21/2018 04:09 PM, David Malcolm wrote: > > This is v2 of the patch; I managed to bit-rot my own patch due to > > my > > fix for r264335, which tightened up the "is this meaningful" > > threshold > > on edit distances when finding spelli

Re: [PATCH][i386] Split reductions (was: Re: [PATCH][RFC][i386] Change sminmax reduction patterns)

2018-10-09 Thread Richard Biener
On Mon, 8 Oct 2018, Richard Biener wrote: > On Fri, 5 Oct 2018, Uros Bizjak wrote: > > > On Thu, Oct 4, 2018 at 2:05 PM Richard Biener wrote: > > > > > > > > > This tries to apply the same trick to sminmax reduction patterns > > > as for the reduc_plus_scal ones, namely reduce %zmm -> %ymm -> %x

[gomp5] Fix handling of task_reduction with variable length array sections

2018-10-09 Thread Jakub Jelinek
Hi! As the following testcase additions show, even the TYPE_MAX_VALUE var needs to be forced into temporary if it is a user variable, otherwise if that variable is changed by the user before taskgroup ends, we don't handle it correctly. In addition to that, this patch removes useless NULL second

[PATCH] Define std::string and related typedefs outside __cxx11 namespace

2018-10-09 Thread Jonathan Wakely
The typedefs for common specializations of std::__cxx11::basic_string do not need to be in the std::__cxx11 namespace. Those typedefs are never used for linkage purposes so don't appear in mangled names, and so don't need to be distinct from the equivalent typedefs for the COW std::basic_string sp

Re: [PATCHv2] Handle not explicitly zero terminated strings in merge sections

2018-10-09 Thread Rainer Orth
Hi Bernd, >> * The merge-all-constants-2.c test doesn't FAIL on Solaris/SPARC with >>/bin/as, although it lacks string merging support, too. The assembler >>output contains >> >> .section".rodata" >> >>so the pattern currently used to check for .rodata is too >>

Re: [PATCHv2] Handle not explicitly zero terminated strings in merge sections

2018-10-09 Thread Bernd Edlinger
On 10/03/18 18:31, Jeff Law wrote: >> - && (len = int_size_in_bytes (TREE_TYPE (decl))) > 0 >> - && TREE_STRING_LENGTH (decl) >= len) >> + && (len = int_size_in_bytes (TREE_TYPE (decl))) >= 0 >> + && TREE_STRING_LENGTH (decl) == len) > Not sure why you want to test for >= 0 here

RE: [PATCH][GCC][mid-end] Add a hook to support telling the mid-end when to probe the stack [patch (2/6)]

2018-10-09 Thread Tamar Christina
Hi Richard, > -Original Message- > From: Richard Biener > Sent: Tuesday, October 9, 2018 08:28 > To: Tamar Christina > Cc: Jeff Law ; gcc-patches@gcc.gnu.org; nd > ; i...@airs.com > Subject: RE: [PATCH][GCC][mid-end] Add a hook to support telling the mid- > end when to probe the stack [p

[PATCH] Fix setting of hotness in non-LTO mode (PR gcov-profile/77698).

2018-10-09 Thread Martin Liška
Hi. In non-LTO mode, we should not set hotness according to computed histogram in ipa-profile. Following patch does that and fixes the test-case isolated from PR. Patch survives regression tests on x86_64-linux-gnu. Ready for trunk? Thanks, Martin gcc/ChangeLog: 2018-10-09 Martin Liska

Re: [PATCHv2] Handle not explicitly zero terminated strings in merge sections

2018-10-09 Thread Rainer Orth
Hi Eric, >> Besides, the patch seems to have produced more fallout on Solaris: I see >> many new Go testsuite failures on Solaris 10 which probably are related, >> and Solaris bootstrap with Ada included is broken due to the extended >> usage of string merging. I'm currently investigating what's

[PATCH] Help PR63155 PTA hog a bit

2018-10-09 Thread Richard Biener
This helps us throw away constraints from uninitialized stuff earlier. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2018-10-09 Richard Biener PR tree-optimization/63155 * tree-ssa-structalias.c: Include tree-ssa.h. (get_constraint_for_ssa_v

Re: [PATCH] Come up with gcc/testsuite/g++.target/i386/i386.dg and move there some tests.

2018-10-09 Thread Martin Liška
On 10/9/18 11:03 AM, Rainer Orth wrote: > Hi Martin, > >> rename from gcc/testsuite/g++.dg/ext/pr82625.C >> rename to gcc/testsuite/g++.target/i386/pr82625.C >> index 59b174f8c51..0eb70baed5e 100644 >> --- a/gcc/testsuite/g++.dg/ext/pr82625.C >> +++ b/gcc/testsuite/g++.target/i386/pr82625.C >> @@

[PATCH] Fix cut&paste fallout

2018-10-09 Thread Richard Biener
Committed as obvious. Richard. 2018-10-09 Richard Biener * tree-vectorizer.c (dump_stmt_cost): Fix cut&paste missing replacements. diff --git a/gcc/tree-vectorizer.c b/gcc/tree-vectorizer.c index 0ab366b79a3..60ee7f6380c 100644 --- a/gcc/tree-vectorizer.c +++ b/gcc/tree-vec

Re: [PATCH] Make std::list::iterator == and != global inline friend

2018-10-09 Thread Jonathan Wakely
On 09/10/18 07:25 +0200, François Dumont wrote: As we talked one day I would like to make all iterator operators global for consistency. So here is the patch to do so for std::list iterators. By "global" you mean "non-member", right? Thanks to this change the operators ==(iterator, const_it

[C++ Patch PING] Re: [C++ Patch] PR 84423 ("[6/7/8/9 Regression] [concepts] ICE with invalid using declaration")

2018-10-09 Thread Paolo Carlini
Hi, gently pinging the below... On 29/09/18 21:27, Paolo Carlini wrote: Hi again, On 9/28/18 9:15 PM, Paolo Carlini wrote: Thanks. About the location, you are certainly right, but doesn't seem trivial. Something we can do *now* is using declspecs->locations[ds_typedef] and declspecs->locatio

Re: introduce --enable-mingw-full32 to default to --large-address-aware

2018-10-09 Thread JonY
On 10/09/2018 04:59 AM, Alexandre Oliva wrote: > On Oct 5, 2018, Joseph Myers wrote: > >> A new configure option needs documenting in install.texi. > > Ah, yes, thanks for the reminder. > > On Oct 6, 2018, JonY <10wa...@gmail.com> wrote: > >> They're both OK as far as I can see. I just don't

Re: [PATCH] Come up with gcc/testsuite/g++.target/i386/i386.dg and move there some tests.

2018-10-09 Thread Rainer Orth
Hi Martin, > rename from gcc/testsuite/g++.dg/ext/pr82625.C > rename to gcc/testsuite/g++.target/i386/pr82625.C > index 59b174f8c51..0eb70baed5e 100644 > --- a/gcc/testsuite/g++.dg/ext/pr82625.C > +++ b/gcc/testsuite/g++.target/i386/pr82625.C > @@ -1,7 +1,7 @@ > /* { dg-do compile } */ > /* { dg

Re: [PATCH] Come up with gcc/testsuite/g++.target/i386/i386.dg and move there some tests.

2018-10-09 Thread Martin Liška
Hi. There's another move of C++ tests, this time these that have dg-require-ifunc. Key question is whether we want to make subfolders for i386 tests (ext, other, ..)? Survives make check -k RUNTESTFLAGS="i386.exp" Martin >From d36db4d5b8306dcbe2d63762bc8596e05132e46a Mon Sep 17 00:00:00 2001 Fr

Re: [PATCH, ARM] Clean up arm backend using the @ construct for MD patterns

2018-10-09 Thread Ramana Radhakrishnan
On 09/10/2018 09:27, Mihail Ionescu wrote: > Hi all, > > This patch removes some of the machine mode checks from the arm backend when > emitting instructions by using the '@' construct (Parameterized Names[2]). It > is based on the previous AArch64 patch[1]. > > [1]https://gcc.gnu.org/ml/gcc-patc

Re: [PATCH] Come up with --param asan-stack-small-redzone (PR sanitizer/81715).

2018-10-09 Thread Martin Liška
PING^1 On 9/26/18 11:33 AM, Martin Liška wrote: > On 9/25/18 5:53 PM, Jakub Jelinek wrote: >> On Tue, Sep 25, 2018 at 05:26:44PM +0200, Martin Liška wrote: >>> The only missing piece is how to implement asan_emit_redzone_payload more >>> smart. >>> It means doing memory stores with 8,4,2,1 sizes

Re: [PATCH] ASAN: emit line information of stack variables.

2018-10-09 Thread Jakub Jelinek
On Thu, Sep 27, 2018 at 10:55:10AM +0200, Martin Liška wrote: > @@ -1281,15 +1284,30 @@ asan_emit_stack_protection (rtx base, rtx pbase, > unsigned int alignb, >pp_space (&asan_pp); >pp_wide_integer (&asan_pp, offsets[l - 1] - offsets[l]); >pp_space (&asan_pp); > + > +

[PATCH] Remove dead functions and fix VMS target by moving back some functions.

2018-10-09 Thread Martin Liška
Hi. Utilizing rtags' --find-dead-functions I'm suggesting a removal of part of the functions reported with the script. I built all cross compilers defined in contrib/config-list.mk and I fixed VMS targets that I broke in previous removal. If the folks are happy with the removal, I can probably co

Re: [PATCH] ASAN: emit line information of stack variables.

2018-10-09 Thread Martin Liška
PING^1 On 9/27/18 10:55 AM, Martin Liška wrote: > Hi. > > I've noticed ASAN can inform user about location of stack variables > when a stack violation is detected. > > Sample example: > > ... > This frame has 3 object(s): > [32, 36) 'counter' (line 3) <== Memory access at offset 36 overfl

RE: [PATCH][GCC][mid-end] Add a hook to support telling the mid-end when to probe the stack [patch (2/6)]

2018-10-09 Thread Richard Biener
On Tue, 9 Oct 2018, Tamar Christina wrote: > Hi All, > > I'm looking for permission to backport this patch to the GCC-8 branch > to fix PR86486. > > OK for backport? This doesn't seem to fix a regression and it's been on trunk only for a few days. Richard. > Thanks, > Tamar > > > -Origin