Re: [PATCH 1/3] aarch64: Add support for fp8 convert and scale

2024-11-07 Thread Kyrylo Tkachov
Hi Saurabh, > On 6 Nov 2024, at 11:03, saurabh@arm.com wrote: > > > The AArch64 FEAT_FP8 extension introduces instructions for conversion > and scaling. > > This patch introduces the following intrinsics: > 1. vcvt{1|2}_{bf16|high_bf16|low_bf16}_mf8_fpm. > 2. vcvt{q}_mf8_f16_fpm. > 3. vcvt_

Re: [PATCH] aarch64: Extend support for the AE family of Cortex CPUs

2024-11-07 Thread Kyrylo Tkachov
Hi Victor, > On 31 Oct 2024, at 22:40, Victor Do Nascimento > wrote: > > Implement -mcpu options for: > > - Cortex-A520AE > - Cortex-A720AE > - Cortex-R82AE > > These all implement the same feature sets as their non-AE > counterparts, using the same scheduler and costs and differing only i

Re: [PATCH 2/2] aarch64: Add AdvSIMD LUT extension and vluti2{q}_lane{q} intrinsics

2024-11-06 Thread Kyrylo Tkachov
Hi Vladimir, Thanks for the patches! > On 6 Nov 2024, at 08:50, vladimir.miloser...@arm.com wrote: > > > The AArch64 FEAT_LUT extension is optional from Armv9.2-a and mandatory > from Armv9.5-a. This extension introduces instructions for lookup table > read with 2-bit indices. > > This patch ad

Fwd: [PATCH] PR target/117449: Restrict vector rotate match and split to pre-reload

2024-11-05 Thread Kyrylo Tkachov
Forwarding to the correct ML... > Begin forwarded message: > > From: Kyrylo Tkachov via Gcc > Subject: [PATCH] PR target/117449: Restrict vector rotate match and split to > pre-reload > Date: 5 November 2024 at 17:57:40 GMT+1 > To: gcc mailing list > Reply-To: Ky

Re: [PATCH 1/6] PR 117048: simplify-rtx: Simplify (X << C1) [+, ^] (X >> C2) into ROTATE

2024-11-04 Thread Kyrylo Tkachov
> On 4 Nov 2024, at 16:03, Kyrylo Tkachov wrote: > > > >> On 4 Nov 2024, at 15:20, Jakub Jelinek wrote: >> >> On Mon, Nov 04, 2024 at 02:31:29PM +0100, Jakub Jelinek wrote: >>> On Mon, Nov 04, 2024 at 01:07:33PM +, Kyrylo Tkachov wrote: >>>&g

Re: [PATCH 1/6] PR 117048: simplify-rtx: Simplify (X << C1) [+, ^] (X >> C2) into ROTATE

2024-11-04 Thread Kyrylo Tkachov
> On 4 Nov 2024, at 15:20, Jakub Jelinek wrote: > > On Mon, Nov 04, 2024 at 02:31:29PM +0100, Jakub Jelinek wrote: >> On Mon, Nov 04, 2024 at 01:07:33PM +, Kyrylo Tkachov wrote: >>>> This seems to have broken bootstrap on multiple targets and is caus

Re: [PATCH 1/6] PR 117048: simplify-rtx: Simplify (X << C1) [+, ^] (X >> C2) into ROTATE

2024-11-04 Thread Kyrylo Tkachov
> On 4 Nov 2024, at 13:55, Richard Biener wrote: > > On Thu, Oct 31, 2024 at 4:30 PM Jeff Law wrote: >> >> >> >> On 10/27/24 10:21 AM, Kyrylo Tkachov wrote: >>> Hi all, >>> >>> simplify-rtx can transform (X << C1) | (X &

Re: [PATCH] AArch64: Switch off early scheduling

2024-10-31 Thread Kyrylo Tkachov
> On 31 Oct 2024, at 18:06, Richard Sandiford wrote: > > Wilco Dijkstra writes: >> The early scheduler takes up ~33% of the total build time, however it doesn't >> provide a meaningful performance gain. This is partly because modern OoO >> cores >> need far less scheduling, partly because th

Re: [PATCH 4/6] expmed, aarch64: Optimize vector rotates as vector permutes where possible

2024-10-31 Thread Kyrylo Tkachov
Hi Jeff, > On 31 Oct 2024, at 16:25, Jeff Law wrote: > > > > On 10/27/24 10:22 AM, Kyrylo Tkachov wrote: >> Hi all, >> Some vector rotate operations can be implemented in a single instruction >> rather than using the fallback SHL+USRA sequence. >> In par

Re: [PATCH v2 04/21] aarch64: Add __builtin_aarch64_chkfeat

2024-10-31 Thread Kyrylo Tkachov
> On 31 Oct 2024, at 14:23, Yury Khrustalev wrote: > > From: Szabolcs Nagy > > Builtin for chkfeat: the input argument is used to initialize x16 then > execute chkfeat and return the updated x16. > > Note: ACLE __chkfeat(x) plans to flip the bits to be more intuitive > (xor the input to outp

Re: [PATCH v2 07/21] aarch64: Add GCS builtins

2024-10-31 Thread Kyrylo Tkachov
Hi Yury, > On 31 Oct 2024, at 14:23, Yury Khrustalev wrote: > > From: Szabolcs Nagy > > Add new builtins for GCS: > > void *__builtin_aarch64_gcspr (void) > uint64_t __builtin_aarch64_gcspopm (void) > void *__builtin_aarch64_gcsss (void *) > > The builtins are always enabled, but should b

Re: [PATCH] aarch64: Add support for FUJITSU-MONAKA (-mcpu=fujitsu-monaka) CPU

2024-10-31 Thread Kyrylo Tkachov
> On 31 Oct 2024, at 11:50, Richard Sandiford wrote: > > "Yuta Mukai (Fujitsu)" writes: >> Hello, >> >> This patch adds initial support for FUJITSU-MONAKA CPU, which we are >> developing. >> This is the slides for the CPU: >> https://www.fujitsu.com/downloads/SUPER/topics/isc24/next-arm-bas

Re: [PATCH 6/6] simplify-rtx: Simplify ROTATE:HI (X:HI, 8) into BSWAP:HI (X)

2024-10-29 Thread Kyrylo Tkachov
> On 27 Oct 2024, at 20:42, Jeff Law wrote: > > > > On 10/24/24 12:24 AM, Kyrylo Tkachov wrote: >>> On 24 Oct 2024, at 07:36, Jeff Law wrote: >>> >>> >>> >>> On 10/22/24 2:26 PM, Kyrylo Tkachov wrote: >>>> Hi all, &g

[PATCH][committed] aarch64: Use implementation namespace for vxarq_u64 immediate argument

2024-10-28 Thread Kyrylo Tkachov
Hi all, Looks like this immediate variable was missed out when I last fixed the namespace issues in arm_neon.h. Fixed in the obvious manner. Bootstrapped and tested on aarch64-none-linux-gnu. Pushing to trunk. Thanks, Kyrill Signed-off-by: Kyrylo Tkachov * config/aarch64/arm_neon.h

Re: [PATCH 4/6] aarch64: Optimize vector rotates into REV* instructions where possible

2024-10-27 Thread Kyrylo Tkachov
> On 25 Oct 2024, at 15:25, Richard Sandiford wrote: > > Kyrylo Tkachov writes: >>> On 25 Oct 2024, at 13:46, Richard Sandiford >>> wrote: >>> >>> Kyrylo Tkachov writes: >>>> Thank you for the suggestions! I’m trying them

[PATCH 6/6] simplify-rtx: Simplify ROTATE:HI (X:HI, 8) into BSWAP:HI (X)

2024-10-27 Thread Kyrylo Tkachov
This change is not enough to generate the equivalent sequence in SVE, but that is something that should be tackled separately. Bootstrapped and tested on aarch64-none-linux-gnu. Signed-off-by: Kyrylo Tkachov gcc/ * simplify-rtx.cc (simplify_context::simplify_binary_operat

[PATCH 4/6] expmed, aarch64: Optimize vector rotates as vector permutes where possible

2024-10-27 Thread Kyrylo Tkachov
ensure the permute indices are not messed up. Bootstrapped and tested on aarch64-none-linux-gnu. Richard had approved these changes in the previous iteration, but I’ll only push this after the prerequisites in the series. Thanks, Kyrill Signed-off-by: Kyrylo Tkachov gcc/ * expmed.h

[PATCH 5/6] aarch64: Emit XAR for vector rotates where possible

2024-10-27 Thread Kyrylo Tkachov
usrav31.4s, v0.4s, 23 mov v0.16b, v31.16b ret G2: shl v31.8b, v0.8b, 3 usrav31.8b, v0.8b, 5 mov v0.8b, v31.8b ret Bootstrapped and tested on aarch64-none-linux-gnu. Signed-off-by: Kyrylo Tkachov gcc/

[PATCH 3/6] PR 117048: aarch64: Add define_insn_and_split for vector ROTATE

2024-10-27 Thread Kyrylo Tkachov
-none-linux-gnu. I’ll push this if the prerequisites are approved. Thanks, Kyrill Signed-off-by: Kyrylo Tkachov gcc/ PR target/117048 * config/aarch64/aarch64-simd.md (*aarch64_simd_rotate_imm): New define_insn_and_split. gcc/testsuite/ PR target/117048

[PATCH 1/6] PR 117048: simplify-rtx: Simplify (X << C1) [+,^] (X >> C2) into ROTATE

2024-10-27 Thread Kyrylo Tkachov
lf-tests in this patch to validate the transformation. Bootstrapped and tested on aarch64-none-linux-gnu. Ok for mainline? Thanks, Kyrill Signed-off-by: Kyrylo Tkachov PR target/117048 * simplify-rtx.cc (extract_ashift_operands_p): Define. (simplif

[PATCH 2/6] aarch64: Use canonical RTL representation for SVE2 XAR and extend it to fixed-width modes

2024-10-27 Thread Kyrylo Tkachov
ed on aarch64-none-linux-gnu. Ok for mainline? Thanks, Kyrill Signed-off-by: Kyrylo Tkachov gcc/ * config/aarch64/iterators.md (SVE_ASIMD_FULL_I): New mode iterator. * config/aarch64/aarch64-sve2.md (@aarch64_sve2_xar): Use SVE_ASIMD_FULL_I modes. Use ROTATE code for the r

Re: [PATCH 4/6] aarch64: Optimize vector rotates into REV* instructions where possible

2024-10-25 Thread Kyrylo Tkachov
> On 25 Oct 2024, at 13:46, Richard Sandiford wrote: > > Kyrylo Tkachov writes: >> Thank you for the suggestions! I’m trying them out now. >> >>>> + if (rotamnt % BITS_PER_UNIT != 0) >>>> +return NULL_RTX; >>>> + machine_mo

Re: [PATCH 4/6] aarch64: Optimize vector rotates into REV* instructions where possible

2024-10-25 Thread Kyrylo Tkachov
Thank you for the suggestions! I’m trying them out now. > On 24 Oct 2024, at 21:11, Richard Sandiford wrote: > > Kyrylo Tkachov writes: >> Hi Richard, >> >>> On 23 Oct 2024, at 11:30, Richard Sandiford >>> wrote: >>> >>> Kyrylo Tk

Re: [PATCH] aarch64: Support multiple variants including up to 3

2024-10-25 Thread Kyrylo Tkachov
Hi Andrew, > On 25 Oct 2024, at 01:10, Andrew Pinski wrote: > > On Mon, Jun 3, 2024 at 2:23 AM Andrew Pinski (QUIC) > wrote: >> >>> -Original Message- >>> From: Andrew Pinski (QUIC) >>> Sent: Saturday, May 4, 2024 2:03 AM >>> To: gcc-patches@gcc.gnu.org >>> Cc: Andrew Pinski (QUIC) >

Re: [PATCH 4/6] aarch64: Optimize vector rotates into REV* instructions where possible

2024-10-25 Thread Kyrylo Tkachov
Hi Richard, > On 23 Oct 2024, at 11:30, Richard Sandiford wrote: > > Kyrylo Tkachov writes: >> Hi all, >> >> Some vector rotate operations can be implemented in a single instruction >> rather than using the fallback SHL+USRA sequence. >> In particu

Re: SVE intrinsics: Fold constant operands for svlsl.

2024-10-24 Thread Kyrylo Tkachov
> On 24 Oct 2024, at 10:39, Soumya AR wrote: > > Hi Richard, > > > On 23 Oct 2024, at 5:58 PM, Richard Sandiford > > wrote: > > > > External email: Use caution opening links or attachments > > > > > > Soumya AR writes: > >> diff --git a/gcc/config/aarch64/aarch64-sve-builtins.cc > >> b/

Re: [PATCH 6/6] simplify-rtx: Simplify ROTATE:HI (X:HI, 8) into BSWAP:HI (X)

2024-10-23 Thread Kyrylo Tkachov
> On 24 Oct 2024, at 07:36, Jeff Law wrote: > > > > On 10/22/24 2:26 PM, Kyrylo Tkachov wrote: >> Hi all, >> With recent patch to improve detection of vector rotates at RTL level >> combine now tries matching a V8HImode rotate by 8 in the example in the >

Re: [PATCH 1/3] PR 117048: simplify-rtx: Simplify (X << C1) [+, ^] (X >> C2) into ROTATE

2024-10-22 Thread Kyrylo Tkachov
I’ve updated and extended this patch series at: https://gcc.gnu.org/pipermail/gcc-patches/2024-October/666137.html So please review that one instead. Thanks, Kyrill > On 16 Oct 2024, at 15:56, Kyrylo Tkachov wrote: > > Hi all, > > The motivating testcase for this is in AAr

[PATCH 3/6] PR 117048: aarch64: Add define_insn_and_split for vector ROTATE

2024-10-22 Thread Kyrylo Tkachov
on aarch64-none-linux-gnu. I’ll commit this if the prerequisites are approved. Thanks, Kyrill Signed-off-by: Kyrylo Tkachov gcc/ PR target/117048 * config/aarch64/aarch64-simd.md (*aarch64_simd_rotate_imm): New define_insn_and_split. gcc/testsuite/ P

[PATCH 6/6] simplify-rtx: Simplify ROTATE:HI (X:HI, 8) into BSWAP:HI (X)

2024-10-22 Thread Kyrylo Tkachov
This change is not enough to generate the equivalent sequence in SVE, but that is something that should be tackled separately. Bootstrapped and tested on aarch64-none-linux-gnu. Signed-off-by: Kyrylo Tkachov gcc/ * simplify-rtx.cc (simplify_context::simplify_binary_operat

[PATCH 2/6] aarch64: Use canonical RTL representation for SVE2 XAR and extend it to fixed-width modes

2024-10-22 Thread Kyrylo Tkachov
e, so restrict the SVE2 pattern accordingly. Tests are added to confirm this. Bootstrapped and tested on aarch64-none-linux-gnu. Ok for mainline? Signed-off-by: Kyrylo Tkachov gcc/ * config/aarch64/iterators.md (SVE_ASIMD_FULL_I): New mode iterator. * config/aarch64/aarch64-sv

[PATCH 5/6] aarch64: Emit XAR for vector rotates where possible

2024-10-22 Thread Kyrylo Tkachov
: shl v31.4s, v0.4s, 9 usrav31.4s, v0.4s, 23 mov v0.16b, v31.16b ret G2: shl v31.8b, v0.8b, 3 usrav31.8b, v0.8b, 5 mov v0.8b, v31.8b ret Bootstrapped and tested on aarch64-none-linux-gnu. Signed-off-

[PATCH 4/6] aarch64: Optimize vector rotates into REV* instructions where possible

2024-10-22 Thread Kyrylo Tkachov
recently added splitter for vector rotates. Bootstrapped and tested on aarch64-none-linux-gnu. Signed-off-by: Kyrylo Tkachov gcc/ * config/aarch64/aarch64-protos.h (aarch64_emit_opt_vec_rotate): Declare prototype. * config/aarch64/aarch64.cc (aarch64_emit_opt_vec_rotate

[PATCH 1/6] PR 117048: simplify-rtx: Simplify (X << C1) [+,^] (X >> C2) into ROTATE

2024-10-22 Thread Kyrylo Tkachov
lf-tests in this patch to validate the transformation. Bootstrapped and tested on aarch64-none-linux-gnu. Ok for mainline? Thanks, Kyrill Signed-off-by: Kyrylo Tkachov PR target/117048 * simplify-rtx.cc (extract_ashift_operands_p): Define. (simplif

Re: [PATCH] AArch64: Remove redundant check in aarch64_simd_mov

2024-10-18 Thread Kyrylo Tkachov
> On 17 Oct 2024, at 22:32, Victor Do Nascimento > wrote: > > FWIW, I definitely agree about the spuriousness of the V2DI mode check. > While I can't approve, I can confirm it looks good. Thanks for looking at it Victor. The patch is ok. Kyrill > > Thanks, > Victor. > > On 10/17/24 16:10,

Re: [PATCH v3] MATCH: Simplify `a rrotate (32-b) -> a lrotate b` [PR109906]

2024-10-17 Thread Kyrylo Tkachov
Hi Eikansh > On 16 Oct 2024, at 18:23, Eikansh Gupta wrote: > > The pattern `a rrotate (32-b)` should be optimized to `a lrotate b`. > The same is also true for `a lrotate (32-b)`. It can be optimized to > `a rrotate b`. > > This patch adds following patterns: > a rrotate (32-b) -> a lrotate b

Re: SVE intrinsics: Fold constant operands for svlsl.

2024-10-17 Thread Kyrylo Tkachov
Hi Soumya > On 17 Oct 2024, at 06:10, Soumya AR wrote: > > Hi Richard, > > Thanks for the feedback. I’ve updated the patch with the suggested change. > Ok for mainline? > > Best, > Soumya > > > On 14 Oct 2024, at 6:40 PM, Richard Sandiford > > wrote: > > > > External email: Use caution ope

[PATCH 3/3] aarch64: Optimize vector rotates into REV* instructions where possible

2024-10-16 Thread Kyrylo Tkachov
d tested on aarch64-none-linux-gnu. As with patch [2/3] interested in feedback on the approach. Thanks, Kyrill Signed-off-by: Kyrylo Tkachov gcc/ * config/aarch64/aarch64-protos.h (aarch64_emit_opt_vec_rotate): Declare prototype. * config/aarch64/aarch64.cc (a

[PATCH 2/3] PR 117048: aarch64: Add define_insn_and_split for vector ROTATE

2024-10-16 Thread Kyrylo Tkachov
on aarch64-none-linux-gnu. Interested in feedback on the approach, but this needs patch [1/3] before this has effect. Signed-off-by: Kyrylo Tkachov gcc/ PR target/117048 * config/aarch64/aarch64-simd.md (*aarch64_simd_rotate_imm): New define_insn_and_split. gcc/testsui

[PATCH 1/3] PR 117048: simplify-rtx: Simplify (X << C1) [+,^] (X >> C2) into ROTATE

2024-10-16 Thread Kyrylo Tkachov
needs some extra AArch64 backend work, but I've added self-tests in this patch to validate the transformation. Bootstrapped and tested on aarch64-none-linux-gnu Ok for mainline? Thanks, Kyrill Signed-off-by: Kyrylo Tkachov PR target/117048 * simplify-r

Re: [PATCH] aarch64: libstdc++: Use shufflevector instead of shuffle in opt_random.h

2024-10-14 Thread Kyrylo Tkachov
> On 14 Oct 2024, at 15:28, Ricardo Jesus wrote: > > External email: Use caution opening links or attachments > > > This patch modifies the implementation of the vectorized mersenne > twister random number generator to use __builtin_shufflevector instead > of __builtin_shuffle. This makes it

Re: [PATCH 3/4]AArch64: enable zero-extends using TBLs for Adv. SIMD

2024-10-14 Thread Kyrylo Tkachov
Hi Tamar, > On 14 Oct 2024, at 12:56, Tamar Christina wrote: > > External email: Use caution opening links or attachments > > > Hi All, > > In this patch series I'm adding support for zero extending using permutes > instead of requiring multi-step decomposition. > > This codegen has the bene

Re: [PATCH 1/2] PR 117048: simplify-rtx: Extend (x << C1) | (X >> C2) --> ROTATE transformation to vector operands

2024-10-11 Thread Kyrylo Tkachov
> On 11 Oct 2024, at 12:28, Richard Sandiford wrote: > > External email: Use caution opening links or attachments > > > Kyrylo Tkachov writes: >> Hi all, >> >> In the testcase from patch [2/2] we want to match a vector rotate operation >> from >&

Re: [PATCH 2/2] PR target/117048 aarch64: Use more canonical and optimization-friendly representation for XAR instruction

2024-10-11 Thread Kyrylo Tkachov
> On 11 Oct 2024, at 12:36, Richard Sandiford wrote: > > External email: Use caution opening links or attachments > > > Kyrylo Tkachov writes: >> The pattern for the Advanced SIMD XAR instruction isn't very >> optimization-friendly at the moment. >>

Re: [PATCH] [PR86710][PR116826] match.pd: Fold logarithmic identities.

2024-10-11 Thread Kyrylo Tkachov
Hi Jennifer, > On 11 Oct 2024, at 10:00, Jennifer Schmitz wrote: > > > >> On 8 Oct 2024, at 10:44, Richard Biener wrote: >> >> External email: Use caution opening links or attachments >> >> >> On Thu, 3 Oct 2024, Jennifer Schmitz wrote: >> >>> >>> On 1 Oct 2024, at 14:27, Richard B

[PATCH 2/2] PR target/117048 aarch64: Use more canonical and optimization-friendly representation for XAR instruction

2024-10-11 Thread Kyrylo Tkachov
t one XAR instruction. Bootstrapped and tested on aarch64-none-linux-gnu. I’ll push it after patch approval of [1/2] leaving some time for comments. I’ll note that the SVE2 patterns for XAR should also be improved in a similar but that is a separate patch. Thanks, Kyrill Signed-off-by: Kyrylo Tkac

[PATCH 1/2] PR 117048: simplify-rtx: Extend (x << C1) | (X >> C2) --> ROTATE transformation to vector operands

2024-10-11 Thread Kyrylo Tkachov
x-gnu. Ok for mainline? Thanks, Kyrill Signed-off-by: Kyrylo Tkachov PR target/117048 * simplify-rtx.cc (simplify_context::simplify_binary_operation_1): Handle vector constants in (x << C1) | (x >> C2) -> ROTATE simplification. 0001-PR-117048-simp

Re: [PATCH] aarch64: Fix folding of degenerate svwhilele case [PR117045]

2024-10-10 Thread Kyrylo Tkachov
> On 9 Oct 2024, at 17:35, Richard Sandiford wrote: > > External email: Use caution opening links or attachments > > > Tamar Christina writes: >> Hi Richard, >> >>> -Original Message- >>> From: Richard Sandiford >>> Sent: Wednesday, October 9, 2024 12:58 PM >>> To: gcc-patches@gcc

Re: [PATCH 2/3] aarch64: libgcc: add prototypes in cpuinfo

2024-10-08 Thread Kyrylo Tkachov
> On 8 Oct 2024, at 11:57, Richard Sandiford wrote: > > External email: Use caution opening links or attachments > > > Christophe Lyon writes: >> On Fri, 4 Oct 2024 at 10:00, Kyrylo Tkachov wrote: >>> >>> >>> >>

Re: [PATCH] aarch64: Set Armv9-A generic L1 cache line size to 64 bytes

2024-10-04 Thread Kyrylo Tkachov
Hi Richard, > On 1 Oct 2024, at 13:35, Richard Sandiford wrote: > > External email: Use caution opening links or attachments > > > Kyrylo Tkachov writes: >> Hi all, >> I'd like to use a value of 64 bytes for the L1 cache size for Armv9-A >

Re: [PATCH 2/2] aarch64: remove SVE2 requirement from SME and diagnose it as unsupported

2024-10-04 Thread Kyrylo Tkachov
Hi Andre, > On 2 Oct 2024, at 19:13, Andre Vieira wrote: > > External email: Use caution opening links or attachments > > > As per the AArch64 ISA FEAT_SME does not require FEAT_SVE2, so we are removing > that false dependency in GCC. However, we chose for now to not support this > combinatio

Re: [PATCH 0/2] aarch64: remove SVE2 requirement from SME and diagnose it as unsupported

2024-10-04 Thread Kyrylo Tkachov
Hi Andre, > On 2 Oct 2024, at 19:13, Andre Vieira wrote: > > External email: Use caution opening links or attachments > > > This patch series removes the requirement of SVE2 for SME, so when a user > passes +sme, SVE2 is not enabled as a result of that. > We do this to be compliant with the IS

Re: [PATCH 3/3] aarch64: libgcc: Add -Werror support

2024-10-04 Thread Kyrylo Tkachov
> On 3 Oct 2024, at 21:44, Christophe Lyon wrote: > > External email: Use caution opening links or attachments > > > When --enable-werror is enabled when running the top-level configure, > it passes --enable-werror-always to subdirs. Some of them, like > libgcc, ignore it. > > This patch ad

Re: [PATCH 2/3] aarch64: libgcc: add prototypes in cpuinfo

2024-10-04 Thread Kyrylo Tkachov
> On 3 Oct 2024, at 21:44, Christophe Lyon wrote: > > External email: Use caution opening links or attachments > > > Add prototypes for __init_cpu_features_resolver and > __init_cpu_features to avoid warnings due to -Wmissing-prototypes. > >libgcc/ >* config/aarch64/cpuinfo.

Re: [PATCH 1/3] aarch64: libgcc: Cleanup warnings in lse.S

2024-10-04 Thread Kyrylo Tkachov
> On 3 Oct 2024, at 21:44, Christophe Lyon wrote: > > External email: Use caution opening links or attachments > > > Since > Commit c608ada288ced0268c1fd4136f56c34b24d4 > Author: Zac Walker > CommitDate: 2024-01-23 15:32:30 + > > Ifdef `.hidden`, `.type`, and `.size` pseudo

Re: [PATCH] aarch64: Optimise calls to ldexp with SVE FSCALE instruction

2024-10-03 Thread Kyrylo Tkachov
> On 3 Oct 2024, at 16:41, Richard Sandiford wrote: > > External email: Use caution opening links or attachments > > > Soumya AR writes: >> From 7fafcb5e0174c56205ec05406c9a412196ae93d3 Mon Sep 17 00:00:00 2001 >> From: Soumya AR >> Date: Thu, 3 Oct 2024 11:53:07 +0530 >> Subject: [PATCH] a

Re: [PATCH] [PR113816] AArch64: Use SVE bit op reduction for vector reductions

2024-10-02 Thread Kyrylo Tkachov
uesday, October 1, 2024 12:20 PM >>> To: Jennifer Schmitz >>> Cc: gcc-patches@gcc.gnu.org; Kyrylo Tkachov >>> Subject: Re: [PATCH] [PR113816] AArch64: Use SVE bit op reduction for vector >>> reductions >>> >>> Jennifer Schmitz writes: >

Re: [PATCH v1][GCC] aarch64: Add GCS build attributes support.

2024-10-01 Thread Kyrylo Tkachov
> On 12 Sep 2024, at 16:43, Eric Gallager wrote: > > > > On Wed, Sep 11, 2024 at 11:51 AM Srinath Parvathaneni > wrote: >> >> This patch adds support for aarch64 gcs build attributes. > > Hi, just wondering if you could clarify what "GCS" stands for in this > context? When I see it, my fir

Re: [PATCH] aarch64: Optimise calls to ldexp with SVE FSCALE instruction

2024-10-01 Thread Kyrylo Tkachov
> On 1 Oct 2024, at 09:48, Tamar Christina wrote: > > External email: Use caution opening links or attachments > > > Hi Soumya, > > Nice patch! > >> -----Original Message- >> From: Kyrylo Tkachov >> Sent: Tuesday, October 1, 2024

Re: [PATCH] aarch64: Optimise calls to ldexp with SVE FSCALE instruction

2024-09-30 Thread Kyrylo Tkachov
Hi Soumya > On 30 Sep 2024, at 18:26, Soumya AR wrote: > > External email: Use caution opening links or attachments > > > This patch uses the FSCALE instruction provided by SVE to implement the > standard ldexp family of functions. > > Currently, with '-Ofast -mcpu=neoverse-v2', GCC generates

[PATCH] aarch64: Set Armv9-A generic L1 cache line size to 64 bytes

2024-09-25 Thread Kyrylo Tkachov
Hi all, I'd like to use a value of 64 bytes for the L1 cache size for Armv9-A generic tuning. As described in g:9a99559a478111f7fbeec29bd78344df7651c707 this value is used to set the std::hardware_destructive_interference_size value which we want to be not overly large when running concurrent appli

Re: [PATCH v2] aarch64: Add fp8 scalar types

2024-09-20 Thread Kyrylo Tkachov
> On 19 Sep 2024, at 15:39, Claudio Bantaloukas > wrote: > > External email: Use caution opening links or attachments > > > On 9/19/2024 2:18 PM, Kyrylo Tkachov wrote: >> Hi Claudio, >> >>> On 19 Sep 2024, at 15:09, Claudio Bantaloukas >&

Re: [PATCH v2] aarch64: Add fp8 scalar types

2024-09-19 Thread Kyrylo Tkachov
Hi Claudio, > On 19 Sep 2024, at 15:09, Claudio Bantaloukas > wrote: > > External email: Use caution opening links or attachments > > > The ACLE defines a new scalar type, __mfp8. This is an opaque 8bit types that > can only be used by fp8 intrinsics. Additionally, the mfloat8_t type is made

Re: [PATCH 1/2] aarch64: Improve vector constant generation using SVE INDEX instruction [PR113328]

2024-09-17 Thread Kyrylo Tkachov
> On 17 Sep 2024, at 10:52, Richard Biener wrote: > > External email: Use caution opening links or attachments > > > On Tue, Sep 17, 2024 at 9:57 AM Kyrylo Tkachov wrote: >> >> >> >>> On 16 Sep 2024, at 16:32, Richard Sandiford >>&g

Re: [PATCH 1/2] aarch64: Improve vector constant generation using SVE INDEX instruction [PR113328]

2024-09-17 Thread Kyrylo Tkachov
> On 16 Sep 2024, at 16:32, Richard Sandiford wrote: > > External email: Use caution opening links or attachments > > > "Pengxuan Zheng (QUIC)" writes: >>> On Thu, Sep 12, 2024 at 2:53 AM Pengxuan Zheng >>> wrote: SVE's INDEX instruction can be used to populate vectors by values

Re: [PATCH] aarch64: Emit ADD X, Y, Y instead of SHL X, Y, #1 for SVE instructions

2024-09-16 Thread Kyrylo Tkachov
Hi Soumya, > On 16 Sep 2024, at 10:51, Soumya AR wrote: > > > >> On 12 Sep 2024, at 7:22 PM, Richard Sandiford >> wrote: >> >> External email: Use caution opening links or attachments >> >> >> Richard Biener writes: >>> On Thu, Sep 12, 2024 at 2:35 PM Richard Sandiford >>> wrote:

[PATCH] aarch64: Define l1_cache_line_size for -mcpu=neoverse-v2

2024-09-16 Thread Kyrylo Tkachov
l Signed-off-by: Kyrylo Tkachov * config/aarch64/tuning_models/neoversev2.h (neoversev2_prefetch_tune): Define. (neoversev2_tunings): Use it. 0001-aarch64-Define-l1_cache_line_size-for-mcpu-neoverse-.patch Description: 0001-aarch64-Define-l1_cache_line_size-for-mcpu-neoverse-.patch

Re: [PATCH 1/2] aarch64: Add SVE2 faminmax intrinsics

2024-09-15 Thread Kyrylo Tkachov
Hi Saurabh, Not a full review, just something I noticed. > On 13 Sep 2024, at 11:06, saurabh@arm.com wrote: > > External email: Use caution opening links or attachments > > > The AArch64 FEAT_FAMINMAX extension is optional from Armv9.2-a and > mandatory from Armv9.5-a. It introduces instru

Re: [PATCH 2/2] aarch64: Add codegen support for SVE2 faminmax

2024-09-15 Thread Kyrylo Tkachov
Hi Saurabh, > On 13 Sep 2024, at 11:06, saurabh@arm.com wrote: > > External email: Use caution opening links or attachments > > > The AArch64 FEAT_FAMINMAX extension is optional from Armv9.2-a and > mandatory from Armv9.5-a. It introduces instructions for computing the > floating point abso

Re: [PATCH v1][GCC] aarch64: Add GCS build attributes support.

2024-09-12 Thread Kyrylo Tkachov
Hi Srinath, Not a full review, just some things that popped out to me. > On 11 Sep 2024, at 17:50, Srinath Parvathaneni > wrote: > > External email: Use caution opening links or attachments > > > This patch adds support for aarch64 gcs build attributes. This support > includes generating two

Re: [PATCH 4/4]AArch64: Define VECTOR_STORE_FLAG_VALUE.

2024-09-09 Thread Kyrylo Tkachov
> On 9 Sep 2024, at 11:06, Tamar Christina wrote: > > External email: Use caution opening links or attachments > > >> -Original Message- >> From: Richard Sandiford >> Sent: Monday, September 9, 2024 9:29 AM >> To: Tamar Christina >> Cc: gcc-patches@gcc.gnu.org; nd ; Richard Earnsha

Re: [PATCH][PR116569] match.pd: Check trunc_mod vector obtap before folding.

2024-09-06 Thread Kyrylo Tkachov
> On 6 Sep 2024, at 16:00, Jakub Jelinek wrote: > > External email: Use caution opening links or attachments > > > On Fri, Sep 06, 2024 at 01:46:01PM +, Jennifer Schmitz wrote: >> In the pattern X - (X / Y) * Y to X % Y, this patch guards the >> simplification for vector types by a check

Re: [PATCH]middle-end: check that the lhs of a COND_EXPR is an SSA_NAME in cond_store recognition [PR116628]

2024-09-06 Thread Kyrylo Tkachov
Hi Tamar, > On 6 Sep 2024, at 14:56, Tamar Christina wrote: > > External email: Use caution opening links or attachments > > > Hi All, > > Because the vect_recog_bool_pattern can at the moment still transition > out of GIMPLE and back into GENERIC the vect_recog_cond_store_pattern can > end

Re: [PATCH 1/2] split-paths: Move check for # of statements in join earlier

2024-09-03 Thread Kyrylo Tkachov
Hi Andrew, > On 3 Sep 2024, at 20:11, Andrew Pinski wrote: > > External email: Use caution opening links or attachments > > > This moves the check for # of statements to copy in join to > be the first check. This check is the cheapest check so it > should be first. Plus add a print to the dump

Re: [PATCH v1 3/9] aarch64: Add minimal C++ support

2024-09-02 Thread Kyrylo Tkachov
Hi Evgeny, > On 2 Sep 2024, at 15:03, Evgeny Karpov wrote: > > External email: Use caution opening links or attachments > > > The patch resolves compilation issues for the C++ language. Previous > patch series contributed to C++ as well, however, C++ could not be > tested until we got a C++ co

Re: [PATCH v6 1/2] aarch64: Add AdvSIMD faminmax intrinsics

2024-08-29 Thread Kyrylo Tkachov
Hi Saurabh, > On 29 Aug 2024, at 09:51, saurabh@arm.com wrote: > > External email: Use caution opening links or attachments > > > The AArch64 FEAT_FAMINMAX extension is optional from Armv9.2-a and > mandatory from Armv9.5-a. It introduces instructions for computing the > floating point abso

Re: [RFC][PATCH] AArch64: Remove AARCH64_EXTRA_TUNE_USE_NEW_VECTOR_COSTS

2024-08-28 Thread Kyrylo Tkachov
> On 28 Aug 2024, at 10:27, Tamar Christina wrote: > > External email: Use caution opening links or attachments > > >> -Original Message- >> From: Kyrylo Tkachov >> Sent: Wednesday, August 28, 2024 8:55 AM >> To: Tamar Christina >> Cc:

Re: [PATCH v5 1/2] aarch64: Add AdvSIMD faminmax intrinsics

2024-08-28 Thread Kyrylo Tkachov
> On 28 Aug 2024, at 11:22, saurabh@arm.com wrote: > > External email: Use caution opening links or attachments > > > The AArch64 FEAT_FAMINMAX extension is optional from Armv9.2-a and > mandatory from Armv9.5-a. It introduces instructions for computing the > floating point absolute maxim

Re: [RFC][PATCH] AArch64: Remove AARCH64_EXTRA_TUNE_USE_NEW_VECTOR_COSTS

2024-08-28 Thread Kyrylo Tkachov
> On 28 Aug 2024, at 11:04, Richard Sandiford wrote: > > External email: Use caution opening links or attachments > > > Tamar Christina writes: >>> The patch was bootstrapped and regtested on aarch64-linux-gnu: >>> No problems bootstrapping, but several test files (in aarch64-sve.exp

Re: [RFC][PATCH] AArch64: Remove AARCH64_EXTRA_TUNE_USE_NEW_VECTOR_COSTS

2024-08-28 Thread Kyrylo Tkachov
d >> Sent: Tuesday, August 27, 2024 11:46 AM >> To: Tamar Christina >> Cc: Jennifer Schmitz ; gcc-patches@gcc.gnu.org; Kyrylo >> Tkachov >> Subject: Re: [RFC][PATCH] AArch64: Remove >> AARCH64_EXTRA_TUNE_USE_NEW_VECTOR_COSTS >> >> Tamar Christi

Re: [PATCH 3/3] aarch64: Add rtx cost for popcount [PR114224]

2024-08-28 Thread Kyrylo Tkachov
> On 28 Aug 2024, at 06:33, Andrew Pinski wrote: > > External email: Use caution opening links or attachments > > > While looking into some popcount related I noticed that the popcount > cost is not modeled at all. This adds both the vector and scalar (for CSSC) > costs. For CSSC, we default

Re: [PATCH] PR target/116365: Add user-friendly arguments to --param aarch64-autovec-preference=N

2024-08-22 Thread Kyrylo Tkachov
Hi Jennifer, > On 22 Aug 2024, at 08:59, Jennifer Schmitz wrote: > > On 21 Aug 2024, at 16:03, Richard Sandiford wrote: >> >> External email: Use caution opening links or attachments >> >> >> Kyrylo Tkachov writes: >>>> On 20 Aug 2024,

Re: [PATCH v4 2/2] aarch64: Add codegen support for AdvSIMD faminmax

2024-08-20 Thread Kyrylo Tkachov
> On 20 Aug 2024, at 17:44, saurabh@arm.com wrote: > > External email: Use caution opening links or attachments > > > The AArch64 FEAT_FAMINMAX extension is optional from Armv9.2-a and > mandatory from Armv9.5-a. It introduces instructions for computing the > floating point absolute maxim

Re: [PATCH v4 1/2] aarch64: Add AdvSIMD faminmax intrinsics

2024-08-20 Thread Kyrylo Tkachov
Hi Saurabh, > On 20 Aug 2024, at 17:44, saurabh@arm.com wrote: > > External email: Use caution opening links or attachments > > > The AArch64 FEAT_FAMINMAX extension is optional from Armv9.2-a and > mandatory from Armv9.5-a. It introduces instructions for computing the > floating point abso

Re: [PATCH] aarch64: Fix caller saves of VNx2QI [PR116238]

2024-08-20 Thread Kyrylo Tkachov
> On 20 Aug 2024, at 20:10, Richard Sandiford wrote: > > External email: Use caution opening links or attachments > > > The testcase contains a VNx2QImode pseudo that is live across a call > and that cannot be allocated a call-preserved register. LRA quite > reasonably tried to save it befo

Re: [PATCH] PR target/116365: Add user-friendly arguments to --param aarch64-autovec-preference=N

2024-08-20 Thread Kyrylo Tkachov
> On 20 Aug 2024, at 19:11, Richard Sandiford wrote: > > External email: Use caution opening links or attachments > > > Jennifer Schmitz writes: >> The param aarch64-autovec-preference=N is a useful tool for testing >> auto-vectorisation in GCC as it allows the user to force a particular >>

Re: [PATCH 1/2] SVE intrinsics: Fold constant operands for svdiv

2024-08-19 Thread Kyrylo Tkachov
Hi Richard, > On 19 Aug 2024, at 14:57, Richard Sandiford wrote: > > External email: Use caution opening links or attachments > > > Jennifer Schmitz writes: >> This patch implements constant folding for svdiv. A new gimple_folder >> method was added that uses const_binop to fold binary operat

Re: [PATCH][RFC] aarch64: Reduce FP reassociation width for Neoverse V2 and set AARCH64_EXTRA_TUNE_FULLY_PIPELINED_FMA

2024-08-19 Thread Kyrylo Tkachov
> On 12 Aug 2024, at 17:24, Tamar Christina wrote: > > External email: Use caution opening links or attachments > > >> -Original Message- >> From: Kyrylo Tkachov >> Sent: Monday, August 12, 2024 3:54 PM >> To: Tamar Christina >> Cc: G

Re: [PATCH v3 0/5] aarch64: Fix intrinsic availability [PR112108]

2024-08-16 Thread Kyrylo Tkachov
> On 15 Aug 2024, at 18:48, Andrew Carlotti wrote: > > External email: Use caution opening links or attachments > > > On Thu, Aug 15, 2024 at 05:15:03PM +0100, Richard Sandiford wrote: >> Andrew Carlotti writes: >>> This series of patches fixes issues with some intrinsics being incorrectly >

Re: [RFC][PATCH] SVE intrinsics: Fold svdiv (svptrue, x, x) to ones

2024-08-13 Thread Kyrylo Tkachov
t;> On 6 Aug 2024, at 4:14 PM, Richard Sandiford >>> wro>> Kyrylo Tkachov writes: >>>>> On 5 Aug 2024, at 18:00, Richard Sandiford >>>>> wro>>>> Kyrylo Tkachov writes: >>>>>>> On 5 Aug 2024,

Re: [PATCH][RFC] aarch64: Reduce FP reassociation width for Neoverse V2 and set AARCH64_EXTRA_TUNE_FULLY_PIPELINED_FMA

2024-08-12 Thread Kyrylo Tkachov
Hi Tamar, > On 12 Aug 2024, at 16:48, Tamar Christina wrote: > > External email: Use caution opening links or attachments > > > Hi Kyrill, > >> -Original Message----- >> From: Kyrylo Tkachov >> Sent: Monday, August 12, 2024 3:07 PM >> To:

[PATCH][RFC] aarch64: Reduce FP reassociation width for Neoverse V2 and set AARCH64_EXTRA_TUNE_FULLY_PIPELINED_FMA

2024-08-12 Thread Kyrylo Tkachov
meone else. Tamar, Richard, does the reasoning above make sense to you? I know that FMA reassociation is something we’ve gone back and forth on in the backend… Thanks, Kyrill Signed-off-by: Kyrylo Tkachov gcc/ChangeLog: * config/aarch64/tuning_models/neoversev2.h (fp_reassoc_

Re: [PATCH] lra: emit caller-save register spills before call insn [PR116028]

2024-08-09 Thread Kyrylo Tkachov
> On 9 Aug 2024, at 19:02, Vladimir Makarov wrote: > > External email: Use caution opening links or attachments > > > On 8/9/24 08:58, Surya Kumari Jangala wrote: >> I am looking into this failure. >> > Sorry for delay with this email. I was on vacation. > > I believe your should reverse t

Re: [PATCH v3 2/2] aarch64: Add codegen support for AdvSIMD faminmax

2024-08-09 Thread Kyrylo Tkachov
> On 7 Aug 2024, at 17:11, saurabh@arm.com wrote: > > External email: Use caution opening links or attachments > > > The AArch64 FEAT_FAMINMAX extension is optional from Armv9.2-a and > mandatory from Armv9.5-a. It introduces instructions for computing the > floating point absolute maximu

[PATCH] aarch64: Emit ADD X, Y, Y instead of SHL X, Y, #1 for Advanced SIMD

2024-08-09 Thread Kyrylo Tkachov
-none-linux-gnu. I’ll leave it up for comments for a few days and commit next week if no objections. Thanks, Kyrill Signed-off-by: Kyrylo Tkachov gcc/ChangeLog: * config/aarch64/aarch64-simd.md (aarch64_simd_imm_shl): Rewrite to new syntax. Add =w,w,vs1 altern

[PATCH][committed] aarch64: Check CONSTM1_RTX in definition of Dm constraint

2024-08-08 Thread Kyrylo Tkachov
ll Signed-off-by: Kyrylo Tkachov gcc/ChangeLog: * config/aarch64/constraints.md (Dm): Match CONSTM1_RTX rather CONST1_RTX. 0001-aarch64-Check-CONSTM1_RTX-in-definition-of-Dm-constr.patch Description: 0001-aarch64-Check-CONSTM1_RTX-in-definition-of-Dm-constr.patch

Re: [PATCH v3 1/2] aarch64: Add AdvSIMD faminmax intrinsics

2024-08-08 Thread Kyrylo Tkachov
Hi Saurabh, > On 7 Aug 2024, at 17:11, saurabh@arm.com wrote: > > External email: Use caution opening links or attachments > > > The AArch64 FEAT_FAMINMAX extension is optional from Armv9.2-a and > mandatory from Armv9.5-a. It introduces instructions for computing the > floating point absolute

Re: [RFC][PATCH] SVE intrinsics: Fold svdiv (svptrue, x, x) to ones

2024-08-06 Thread Kyrylo Tkachov
> On 6 Aug 2024, at 12:44, Richard Sandiford wrote: > > External email: Use caution opening links or attachments > > > Kyrylo Tkachov writes: >>> On 5 Aug 2024, at 18:00, Richard Sandiford >>> wrote: >>> >>> External email: Use cau

Re: [RFC][PATCH] SVE intrinsics: Fold svdiv (svptrue, x, x) to ones

2024-08-06 Thread Kyrylo Tkachov
> On 5 Aug 2024, at 18:00, Richard Sandiford wrote: > > External email: Use caution opening links or attachments > > > Kyrylo Tkachov writes: >>> On 5 Aug 2024, at 12:01, Richard Sandiford >>> wrote: >>> >>> External email: Use cauti

Re: [RFC][PATCH] SVE intrinsics: Fold svdiv (svptrue, x, x) to ones

2024-08-05 Thread Kyrylo Tkachov
> On 5 Aug 2024, at 18:00, Richard Sandiford wrote: > > External email: Use caution opening links or attachments > > > Kyrylo Tkachov writes: >>> On 5 Aug 2024, at 12:01, Richard Sandiford >>> wrote: >>> >>> External email: Use cauti

  1   2   3   4   5   6   7   8   9   10   >