Re: [PATCH] Time profiler - phase 2

2013-12-20 Thread Iain Sandoe
Hi Martin, Thanks for working on this! --- However you have introduced some problems including a bootstrap fail on darwin. On 16 Dec 2013, at 10:13, Jan Hubicka wrote: >> Hello, >> there's updated version of the patch. >> >> Tested on x86_64 with enable bootstrap. >> >> Martin >> >> On 16

Re: [PATCH] Time profiler - phase 2

2013-12-20 Thread Dominique Dhumieres
> Hello, >there's updated version of the patch. > > Tested on x86_64 with enable bootstrap. > > Martin This caused pr59541. TIA Dominique

Re: [PATCH] Time profiler - phase 2

2013-12-16 Thread Jan Hubicka
> Hello, >there's updated version of the patch. > > Tested on x86_64 with enable bootstrap. > > Martin > > On 16 December 2013 00:21, Jan Hubicka wrote: > >> diff --git a/gcc/ChangeLog b/gcc/ChangeLog > >> index 93e857df..d5a0ac8 100644 > >> --- a/gcc/ChangeLog > >> +++ b/gcc/ChangeLog > >>

Re: [PATCH] Time profiler - phase 2

2013-12-15 Thread Martin Liška
Hello, there's updated version of the patch. Tested on x86_64 with enable bootstrap. Martin On 16 December 2013 00:21, Jan Hubicka wrote: >> diff --git a/gcc/ChangeLog b/gcc/ChangeLog >> index 93e857df..d5a0ac8 100644 >> --- a/gcc/ChangeLog >> +++ b/gcc/ChangeLog >> @@ -1,3 +1,14 @@ >> +2013

Re: [PATCH] Time profiler - phase 2

2013-12-15 Thread Jan Hubicka
> diff --git a/gcc/ChangeLog b/gcc/ChangeLog > index 93e857df..d5a0ac8 100644 > --- a/gcc/ChangeLog > +++ b/gcc/ChangeLog > @@ -1,3 +1,14 @@ > +2013-12-15 Martin Liska > + Jan Hubicka > + > + * cgraphunit.c (node_cmp): New function. > + (expand_all_functions): Function ordering

Re: [PATCH] Time profiler - phase 2

2013-12-15 Thread Martin Liška
There's latest version of the patch. Could you please approve the patch? Martin On 5 December 2013 22:32, Jan Hubicka wrote: >> Hello, >>thank you for the trick in ipa-split.c. It really helped! I > > Good!, this patch is pre-approved after testing. >> prepared 2 tests for Inkscape, first wa

Re: [PATCH] Time profiler - phase 2

2013-12-05 Thread Jan Hubicka
> Hello, >thank you for the trick in ipa-split.c. It really helped! I Good!, this patch is pre-approved after testing. > prepared 2 tests for Inkscape, first was just with my function > reordering pass. And for the second, I enable also > -freorder-blocks-and-partition (note: files ending with

Re: [PATCH] Time profiler - phase 2

2013-12-05 Thread Martin Liška
Hello, thank you for the trick in ipa-split.c. It really helped! I prepared 2 tests for Inkscape, first was just with my function reordering pass. And for the second, I enable also -freorder-blocks-and-partition (note: files ending with _blocks.xxx in attached tar). Touched pages: just reorder

Re: [PATCH] Time profiler - phase 2

2013-12-05 Thread Jan Hubicka
> Can you, please, send me the -flto systemtaps for gimp and/or inkscape so we > can decide > on the patch? We should enable it earlier in stage3 rather than later. I see, the PDF was included within the tar file. Was this with -freorder-blocks-and-partition? If so, the patch is OK. I still thi

Re: [PATCH] Time profiler - phase 2

2013-12-05 Thread Jan Hubicka
> Hello, >there are dumps for Inkscape, it looks very well. There are few of > functions that look like this (wpa cgraph): > > _ZL13resync_activeP19_EgeSelectOneActionii/2604322 (resync_active) > @0x7f84af42cea0 > Type: function definition analyzed > Visibility: prevailing_def_ironly > R

Re: [PATCH] Time profiler - phase 2

2013-12-02 Thread Martin Liška
Hello, there are dumps for Inkscape, it looks very well. Link: https://docs.google.com/file/d/0B0pisUJ80pO1Y0t1aEVBRlByR28/edit There are few of functions that look like this (wpa cgraph): _ZL13resync_activeP19_EgeSelectOneActionii/2604322 (resync_active) @0x7f84af42cea0 Type: function defi

Re: [PATCH] Time profiler - phase 2

2013-11-18 Thread Jan Hubicka
> diff --git a/gcc/ChangeLog b/gcc/ChangeLog > index 5cb07b7..754f882 100644 > --- a/gcc/ChangeLog > +++ b/gcc/ChangeLog > @@ -1,3 +1,13 @@ > +2013-11-17 Martin Liska > + Jan Hubicka > + > + * cgraphunit.c (node_cmp): New function. > + (expand_all_functions): Function ordering

Re: [PATCH] Time profiler - phase 2

2013-11-17 Thread Martin Liška
Hello, there's new version of the patch. I wrote email to Cary to negotiate how will implement gold's linker patch. Thanks, Martin On 18 November 2013 00:37, Jan Hubicka wrote: >> Hello, >>there is a new version of the patch, I disabled the branch with >> profile-generate. Could you pleas

Re: [PATCH] Time profiler - phase 2

2013-11-17 Thread Jan Hubicka
> Hello, >there is a new version of the patch, I disabled the branch with > profile-generate. Could you please advise me how should I force to use > profile-reorder-functions just with enable LTO optimization? > > I also attach reordering results: > o gimp-reoder-latest.html (latest patch) > o

Re: [PATCH] Time profiler - phase 2

2013-11-17 Thread Jan Hubicka
> diff --git a/gcc/ChangeLog b/gcc/ChangeLog > index 5cb07b7..754f882 100644 > --- a/gcc/ChangeLog > +++ b/gcc/ChangeLog > @@ -1,3 +1,13 @@ > +2013-11-17 Martin Liska > + Jan Hubicka > + > + * cgraphunit.c (node_cmp): New function. > + (expand_all_functions): Function ordering

Re: [PATCH] Time profiler - phase 2

2013-11-17 Thread Martin Liška
Dear Jan, On 16 November 2013 12:24, Jan Hubicka wrote: >> diff --git a/gcc/ChangeLog b/gcc/ChangeLog >> index c566a85..1562098 100644 >> --- a/gcc/ChangeLog >> +++ b/gcc/ChangeLog >> @@ -1,3 +1,15 @@ >> +2013-11-13 Martin Liska >> + Jan Hubicka

Re: [PATCH] Time profiler - phase 2

2013-11-16 Thread Jan Hubicka
> diff --git a/gcc/ChangeLog b/gcc/ChangeLog > index c566a85..1562098 100644 > --- a/gcc/ChangeLog > +++ b/gcc/ChangeLog > @@ -1,3 +1,15 @@ > +2013-11-13 Martin Liska > + Jan Hubicka > + > + * cgraphunit.c (node_cmp): New function. > + (ex

[PATCH] Time profiler - phase 2

2013-11-13 Thread Martin Liška
Hello, this patch introduces new function reordering feature that is based on the patch I submitted few days ago. The idea of a new flag (-fprofile-reorder-functions) is to reorder functions according to the first execution in instrumented run. Of course, the option operates only in LTO mode, w