[fortran,patch] Extend IEEE support to all real kinds

2015-08-03 Thread FX
The attached patch extends the IEEE modules to all floating-point kinds. Last time, when I added IEEE support, I restricted it to the float and double types (real kinds 4 and 8), to be extra safe. After discussion with Uros Bizjak and some reading, I’ve come to the conclusion that on most hardwa

Re: [fortran,patch] Extend IEEE support to all real kinds

2015-08-03 Thread Steve Kargl
On Mon, Aug 03, 2015 at 11:14:41PM +0200, FX wrote: > > So, this enables full IEEE support for all real kinds. Nothing > changes to the underlying architecture, it???s almost exclusively > mechanical changes (adding the necessary variants to the interfaces, etc.). > > Bootstrapped and regtested

Re: [fortran,patch] Extend IEEE support to all real kinds

2015-08-03 Thread Uros Bizjak
On Mon, Aug 3, 2015 at 11:14 PM, FX wrote: > The attached patch extends the IEEE modules to all floating-point kinds. Last > time, when I added IEEE support, I restricted it to the float and double > types (real kinds 4 and 8), to be extra safe. After discussion with Uros > Bizjak and some read

Re: [fortran,patch] Extend IEEE support to all real kinds

2015-08-03 Thread Uros Bizjak
On Mon, Aug 3, 2015 at 11:14 PM, FX wrote: > The attached patch extends the IEEE modules to all floating-point kinds. Last > time, when I added IEEE support, I restricted it to the float and double > types (real kinds 4 and 8), to be extra safe. After discussion with Uros > Bizjak and some read

Re: [fortran,patch] Extend IEEE support to all real kinds

2015-08-05 Thread Andreas Schwab
FAIL: gfortran.dg/ieee/large_1.f90 -O0 (test for excess errors) Excess errors: large_1.f90:(.text+0x1792): undefined reference to `logbq' Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something compl

Re: [fortran,patch] Extend IEEE support to all real kinds

2015-08-05 Thread FX
> FAIL: gfortran.dg/ieee/large_1.f90 -O0 (test for excess errors) > Excess errors: > large_1.f90:(.text+0x1792): undefined reference to `logbq’ Fixed by the patch there: https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00124.html Waiting for review. FX

Re: [fortran,patch] Extend IEEE support to all real kinds

2015-08-06 Thread FX
> Can you please also introduce tests for ieee exceptions for long > double and __float128 types (as is done for real and double in > gfortran.dg/ieee/ieee_1.F90) as well as test for supported rounding > modes as done for real and double in gfortran.dg/ieee/rounding_1.f90 ? > > On x86_64, these ne

Re: [fortran,patch] Extend IEEE support to all real kinds

2015-08-06 Thread Uros Bizjak
On Thu, Aug 6, 2015 at 11:26 AM, FX wrote: >> Can you please also introduce tests for ieee exceptions for long >> double and __float128 types (as is done for real and double in >> gfortran.dg/ieee/ieee_1.F90) as well as test for supported rounding >> modes as done for real and double in gfortran.d

Re: [fortran,patch] Extend IEEE support to all real kinds

2015-08-07 Thread Rainer Orth
FX writes: >> FAIL: gfortran.dg/ieee/large_1.f90 -O0 (test for excess errors) >> Excess errors: >> large_1.f90:(.text+0x1792): undefined reference to `logbq’ > > Fixed by the patch there: > https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00124.html > Waiting for review. I think it's a bad idea

Re: [fortran,patch] Extend IEEE support to all real kinds

2015-08-07 Thread FX
> I think it's a bad idea committing an (approved) patch without the > prerequisite, introducing testsuite failures for everyone and sending us > all hunting what's wrong ;-( I realize I probably should have XFAIL’ed the testcase, indeed. But I was hoping for a quick review of the simple libquadm

Re: [fortran,patch] Extend IEEE support to all real kinds

2015-08-08 Thread FX
> 2015-08-06 Uros Bizjak > >PR fortran/64022 >* gfortran.dg/ieee/large_4.f90: New test. > > Tested on x86_64-linux-gnu {,-m32} and alphaev68-linux-gnu. > OK for mainline? OK. Thanks for the patch! FX