Re: [Patch, Fortran] PR68815 - replace '%s' quotes by %< ... %>

2015-12-11 Thread Tobias Burnus
On Fri, Dec 11, 2015 at 12:03:26AM +, Joseph Myers wrote: > On Thu, 10 Dec 2015, Manuel López-Ibáñez wrote: > > On 12/09/2015 03:53 PM, Tobias Burnus wrote: > > > In principle, %<%c%> and %<%d%> should be convertable to %qc and > > > %qd (as the code is more readable), but the current function

Re: [Patch, Fortran] PR68815 - replace '%s' quotes by %< ... %>

2015-12-10 Thread Manuel López-Ibáñez
On 12/09/2015 03:53 PM, Tobias Burnus wrote: In principle, %<%c%> and %<%d%> should be convertable to %qc and %qd (as the code is more readable), but the current function annotation prevent this, telling that the q flag is not valid for %c and %d. As %< is fine, I didn't dig into it. You need

Re: [Patch, Fortran] PR68815 - replace '%s' quotes by %< ... %>

2015-12-10 Thread Joseph Myers
On Thu, 10 Dec 2015, Manuel López-Ibáñez wrote: > On 12/09/2015 03:53 PM, Tobias Burnus wrote: > > In principle, %<%c%> and %<%d%> should be convertable to %qc and > > %qd (as the code is more readable), but the current function > > annotation prevent this, telling that the q flag is not valid

[Patch, Fortran] PR68815 - replace '%s' quotes by %< ... %>

2015-12-09 Thread Tobias Burnus
This patch replaces some of the '%s' quotes of diagnostic strings by the nicer quotes. First, it replaces some leftovers of '%s' -> %qs in directly used error strings. It then also converts some (well: resolve.c only) '%s' to %%<%s%%>, which are using with sprintf(), but which are still passed

Re: [Patch, Fortran] PR68815 - replace '%s' quotes by %< ... %>

2015-12-09 Thread Steve Kargl
On Wed, Dec 09, 2015 at 04:53:37PM +0100, Tobias Burnus wrote: > > Build and regtested on x86-64-gnu-linux. > OK for the trunk? > OK. -- Steve