Re: [PATCH] Fix up sign extension in bswap

2014-10-28 Thread Richard Biener
On Tue, 28 Oct 2014, Jakub Jelinek wrote: > On Tue, Oct 21, 2014 at 10:28:40AM +0100, Thomas Preud'homme wrote: > > --- a/gcc/tree-ssa-math-opts.c > > +++ b/gcc/tree-ssa-math-opts.c > > @@ -1916,7 +1916,8 @@ find_bswap_or_nop_1 (gimple stmt, struct > > symbolic_number *n, int limit) > > i

RE: [PATCH] Fix up sign extension in bswap

2014-10-29 Thread Thomas Preud'homme
> From: Jakub Jelinek [mailto:ja...@redhat.com] > Sent: Tuesday, October 28, 2014 12:27 PM > > Thomas, you know the code better, can you from the fix figure out > a testcase that current trunk miscompiles or doesn't optimize > because of this bug? Here you are (see attachment). Best regards, Th

RE: [PATCH] Fix up sign extension in bswap

2014-10-29 Thread Thomas Preud'homme
M > To: 'Jakub Jelinek'; Richard Biener > Cc: GCC Patches > Subject: RE: [PATCH] Fix up sign extension in bswap > > > From: Jakub Jelinek [mailto:ja...@redhat.com] > > Sent: Tuesday, October 28, 2014 12:27 PM > > > > Thomas, you know the code bette

Re: [PATCH] Fix up sign extension in bswap

2014-10-29 Thread Jakub Jelinek
On Wed, Oct 29, 2014 at 09:36:02AM -, Thomas Preud'homme wrote: > Bummer. Why didn't my MUA warned me on this one? I think this is ok for trunk with proper ChangeLog entry. Jakub

RE: [PATCH] Fix up sign extension in bswap

2014-10-29 Thread Thomas Preud'homme
> From: Jakub Jelinek [mailto:ja...@redhat.com] > Sent: Wednesday, October 29, 2014 9:41 AM > > I think this is ok for trunk with proper ChangeLog entry. Done with following ChangeLog entry: 2014-10-29 Thomas Preud'homme * gcc.dg/optimize-bswapsi-1.c (swap32_e): New bswap test.