Re: [PATCH, Android] MIPS support

2012-04-17 Thread Maxim Kuvyrkov
On 18/04/2012, at 1:10 PM, Fu, Chao-Ying wrote: > Maxim Kuvyrkov wrote: > >> Above definitions are OK. > > Thanks! For avoidance of doubt, please wait for the whole patch to be approved before committing it. Index: gcc/libgcc/unwind-dw2-fde-dip.c ===

RE: [PATCH, Android] MIPS support

2012-04-17 Thread Fu, Chao-Ying
Maxim Kuvyrkov wrote: > > > >> For now, two MIPS changes in gnu-user.h and > unwind-dw2-fde-dip.c can be posted for comment. > >> (I didn't tested this patch, though.) > > You need to test your patches before posting them for review. > Below are a couple of comments on your current version.

Re: [PATCH, Android] MIPS support

2012-04-17 Thread Maxim Kuvyrkov
On 5/04/2012, at 10:16 AM, Maxim Kuvyrkov wrote: > Chao, > > Let's take discussion of MIPS changes to gcc-patches@. Please follow up here. > > -- > Maxim Kuvyrkov > CodeSourcery / Mentor Graphics > > On 5/04/2012, at 10:10 AM, Fu, Chao-Ying wrote: > >> For now, two MIPS changes in gnu-user.h