On Thu, Nov 20, 2014 at 05:33:57PM -0600, James Norris wrote:
> >>+ t = OMP_CLAUSE_ASYNC_EXPR (c);
> >>+ if (t == error_mark_node)
> >>+ remove = true;
> >>+ else if (!type_dependent_expression_p (t)
> >>+ && !INTEGRAL_TYPE_P (TREE_TYPE (t)))
> >>+ {
> >>+
On Thu, Nov 20, 2014 at 05:50:33PM -0600, James Norris wrote:
> >>+ case 'h':
> >>+ if (!strcmp ("host", p))
> >>+ result = PRAGMA_OMP_CLAUSE_SELF;
> >>+ break;
> >Shouldn't this be PRAGMA_OMP_CLAUSE_HOST (PRAGMA_OACC_CLAUSE_HOST)
> >instead? It is _HOST in the C++ patch, are there
Hi!
On 11/13/2014 09:04 AM, Jakub Jelinek wrote:
On Wed, Nov 05, 2014 at 03:39:44PM -0600, James Norris wrote:
* c-typeck.c (c_finish_oacc_parallel, c_finish_oacc_kernels,
c_finish_oacc_data): New functions.
(handle_omp_array_sections, c_finish_omp_clauses):
Handle shou
Hi!
On 11/13/2014 07:02 AM, Jakub Jelinek wrote:
On Wed, Nov 05, 2014 at 03:37:08PM -0600, James Norris wrote:
2014-11-05 James Norris
Cesar Philippidis
Thomas Schwinge
Ilmir Usmanov
...
Please check formatting. I see various spots with 8 spaces i
On Wed, 5 Nov 2014, James Norris wrote:
> Hi!
>
> This patch represents the changes for OpenACC 2.0
> in the C front-end. At present these files will
> not compile as the changes for the middle end are
> not present.
So will things compile with the combination of this patch and the
middle-end p
On Wed, Nov 05, 2014 at 03:39:44PM -0600, James Norris wrote:
> * c-typeck.c (c_finish_oacc_parallel, c_finish_oacc_kernels,
> c_finish_oacc_data): New functions.
> (handle_omp_array_sections, c_finish_omp_clauses):
Handle should be on the above line, no need to wrap too early.
On Wed, Nov 05, 2014 at 03:37:08PM -0600, James Norris wrote:
> 2014-11-05 James Norris
> Cesar Philippidis
> Thomas Schwinge
> Ilmir Usmanov
...
Please check formatting. I see various spots with 8 spaces instead of tabs,
e.g. on
+ check_no_duplicate_claus
Hi!
On Wed, 5 Nov 2014 21:41:02 +, Joseph Myers wrote:
> I think the TODO: XXX FIX -2 and TODO XXX: FIX -1 comments need, at least,
> more explanation of what the issue is and where the constants come from,
> even if something is left until later to be fixed.
Such constants should go into
I think the TODO: XXX FIX -2 and TODO XXX: FIX -1 comments need, at least,
more explanation of what the issue is and where the constants come from,
even if something is left until later to be fixed.
--
Joseph S. Myers
jos...@codesourcery.com
