Re: Re: Re: [VOTE] Vote for releasing Apache Doris 1.0.0-incubating-rc02

2022-04-01 Thread Calvin Kirs
Hi, I add some comments in PR, Another suggestion is that the release-note should not be in the form of a Github issue, because it can be modified. The common practice is to include a release-note file in the released package. 陈明雨 于2022年4月2日周六 10:08写道: > > Hi Kris, > Thanks for your review. > In

Re: Re: [VOTE] Vote for releasing Apache Doris 1.0.0-incubating-rc02

2022-04-01 Thread Calvin Kirs
Calvin Kirs 于2022年4月1日周五 22:57写道: > > Hi, > + 0 (binding) > I only checked source packages. > > - incubating in the name > - LICENSE, NOTICE, DISCLAIMER are there and look good > - hash and signature look good > > I have some questions about binary packages, which is why I chose +0. > > I checked

Re: Re: [VOTE] Vote for releasing Apache Doris 1.0.0-incubating-rc02

2022-04-01 Thread Calvin Kirs
Hi, + 0 (binding) I only checked source packages. - incubating in the name - LICENSE, NOTICE, DISCLAIMER are there and look good - hash and signature look good I have some questions about binary packages, which is why I chose +0. I checked the corresponding binary package, but the dependencies l